fastlane 2.65.0 → 2.66.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6b2a78c9b6e3e48a30f9433cfda1c683e6a3ce6
-  data.tar.gz: d6efe4c63a4b99dbc604001a97be4b5b1c5991c6
+  metadata.gz: 6ec7b1127c00a1e221eb4d72105724ff0f4c0b37
+  data.tar.gz: d4d307e021d7548af03a580fc677bea6af828912
 SHA512:
-  metadata.gz: a71be3e1dc14441c66ca144644c91ef2b672745e7ff273e47a605ff24c3093ec7785c4c83c2b25b85fe782e2cabdd5e9d5140b5afe2fe0dc6324172f61af492c
-  data.tar.gz: 89a89b2265e85b4e2c3edc6826628d22e0df9aa79561a71576e7a848ae4601155495615556225cb5059a848c785f6aa39119ce0719008028bb2cd84fedd715c9
+  metadata.gz: 0832577ea0780bf5c9b65e4aa5ca7225b8730376d03dbb1d4a440e9c1f209ec79a7661f29721f37a46746d04bea18cfbc5c7d1caea30e4a2d45913beefe11d85
+  data.tar.gz: 3b499a83814e5d15f8e052d8eaa75dba15e6cc6ce787f35931ed02c2d5ee0a6e163bfb121de21d2435c46b0408ca022cb088028b38806dca978f2253346039a6

data/fastlane/lib/fastlane/actions/app_store_build_number.rb

@@ -13,6 +13,8 @@ module Fastlane
         Spaceship::Tunes.select_team
         UI.message("Login successful")
 
+        platform = params[:platform]
+
         app = Spaceship::Tunes::Application.find(params[:app_identifier])
         if params[:live]
           UI.message("Fetching the latest build number for live-version")
@@ -22,7 +24,7 @@ module Fastlane
           unless version_number
             # Automatically fetch the latest version in testflight
             begin
-              testflight_version = app.build_trains.keys.last
+              testflight_version = app.all_build_train_numbers(platform: platform).sort_by { |v| Gem::Version.new(v) }.last
             rescue
               testflight_version = params[:version]
             end
@@ -38,14 +40,17 @@ module Fastlane
           UI.message("Fetching the latest build number for version #{version_number}")
 
           begin
-            train = app.build_trains[version_number]
-            build_nr = train.builds.map(&:build_version).map(&:to_i).sort.last
+            build_nr = app.all_builds_for_train(train: version_number, platform: platform).map(&:build_version).map(&:to_i).sort.last
+            if build_nr.nil? && params[:initial_build_number]
+              UI.message("Could not find a build on iTC. Using supplied 'initial_build_number' option")
+              build_nr = params[:initial_build_number]
+            end
           rescue
-            UI.user_error!("could not find a build on iTC - and 'initial_build_number' option is not set") unless params[:initial_build_number]
+            UI.user_error!("Could not find a build on iTC - and 'initial_build_number' option is not set") unless params[:initial_build_number]
             build_nr = params[:initial_build_number]
           end
         end
-        UI.message("Latest upload is build number: #{build_nr}")
+        UI.message("Latest upload for version #{version_number} is build: #{build_nr}")
         Actions.lane_context[SharedValues::LATEST_BUILD_NUMBER] = build_nr
       end
 
@@ -97,6 +102,16 @@ module Fastlane
                                        env_name: "LATEST_VERSION",
                                        description: "The version number whose latest build number we want",
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :platform,
+                                       short_option: "-j",
+                                       env_name: "APPSTORE_PLATFORM",
+                                       description: "The platform to use (optional)",
+                                       optional: true,
+                                       is_string: true,
+                                       default_value: "ios",
+                                       verify_block: proc do |value|
+                                         UI.user_error!("The platform can only be ios, appletvos, or osx") unless %('ios', 'appletvos', 'osx').include? value
+                                       end),
           FastlaneCore::ConfigItem.new(key: :team_name,
                                        short_option: "-e",
                                        env_name: "LATEST_TESTFLIGHT_BUILD_NUMBER_TEAM_NAME",

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -47,9 +47,6 @@ module Fastlane
         UI.message(message.join(" "))
 
         # Loop through all app versions and download their dSYM
-        # This will need to change with the new build trains endpoints
-        # can use app.build_trains(platform: platform).versions to check for the right version
-        # then iterate through the builds
         app.all_build_train_numbers(platform: platform).each do |train_number|
           if version && version != train_number
             next
@@ -60,7 +57,7 @@ module Fastlane
             end
 
             begin
-              download_url = build.details.dsym_url
+              download_url = build.dsym_url
             rescue Spaceship::TunesClient::ITunesConnectError => ex
               UI.error("Error accessing dSYM file for build\n\n#{build}\n\nException: #{ex}")
             end
@@ -162,7 +159,8 @@ module Fastlane
                                        short_option: "-p",
                                        env_name: "DOWNLOAD_DSYMS_PLATFORM",
                                        description: "The app platform for dSYMs you wish to download",
-                                       optional: true),
+                                       optional: true,
+                                       default_value: :ios),
           FastlaneCore::ConfigItem.new(key: :version,
                                        short_option: "-v",
                                        env_name: "DOWNLOAD_DSYMS_VERSION",

data/fastlane/lib/fastlane/actions/latest_testflight_build_number.rb

@@ -53,6 +53,16 @@ module Fastlane
                                        env_name: "LATEST_VERSION",
                                        description: "The version number whose latest build number we want",
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :platform,
+                                       short_option: "-j",
+                                       env_name: "APPSTORE_PLATFORM",
+                                       description: "The platform to use (optional)",
+                                       optional: true,
+                                       is_string: true,
+                                       default_value: "ios",
+                                       verify_block: proc do |value|
+                                         UI.user_error!("The platform can only be ios, or appletvos") unless %('ios', 'appletvos').include? value
+                                       end),
           FastlaneCore::ConfigItem.new(key: :initial_build_number,
                                        env_name: "INITIAL_BUILD_NUMBER",
                                        description: "sets the build number to given value if no build is in current train",

data/fastlane/lib/fastlane/setup/setup_ios.rb

@@ -34,6 +34,9 @@ module Fastlane
           detect_if_app_is_available
         end
         print_config_table
+        if self.project.schemes.count > 1
+          UI.important("Note: If the values above are incorrect, it is possible the wrong scheme was selected")
+        end
         if UI.confirm("Please confirm the above values")
           default_setup
         else
@@ -137,6 +140,8 @@ module Fastlane
       config = {}
       FastlaneCore::Project.detect_projects(config)
       self.project = FastlaneCore::Project.new(config)
+      self.project.select_scheme(preferred_to_include: self.project.project_name)
+
       self.app_identifier = self.project.default_app_identifier # These two vars need to be accessed in order to be set
       self.app_name = self.project.default_app_name # They are set as a side effect, this could/should be changed down the road
     end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.65.0'.freeze
+  VERSION = '2.66.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/pilot/lib/pilot/build_manager.rb

@@ -98,7 +98,7 @@ module Pilot
 
       puts Terminal::Table.new(
         title: "#{app.name} Builds".green,
-        headings: ["Version #", "Build #", "Testing", "Installs", "Sessions"],
+        headings: ["Version #", "Build #", "Installs"],
         rows: FastlaneCore::PrintTable.transform_output(rows)
       )
     end
@@ -119,9 +119,7 @@ module Pilot
     def describe_build(build)
       row = [build.train_version,
              build.build_version,
-             build.testing_status,
-             build.install_count,
-             build.session_count]
+             build.install_count]
 
       return row
     end

data/pilot/lib/pilot/commands_generator.rb

@@ -104,6 +104,7 @@ module Pilot
 
         c.action do |args, options|
           config = create_config(options)
+          UI.user_error!("You must include an `app_identifier` to list testers") unless config[:app_identifier]
           Pilot::TesterManager.new.list_testers(config)
         end
       end

data/pilot/lib/pilot/options.rb

@@ -24,6 +24,7 @@ module Pilot
                                      env_name: "PILOT_PLATFORM",
                                      description: "The platform to use (optional)",
                                      optional: true,
+                                     default_value: 'ios',
                                      verify_block: proc do |value|
                                        UI.user_error!("The platform can only be ios, appletvos, or osx") unless ['ios', 'appletvos', 'osx'].include? value
                                      end),

data/pilot/lib/pilot/tester_exporter.rb

@@ -12,22 +12,24 @@ module Pilot
       app_filter = (config[:apple_id] || config[:app_identifier])
       if app_filter
         app = Spaceship::Application.find(app_filter)
-        testers = Spaceship::Tunes::Tester::External.all_by_app(app.apple_id)
+
+        testers = Spaceship::TestFlight::Tester.all(app_id: app.apple_id)
       else
-        testers = Spaceship::Tunes::Tester::External.all
+        testers = Spaceship::TestFlight::Tester.all
       end
 
       file = config[:testers_file_path]
 
       CSV.open(file, "w") do |csv|
-        csv << ['First', 'Last', 'Email', 'Groups', 'Devices', 'Installed Version', 'Install Date']
+        csv << ['First', 'Last', 'Email', 'Groups', 'Installed Version', 'Install Date']
 
         testers.each do |tester|
-          group_names = tester.groups_list(';') || ""
-          install_version = tester.latest_build || ""
+          group_names = tester.groups.join(";") || ""
+          latest_install_info = tester.latest_install_info
+          install_version = latest_install_info["latestInstalledShortVersion"] || ""
           pretty_date = tester.pretty_install_date || ""
 
-          csv << [tester.first_name, tester.last_name, tester.email, group_names, tester.devices.count, install_version, pretty_date]
+          csv << [tester.first_name, tester.last_name, tester.email, group_names, install_version, pretty_date]
         end
 
         UI.success("Successfully exported CSV to #{file}")

data/pilot/lib/pilot/tester_manager.rb

@@ -9,6 +9,9 @@ module Pilot
       app = find_app(app_filter: config[:apple_id] || config[:app_identifier])
       UI.user_error!("You must provide either a Apple ID for the app (with the `:apple_id` option) or app identifier (with the `:app_identifier` option)") unless app
 
+      groups_param = config[:groups]
+      UI.user_error!("You must provide 1 or more groups (with the `:groups` option)") unless groups_param
+
       tester = find_app_tester(email: config[:email], app: app)
       tester ||= create_tester(
         email: config[:email],
@@ -17,18 +20,10 @@ module Pilot
         app: app
       )
       begin
+        # Groups are now required
         groups = Spaceship::TestFlight::Group.add_tester_to_groups!(tester: tester, app: app, groups: config[:groups])
-        if tester.kind_of?(Spaceship::Tunes::Tester::Internal)
-          UI.success("Successfully added tester to app #{app.name}")
-        else
-          # tester was added to the group(s) in the above add_tester_to_groups() call, now we need to let the user know which group(s)
-          if config[:groups]
-            group_names = groups.map(&:name).join(", ")
-            UI.success("Successfully added tester to group(s): #{group_names} in app: #{app.name}")
-          else
-            UI.success("Successfully added tester to the default tester group in app: #{app.name}")
-          end
-        end
+        group_names = groups.map(&:name).join(", ")
+        UI.success("Successfully added tester to group(s): #{group_names} in app: #{app.name}")
       rescue => ex
         UI.error("Could not add #{tester.email} to app: #{app.name}")
         raise ex
@@ -66,7 +61,7 @@ module Pilot
       begin
         # If no groups are passed to options, remove the tester from the app-level,
         # otherwise remove the tester from the groups specified.
-        if config[:groups].nil? && tester.kind_of?(Spaceship::Tunes::Tester::External)
+        if config[:groups].nil?
           test_flight_testers = Spaceship::TestFlight::Tester.search(app_id: app.apple_id, text: tester.email, is_email_exact_match: true)
 
           if test_flight_testers.length > 1
@@ -95,7 +90,7 @@ module Pilot
       if app_filter
         list_testers_by_app(app_filter)
       else
-        list_testers_global
+        UI.user_error!("You must include an `app_identifier` to `list_testers`")
       end
     end
 
@@ -112,16 +107,15 @@ module Pilot
 
     def find_app_tester(email: nil, app: nil)
       current_user = find_current_user
+      app_apple_id = app.nil? ? nil : app.apple_id
 
       if current_user.admin?
-        tester = Spaceship::Tunes::Tester::Internal.find(email)
-        tester ||= Spaceship::Tunes::Tester::External.find(email)
+        tester = Spaceship::TestFlight::Tester.find(app_id: app_apple_id, email: email)
       elsif current_user.app_manager?
-        unless app
+        unless app_apple_id
           UI.user_error!("Account #{current_user.email_address} is only an 'App Manager' and therefore you must also define what app this tester (#{email}) should be added to")
         end
-        tester = Spaceship::Tunes::Tester::Internal.find_by_app(app.apple_id, email)
-        tester ||= Spaceship::Tunes::Tester::External.find_by_app(app.apple_id, email)
+        tester = Spaceship::TestFlight::Tester.find(app_id: app_apple_id, email: email)
       else
         UI.user_error!("Account #{current_user.email_address} doesn't have a role that is allowed to administer app testers, current roles: #{current_user.roles}")
         tester = nil
@@ -147,24 +141,17 @@ module Pilot
 
     def create_tester(email: nil, first_name: nil, last_name: nil, app: nil)
       current_user = find_current_user
-      if current_user.admin?
-        tester = Spaceship::Tunes::Tester::External.create!(email: email,
-                                                       first_name: first_name,
-                                                        last_name: last_name)
-        UI.success("Successfully added tester: #{email} to your account")
-      elsif current_user.app_manager?
-
+      if current_user.admin? || current_user.app_manager?
         Spaceship::TestFlight::Tester.create_app_level_tester(app_id: app.apple_id,
-                                                          first_name: first_name,
-                                                           last_name: last_name,
+                                                          first_name: first_name || '',
+                                                           last_name: last_name || '',
                                                                email: email)
-        tester = Spaceship::Tunes::Tester::External.find_by_app(app.apple_id, email)
+
         UI.success("Successfully added tester: #{email} to app: #{app.name}")
+        return Spaceship::TestFlight::Tester.find(app_id: app.apple_id, email: email)
       else
         UI.user_error!("Current account doesn't have permission to create a tester")
       end
-
-      return tester
     rescue => ex
       UI.error("Could not create tester #{email}")
       raise ex
@@ -173,53 +160,21 @@ module Pilot
     def list_testers_by_app(app_filter)
       app = Spaceship::Application.find(app_filter)
       UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
-
-      int_testers = Spaceship::Tunes::Tester::Internal.all_by_app(app.apple_id)
-      ext_testers = Spaceship::Tunes::Tester::External.all_by_app(app.apple_id)
-
-      list_by_app(int_testers, "Internal Testers")
-      puts ""
-      list_by_app(ext_testers, "External Testers")
-    end
-
-    def list_testers_global
-      begin
-        int_testers = Spaceship::Tunes::Tester::Internal.all
-        ext_testers = Spaceship::Tunes::Tester::External.all
-      rescue Spaceship::Client::InsufficientPermissions
-        UI.user_error!("You don't have the permission to list the testers of your whole team. Please provide an app identifier to list all testers of a specific application.")
-      end
-
-      list_global(int_testers, "Internal Testers")
-      puts ""
-      list_global(ext_testers, "External Testers")
-    end
-
-    def list_global(all_testers, title)
-      headers = ["First", "Last", "Email", "Groups", "Devices", "Latest Version", "Latest Install Date"]
-      list(all_testers, "#{title} (#{all_testers.count})", headers) do |tester|
-        [
-          tester.first_name,
-          tester.last_name,
-          tester.email,
-          tester.groups_list,
-          tester.devices.count,
-          tester.latest_build,
-          tester.pretty_install_date
-        ]
-      end
+      testers = Spaceship::TestFlight::Tester.all(app_id: app.apple_id)
+      list_by_app(testers, "All Testers")
     end
 
     def list_by_app(all_testers, title)
       headers = ["First", "Last", "Email", "Groups"]
       list(all_testers, "#{title} (#{all_testers.count})", headers) do |tester|
+        tester_groups = tester.groups.nil? ? nil : tester.groups.join(";")
         [
           tester.first_name,
           tester.last_name,
           tester.email,
-          tester.groups_list
+          tester_groups
           # Testers returned by the query made in the context of an app do not contain
-          # the devices, version, or install date information
+          # the version, or install date information
         ]
       end
     end
@@ -245,7 +200,7 @@ module Pilot
       rows << ["Email", tester.email]
 
       if tester.groups.to_s.length > 0
-        rows << ["Groups", tester.groups_list]
+        rows << ["Groups", tester.groups.join(";")]
       end
 
       if tester.latest_install_date
@@ -253,21 +208,6 @@ module Pilot
         rows << ["Latest Install Date", tester.pretty_install_date]
       end
 
-      if tester.devices.to_s.length == 0
-        rows << ["Devices", "No devices"]
-      else
-        rows << ["#{tester.devices.count} Devices", ""]
-        tester.devices.each do |device|
-          current = "\u2022 #{device['model']}, iOS #{device['osVersion']}"
-
-          if rows.last[1].length == 0
-            rows.last[1] = current
-          else
-            rows << ["", current]
-          end
-        end
-      end
-
       puts Terminal::Table.new(
         title: tester.email.green,
         rows: FastlaneCore::PrintTable.transform_output(rows)

data/pilot/lib/pilot/tester_util.rb

@@ -1,16 +0,0 @@
-require "spaceship/base"
-require "spaceship/tunes/tunes_base"
-require "spaceship/tunes/tester"
-
-module Spaceship
-  module Tunes
-    # monkey patched
-    # move this to spaceship
-    class Tester < TunesBase
-      def pretty_install_date
-        return nil unless latest_install_date
-        Time.at((latest_install_date / 1000)).strftime("%m/%d/%y %H:%M")
-      end
-    end
-  end
-end

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -153,17 +153,27 @@ module Spaceship::TestFlight
       page_size = 40 # that's enforced by the iTC servers
       offset = nil
       resulting_array = []
+      initial_url = "providers/#{team_id}/apps/#{app_id}/testers?limit=#{page_size}&sort=email&order=asc"
+      response = request(:get, initial_url)
+      result = Array(handle_response(response))
+      resulting_array += result
+      return resulting_array if result.count == 0
+      offset = result.last['id']
 
       loop do
-        url = "providers/#{team_id}/apps/#{app_id}/testers?limit=#{page_size}&sort=email&order=asc"
+        url = "providers/#{team_id}/apps/#{app_id}/testers?offset=added,#{offset}&limit=#{page_size}&sort=status,default&order=asc"
         url += "&offset=#{offset}" if offset
         response = request(:get, url)
         result = Array(handle_response(response))
-        resulting_array += result
+
         break if result.count == 0
-        offset = "#{result.last['email']}%2C#{result.last['id']}"
+        # If there are no more, the last response seems to be repeated
+        break if offset == result.last['id']
+
+        resulting_array += result
+        offset = result.last['id']
       end
-      return resulting_array
+      return resulting_array.uniq
     end
 
     def delete_tester_from_app(app_id: nil, tester_id: nil)

data/spaceship/lib/spaceship/test_flight/group.rb

@@ -71,19 +71,11 @@ module Spaceship::TestFlight
     end
 
     def self.add_tester_to_groups!(tester: nil, app: nil, groups: nil)
-      if tester.kind_of?(Spaceship::Tunes::Tester::Internal)
-        self.internal_group(app_id: app.apple_id).add_tester!(tester)
-      else
-        self.perform_for_groups_in_app(app: app, groups: groups) { |group| group.add_tester!(tester) }
-      end
+      self.perform_for_groups_in_app(app: app, groups: groups) { |group| group.add_tester!(tester) }
     end
 
     def self.remove_tester_from_groups!(tester: nil, app: nil, groups: nil)
-      if tester.kind_of?(Spaceship::Tunes::Tester::Internal)
-        self.internal_group(app_id: app.apple_id).remove_tester!(tester)
-      else
-        self.perform_for_groups_in_app(app: app, groups: groups) { |group| group.remove_tester!(tester) }
-      end
+      self.perform_for_groups_in_app(app: app, groups: groups) { |group| group.remove_tester!(tester) }
     end
 
     def default_external_group?

data/spaceship/lib/spaceship/test_flight/tester.rb

@@ -41,9 +41,13 @@ module Spaceship::TestFlight
     # }
     attr_accessor :latest_install_info
 
+    attr_accessor :latest_install_date
+
     # @return (Integer) Number of sessions
     attr_accessor :session_count
 
+    attr_accessor :groups
+
     attr_mapping(
       'id' => :tester_id,
       'email' => :email,
@@ -52,9 +56,22 @@ module Spaceship::TestFlight
       'latestInstallInfo' => :latest_install_info,
       'sessionCount' => :session_count,
       'firstName' => :first_name,
-      'lastName' => :last_name
+      'lastName' => :last_name,
+      'groups' => :groups
     )
 
+    def latest_install_date
+      return nil unless latest_install_info
+      latest_installed_date = latest_install_info["latestInstalledDate"]
+      return latest_installed_date
+    end
+
+    def pretty_install_date
+      return nil unless latest_installed_date
+
+      Time.at((latest_installed_date / 1000)).strftime("%m/%d/%y %H:%M")
+    end
+
     # @return (Array) Returns all beta testers available for this account
     def self.all(app_id: nil)
       client.testers_for_app(app_id: app_id).map { |data| self.new(data) }

data/spaceship/lib/spaceship/tunes/application.rb

@@ -261,13 +261,13 @@ module Spaceship
       # TestFlight: A reference to all the build trains
       # @return [Hash] a hash, the version number and platform being the key
       def build_trains(platform: nil)
-        TestFlight::BuildTrains.all(app_id: self.apple_id, platform: platform)
+        TestFlight::BuildTrains.all(app_id: self.apple_id, platform: platform || self.platform)
       end
 
       # The numbers of all build trains that were uploaded
       # @return [Array] An array of train version numbers
       def all_build_train_numbers(platform: nil)
-        return self.build_trains.versions
+        return self.build_trains(platform: platform || self.platform).versions
       end
 
       # Receive the build details for a specific build
@@ -275,19 +275,19 @@ module Spaceship
       # which might happen if you don't use TestFlight
       # This is used to receive dSYM files from Apple
       def all_builds_for_train(train: nil, platform: nil)
-        return TestFlight::Build.builds_for_train(app_id: self.apple_id, platform: platform, train_version: train)
+        return TestFlight::Build.builds_for_train(app_id: self.apple_id, platform: platform || self.platform, train_version: train)
       end
 
       # @return [Array] This will return an array of *all* processing builds
       #   this include pre-processing or standard processing
       def all_processing_builds(platform: nil)
-        return TestFlight::Build.all_processing_builds(app_id: self.apple_id, platform: platform)
+        return TestFlight::Build.all_processing_builds(app_id: self.apple_id, platform: platform || self.platform)
       end
 
       # Get all builds that are already processed for all build trains
       # You can either use the return value (array) or pass a block
       def builds(platform: nil)
-        all = TestFlight::Build.all(app_id: self.apple_id, platform: platform)
+        all = TestFlight::Build.all(app_id: self.apple_id, platform: platform || self.platform)
         return all unless block_given?
         all.each { |build| yield(build) }
       end

data/spaceship/lib/spaceship/tunes/sandbox_tester.rb

@@ -0,0 +1,72 @@
+module Spaceship
+  module Tunes
+    class SandboxTester < TunesBase
+      # @return (String) The email of this sandbox tester
+      # @example
+      #   "tester@spaceship.com"
+      attr_accessor :email
+
+      # @return (String) The first name of this tester
+      # @example
+      #   "Cary"
+      attr_accessor :first_name
+
+      # @return (String) The last name of this tester
+      # @example
+      #   "Bennett"
+      attr_accessor :last_name
+
+      # @return (String) The two-letter country code of this tester
+      # @example
+      #   "US"
+      attr_accessor :country
+
+      attr_mapping(
+        'emailAddress.value' => :email,
+        'firstName.value' => :first_name,
+        'lastName.value' => :last_name,
+        'storeFront.value' => :country
+      )
+
+      def self.url
+        {
+          index:  "ra/users/iap",
+          create: "ra/users/iap/add",
+          delete: "ra/users/iap/delete"
+        }
+      end
+
+      def self.all
+        client.sandbox_testers(self).map { |tester| self.new(tester) }
+      end
+
+      def self.create!(email: nil, password: nil, first_name: 'Test', last_name: 'Test', country: 'US')
+        data = client.create_sandbox_tester!(
+          tester_class: self,
+          email: email,
+          password: password,
+          first_name: first_name,
+          last_name: last_name,
+          country: country
+        )
+        self.new(data)
+      end
+
+      def self.delete!(emails)
+        client.delete_sandbox_testers!(self, emails)
+      end
+
+      def self.delete_all!
+        delete!(self.all.map(&:email))
+      end
+
+      #####################################################
+      # @!group Subclasses
+      #####################################################
+      # Delete current tester
+      def delete!
+        client.delete_tester!(self)
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/tunes/tunes.rb

@@ -22,7 +22,7 @@ require 'spaceship/tunes/build_details'
 require 'spaceship/tunes/build_train'
 require 'spaceship/tunes/device_type'
 require 'spaceship/tunes/app_trailer'
-require 'spaceship/tunes/tester'
+require 'spaceship/tunes/sandbox_tester'
 require 'spaceship/tunes/app_details'
 require 'spaceship/tunes/pricing_tier'
 require 'spaceship/tunes/recovery_device'

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -1172,127 +1172,6 @@ module Spaceship
       handle_itc_response(r.body)
     end
 
-    #####################################################
-    # @!group Testers
-    #####################################################
-    def testers(tester)
-      url = tester.url[:index]
-      r = request(:get, url)
-      parse_response(r, 'data')['testers']
-    end
-
-    def testers_by_app(tester, app_id)
-      url = tester.url(app_id)[:index_by_app]
-      r = request(:get, url)
-      parse_response(r, 'data')['users']
-    end
-
-    # Returns a list of available testing groups
-    # e.g.
-    #   {"b6f65dbd-c845-4d91-bc39-0b661d608970" => "Boarding",
-    #    "70402368-9deb-409f-9a26-bb3f215dfee3" => "Automatic"}
-    def groups
-      return @cached_groups if @cached_groups
-      r = request(:get, '/WebObjects/iTunesConnect.woa/ra/users/pre/ext')
-      @cached_groups = parse_response(r, 'data')['groups']
-    end
-
-    def create_tester!(tester: nil, email: nil, first_name: nil, last_name: nil, groups: nil)
-      url = tester.url[:create]
-      raise "Action not provided for this tester type." unless url
-
-      tester_data = {
-        emailAddress: {
-          value: email
-        },
-        firstName: {
-          value: first_name || ""
-        },
-        lastName: {
-          value: last_name || ""
-        },
-        testing: {
-          value: true
-        }
-      }
-
-      if groups
-        tester_data[:groups] = groups.map do |group_name_or_group_id|
-          if self.groups.value?(group_name_or_group_id)
-            # This is an existing group, let's use that, the user specified the group name
-            group_name = group_name_or_group_id
-            group_id = self.groups.key(group_name_or_group_id)
-          elsif self.groups.key?(group_name_or_group_id)
-            # This is an existing group, let's use that, the user specified the group ID
-            group_name = self.groups[group_name_or_group_id]
-            group_id = group_name_or_group_id
-          else
-            group_name = group_name_or_group_id
-            group_id = nil # this is expected by the iTC API
-          end
-
-          {
-            "id" => group_id,
-            "name" => {
-              "value" => group_name
-            }
-          }
-        end
-      end
-
-      data = { testers: [tester_data] }
-
-      r = request(:post) do |req|
-        req.url url
-        req.body = data.to_json
-        req.headers['Content-Type'] = 'application/json'
-      end
-
-      data = parse_response(r, 'data')['testers']
-      handle_itc_response(data) || data[0]
-    end
-
-    def delete_tester!(tester)
-      url = tester.class.url[:delete]
-      raise "Action not provided for this tester type." unless url
-
-      data = [
-        {
-          emailAddress: {
-            value: tester.email
-          },
-          firstName: {
-            value: tester.first_name
-          },
-          lastName: {
-            value: tester.last_name
-          },
-          testing: {
-            value: false
-          },
-          userName: tester.email,
-          testerId: tester.tester_id
-        }
-      ]
-
-      r = request(:post) do |req|
-        req.url url
-        req.body = data.to_json
-        req.headers['Content-Type'] = 'application/json'
-      end
-
-      data = parse_response(r, 'data')['testers']
-      handle_itc_response(data) || data[0]
-    end
-
-    def add_tester_to_app!(tester, app_id)
-      update_tester_from_app!(tester, app_id, true)
-    end
-
-    def remove_tester_from_app!(tester, app_id)
-      update_tester_from_app!(tester, app_id, false)
-    end
-
     #####################################################
     # @!group Sandbox Testers
     #####################################################

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.65.0
+  version: 2.66.0
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-20 00:00:00.000000000 Z
+date: 2017-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -225,14 +225,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
   name: babosa
   requirement: !ruby/object:Gem::Requirement
@@ -808,7 +808,6 @@ files:
 - credentials_manager/lib/credentials_manager/appfile_config.rb
 - credentials_manager/lib/credentials_manager/cli.rb
 - deliver/README.md
-- deliver/lib/.DS_Store
 - deliver/lib/assets/DeliverfileDefault
 - deliver/lib/assets/ScreenshotsHelp
 - deliver/lib/assets/summary.html.erb
@@ -846,6 +845,7 @@ files:
 - fastlane/lib/assets/s3_plist_template.erb
 - fastlane/lib/assets/s3_version_template.erb
 - fastlane/lib/fastlane.rb
+- fastlane/lib/fastlane/.DS_Store
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
 - fastlane/lib/fastlane/actions/README.md
@@ -1294,6 +1294,7 @@ files:
 - pilot/lib/pilot/tester_manager.rb
 - pilot/lib/pilot/tester_util.rb
 - precheck/README.md
+- precheck/lib/.DS_Store
 - precheck/lib/assets/PrecheckfileTemplate
 - precheck/lib/precheck.rb
 - precheck/lib/precheck/commands_generator.rb
@@ -1363,7 +1364,6 @@ files:
 - sigh/lib/sigh/resign.rb
 - sigh/lib/sigh/runner.rb
 - snapshot/README.md
-- snapshot/lib/.DS_Store
 - snapshot/lib/assets/SnapfileTemplate
 - snapshot/lib/assets/SnapshotHelper.swift
 - snapshot/lib/assets/SnapshotHelperXcode8.swift
@@ -1477,9 +1477,9 @@ files:
 - spaceship/lib/spaceship/tunes/members.rb
 - spaceship/lib/spaceship/tunes/pricing_tier.rb
 - spaceship/lib/spaceship/tunes/recovery_device.rb
+- spaceship/lib/spaceship/tunes/sandbox_tester.rb
 - spaceship/lib/spaceship/tunes/spaceship.rb
 - spaceship/lib/spaceship/tunes/territory.rb
-- spaceship/lib/spaceship/tunes/tester.rb
 - spaceship/lib/spaceship/tunes/transit_app_file.rb
 - spaceship/lib/spaceship/tunes/tunes.rb
 - spaceship/lib/spaceship/tunes/tunes_base.rb
@@ -1536,7 +1536,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.2.5
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and

data/spaceship/lib/spaceship/tunes/tester.rb

@@ -1,283 +0,0 @@
-module Spaceship
-  module Tunes
-    class Tester < TunesBase
-      # @return (String) The identifier of this tester, provided by iTunes Connect
-      # @example
-      #   "60f858b4-60a8-428a-963a-f943a3d68d17"
-      attr_accessor :tester_id
-
-      # @return (String) The email of this tester
-      # @example
-      #   "tester@spaceship.com"
-      attr_accessor :email
-
-      # @return (String) The first name of this tester
-      # @example
-      #   "Cary"
-      attr_accessor :first_name
-
-      # @return (String) The last name of this tester
-      # @example
-      #   "Bennett"
-      attr_accessor :last_name
-
-      # @return (Array) an array of associated groups
-      # @example
-      #    [{
-      #      "id": "e031e048-4f0f-4c1e-8d8a-a5341a267986",
-      #      "name": {
-      #        "value": "My App Testers"
-      #      }
-      #    }]
-      attr_accessor :groups
-
-      # @return (Array) An array of registered devices for this user
-      # @example
-      #    [{
-      #      "model": "iPhone 6",
-      #      "os": "iOS",
-      #      "osVersion": "8.3",
-      #      "name": null
-      #    }]
-      attr_accessor :devices
-
-      # Information about the most recent beta install
-      # @return [Integer] The ID of the most recently installed app
-      attr_accessor :latest_install_app_id
-
-      # @return [Integer] Date of the last install of this tester
-      #   Number of seconds since 1970
-      attr_accessor :latest_install_date
-
-      # @return [Integer] The build number of the last installed build
-      attr_accessor :latest_installed_build_number
-
-      # @return [Integer] The version number of the last installed build
-      attr_accessor :latest_installed_version_number
-
-      # @return [String] The full version of the last installed build
-      attr_accessor :latest_build
-
-      attr_mapping(
-        'testerId' => :tester_id,
-        'emailAddress.value' => :email,
-        'firstName.value' => :first_name,
-        'lastName.value' => :last_name,
-        'groups' => :groups,
-        'devices' => :devices,
-        'latestInstalledAppAdamId' => :latest_install_app_id,
-        'latestInstallByPlatform.ios.installDate' => :latest_install_date,
-        'latestInstallByPlatform.ios.shortVersion' => :latest_installed_version_number,
-        'latestInstallByPlatform.ios.version' => :latest_installed_build_number,
-        'latestBuild' => :latest_build
-      )
-
-      class << self
-        # @return (Hash) All urls for the ITC used for web requests
-        def url
-          raise "You have to use a subclass: Internal or External"
-        end
-
-        # @return (Array) Returns all beta testers available for this account
-        def all
-          client.testers(self).map { |tester| self.factory(tester) }
-        end
-
-        # @return (Spaceship::Tunes::Tester) Returns the tester matching the parameter
-        #   as either the Tester id or email
-        # @param identifier (String) (required): Value used to filter the tester, case insensitive
-        def find(identifier)
-          all.find do |tester|
-            (tester.tester_id.to_s.casecmp(identifier.to_s).zero? or tester.email.to_s.casecmp(identifier.to_s).zero?)
-          end
-        end
-
-        def groups
-          client.groups
-        end
-
-        # Create new tester in iTunes Connect
-        # @param email (String) (required): The email of the new tester
-        # @param first_name (String) (optional): The first name of the new tester
-        # @param last_name (String) (optional): The last name of the new tester
-        # @param groups (Array) (option): Names/IDs of existing groups for the new tester
-        # @example
-        #   Spaceship::Tunes::Tester.external.create!(email: "tester@mathiascarignani.com", first_name: "Cary", last_name: "Bennett", groups: ["Testers"])
-        # @return (Tester): The newly created tester
-        def create!(email: nil, first_name: nil, last_name: nil, groups: nil)
-          client.create_tester!(tester: self,
-                                 email: email,
-                            first_name: first_name,
-                             last_name: last_name,
-                                groups: groups)
-          # The response of the client request is a hash but doesn't contain all of the necessary data (like testerId, etc)
-          # use #find to get an instance of Tester with all of the data.
-          find(email)
-        end
-
-        #####################################################
-        # @!group App
-        #####################################################
-
-        # @return (Array) Returns all beta testers available for this account filtered by app
-        # @param app_id (String) (required): The app id to filter the testers
-        def all_by_app(app_id)
-          client.testers_by_app(self, app_id).map { |tester| self.factory(tester) }
-        end
-
-        # @return (Spaceship::Tunes::Tester) Returns the tester matching the parameter
-        #   as either the Tester id or email
-        # @param app_id (String) (required): The app id to filter the testers
-        # @param identifier (String) (required): Value used to filter the tester, case insensitive
-        def find_by_app(app_id, identifier)
-          all_by_app(app_id).find do |tester|
-            (tester.tester_id.to_s.casecmp(identifier.to_s).zero? or tester.email.to_s.casecmp(identifier.to_s).zero?)
-          end
-        end
-
-        # Add all testers to the app received
-        # @param app_id (String) (required): The app id to filter the testers
-        def add_all_to_app!(app_id)
-          all.each do |tester|
-            begin
-              tester.add_to_app!(app_id)
-            rescue => ex
-              if ex.to_s.include? "testerEmailExistsInternal" or ex.to_s.include? "duplicate.email"
-                # That's a non-relevant error message by iTC
-                # ignore that
-              else
-                raise ex
-              end
-            end
-          end
-        end
-      end
-
-      def setup
-        self.devices ||= [] # by default, an empty array instead of nil
-      end
-
-      #####################################################
-      # @!group Subclasses
-      #####################################################
-      class External < Tester
-        def self.url(app_id = nil)
-          {
-            index: "ra/users/pre/ext",
-            index_by_app: "ra/user/externalTesters/#{app_id}/",
-            create: "ra/users/pre/create",
-            delete: "ra/users/pre/ext/delete",
-            update_by_app: "ra/user/externalTesters/#{app_id}/"
-          }
-        end
-      end
-
-      class Internal < Tester
-        def self.url(app_id = nil)
-          {
-            index: "ra/users/pre/int",
-            index_by_app: "ra/user/internalTesters/#{app_id}/",
-            create: nil,
-            delete: nil,
-            update_by_app: "ra/user/internalTesters/#{app_id}/"
-          }
-        end
-      end
-
-      # Delete current tester
-      def delete!
-        client.delete_tester!(self)
-      end
-
-      #####################################################
-      # @!group App
-      #####################################################
-
-      # Add current tester to list of the app testers
-      # @param app_id (String) (required): The id of the application to which want to modify the list
-      def add_to_app!(app_id)
-        raise "`[tester].add_to_app!` got removed from spaceship as the TestFlight API changed, please use `app.default_external_group.add_tester!(tester)` instead"
-      end
-
-      # Remove current tester from list of the app testers
-      # @param app_id (String) (required): The id of the application to which want to modify the list
-      def remove_from_app!(app_id)
-        raise "`[tester].remove_from_app!` got removed from spaceship as the TestFlight API changed, please use `app.default_external_group.remove_tester!(tester)` instead"
-      end
-
-      #####################################################
-      # @!group Helpers
-      #####################################################
-
-      # Return a list of the Tester's group, if any
-      # @return
-      def groups_list(separator = ', ')
-        if groups
-          group_names = groups.map { |group| group["name"]["value"] }
-          group_names.join(separator)
-        end
-      end
-    end
-
-    class SandboxTester < TunesBase
-      # @return (String) The email of this tester
-      # @example
-      #   "tester@spaceship.com"
-      attr_accessor :email
-
-      # @return (String) The first name of this tester
-      # @example
-      #   "Cary"
-      attr_accessor :first_name
-
-      # @return (String) The last name of this tester
-      # @example
-      #   "Bennett"
-      attr_accessor :last_name
-
-      # @return (String) The two-letter country code of this tester
-      # @example
-      #   "US"
-      attr_accessor :country
-
-      attr_mapping(
-        'emailAddress.value' => :email,
-        'firstName.value' => :first_name,
-        'lastName.value' => :last_name,
-        'storeFront.value' => :country
-      )
-
-      def self.url
-        {
-          index:  "ra/users/iap",
-          create: "ra/users/iap/add",
-          delete: "ra/users/iap/delete"
-        }
-      end
-
-      def self.all
-        client.sandbox_testers(self).map { |tester| self.new(tester) }
-      end
-
-      def self.create!(email: nil, password: nil, first_name: 'Test', last_name: 'Test', country: 'US')
-        data = client.create_sandbox_tester!(
-          tester_class: self,
-          email: email,
-          password: password,
-          first_name: first_name,
-          last_name: last_name,
-          country: country
-        )
-        self.new(data)
-      end
-
-      def self.delete!(emails)
-        client.delete_sandbox_testers!(self, emails)
-      end
-
-      def self.delete_all!
-        delete!(self.all.map(&:email))
-      end
-    end
-  end
-end