fastlane 2.65.0.beta.20171113010004 → 2.65.0.beta.20171114010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c408eb7ead882ca5d84a83f837d75529b604ad6
-  data.tar.gz: 0a1d72448e23bcdfc137771310534d7bf6e16437
+  metadata.gz: 9320ab6f7ae03020ddcb7b2da70e69a4695f650f
+  data.tar.gz: 4a4dd0ba952972ae35413b3b82e1ff8b9afcb1f0
 SHA512:
-  metadata.gz: 7c9af371cae9072fd14bee29ab0f059f8a952eb128e88afc4e7a4435f4cf81c3a5970304f03041ed0f4bbcdf1faf73f3d83de9bf6026da5bad6171435c60f82a
-  data.tar.gz: 0e4d6b340ff3b54c2add547faf57f007d9a785588cd11e540aad60c56231b0fd7272701fca89ace82550f3c572e98f8215b2fb66d886bfb26d21b61d1236e16f
+  metadata.gz: 2b1cc2aefc1a6c8561c5a06075cddd573abd7508651137906658b3d8f6348d9c9e6ebbd67a3f4dbda62fe3bbd625ee6ab9f14950bba635743556e526484e0c85
+  data.tar.gz: 5ba27066793eafab0abdf17280e4e7c65ca1c6c33c3784e19524f8aa0273c18cb819d0fbb9c5a0d05f11eddfe56fed484002dd03b0b02f4079b567991b7b38b5

data/fastlane/lib/fastlane/actions/docs/precheck.md

@@ -26,22 +26,26 @@ Apple rejects builds for many avoidable metadata issues like including swear wor
 |          |  precheck Features  |
 |----------|-----------------|
 |🐛|  product bug mentions|
-|🙅‍♂️|Swear word checker|
+|🙅|Swear word checker|
 |🤖|Mentioning other platforms|
 |😵|URL reachability checker|
 |📝|Placeholder/test words/mentioning future features|
 |📅|Copyright date checking|
 |🙈|Customizable word list checking|
-|📢|You can decide if you want to warn  about potential problems and continue or have _fastlane_ show an error and stop after all scans are done.|
+|📢|You can decide if you want to warn about potential problems and continue or have _fastlane_ show an error and stop after all scans are done|
 
 # Usage
 Run _fastlane precheck_ to check the app metadata from iTunes Connect
 
-    fastlane precheck
+```no-highlight
+fastlane precheck
+```
 
 To get a list of available options run
-    
-    fastlane action precheck
+
+```no-highlight
+fastlane action precheck
+```
 
 <img src="/img/actions/precheck.gif" />
     

data/fastlane/lib/fastlane/actions/gradle.rb

@@ -36,6 +36,7 @@ module Fastlane
         flags = []
         flags << "-p #{project_dir.shellescape}"
         flags << params[:properties].map { |k, v| "-P#{k.to_s.shellescape}=#{v.to_s.shellescape}" }.join(' ') unless params[:properties].nil?
+        flags << params[:system_properties].map { |k, v| "-D#{k.to_s.shellescape}=#{v.to_s.shellescape}" }.join(' ') unless params[:system_properties].nil?
         flags << params[:flags] unless params[:flags].nil?
 
         # Run the actual gradle task
@@ -125,6 +126,11 @@ module Fastlane
                                        description: 'Gradle properties to be exposed to the gradle script',
                                        optional: true,
                                        is_string: false),
+          FastlaneCore::ConfigItem.new(key: :system_properties,
+                                       env_name: 'FL_GRADLE_SYSTEM_PROPERTIES',
+                                       description: 'Gradle system properties to be exposed to the gradle script',
+                                       optional: true,
+                                       is_string: false),
           FastlaneCore::ConfigItem.new(key: :serial,
                                        env_name: 'FL_ANDROID_SERIAL',
                                        description: 'Android serial, which device should be used for this command',

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.65.0.beta.20171113010004'.freeze
+  VERSION = '2.65.0.beta.20171114010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -2,13 +2,21 @@ module FastlaneCore
   class BuildWatcher
     class << self
       # @return The build we waited for. This method will always return a build
-      def wait_for_build_processing_to_be_complete(app_id: nil, platform: nil, poll_interval: 10)
-        # First, find the train and build version we want to watch for
-        watched_build = watching_build(app_id: app_id, platform: platform)
-        UI.crash!("Could not find a build for app: #{app_id} on platform: #{platform}") if watched_build.nil?
+      def wait_for_build_processing_to_be_complete(app_id: nil, platform: nil, train_version: nil, build_version: nil, poll_interval: 10, strict_build_watch: false)
+        unless strict_build_watch
+          # First, find the train and build version we want to watch for
+          watched_build = watching_build(app_id: app_id, platform: platform)
+          UI.crash!("Could not find a build for app: #{app_id} on platform: #{platform}") if watched_build.nil?
+
+          unless watched_build.train_version == train_version && watched_build.build_version == build_version
+            UI.important("Started watching build #{watched_build.train_version} - #{watched_build.build_version} but expected #{train_version} - #{build_version}")
+          end
+          train_version = watched_build.train_version
+          build_version = watched_build.build_version
+        end
 
         loop do
-          matched_build = matching_build(watched_build: watched_build, app_id: app_id, platform: platform)
+          matched_build = matching_build(watched_train_version: train_version, watched_build_version: build_version, app_id: app_id, platform: platform)
 
           report_status(build: matched_build)
 
@@ -29,9 +37,9 @@ module FastlaneCore
         watched_build || Spaceship::TestFlight::Build.latest(app_id: app_id, platform: platform)
       end
 
-      def matching_build(watched_build: nil, app_id: nil, platform: nil)
-        matched_builds = Spaceship::TestFlight::Build.builds_for_train(app_id: app_id, platform: platform, train_version: watched_build.train_version, retry_count: 2)
-        matched_builds.find { |build| build.build_version == watched_build.build_version }
+      def matching_build(watched_train_version: nil, watched_build_version: nil, app_id: nil, platform: nil)
+        matched_builds = Spaceship::TestFlight::Build.builds_for_train(app_id: app_id, platform: platform, train_version: watched_train_version, retry_count: 2)
+        matched_builds.find { |build| build.build_version == watched_build_version }
       end
 
       def report_status(build: nil)
@@ -44,7 +52,7 @@ module FastlaneCore
           UI.message("Build doesn't show up in the build list anymore, waiting for it to appear again")
         elsif build.active?
           UI.success("Build #{build.train_version} - #{build.build_version} is already being tested")
-        elsif build.ready_to_submit? || build.export_compliance_missing?
+        elsif build.ready_to_submit? || build.export_compliance_missing? || build.review_rejected?
           UI.success("Successfully finished processing the build #{build.train_version} - #{build.build_version}")
         else
           UI.message("Waiting for iTunes Connect to finish processing the new build (#{build.train_version} - #{build.build_version})")

data/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb

@@ -17,6 +17,13 @@ module FastlaneCore
       return nil
     end
 
+    # Fetches the app build number from the given ipa file.
+    def self.fetch_app_build(path)
+      plist = self.fetch_info_plist_file(path)
+      return plist['CFBundleVersion'] if plist
+      return nil
+    end
+
     # Fetches the app platform from the given ipa file.
     def self.fetch_app_platform(path)
       plist = self.fetch_info_plist_file(path)

data/pilot/lib/pilot/build_manager.rb

@@ -35,7 +35,13 @@ module Pilot
       end
 
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
-      latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform, poll_interval: config[:wait_processing_interval])
+      app_version = FastlaneCore::IpaFileAnalyser.fetch_app_version(config[:ipa])
+      app_build = FastlaneCore::IpaFileAnalyser.fetch_app_build(config[:ipa])
+      latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform, train_version: app_version, build_version: app_build, poll_interval: config[:wait_processing_interval], strict_build_watch: config[:wait_for_uploaded_build])
+
+      unless latest_build.train_version == app_version && latest_build.build_version == app_build
+        UI.important("Uploaded app #{app_version} - #{app_build}, but received build #{latest_build.train_version} - #{latest_build.build_version}. If you want to wait for uploaded build to be finished processing, use the `wait_for_uploaded_build` option")
+      end
 
       distribute(options, build: latest_build)
     end

data/pilot/lib/pilot/options.rb

@@ -158,7 +158,12 @@ module Pilot
                                      type: Array,
                                      verify_block: proc do |value|
                                        UI.user_error!("Could not evaluate array from '#{value}'") unless value.kind_of?(Array)
-                                     end)
+                                     end),
+        FastlaneCore::ConfigItem.new(key: :wait_for_uploaded_build,
+                                     env_name: "PILOT_WAIT_FOR_UPLOADED_BUILD",
+                                     description: "Use version info from uploaded ipa file to determine what build to use for distribution. If set to false, latest processing or any latest build will be used",
+                                     is_string: false,
+                                     default_value: false)
       ]
     end
   end

data/precheck/lib/precheck/rules/unreachable_urls_rule.rb

@@ -24,7 +24,9 @@ module Precheck
         return RuleReturn.new(validation_state: Precheck::VALIDATION_STATES[:failed], failure_data: "empty url") if url.empty?
 
         begin
-          request = Faraday.new(URI.encode(url)) do |connection|
+          uri = Addressable::URI.parse(url)
+          uri.fragment = nil
+          request = Faraday.new(URI.encode(uri.to_s)) do |connection|
             connection.use FaradayMiddleware::FollowRedirects
             connection.adapter :net_http
           end

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -69,7 +69,8 @@ module Spaceship::TestFlight
       active: 'testflight.build.state.testing.active',
       ready_to_submit: 'testflight.build.state.submit.ready',
       ready_to_test: 'testflight.build.state.testing.ready',
-      export_compliance_missing: 'testflight.build.state.export.compliance.missing'
+      export_compliance_missing: 'testflight.build.state.export.compliance.missing',
+      review_rejected: 'testflight.build.state.review.rejected'
     }
 
     # Find a Build by `build_id`.
@@ -130,8 +131,12 @@ module Spaceship::TestFlight
       external_state == BUILD_STATES[:export_compliance_missing]
     end
 
+    def review_rejected?
+      external_state == BUILD_STATES[:review_rejected]
+    end
+
     def processed?
-      active? || ready_to_submit? || export_compliance_missing?
+      active? || ready_to_submit? || export_compliance_missing? || review_rejected?
     end
 
     # Getting builds from BuildTrains only gets a partial Build object

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.65.0.beta.20171113010004
+  version: 2.65.0.beta.20171114010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-13 00:00:00.000000000 Z
+date: 2017-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier