fastlane 2.62.0.beta.20171011010003 → 2.62.0.beta.20171014010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 655de0a004eb58da525ad4be8ba304ed511dd7f5
-  data.tar.gz: 95be51a8bb6933d1c8336c93b33fcbbc0f5bdec4
+  metadata.gz: 91e35cb694e77c43f4022a94f6f396d865cd5f38
+  data.tar.gz: e30e419e22a2a08246c78471501cd5cc692afab2
 SHA512:
-  metadata.gz: e20f511b4c826b6d54f7d9065566c8b4fb01239a4a3546a6df2bea2876437d9a51706d4f551b14f2e62a4b66ecc381f70666f8005a9809d199231e7f5b521685
-  data.tar.gz: 735e7a2cc2bdec2c4d8dc3425cd3ec59e99049adf0fc268c965ff2ec85ff56fb15ec2b6a563d3c4c4a41109d3e2d2502f2091df3762ea820cfbdc7d0080f2f39
+  metadata.gz: 99433dbfc2df4a93fe63021e255f178e0e92f1a6a7183403e2de90157f01557393669eba37b7edd249f9a96cd8e62790b9d97261a09af2bf0c5668cbc4ad04a4
+  data.tar.gz: e99633444490b704bcff01ceec19c5b9cb5875e1a7ff81f144d6c1e47488535c4b4852878df25b88d6203cb42325e5d4d0766104086813d048337139f2259d22

data/deliver/lib/assets/DeliverfileDefault

@@ -1,6 +1,6 @@
 ###################### More Options ######################
 # If you want to have even more control, check out the documentation
-# https://github.com/fastlane/fastlane/blob/master/deliver/Deliverfile.md
+# https://docs.fastlane.tools/actions/deliver
 
 
 ###################### Automatically generated ######################

data/deliver/lib/deliver/options.rb

@@ -181,10 +181,12 @@ module Deliver
                                      verify_block: proc do |value|
                                        ENV["FASTLANE_TEAM_NAME"] = value.to_s
                                      end),
+        # rubocop:disable Metrics/LineLength
         FastlaneCore::ConfigItem.new(key: :itc_provider,
                                      env_name: "DELIVER_ITC_PROVIDER",
-                                     description: "The provider short name to be used with the iTMSTransporter to identify your team",
+                                     description: "The provider short name to be used with the iTMSTransporter to identify your team. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
                                      optional: true),
+        # rubocop:enable Metrics/LineLength
         FastlaneCore::ConfigItem.new(key: :overwrite_screenshots,
                                      env_name: "DELIVER_OVERWRITE_SCREENSHOTS",
                                      description: "Clear all previously uploaded screenshots before uploading the new ones",

data/fastlane/lib/fastlane/actions/docs/match.md

@@ -250,13 +250,13 @@ _match_ can even use the same one Git repository for all bundle identifiers.
 
 ### Setup Xcode project
 
-[Docs on how to set up your Xcode project](https://docs.fastlane.tools/codesigning/XcodeProject/)
+[Docs on how to set up your Xcode project](/codesigning/xcode-project/)
 
 #### To build from the command line using [fastlane](https://fastlane.tools)
 
 _match_ automatically pre-fills environment variables with the UUIDs of the correct provisioning profiles, ready to be used in your Xcode project.
 
-More information about how to setup your Xcode project can be found [here](https://docs.fastlane.tools/codesigning/XcodeProject/)
+More information about how to setup your Xcode project can be found [here](/codesigning/xcode-project/)
 
 #### To build from Xcode manually
 
@@ -264,7 +264,7 @@ This is useful when installing your application on your device using the Develop
 
 You can statically select the right provisioning profile in your Xcode project (the name will be `match Development tools.fastlane.app`).
 
-[Docs on how to set up your Xcode project](/codesigning/xcode-project/.md)
+[Docs on how to set up your Xcode project](/codesigning/xcode-project/)
 
 ### Continuous Integration
 

data/fastlane/lib/fastlane/actions/docs/snapshot.md

@@ -91,7 +91,7 @@ Here a few links to get started:
 - In your UI Test class, click the `Record` button on the bottom left and record your interaction
 - To take a snapshot, call the following between interactions
  -  Swift: `snapshot("01LoginScreen")`
- -  Objective C: `[Snapshot snapshot:@"01LoginScreen" waitForLoadingIndicator:YES];`
+ -  Objective C: `[Snapshot snapshot:@"01LoginScreen" timeWaitingForIdle:10];`
 - Add the following code to your `setUp()` method
 
 **Swift**

data/fastlane/lib/fastlane/actions/hockey.rb

@@ -119,7 +119,7 @@ module Fastlane
         else
 
           if build_file.nil?
-            UI.user_error!("You have to provide a build file")
+            UI.user_error!("You have to provide a build file (params 'apk' or 'ipa')")
           end
 
           if options[:ipa].to_s.end_with?(".ipa")

data/fastlane/lib/fastlane/actions/pod_push.rb

@@ -18,6 +18,11 @@ module Fastlane
           command << " --sources='#{sources}'"
         end
 
+        if params[:swift_version]
+          swift_version = params[:swift_version]
+          command << " --swift-version=#{swift_version}"
+        end
+
         if params[:allow_warnings]
           command << " --allow-warnings"
         end
@@ -74,6 +79,10 @@ module Fastlane
                                        verify_block: proc do |value|
                                          UI.user_error!("Sources must be an array.") unless value.kind_of?(Array)
                                        end),
+          FastlaneCore::ConfigItem.new(key: :swift_version,
+                                       description: "The SWIFT_VERSION that should be used to lint the spec. This takes precedence over a .swift-version file",
+                                       optional: true,
+                                       is_string: false),
           FastlaneCore::ConfigItem.new(key: :verbose,
                                        description: "Show more debugging information",
                                        optional: true,

data/fastlane/lib/fastlane/actions/update_project_team.rb

@@ -32,6 +32,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :path,
                                        env_name: "FL_PROJECT_SIGNING_PROJECT_PATH",
                                        description: "Path to your Xcode project",
+                                       default_value: Dir['*.xcodeproj'].first,
                                        verify_block: proc do |value|
                                          UI.user_error!("Path is invalid") unless File.exist?(value)
                                        end),
@@ -52,6 +53,7 @@ module Fastlane
 
       def self.example_code
         [
+          'update_project_team',
           'update_project_team(
             path: "Example.xcodeproj",
             teamid: "A3ZZVJ7CNY"

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -83,7 +83,9 @@ module Fastlane
         command << "-p #{params[:platform] == 'appletvos' ? 'tvos' : params[:platform]}"
         command << File.expand_path(path).shellescape
         begin
-          Actions.sh(command.join(" "), log: false)
+          command_to_execute = command.join(" ")
+          UI.verbose("upload_dsym using command: #{command_to_execute}")
+          Actions.sh(command_to_execute, log: false)
         rescue => ex
           UI.error ex.to_s # it fails, however we don't want to fail everything just for this
         end
@@ -96,6 +98,7 @@ module Fastlane
             next unless result
             next unless result.kind_of?(Hash)
             params[:api_token] ||= result["APIKey"]
+            UI.verbose("found an APIKey in #{current}")
           end
         end
         UI.user_error!("Please provide an api_token using api_token:") unless params[:api_token]

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.62.0.beta.20171011010003'.freeze
+  VERSION = '2.62.0.beta.20171014010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/gym/lib/gym/detect_values.rb

@@ -65,9 +65,11 @@ module Gym
       Gym.config[:export_options] ||= {}
       hash_to_use = (Gym.config[:export_options][:provisioningProfiles] || {}).dup || {} # dup so we can show the original values in `verbose` mode
 
-      mapping_object = CodeSigningMapping.new(project: Gym.project)
-      hash_to_use = mapping_object.merge_profile_mapping(primary_mapping: hash_to_use,
+      unless Gym.config[:skip_profile_detection]
+        mapping_object = CodeSigningMapping.new(project: Gym.project)
+        hash_to_use = mapping_object.merge_profile_mapping(primary_mapping: hash_to_use,
                                                            export_method: Gym.config[:export_method])
+      end
 
       return if hash_to_use.count == 0 # We don't want to set a mapping if we don't have one
       Gym.config[:export_options][:provisioningProfiles] = hash_to_use

data/gym/lib/gym/generators/package_command_generator_xcode7.rb

@@ -31,6 +31,7 @@ module Gym
         options << "-exportPath '#{temporary_output_path}'"
         options << "-toolchain '#{config[:toolchain]}'" if config[:toolchain]
         options << config[:export_xcargs] if config[:export_xcargs]
+        options << config[:xcargs] if config[:xcargs]
 
         options
       end

data/gym/lib/gym/options.rb

@@ -234,7 +234,13 @@ module Gym
                                      env_name: "XCPRETTY_UTF",
                                      description: "Have xcpretty use unicode encoding when reporting builds",
                                      optional: true,
-                                     is_string: false)
+                                     is_string: false),
+        FastlaneCore::ConfigItem.new(key: :skip_profile_detection,
+                                     env_name: "GYM_SKIP_PROFILE_DETECTION",
+                                     description: "Do not try to build a profile mapping from the xcodeproj. Match or a manually provided mapping should be used",
+                                     optional: true,
+                                     is_string: false,
+                                     default_value: false)
       ]
     end
   end

data/pilot/lib/pilot/options.rb

@@ -144,10 +144,12 @@ module Pilot
                                      verify_block: proc do |value|
                                        ENV["FASTLANE_TEAM_ID"] = value.to_s
                                      end),
+        # rubocop:disable Metrics/LineLength
         FastlaneCore::ConfigItem.new(key: :itc_provider,
                                      env_name: "PILOT_ITC_PROVIDER",
-                                     description: "The provider short name to be used with the iTMSTransporter to identify your team",
+                                     description: "The provider short name to be used with the iTMSTransporter to identify your team. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
                                      optional: true),
+        # rubocop:enable Metrics/LineLength
         FastlaneCore::ConfigItem.new(key: :groups,
                                      short_option: "-g",
                                      env_name: "PILOT_GROUPS",

data/snapshot/lib/assets/SnapshotHelper.swift

@@ -19,17 +19,23 @@ import XCTest
 var deviceLanguage = ""
 var locale = ""
 
-@available(*, deprecated, message: "use setupSnapshot: instead")
-func setLanguage(_ app: XCUIApplication) {
-    setupSnapshot(app)
-}
-
 func setupSnapshot(_ app: XCUIApplication) {
     Snapshot.setupSnapshot(app)
 }
 
-func snapshot(_ name: String, waitForLoadingIndicator: Bool = true) {
-    Snapshot.snapshot(name, waitForLoadingIndicator: waitForLoadingIndicator)
+func snapshot(_ name: String, waitForLoadingIndicator: Bool) {
+    if waitForLoadingIndicator {
+        Snapshot.snapshot(name)
+    } else {
+        Snapshot.snapshot(name, timeWaitingForIdle: 0)
+    }
+}
+
+/// - Parameters:
+///   - name: The name of the snapshot
+///   - timeout: Amount of seconds to wait until the network loading indicator disappears. Pass `0` if you don't want to wait.
+func snapshot(_ name: String, timeWaitingForIdle timeout: TimeInterval = 20) {
+    Snapshot.snapshot(name, timeWaitingForIdle: timeout)
 }
 
 enum SnapshotError: Error, CustomDebugStringConvertible {
@@ -37,7 +43,7 @@ enum SnapshotError: Error, CustomDebugStringConvertible {
     case cannotFindHomeDirectory
     case cannotFindSimulatorHomeDirectory
     case cannotAccessSimulatorHomeDirectory(String)
-    
+
     var debugDescription: String {
         switch self {
         case .cannotDetectUser:
@@ -116,9 +122,9 @@ open class Snapshot: NSObject {
         }
     }
 
-    open class func snapshot(_ name: String, waitForLoadingIndicator: Bool = true) {
-        if waitForLoadingIndicator {
-            waitForLoadingIndicatorToDisappear()
+    open class func snapshot(_ name: String, timeWaitingForIdle timeout: TimeInterval = 20) {
+        if timeout > 0 {
+            waitForLoadingIndicatorToDisappear(within: timeout)
         }
 
         print("snapshot: \(name)") // more information about this, check out https://github.com/fastlane/fastlane/tree/master/snapshot#how-does-it-work
@@ -140,17 +146,14 @@ open class Snapshot: NSObject {
         #endif
     }
 
-    class func waitForLoadingIndicatorToDisappear() {
+    class func waitForLoadingIndicatorToDisappear(within timeout: TimeInterval) {
         #if os(tvOS)
             return
         #endif
 
-        let query = XCUIApplication().statusBars.children(matching: .other).element(boundBy: 1).children(matching: .other)
-
-        while (0..<query.count).map({ query.element(boundBy: $0) }).contains(where: { $0.isLoadingIndicator }) {
-            sleep(1)
-            print("Waiting for loading indicator to disappear...")
-        }
+        let networkLoadingIndicator = XCUIApplication().otherElements.deviceStatusBars.networkLoadingIndicators.element
+        let networkLoadingIndicatorDisappeared = XCTNSPredicateExpectation(predicate: NSPredicate(format: "exists == false"), object: networkLoadingIndicator)
+        XCTWaiter.wait(for: [networkLoadingIndicatorDisappeared], timeout: timeout)
     }
 
     class func pathPrefix() throws -> URL? {
@@ -180,16 +183,63 @@ open class Snapshot: NSObject {
     }
 }
 
-extension XCUIElement {
-    var isLoadingIndicator: Bool {
-        let whiteListedLoaders = ["GeofenceLocationTrackingOn", "StandardLocationTrackingOn"]
-        if whiteListedLoaders.contains(self.identifier) {
-            return false
+private extension XCUIElementAttributes {
+    var isNetworkLoadingIndicator: Bool {
+        if hasWhiteListedIdentifier { return false }
+
+        let hasOldLoadingIndicatorSize = frame.size == CGSize(width: 10, height: 20)
+        let hasNewLoadingIndicatorSize = frame.size.width.isBetween(46, and: 47) && frame.size.height.isBetween(2, and: 3)
+
+        return hasOldLoadingIndicatorSize || hasNewLoadingIndicatorSize
+    }
+
+    var hasWhiteListedIdentifier: Bool {
+        let whiteListedIdentifiers = ["GeofenceLocationTrackingOn", "StandardLocationTrackingOn"]
+
+        return whiteListedIdentifiers.contains(identifier)
+    }
+
+    func isStatusBar(_ deviceWidth: CGFloat) -> Bool {
+        if elementType == .statusBar { return true }
+        guard frame.origin == .zero else { return false }
+
+        let oldStatusBarSize = CGSize(width: deviceWidth, height: 20)
+        let newStatusBarSize = CGSize(width: deviceWidth, height: 44)
+
+        return [oldStatusBarSize, newStatusBarSize].contains(frame.size)
+    }
+}
+
+private extension XCUIElementQuery {
+    var networkLoadingIndicators: XCUIElementQuery {
+        let isNetworkLoadingIndicator = NSPredicate { (evaluatedObject, _) in
+            guard let element = evaluatedObject as? XCUIElementAttributes else { return false }
+
+            return element.isNetworkLoadingIndicator
         }
-        return self.frame.size == CGSize(width: 10, height: 20)
+
+        return self.containing(isNetworkLoadingIndicator)
+    }
+
+    var deviceStatusBars: XCUIElementQuery {
+        let deviceWidth = XCUIApplication().frame.width
+
+        let isStatusBar = NSPredicate { (evaluatedObject, _) in
+            guard let element = evaluatedObject as? XCUIElementAttributes else { return false }
+
+            return element.isStatusBar(deviceWidth)
+        }
+
+        return self.containing(isStatusBar)
+    }
+}
+
+private extension CGFloat {
+    func isBetween(_ numberA: CGFloat, and numberB: CGFloat) -> Bool {
+        return numberA...numberB ~= self
     }
 }
 
 // Please don't remove the lines below
 // They are used to detect outdated configuration files
-// SnapshotHelperVersion [1.5]
+// SnapshotHelperVersion [1.6]

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -111,6 +111,30 @@ module Spaceship
       send_shared_login_request(user, password)
     end
 
+    # Sometimes we get errors or info nested in our data
+    # This method allows you to pass in a set of keys to check for
+    # along with the name of the sub_section of your original data
+    # where we should check
+    # Returns a mapping of keys to data array if we find anything, otherwise, empty map
+    def fetch_errors_in_data(data_section: nil, sub_section_name: nil, keys: nil)
+      if data_section && sub_section_name
+        sub_section = data_section[sub_section_name]
+      else
+        sub_section = data_section
+      end
+
+      unless sub_section
+        return {}
+      end
+
+      error_map = {}
+      keys.each do |key|
+        errors = sub_section.fetch(key, [])
+        error_map[key] = errors if errors.count > 0
+      end
+      return error_map
+    end
+
     # rubocop:disable Metrics/PerceivedComplexity
     # If the response is coming from a flaky api, set flaky_api_call to true so we retry a little.
     # Patience is a virtue.
@@ -119,12 +143,17 @@ module Spaceship
       return unless raw.kind_of? Hash
 
       data = raw['data'] || raw # sometimes it's with data, sometimes it isn't
+      error_keys_to_check = [
+        "sectionErrorKeys",
+        "sectionInfoKeys",
+        "sectionWarningKeys",
+        "validationErrors"
+      ]
+      errors_in_data = fetch_errors_in_data(data_section: data, keys: error_keys_to_check)
+      errors_in_version_info = fetch_errors_in_data(data_section: data, sub_section_name: "versionInfo", keys: error_keys_to_check)
 
-      if data.fetch('sectionErrorKeys', []).count == 0 and
-         data.fetch('sectionInfoKeys', []).count == 0 and
-         data.fetch('sectionWarningKeys', []).count == 0 and
-         data.fetch('validationErrors', []).count == 0
-
+      # If we have any errors or "info" we need to treat them as warnings or errors
+      if errors_in_data.count == 0 && errors_in_version_info.count == 0
         logger.debug("Request was successful")
       end
 
@@ -154,8 +183,15 @@ module Spaceship
       end
 
       errors = handle_response_hash.call(data)
-      errors += data.fetch('sectionErrorKeys', [])
-      errors += data.fetch('validationErrors', [])
+
+      # Search at data level, as well as "versionInfo" level for errors
+      error_keys = ["sectionErrorKeys", "validationErrors"]
+      errors_in_data = fetch_errors_in_data(data_section: data, keys: error_keys)
+      errors_in_version_info = fetch_errors_in_data(data_section: data, sub_section_name: "versionInfo", keys: error_keys)
+
+      errors += errors_in_data.values if errors_in_data.values
+      errors += errors_in_version_info.values if errors_in_version_info.values
+      errors = errors.flat_map { |value| value }
 
       # Sometimes there is a different kind of error in the JSON response
       # e.g. {"warn"=>nil, "error"=>["operation_failed"], "info"=>nil}
@@ -177,8 +213,18 @@ module Spaceship
         end
       end
 
-      puts data['sectionInfoKeys'] if data['sectionInfoKeys']
-      puts data['sectionWarningKeys'] if data['sectionWarningKeys']
+      # Search at data level, as well as "versionInfo" level for info and warnings
+      info_keys = ["sectionInfoKeys", "sectionWarningKeys"]
+      info_in_data = fetch_errors_in_data(data_section: data, keys: info_keys)
+      info_in_version_info = fetch_errors_in_data(data_section: data, sub_section_name: "versionInfo", keys: info_keys)
+
+      info_in_data.each do |info_key, info_value|
+        puts(info_value)
+      end
+
+      info_in_version_info.each do |info_key, info_value|
+        puts(info_value)
+      end
 
       return data
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.62.0.beta.20171011010003
+  version: 2.62.0.beta.20171014010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-11 00:00:00.000000000 Z
+date: 2017-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1497,24 +1497,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- spaceship/lib
-- scan/lib
+- supply/lib
+- screengrab/lib
+- match/lib
+- precheck/lib
 - sigh/lib
+- produce/lib
+- scan/lib
+- gym/lib
 - snapshot/lib
-- screengrab/lib
+- frameit/lib
 - fastlane/lib
 - cert/lib
-- pem/lib
-- gym/lib
-- produce/lib
-- deliver/lib
-- supply/lib
-- match/lib
-- frameit/lib
-- credentials_manager/lib
 - pilot/lib
-- precheck/lib
+- spaceship/lib
+- credentials_manager/lib
+- deliver/lib
 - fastlane_core/lib
+- pem/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="