fastlane 2.58.0.beta.20170919010003 → 2.58.0.beta.20170920010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 062d1ebef3c070002849d24fadc7665693f5adf0
-  data.tar.gz: 731ede3f44e04f2b7c2f22a3fcfd132ad860d0f7
+  metadata.gz: a1aee2a4ce2c2f291827675b8cfbc2509337817f
+  data.tar.gz: 2c0a3895848af582417fcbf8581ea28cd6667b3b
 SHA512:
-  metadata.gz: aa91a3786f1301d51c2bf9815151fae38c4bc2d0a39db93c2524e6305075d0fb0483125ac61653f43999b84942b73f9cb52c01c6814ac4ab7f3335ffc9970c1c
-  data.tar.gz: 63149c261201f11f14499902524e8ba28930705879b4c383917809fa66de609cac8e351729569f7f0b44875a01540cf76d83d45ca9d915b68bffef902955cb71
+  metadata.gz: 7246060005b8de3927014bc6237032ae0e816c5a3dcc378f59a4235e3560ded56bf101e5cdee8e9034a419cab0f7800d697ee8ff0d561f33241fa81435c24431
+  data.tar.gz: 964fc6bfcdd559f16578c22c484ead850d588dfff08a3ec15183477e411ece96b3fb169f305e767e00779889141bee6f7278108360db12525fdbdb9f0f3f2d31

data/cert/lib/cert/runner.rb

@@ -5,7 +5,7 @@ module Cert
     def launch
       run
 
-      installed = FastlaneCore::CertChecker.installed?(ENV["CER_FILE_PATH"], Cert.config[:keychain_path], Cert.config[:keychain_password])
+      installed = FastlaneCore::CertChecker.installed?(ENV["CER_FILE_PATH"])
       UI.message "Verifying the certificate is properly installed locally..."
       UI.user_error!("Could not find the newly generated certificate installed", show_github_issues: true) unless installed
       UI.success "Successfully installed certificate #{ENV['CER_CERTIFICATE_ID']}"

data/fastlane/lib/fastlane/actions/prompt.rb

@@ -44,7 +44,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :text,
                                        description: "The text that will be displayed to the user",
-                                       default_value: "Please enter a text: "),
+                                       default_value: "Please enter some text: "),
           FastlaneCore::ConfigItem.new(key: :ci_input,
                                        description: "The default text that will be used when being executed on a CI service",
                                        default_value: ''),

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.58.0.beta.20170919010003'.freeze
+  VERSION = '2.58.0.beta.20170920010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/fastlane_core/lib/fastlane_core/cert_checker.rb

@@ -3,10 +3,10 @@ require 'tempfile'
 module FastlaneCore
   # This class checks if a specific certificate is installed on the current mac
   class CertChecker
-    def self.installed?(path, keychain = nil, password = nil)
+    def self.installed?(path)
       UI.user_error!("Could not find file '#{path}'") unless File.exist?(path)
 
-      ids = installed_identies(keychain, password)
+      ids = installed_identies
       finger_print = sha1_fingerprint(path)
 
       return ids.include? finger_print
@@ -17,10 +17,10 @@ module FastlaneCore
       installed?(path)
     end
 
-    def self.installed_identies(keychain, password)
+    def self.installed_identies
       install_wwdr_certificate unless wwdr_certificate_installed?
 
-      available = list_available_identities(keychain, password)
+      available = list_available_identities
       # Match for this text against word boundaries to avoid edge cases around multiples of 10 identities!
       if /\b0 valid identities found\b/ =~ available
         UI.error([
@@ -44,13 +44,8 @@ module FastlaneCore
       return ids
     end
 
-    def self.list_available_identities(keychain, password)
-      keychain = File.expand_path(keychain)
-      locked = keychain and !system("security show-keychain-info #{keychain} >/dev/null 2>/dev/null")
-      `security unlock -p #{password} #{keychain}` if locked
-      `security find-identity -v -p codesigning #{keychain}`
-    ensure
-      `security lock #{keychain}` if locked
+    def self.list_available_identities
+      `security find-identity -v -p codesigning`
     end
 
     def self.wwdr_certificate_installed?

data/fastlane_core/lib/fastlane_core/ipa_upload_package_builder.rb

@@ -34,7 +34,7 @@ module FastlaneCore
     private
 
     def copy_ipa(ipa_path)
-      ipa_file_name = "#{File.basename(ipa_path, '.ipa')}(#{Digest::SHA256.file(ipa_path).hexdigest}).ipa"
+      ipa_file_name = "#{File.basename(ipa_path, '.ipa')}_#{Digest::SHA256.file(ipa_path).hexdigest}.ipa"
       resulting_path = File.join(self.package_path, ipa_file_name)
       FileUtils.cp(ipa_path, resulting_path)
 

data/fastlane_core/lib/fastlane_core/ui/github_issue_inspector_reporter.rb

@@ -17,6 +17,7 @@ module Fastlane
       report.issues[0..(NUMBER_OF_ISSUES_INLINE - 1)].each { |issue| print_issue_full(issue) }
 
       if report.issues.count > NUMBER_OF_ISSUES_INLINE
+        report.url.sub!('\'', '%27')
         puts "and #{report.total_results - NUMBER_OF_ISSUES_INLINE} more at: #{report.url}"
         puts ""
       end

data/precheck/lib/precheck/options.rb

@@ -12,6 +12,7 @@ module Precheck
         FutureFunctionalityRule,
         TestWordsRule,
         CurseWordsRule,
+        FreeStuffIAPRule,
         CustomTextRule,
         CopyrightDateRule,
         UnreachableURLRule
@@ -56,7 +57,14 @@ module Precheck
                                      env_name: "PRECHECK_DEFAULT_RULE_LEVEL",
                                      description: "The default rule level unless otherwise configured",
                                      is_string: false,
-                                     default_value: RULE_LEVELS[:error])
+                                     default_value: RULE_LEVELS[:error]),
+        FastlaneCore::ConfigItem.new(key: :include_in_app_purchases,
+                                     short_option: "-i",
+                                     env_name: "PRECHECK_INCLUDE_IN_APP_PURCHASES",
+                                     description: "Should check in-app purchases?",
+                                     is_string: false,
+                                     optional: true,
+                                     default_value: true)
       ] + rules
     end
   end

data/precheck/lib/precheck/rule_processor.rb

@@ -149,6 +149,7 @@ module Precheck
 
     def self.generate_text_items_to_check(app: nil, app_version: nil)
       items = []
+
       items << TextItemToCheck.new(app_version.copyright, :copyright, "copyright")
 
       items += collect_text_items_from_language_item(hash: app_version.keywords,
@@ -175,10 +176,34 @@ module Precheck
                                                 item_name: :app_subtitle,
                                     friendly_name_postfix: "app name subtitle",
                                               is_optional: true)
+
+      should_include_iap = Precheck.config[:include_in_app_purchases]
+      if should_include_iap
+        UI.message "Reading in-app purchases. If you have a lot, this might take a while"
+        UI.message "You can disable IAP checking by setting the `include_in_app_purchases` flag to `false`"
+        in_app_purchases = app.in_app_purchases.all
+        in_app_purchases ||= []
+        in_app_purchases.each do |purchase|
+          items += collect_iap_language_items(purchase_edit_versions: purchase.edit.versions)
+        end
+        UI.message "Done reading in-app purchases"
+      end
+
+      return items
+    end
+
+    def self.collect_iap_language_items(purchase_edit_versions: nil, is_optional: false)
+      items = []
+      purchase_edit_versions.each do |language_key, hash|
+        name = hash[:name]
+        description = hash[:description]
+        items << TextItemToCheck.new(name, :in_app_purchase, "in-app purchase name: #{name}: (#{language_key})", is_optional)
+        items << TextItemToCheck.new(description, :in_app_purchase, "in-app purchase desc: #{description}: (#{language_key})", is_optional)
+      end
       return items
     end
 
-    #   # a few attributes are LanguageItem this method creates a TextItemToCheck for each pair
+    # a few attributes are LanguageItem this method creates a TextItemToCheck for each pair
     def self.collect_text_items_from_language_item(hash: nil, item_name: nil, friendly_name_postfix: nil, is_optional: false)
       items = []
       hash.each do |key, value|

data/precheck/lib/precheck/rules/free_stuff_iap_rule.rb

@@ -0,0 +1,32 @@
+require 'precheck/rule'
+require 'precheck/rules/abstract_text_match_rule'
+
+module Precheck
+  class FreeStuffIAPRule < AbstractTextMatchRule
+    def self.key
+      :free_stuff_in_iap
+    end
+
+    def self.env_name
+      "RULE_FREE_STUFF_IN_IAP"
+    end
+
+    def self.friendly_name
+      "No words indicating your IAP is free"
+    end
+
+    def self.description
+      "using text indicating that your IAP is free"
+    end
+
+    def supported_fields_symbol_set
+      [:in_app_purchase].to_set
+    end
+
+    def lowercased_words_to_look_for
+      [
+        "free"
+      ].map(&:downcase)
+    end
+  end
+end

data/snapshot/lib/snapshot/reports_generator.rb

@@ -88,6 +88,7 @@ module Snapshot
         'Apple TV 1080p' => 'Apple TV',
         'Apple TV 4K (at 1080p)' => 'Apple TV 4K (at 1080p)',
         'Apple TV 4K' => 'Apple TV 4K',
+        'Apple TV' => 'Apple TV',
         'Mac' => 'Mac'
       }
     end

data/snapshot/lib/snapshot/test_command_generator.rb

@@ -55,9 +55,17 @@ module Snapshot
         end
         # Return true if all devices are iOS devices
         return true unless all_ios.include?(false)
+
+        all_tvos = devices.map do |device|
+          device = device.downcase
+          device.start_with?('apple tv')
+        end
+        # Return true if all devices are iOS devices
+        return true unless all_tvos.include?(false)
+
         # There should only be more than 1 device type if
-        # it is iOS, therefore, if there is more than 1
-        # device in the array, and they are not all iOS
+        # it is iOS or tvOS, therefore, if there is more than 1
+        # device in the array, and they are not all iOS or tvOS
         # as checked above, that would imply that this is a mixed bag
         return devices.count == 1
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.58.0.beta.20170919010003
+  version: 2.58.0.beta.20170920010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-19 00:00:00.000000000 Z
+date: 2017-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1246,6 +1246,7 @@ files:
 - precheck/lib/precheck/rules/copyright_date_rule.rb
 - precheck/lib/precheck/rules/curse_words_rule.rb
 - precheck/lib/precheck/rules/custom_text_rule.rb
+- precheck/lib/precheck/rules/free_stuff_iap_rule.rb
 - precheck/lib/precheck/rules/future_functionality_rule.rb
 - precheck/lib/precheck/rules/negative_apple_sentiment_rule.rb
 - precheck/lib/precheck/rules/other_platforms_rule.rb