fastlane 2.56.0.beta.20170907010003 → 2.56.0.beta.20170908010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2839e587204146a6814c5a55b3e178da5aedf736
-  data.tar.gz: d0ec06f58ae3104b329b1e990858b4645cfa67da
+  metadata.gz: 72272fe0f501813a435dd4c3070400647818d4d4
+  data.tar.gz: 10e25aa18e05dc977efcc70e0424a377985dd0fd
 SHA512:
-  metadata.gz: ebc67ba6999698a3f4d79bb5b4cf3c952999695d8293099db5274668dd141dff6d75f9f4de6be447d312f81754f4665f580d696c475abc0d152264b7ff0002cf
-  data.tar.gz: b1c03e9c386a9531a640cb0eba3b22178558f73df04fb3f29745914aa2467042d5583e516be21470086d5d29dc9e4aeb4f7e4d50df36a355e650eecc8f512ce6
+  metadata.gz: 25b341e98475a2c8588b94b77f97a96d61a1c8d0e076935cb952c0543391b98d89cec0a444e025854884d57b0f8b72f5d4a08e769e67826f27f82c3eb1132af6
+  data.tar.gz: f41ecd0b5405ac0481b9db7e4ced3b135cb1531e1c55df1a08db51237cc373474098adaab5e6f712bffeefddad0de99b2c956f5da0daf517c96e903c702d7615

data/credentials_manager/lib/credentials_manager/account_manager.rb

@@ -33,7 +33,9 @@ module CredentialsManager
     end
 
     def fetch_password_from_env
-      ENV["FASTLANE_PASSWORD"] || ENV["DELIVER_PASSWORD"]
+      password = ENV["FASTLANE_PASSWORD"] || ENV["DELIVER_PASSWORD"]
+      return password if password.to_s.length > 0
+      return nil
     end
 
     def password(ask_if_missing: true)

data/deliver/lib/deliver/commands_generator.rb

@@ -102,7 +102,10 @@ module Deliver
           end
 
           require 'deliver/setup'
+
           options = FastlaneCore::Configuration.create(deliverfile_options, options.__hash__)
+          options[:run_precheck_before_submit] = false # precheck doesn't need to run during init
+
           Deliver::Runner.new(options) # to login...
           Deliver::Setup.new.run(options)
         end

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -1,3 +1,5 @@
+require 'thread'
+
 module Fastlane
   module Actions
     class UploadSymbolsToCrashlyticsAction < Action
@@ -20,8 +22,13 @@ module Fastlane
         dsym_paths = dsym_paths.collect { |a| File.expand_path(a) }
         dsym_paths.uniq!
 
+        max_worker_threads = params[:dsym_worker_threads]
+        if max_worker_threads > 1
+          UI.message("Using #{max_worker_threads} threads for Crashlytics dSYM upload 🏎")
+        end
+
         dsym_paths.each do |current_path|
-          handle_dsym(params, current_path)
+          handle_dsym(params, current_path, max_worker_threads)
         end
 
         UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
@@ -29,7 +36,7 @@ module Fastlane
 
       # @param current_path this is a path to either a dSYM or a zipped dSYM
       #   this might also be either nested or not, we're flexible
-      def self.handle_dsym(params, current_path)
+      def self.handle_dsym(params, current_path, max_worker_threads)
         if current_path.end_with?(".dSYM")
           upload_dsym(params, current_path)
         elsif current_path.end_with?(".zip")
@@ -39,9 +46,11 @@ module Fastlane
           Dir.mktmpdir do |dir|
             Dir.chdir(dir) do
               Actions.sh("unzip -qo #{current_path.shellescape}")
+              work_q = Queue.new
               Dir["*.dSYM"].each do |sub|
-                handle_dsym(params, sub)
+                work_q.push sub
               end
+              execute_uploads(params, max_worker_threads, work_q)
             end
           end
         else
@@ -49,6 +58,23 @@ module Fastlane
         end
       end
 
+      def self.execute_uploads(params, max_worker_threads, work_q)
+        number_of_threads = [max_worker_threads, work_q.size].min
+        workers = (0...number_of_threads).map do
+          Thread.new do
+            begin
+              while work_q.size > 0
+                current_path = work_q.pop(true)
+                upload_dsym(params, current_path)
+              end
+            rescue => ex
+              UI.error ex.to_s
+            end
+          end
+        end
+        workers.map(&:join)
+      end
+
       def self.upload_dsym(params, path)
         UI.message("Uploading '#{path}'...")
         command = []
@@ -133,6 +159,18 @@ module Fastlane
                                        verify_block: proc do |value|
                                          available = ['ios', 'appletvos', 'mac']
                                          UI.user_error!("Invalid platform '#{value}', must be #{available.join(', ')}") unless available.include?(value)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :dsym_worker_threads,
+                                       env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_DSYM_WORKER_THREADS",
+                                       type: Integer,
+                                       default_value: 1,
+                                       optional: true,
+                                       description: "The number of threads to use for simultaneous dSYM upload",
+                                       verify_block: proc do |value|
+                                         min_threads = 1
+                                         max_threads = 15
+                                         UI.user_error!("Too few threads (#{value}) minimum number of threads: #{min_threads}") unless value >= min_threads
+                                         UI.user_error!("Too many threads (#{value}) maximum number of threads: #{max_threads}") unless value <= max_threads
                                        end)
         ]
       end

data/fastlane/lib/fastlane/environment_printer.rb

@@ -258,7 +258,7 @@ module Fastlane
         env_output << "\n"
         env_output << "```ruby\n"
         env_output <<  File.read(fastlane_path)
-        env_output <<  "```\n"
+        env_output <<  "\n```\n"
         env_output << "</details>"
       else
         env_output << "**No Fastfile found**\n"
@@ -272,7 +272,7 @@ module Fastlane
         env_output << "\n"
         env_output << "```ruby\n"
         env_output <<  File.read(appfile_path)
-        env_output <<  "```\n"
+        env_output <<  "\n```\n"
         env_output << "</details>"
       else
         env_output << "**No Appfile found**\n"

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.56.0.beta.20170907010003'.freeze
+  VERSION = '2.56.0.beta.20170908010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/fastlane_core/lib/fastlane_core/cert_checker.rb

@@ -61,7 +61,7 @@ module FastlaneCore
       filename = file.path
       keychain = wwdr_keychain
       keychain = "-k #{keychain.shellescape}" unless keychain.empty?
-      Helper.backticks("curl -o #{filename} #{url} && security import #{filename} #{keychain}", print: FastlaneCore::Globals.verbose?)
+      Helper.backticks("curl -f -o #{filename} #{url} && security import #{filename} #{keychain}", print: FastlaneCore::Globals.verbose?)
       UI.user_error!("Could not install WWDR certificate") unless $?.success?
     end
 

data/gym/lib/gym/error_handler.rb

@@ -214,8 +214,9 @@ module Gym
       def print_environment_information
         if Gym.config[:export_method].to_s == "development"
           UI.message("")
-          UI.error("Your `export_method` in gym is defined as `:development`")
-          UI.error("which can't be used for `ipa` files for beta or App Store distribution")
+          UI.error("Your `export_method` in gym is defined as `development`")
+          UI.error("which might cause problems when signing your application")
+          UI.error("Are you sure want to build and export for development?")
           UI.error("Please make sure to define the correct export methods when calling")
           UI.error("gym in your Fastfile or from the command line")
           UI.message("")

data/match/README.md

@@ -274,6 +274,8 @@ end
 
 By using the `force_for_new_devices` parameter, `match` will check if the device count has changed since the last time you ran `match`, and automatically re-generate the provisioning profile if necessary. You can also use `force: true` to re-generate the provisioning profile on each run.
 
+_**Important:** The `force_for_new_devices` parameter is ignored for App Store provisioning profiles since they don't contain any device information._
+
 If you're not using `fastlane`, you can also use the `force_for_new_devices` option from the command line:
 
 ```

data/match/lib/match/options.rb

@@ -125,7 +125,7 @@ module Match
                                      optional: true),
         FastlaneCore::ConfigItem.new(key: :force_for_new_devices,
                                      env_name: "MATCH_FORCE_FOR_NEW_DEVICES",
-                                     description: "Renew the provisioning profiles if the device count on the developer portal has changed",
+                                     description: "Renew the provisioning profiles if the device count on the developer portal has changed. Ignored for profile type 'appstore'",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :skip_docs,

data/match/lib/match/runner.rb

@@ -120,7 +120,14 @@ module Match
       profile = profiles.last
 
       if params[:force_for_new_devices] && !params[:readonly]
-        params[:force] = device_count_different?(profile: profile) unless params[:force]
+        if prov_type != :appstore
+          params[:force] = device_count_different?(profile: profile) unless params[:force]
+        else
+          # App Store provisioning profiles don't contain device identifiers and
+          # thus shouldn't be renewed if the device count has changed.
+          UI.important "Warning: `force_for_new_devices` is set but is ignored for App Store provisioning profiles."
+          UI.important "You can safely stop specifying `force_for_new_devices` when running Match for type 'appstore'."
+        end
       end
 
       if profile.nil? or params[:force]

data/precheck/lib/precheck/rule_processor.rb

@@ -55,7 +55,7 @@ module Precheck
       rules.each do |rule|
         rule_config = Precheck.config[rule.key]
         rule_level = rule_config[:level].to_sym unless rule_config.nil?
-        rule_level ||= Precheck.config[:default_rule_level]
+        rule_level ||= Precheck.config[:default_rule_level].to_sym
 
         if rule_level == RULE_LEVELS[:skip]
           skipped_rules << rule
@@ -87,13 +87,18 @@ module Precheck
 
           # if we passed, then go to the next item, otherwise, recode the failure
           next unless result.status == VALIDATION_STATES[:failed]
-          add_new_result_to_rule_hash(rule_hash: error_results, result: result) if rule_level == RULE_LEVELS[:error]
-          add_new_result_to_rule_hash(rule_hash: warning_results, result: result) if rule_level == RULE_LEVELS[:warn]
+          error_results = add_new_result_to_rule_hash(rule_hash: error_results, result: result) if rule_level == RULE_LEVELS[:error]
+          warning_results = add_new_result_to_rule_hash(rule_hash: warning_results, result: result) if rule_level == RULE_LEVELS[:warn]
           rule_failed_at_least_once = true
         end
 
         if rule_failed_at_least_once
-          UI.error "😵  Failed: #{rule.class.friendly_name}-> #{rule.description}"
+          message = "😵  Failed: #{rule.class.friendly_name}-> #{rule.description}"
+          if rule_level == RULE_LEVELS[:error]
+            UI.error message
+          else
+            UI.important message
+          end
         else
           UI.message "✅  Passed: #{rule.class.friendly_name}"
         end
@@ -109,9 +114,12 @@ module Precheck
 
     # hash will be { rule: [result, result, result] }
     def self.add_new_result_to_rule_hash(rule_hash: nil, result: nil)
-      result_array = rule_hash[result.rule] ||= []
-      result_array << result
-      rule_hash[result.rule] = result_array
+      unless rule_hash.include?(result.rule)
+        rule_hash[result.rule] = []
+      end
+      rule_results = rule_hash[result.rule]
+      rule_results << result
+      return rule_hash
     end
 
     def self.generate_url_items_to_check(app: nil, app_version: nil)

data/precheck/lib/precheck/runner.rb

@@ -40,10 +40,14 @@ module Precheck
       end
 
       if processor_result.should_trigger_user_error?
-        UI.user_error!("precheck found one or more potential problems that must be addressed before submitting to review")
+        UI.user_error!("precheck 👮‍♀️ 👮  found one or more potential problems that must be addressed before submitting to review")
         return false
       end
 
+      if processor_result.has_errors_or_warnings?
+        UI.important "precheck 👮‍♀️ 👮  found one or more potential metadata problems, but this won't prevent fastlane from completing 👍".yellow
+      end
+
       if !processor_result.has_errors_or_warnings? && !processor_result.items_not_checked?
         UI.message "precheck 👮‍♀️ 👮  finished without detecting any potential problems 🛫".green
       end
@@ -77,8 +81,14 @@ module Precheck
       if rows.length == 0
         return nil
       else
+        title_text = "Potential problems"
+        if error_results.length > 0
+          title_text = title_text.red
+        else
+          title_text = title_text.yellow
+        end
         return Terminal::Table.new(
-          title: "Potential problems".red,
+          title: title_text,
           headings: ["Field", "Failure reason"],
           rows: FastlaneCore::PrintTable.transform_output(rows)
         ).to_s

data/spaceship/lib/spaceship/client.rb

@@ -686,7 +686,7 @@ module Spaceship
         end
 
         if response.body.to_s.include?("<title>302 Found</title>")
-          raise AppleTimeoutError.new, "Apple 302 detected"
+          raise AppleTimeoutError.new, "Apple 302 detected - this might be temporary server error, check https://developer.apple.com/system-status/ to see if there is a known downtime"
         end
         return response
       end

data/spaceship/lib/spaceship/tunes/iap_status.rb

@@ -25,6 +25,9 @@ module Spaceship
       # In-app purchase rejected for whatever reason
       REJECTED = "Rejected"
 
+      # The developer took the app from the App Store
+      DEVELOPER_REMOVED_FROM_SALE = "Developer Removed From Sale"
+
       # Get the iap status matching based on a string (given by iTunes Connect)
       def self.get_from_string(text)
         mapping = {
@@ -34,7 +37,8 @@ module Spaceship
           'inReview' => IN_REVIEW,
           'readyForSale' => APPROVED,
           'deleted' => DELETED,
-          'rejected' => REJECTED
+          'rejected' => REJECTED,
+          'developerRemovedFromSale' => DEVELOPER_REMOVED_FROM_SALE
         }
 
         mapping.each do |itc_status, readable_status|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.56.0.beta.20170907010003
+  version: 2.56.0.beta.20170908010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-07 00:00:00.000000000 Z
+date: 2017-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier