fastlane 2.51.0.beta.20170805010003 → 2.51.0.beta.20170806010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c80a60da667579980bad460738cbe5b059919917
-  data.tar.gz: 4357bd33a339313330880af387993c43f2f28c6f
+  metadata.gz: 7df61df3b899ddc2e8d9a2378ac08e8f9c0f08d2
+  data.tar.gz: 60770563b17ee83d5a45231be4afcbb6d62b4846
 SHA512:
-  metadata.gz: de777b2403bdd92db984ea1b8515a9183e13cfcea5430045956e486488a323a35ba50894add2fe7142dfd8f39c19bcbb3443d98afdbc54673f998a82c20384c6
-  data.tar.gz: 89d84c143b3b6838946a2a17c5e84f3db7b964a28bf40381feffb0ac0baccdf1ddc7646f3f70ad6c0f838954a54aeb4b9b8db8a401b4646f2cb01ecb43d22675
+  metadata.gz: 8f46f8a2ea46e50859ff763e2e3bea09cea25d17c6f78bbc00dbd62cb3ba5c75f38938e901829ea46d6992af241c2682649a890837aef3063223fa0eec916c27
+  data.tar.gz: f259ca025933f742be368b6d8b749eea53c530bc4275cf137f624c0dbcc1fc46eed7d0825003d518d64b34b89555682415929cc6800833a206ecf3fdfb0ba1d4

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.51.0.beta.20170805010003'.freeze
+  VERSION = '2.51.0.beta.20170806010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
 end

data/spaceship/lib/spaceship/portal/passbook.rb

@@ -41,15 +41,9 @@ module Spaceship
       )
 
       class << self
-        # Create a new object based on a hash.
-        # This is used to create a new object based on the server response.
-        def factory(attrs)
-          self.new(attrs)
-        end
-
         # @return (Array) Returns all passbook available for this account
         def all
-          client.passbooks.map { |pass_type| self.factory(pass_type) }
+          client.passbooks.map { |pass_type| self.new(pass_type) }
         end
 
         # Creates a new Passbook ID on the Apple Dev Portal

data/spaceship/lib/spaceship/portal/website_push.rb

@@ -41,16 +41,10 @@ module Spaceship
       )
 
       class << self
-        # Create a new object based on a hash.
-        # This is used to create a new object based on the server response.
-        def factory(attrs)
-          self.new(attrs)
-        end
-
         # @param mac [Bool] Fetches Mac website push if true
         # @return (Array) Returns all website push available for this account
         def all(mac: false)
-          client.website_push(mac: mac).map { |website_push| self.factory(website_push) }
+          client.website_push(mac: mac).map { |website_push| self.new(website_push) }
         end
 
         # Creates a new Website Push ID on the Apple Dev Portal

data/spaceship/lib/spaceship/tunes/app_ratings.rb

@@ -44,8 +44,8 @@ module Spaceship
       end
 
       # @return (Array) of Review Objects
-      def reviews(store_front, versionId = '')
-        raw_reviews = client.get_reviews(application.apple_id, application.platform, store_front, versionId)
+      def reviews(store_front = '', version_id = '')
+        raw_reviews = client.get_reviews(application.apple_id, application.platform, store_front, version_id)
         raw_reviews.map do |review|
           review["value"]["application"] = self.application
           AppReview.factory(review["value"])
@@ -98,8 +98,8 @@ module Spaceship
         'lastModified' => :last_modified,
         'helpfulViews' => :helpful_views,
         'totalViews' => :total_views,
-        'developerResponse' => :raw_developer_response,
-        'edited' => :edited
+        'edited' => :edited,
+        'developerResponse' => :raw_developer_response
       })
       class << self
         # Create a new object based on a hash.

data/spaceship/lib/spaceship/tunes/iap.rb

@@ -14,17 +14,11 @@ module Spaceship
       # @return (Spaceship::Tunes::Application) A reference to the application
       attr_accessor :application
 
-      class << self
-        def factory(attrs)
-          return self.new(attrs)
-        end
-      end
-
       # @return (Spaceship::Tunes::IAPFamilies) A reference to the familie list
       def families
         attrs = {}
         attrs[:application] = self.application
-        Tunes::IAPFamilies.factory(attrs)
+        Tunes::IAPFamilies.new(attrs)
       end
 
       # Creates a new In-App-Purchese on iTunes Connect

data/spaceship/lib/spaceship/tunes/iap_detail.rb

@@ -43,12 +43,6 @@ module Spaceship
         'clearedForSale.value' => :cleared_for_sale
       })
 
-      class << self
-        def factory(attrs)
-          return self.new(attrs)
-        end
-      end
-
       # @return (Hash) Hash of languages
       # @example: {
       #   'de-DE': {

data/spaceship/lib/spaceship/tunes/iap_families.rb

@@ -5,12 +5,6 @@ module Spaceship
       # @return (Spaceship::Tunes::Application) A reference to the application
       attr_accessor :application
 
-      class << self
-        def factory(attrs)
-          return self.new(attrs)
-        end
-      end
-
       # Create a new Purchase Family
       # a freshly created family has to have atleast one product.
       # the product will be created, and versions/pricing_intervals and so on

data/spaceship/lib/spaceship/tunes/iap_family_details.rb

@@ -16,12 +16,6 @@ module Spaceship
         'name.value' => :name
       })
 
-      class << self
-        def factory(attrs)
-          return self.new(attrs)
-        end
-      end
-
       def versions=(value = {})
         if value.kind_of?(Array)
           # input that comes from iTC api

data/spaceship/lib/spaceship/tunes/iap_family_list.rb

@@ -16,17 +16,11 @@ module Spaceship
         'name.value' => :name
       })
 
-      class << self
-        def factory(attrs)
-          return self.new(attrs)
-        end
-      end
-
       # return a editable family object
       def edit
         attrs = client.load_iap_family(app_id: application.apple_id, family_id: self.family_id)
         attrs[:application] = application
-        Tunes::IAPFamilyDetails.factory(attrs)
+        Tunes::IAPFamilyDetails.new(attrs)
       end
     end
   end

data/spaceship/lib/spaceship/tunes/iap_list.rb

@@ -44,12 +44,6 @@ module Spaceship
         'canDeleteAddOn' => :can_delete_addon
       })
 
-      class << self
-        def factory(attrs)
-          return self.new(attrs)
-        end
-      end
-
       def type
         Tunes::IAPType.get_from_string(raw_data["addOnType"])
       end
@@ -61,7 +55,7 @@ module Spaceship
       def edit
         attrs = client.load_iap(app_id: application.apple_id, purchase_id: self.purchase_id)
         attrs[:application] = application
-        Tunes::IAPDetail.factory(attrs)
+        Tunes::IAPDetail.new(attrs)
       end
 
       def delete!

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -258,22 +258,28 @@ module Spaceship
       parse_response(r, 'data')
     end
 
-    def get_ratings(app_id, platform, versionId = '', storefront = '')
-      # if storefront or versionId is empty api fails
+    def get_ratings(app_id, platform, version_id = '', storefront = '')
+      # if storefront or version_id is empty api fails
       rating_url = "ra/apps/#{app_id}/platforms/#{platform}/reviews/summary?"
       rating_url << "storefront=#{storefront}" unless storefront.empty?
-      rating_url << "versionId=#{versionId}" unless versionId.empty?
+      rating_url << "version_id=#{version_id}" unless version_id.empty?
 
       r = request(:get, rating_url)
       parse_response(r, 'data')
     end
 
-    def get_reviews(app_id, platform, storefront, versionId = '')
+    def get_reviews(app_id, platform, storefront, version_id)
       index = 0
       per_page = 100 # apple default
       all_reviews = []
       loop do
-        r = request(:get, "ra/apps/#{app_id}/platforms/#{platform}/reviews?storefront=#{storefront}&versionId=#{versionId}&index=#{index}")
+        rating_url = "ra/apps/#{app_id}/platforms/#{platform}/reviews?"
+        rating_url << "sort=REVIEW_SORT_ORDER_MOST_RECENT"
+        rating_url << "&index=#{index}"
+        rating_url << "&storefront=#{storefront}" unless storefront.empty?
+        rating_url << "&version_id=#{version_id}" unless version_id.empty?
+
+        r = request(:get, rating_url)
         all_reviews.concat(parse_response(r, 'data')['reviews'])
         if all_reviews.count < parse_response(r, 'data')['reviewCount']
           index += per_page

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.51.0.beta.20170805010003
+  version: 2.51.0.beta.20170806010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-05 00:00:00.000000000 Z
+date: 2017-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier