fastlane 2.37.0.beta.20170601010043 → 2.37.0.beta.20170602010027

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3cb7b7fb4a4bfc18f7e73e2aec50f4c956326f9
-  data.tar.gz: 977106738fa32888cc772b6844ec7433747a24f2
+  metadata.gz: a4b511987043d3ffedff763ec2e2e5fce1f7c457
+  data.tar.gz: 5700e2b138071d18dd80bff0789e935e111cf859
 SHA512:
-  metadata.gz: b99d57aaa6bb015338d7d5c1d2a0385b469273665eb077004cdc9acee137e06be82945f29cff4c8beb97017f24828d2d42518a47a272d5f4cf040bc1ff607610
-  data.tar.gz: bbfcb73c1eef73ecba7bb3b095f6d08c373cde6465aa924d5fa6beba693839096b372a0f89231c6acd904c227b133564c2d071a61d46a37a4caffbbe32b24004
+  metadata.gz: c2d420b538d240e89ff01005cf15aeb02ceb982ab27d74a9a5fb25ab9c48ec4c76b714227038754f99cb7a16d7b5f49383fadc3851debf915e669d9f4b2b2f59
+  data.tar.gz: e12c6dce1ef0bc9b20014ac8b30d843e5c240b52ce4982a4e26beee40e911b509569fae6aa3386376c9519f9e3c45d47bcd1029fdab189d565d12f2731689792

data/fastlane/lib/fastlane/helper/sh_helper.rb

@@ -29,9 +29,7 @@ module Fastlane
       UI.command(command) if print_command
 
       result = ''
-      if Helper.test?
-        result << command # only for the tests
-      else
+      if Helper.sh_enabled?
         exit_status = nil
         IO.popen(command, err: [:child, :out]) do |io|
           io.sync = true
@@ -51,9 +49,15 @@ module Fastlane
                     end
           message += "\n#{result}" if print_command_output
 
-          error_callback.call(result) if error_callback
-          UI.shell_error!(message)
+          if error_callback
+            UI.error(message)
+            error_callback.call(result)
+          else
+            UI.shell_error!(message)
+          end
         end
+      else
+        result << command # only for the tests
       end
 
       result

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.37.0.beta.20170601010043'.freeze
+  VERSION = '2.37.0.beta.20170602010027'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -24,6 +24,11 @@ module FastlaneCore
       defined? SpecHelper
     end
 
+    # @return true if it is enabled to execute external commands
+    def self.sh_enabled?
+      !self.test?
+    end
+
     # removes ANSI colors from string
     def self.strip_ansi_colors(str)
       str.gsub(/\e\[([;\d]+)?m/, '')

data/spaceship/lib/spaceship/tunes/app_ratings.rb

@@ -6,45 +6,41 @@ module Spaceship
       #   this version is for
       attr_accessor :application
 
-      # @return (Spaceship::Tunes::AppRatingSummary) A summary of the overall ratings for the application
-      attr_accessor :rating_summary
-
-      # @return (Hash) mapping country codes to a (Spaceship::Tunes::AppRatingSummary) summary of ratings for that country
-      attr_reader :store_fronts
-
-      # @return (Hash) of iTunesConnect version id's to readable version numbers
-      attr_reader :versions
-
-      attr_mapping({
-        'versions' => :versions
-      })
+      # @return (Integer) total number of ratings recevied
+      attr_accessor :rating_count
 
-      class << self
-        # Create a new object based on a hash.
-        # This is used to create a new object based on the server response.
-        def factory(attrs)
-          obj = self.new(attrs)
+      # @return (Integer) total number of one star ratings recevied
+      attr_accessor :one_star_rating_count
 
-          obj.unfold_rating_summary(attrs['ratings'])
-          obj.unfold_store_fronts(attrs['storeFronts'])
+      # @return (Integer) total number of two star ratings recevied
+      attr_accessor :two_star_rating_count
 
-          return obj
-        end
-      end
+      # @return (Integer) total number of three star ratings recevied
+      attr_accessor :three_star_rating_count
 
-      def unfold_rating_summary(attrs)
-        unfolded_rating_summary = AppRatingSummary.new(attrs)
-        instance_variable_set(:@rating_summary, unfolded_rating_summary)
-      end
+      # @return (Integer) total number of four star ratings recevied
+      attr_accessor :four_star_rating_count
 
-      def unfold_store_fronts(attrs)
-        unfolded_store_fronts = {}
+      # @return (Integer) total number of five star ratings recevied
+      attr_accessor :five_star_rating_count
 
-        attrs.each do |info|
-          unfolded_store_fronts[info['countryCode']] = AppRatingSummary.new(info['ratings'])
-        end
+      attr_mapping({
+        'reviewCount' => :review_count,
+        'ratingCount' => :rating_count,
+        'ratingOneCount' => :one_star_rating_count,
+        'ratingTwoCount' => :two_star_rating_count,
+        'ratingThreeCount' => :three_star_rating_count,
+        'ratingFourCount' => :four_star_rating_count,
+        'ratingFiveCount' => :five_star_rating_count
+      })
 
-        instance_variable_set(:@store_fronts, unfolded_store_fronts)
+      # @return (Float) the average rating for this summary (rounded to 2 decimal places)
+      def average_rating
+        ((one_star_rating_count +
+          (two_star_rating_count * 2) +
+          (three_star_rating_count * 3) +
+          (four_star_rating_count * 4) +
+          (five_star_rating_count * 5)) / rating_count.to_f).round(2)
       end
 
       # @return (Array) of Review Objects
@@ -124,47 +120,5 @@ module Spaceship
         false
       end
     end
-
-    class AppRatingSummary < TunesBase
-      # @return (Integer) total number of reviews recevied
-      attr_reader :review_count
-
-      # @return (Integer) total number of ratings recevied
-      attr_reader :rating_count
-
-      # @return (Integer) total number of one star ratings recevied
-      attr_reader :one_star_rating_count
-
-      # @return (Integer) total number of two star ratings recevied
-      attr_reader :two_star_rating_count
-
-      # @return (Integer) total number of three star ratings recevied
-      attr_reader :three_star_rating_count
-
-      # @return (Integer) total number of four star ratings recevied
-      attr_reader :four_star_rating_count
-
-      # @return (Integer) total number of five star ratings recevied
-      attr_reader :five_star_rating_count
-
-      attr_mapping({
-        'reviewCount' => :review_count,
-        'ratingCount' => :rating_count,
-        'ratingOneCount' => :one_star_rating_count,
-        'ratingTwoCount' => :two_star_rating_count,
-        'ratingThreeCount' => :three_star_rating_count,
-        'ratingFourCount' => :four_star_rating_count,
-        'ratingFiveCount' => :five_star_rating_count
-      })
-
-      # @return (Float) the average rating for this summary (rounded to 2 decimal places)
-      def average_rating
-        ((self.one_star_rating_count +
-          (self.two_star_rating_count * 2) +
-          (self.three_star_rating_count * 3) +
-          (self.four_star_rating_count * 4) +
-          (self.five_star_rating_count * 5)) / self.rating_count.to_f).round(2)
-      end
-    end
   end
 end

data/spaceship/lib/spaceship/tunes/application.rb

@@ -129,10 +129,10 @@ module Spaceship
         client.get_resolution_center(apple_id, platform)
       end
 
-      def ratings
-        attrs = client.get_rating_summary(apple_id, platform)
+      def ratings(version_id: '', storefront: '')
+        attrs = client.get_ratings(apple_id, platform, version_id, storefront)
         attrs[:application] = self
-        Tunes::AppRatings.factory(attrs)
+        Tunes::AppRatings.new(attrs)
       end
 
       def platforms

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -258,8 +258,13 @@ module Spaceship
       parse_response(r, 'data')
     end
 
-    def get_rating_summary(app_id, platform, versionId = '')
-      r = request(:get, "ra/apps/#{app_id}/reviews/summary?platform=#{platform}&versionId=#{versionId}")
+    def get_ratings(app_id, platform, versionId = '', storefront = '')
+      # if storefront or versionId is empty api fails
+      rating_url = "ra/apps/#{app_id}/platforms/#{platform}/reviews/summary?"
+      rating_url << "storefront=#{storefront}" unless storefront.empty?
+      rating_url << "versionId=#{versionId}" unless versionId.empty?
+
+      r = request(:get, rating_url)
       parse_response(r, 'data')
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.37.0.beta.20170601010043
+  version: 2.37.0.beta.20170602010027
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-01 00:00:00.000000000 Z
+date: 2017-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1368,22 +1368,22 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
+- frameit/lib
 - spaceship/lib
-- scan/lib
-- supply/lib
-- cert/lib
+- screengrab/lib
+- deliver/lib
+- credentials_manager/lib
 - sigh/lib
+- supply/lib
 - produce/lib
-- fastlane/lib
-- screengrab/lib
+- scan/lib
+- gym/lib
 - pem/lib
-- credentials_manager/lib
-- deliver/lib
-- frameit/lib
-- match/lib
+- cert/lib
+- fastlane/lib
 - snapshot/lib
-- gym/lib
 - fastlane_core/lib
+- match/lib
 - pilot/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements: