fastlane 2.36.0.beta.20170525010052 → 2.36.0.beta.20170526010038

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 081c66bd3dfba98434c2ddf9c795766f8f639df2
-  data.tar.gz: 0392045cfe30e5e03da8173b5f8876eb39d91b1b
+  metadata.gz: 329787ce0352fd64933af8c2b0f9f15554c9a90e
+  data.tar.gz: af4b86be47e45d429aab1ac60d66f2789693d197
 SHA512:
-  metadata.gz: c158081ba4cfd9237606bd89ed40d4c3747c690e95c9de03569ded3fda250760a6f70f81112267f3d8e50c0fa8eb85ee8ebdaa8411865cfc8a5764f393fdbd59
-  data.tar.gz: c282fbbfd0cdd4c636ddbcb9758eec8d0ba1c1f1f56267eddcd45dd22e46953a36d9721f4dbb0ace67d5862a56778c25bc640147d3785336cd9765b2e2b52376
+  metadata.gz: 23cc555705f3a818ce241f2da2e4475713b7426877f1fb56b2ee1c37576f072cbbf4ab114a0434d676a90c53c04d2486caa36ab59251f32b975a72cce173f4e7
+  data.tar.gz: ed709bd47ea5218ac86ee747cb456514ca34949aafe5a9ff9423998d9b46ec73579b1f546ba3e44128938b2dfb91a7a9ce3670d78457e9e0e34469ccb14d8a27

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -112,7 +112,7 @@ module Fastlane
                                        short_option: "-a",
                                        env_name: "DOWNLOAD_DSYMS_APP_IDENTIFIER",
                                        description: "The bundle identifier of your app",
-                                       optional: true,
+                                       optional: false,
                                        default_value: CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)),
           FastlaneCore::ConfigItem.new(key: :team_id,
                                        short_option: "-k",

data/fastlane/lib/fastlane/cli_tools_distributor.rb

@@ -92,6 +92,7 @@ module Fastlane
           UI.important "to launch fastlane faster, please use"
           UI.message ""
           UI.command "bundle exec fastlane #{ARGV.join(' ')}"
+          UI.message ""
         else
           # fastlane is slow and there is no Gemfile
           # Let's tell the user how to use `gem cleanup` and how to

data/fastlane/lib/fastlane/lane_manager.rb

@@ -233,11 +233,16 @@ module Fastlane
         [key, content.to_s]
       end
 
-      require 'terminal-table'
-      puts Terminal::Table.new({
-        title: "Lane Context".yellow,
-        rows: FastlaneCore::PrintTable.transform_output(rows)
-      })
+      begin
+        require 'terminal-table'
+        puts Terminal::Table.new({
+          title: "Lane Context".yellow,
+          rows: FastlaneCore::PrintTable.transform_output(rows)
+        })
+      rescue
+        os = Helper.linux? ? 'linux' : 'mac'
+        UI.crash!("Something went wrong trying to print the lane context on #{os}")
+      end
     end
   end
 end

data/fastlane/lib/fastlane/runner.rb

@@ -319,14 +319,23 @@ module Fastlane
     end
 
     def set_before_all(platform, block)
+      unless before_all_blocks[platform].nil?
+        UI.error("You defined multiple `before_all` blocks in your `Fastfile`. The last one being set will be used.")
+      end
       before_all_blocks[platform] = block
     end
 
     def set_after_all(platform, block)
+      unless after_all_blocks[platform].nil?
+        UI.error("You defined multiple `after_all` blocks in your `Fastfile`. The last one being set will be used.")
+      end
       after_all_blocks[platform] = block
     end
 
     def set_error(platform, block)
+      unless error_blocks[platform].nil?
+        UI.error("You defined multiple `error` blocks in your `Fastfile`. The last one being set will be used.")
+      end
       error_blocks[platform] = block
     end
 

data/fastlane/lib/fastlane/setup/crashlytics_beta.rb

@@ -55,7 +55,8 @@ module Fastlane
 
 # rubocop:disable Style/IndentationConsistency
 %{  #
-  # Learn more here: https://github.com/fastlane/setups/blob/master/samples-ios/distribute-beta-build.md 🚀
+  # Learn more here: https://docs.fastlane.tools/getting-started/ios/beta-deployment/
+  #             and: https://docs.fastlane.tools/getting-started/android/beta-deployment/
   #
   lane :beta do |values|
     # Fabric generated this lane for deployment to Crashlytics Beta

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.36.0.beta.20170525010052'.freeze
+  VERSION = '2.36.0.beta.20170526010038'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -62,7 +62,20 @@ module Commander
           raise e
         else
           FastlaneCore::CrashReporter.report_crash(exception: e, action: @program[:name])
-          abort e.to_s
+          if self.active_command.name == "help" && @default_command == :help # need to access directly via @
+            # This is a special case, for example for pilot
+            # when the user runs `fastlane pilot -u user@google.com`
+            # This would be confusing, as the user probably wanted to use `pilot list`
+            # or some other command. Because `-u` isn't available for the `pilot --help`
+            # command it would show this very confusing error message otherwise
+            abort "Please ensure to use one of the available commands (#{self.commands.keys.join(', ')})".red
+          else
+            # This would print something like
+            #
+            #   invalid option: -u
+            #
+            abort e.to_s
+          end
         end
       rescue FastlaneCore::Interface::FastlaneCommonException => e # these are exceptions that we dont count as crashes
         display_user_error!(e, e.to_s)

data/scan/lib/scan/runner.rb

@@ -5,6 +5,10 @@ require 'terminal-table'
 
 module Scan
   class Runner
+    def initialize
+      @test_command_generator = TestCommandGenerator.new
+    end
+
     def run
       handle_results(test_app)
     end
@@ -16,7 +20,7 @@ module Scan
       # This way it's okay to just call it for the first simulator we're using for
       # the first test run
       open_simulator_for_device(Scan.devices.first) if Scan.devices
-      command = TestCommandGenerator.generate
+      command = @test_command_generator.generate
       prefix_hash = [
         {
           prefix: "Running Tests: ",
@@ -80,7 +84,17 @@ module Scan
     end
 
     def test_results
-      return "" unless Scan.cache[:temp_junit_report]
+      temp_junit_report = Scan.cache[:temp_junit_report]
+      return File.read(temp_junit_report) if temp_junit_report && File.file?(temp_junit_report)
+
+      # Something went wrong with the temp junit report for the test success/failures count.
+      # We'll have to regenerate from the xcodebuild log, like we did before version 2.34.0.
+      UI.message("Generating test results. This may take a while for large projects.")
+
+      reporter_options_generator = XCPrettyReporterOptionsGenerator.new(false, [], [], "", false)
+      reporter_options = reporter_options_generator.generate_reporter_options
+      cmd = "cat #{@test_command_generator.xcodebuild_log_path} | xcpretty #{reporter_options.join(' ')} &> /dev/null"
+      system(cmd)
       File.read(Scan.cache[:temp_junit_report])
     end
 

data/scan/lib/scan/test_command_generator.rb

@@ -1,149 +1,147 @@
 module Scan
   # Responsible for building the fully working xcodebuild command
   class TestCommandGenerator
-    class << self
-      def generate
-        parts = prefix
-        parts << "env NSUnbufferedIO=YES xcodebuild"
-        parts += options
-        parts += actions
-        parts += suffix
-        parts += pipe
-
-        parts
-      end
+    def generate
+      parts = prefix
+      parts << "env NSUnbufferedIO=YES xcodebuild"
+      parts += options
+      parts += actions
+      parts += suffix
+      parts += pipe
+
+      parts
+    end
 
-      def prefix
-        ["set -o pipefail &&"]
-      end
+    def prefix
+      ["set -o pipefail &&"]
+    end
 
-      # Path to the project or workspace as parameter
-      # This will also include the scheme (if given)
-      # @return [Array] The array with all the components to join
-      def project_path_array
-        proj = Scan.project.xcodebuild_parameters
-        return proj if proj.count > 0
-        UI.user_error!("No project/workspace found")
-      end
+    # Path to the project or workspace as parameter
+    # This will also include the scheme (if given)
+    # @return [Array] The array with all the components to join
+    def project_path_array
+      proj = Scan.project.xcodebuild_parameters
+      return proj if proj.count > 0
+      UI.user_error!("No project/workspace found")
+    end
+
+    def options
+      config = Scan.config
+
+      options = []
+      options += project_path_array unless config[:xctestrun]
+      options << "-sdk '#{config[:sdk]}'" if config[:sdk]
+      options << destination # generated in `detect_values`
+      options << "-toolchain '#{config[:toolchain]}'" if config[:toolchain]
+      options << "-derivedDataPath '#{config[:derived_data_path]}'" if config[:derived_data_path]
+      options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
+      options << "-enableCodeCoverage #{config[:code_coverage] ? 'YES' : 'NO'}" unless config[:code_coverage].nil?
+      options << "-enableAddressSanitizer #{config[:address_sanitizer] ? 'YES' : 'NO'}" unless config[:address_sanitizer].nil?
+      options << "-enableThreadSanitizer #{config[:thread_sanitizer] ? 'YES' : 'NO'}" unless config[:thread_sanitizer].nil?
+      options << "-xcconfig '#{config[:xcconfig]}'" if config[:xcconfig]
+      options << "-xctestrun '#{config[:xctestrun]}'" if config[:xctestrun]
+      options << config[:xcargs] if config[:xcargs]
+
+      # detect_values will ensure that these values are present as Arrays if
+      # they are present at all
+      options += config[:only_testing].map { |test_id| "-only-testing:#{test_id}" } if config[:only_testing]
+      options += config[:skip_testing].map { |test_id| "-skip-testing:#{test_id}" } if config[:skip_testing]
+
+      options
+    end
+
+    def actions
+      config = Scan.config
+
+      actions = []
+      actions << :clean if config[:clean]
 
-      def options
-        config = Scan.config
-
-        options = []
-        options += project_path_array unless config[:xctestrun]
-        options << "-sdk '#{config[:sdk]}'" if config[:sdk]
-        options << destination # generated in `detect_values`
-        options << "-toolchain '#{config[:toolchain]}'" if config[:toolchain]
-        options << "-derivedDataPath '#{config[:derived_data_path]}'" if config[:derived_data_path]
-        options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
-        options << "-enableCodeCoverage #{config[:code_coverage] ? 'YES' : 'NO'}" unless config[:code_coverage].nil?
-        options << "-enableAddressSanitizer #{config[:address_sanitizer] ? 'YES' : 'NO'}" unless config[:address_sanitizer].nil?
-        options << "-enableThreadSanitizer #{config[:thread_sanitizer] ? 'YES' : 'NO'}" unless config[:thread_sanitizer].nil?
-        options << "-xcconfig '#{config[:xcconfig]}'" if config[:xcconfig]
-        options << "-xctestrun '#{config[:xctestrun]}'" if config[:xctestrun]
-        options << config[:xcargs] if config[:xcargs]
-
-        # detect_values will ensure that these values are present as Arrays if
-        # they are present at all
-        options += config[:only_testing].map { |test_id| "-only-testing:#{test_id}" } if config[:only_testing]
-        options += config[:skip_testing].map { |test_id| "-skip-testing:#{test_id}" } if config[:skip_testing]
-
-        options
+      if config[:build_for_testing]
+        actions << "build-for-testing"
+      elsif config[:test_without_building] || config[:xctestrun]
+        actions << "test-without-building"
+      else
+        actions << :build unless config[:skip_build]
+        actions << :test
       end
 
-      def actions
-        config = Scan.config
+      actions
+    end
 
-        actions = []
-        actions << :clean if config[:clean]
+    def suffix
+      suffix = []
+      suffix
+    end
 
-        if config[:build_for_testing]
-          actions << "build-for-testing"
-        elsif config[:test_without_building] || config[:xctestrun]
-          actions << "test-without-building"
-        else
-          actions << :build unless config[:skip_build]
-          actions << :test
-        end
+    def pipe
+      pipe = ["| tee '#{xcodebuild_log_path}'"]
 
-        actions
+      if Scan.config[:output_style] == 'raw'
+        return pipe
       end
 
-      def suffix
-        suffix = []
-        suffix
+      formatter = []
+      if Scan.config[:formatter]
+        formatter << "-f `#{Scan.config[:formatter]}`"
+      elsif FastlaneCore::Env.truthy?("TRAVIS")
+        formatter << "-f `xcpretty-travis-formatter`"
+        UI.success("Automatically switched to Travis formatter")
       end
 
-      def pipe
-        pipe = ["| tee '#{xcodebuild_log_path}'"]
-
-        if Scan.config[:output_style] == 'raw'
-          return pipe
-        end
-
-        formatter = []
-        if Scan.config[:formatter]
-          formatter << "-f `#{Scan.config[:formatter]}`"
-        elsif FastlaneCore::Env.truthy?("TRAVIS")
-          formatter << "-f `xcpretty-travis-formatter`"
-          UI.success("Automatically switched to Travis formatter")
-        end
-
-        if Helper.colors_disabled?
-          formatter << "--no-color"
-        end
-
-        if Scan.config[:output_style] == 'basic'
-          formatter << "--no-utf"
-        end
-
-        if Scan.config[:output_style] == 'rspec'
-          formatter << "--test"
-        end
-
-        reporter_options_generator = XCPrettyReporterOptionsGenerator.new(Scan.config[:open_report],
-                                                                          Scan.config[:output_types],
-                                                                          Scan.config[:output_files] || Scan.config[:custom_report_file_name],
-                                                                          Scan.config[:output_directory],
-                                                                          Scan.config[:use_clang_report_name])
-        reporter_options = reporter_options_generator.generate_reporter_options
-        return pipe << "| xcpretty #{formatter.join(' ')} #{reporter_options.join(' ')}"
+      if Helper.colors_disabled?
+        formatter << "--no-color"
       end
 
-      # Store the raw file
-      def xcodebuild_log_path
-        file_name = "#{Scan.project.app_name}-#{Scan.config[:scheme]}.log"
-        containing = File.expand_path(Scan.config[:buildlog_path])
-        FileUtils.mkdir_p(containing)
+      if Scan.config[:output_style] == 'basic'
+        formatter << "--no-utf"
+      end
 
-        return File.join(containing, file_name)
+      if Scan.config[:output_style] == 'rspec'
+        formatter << "--test"
       end
 
-      # Generate destination parameters
-      def destination
-        unless Scan.cache[:destination]
-          Scan.cache[:destination] = [*Scan.config[:destination]].map { |dst| "-destination '#{dst}'" }.join(' ')
-        end
-        Scan.cache[:destination]
+      @reporter_options_generator = XCPrettyReporterOptionsGenerator.new(Scan.config[:open_report],
+                                                                         Scan.config[:output_types],
+                                                                         Scan.config[:output_files] || Scan.config[:custom_report_file_name],
+                                                                         Scan.config[:output_directory],
+                                                                         Scan.config[:use_clang_report_name])
+      reporter_options = @reporter_options_generator.generate_reporter_options
+      return pipe << "| xcpretty #{formatter.join(' ')} #{reporter_options.join(' ')}"
+    end
+
+    # Store the raw file
+    def xcodebuild_log_path
+      file_name = "#{Scan.project.app_name}-#{Scan.config[:scheme]}.log"
+      containing = File.expand_path(Scan.config[:buildlog_path])
+      FileUtils.mkdir_p(containing)
+
+      return File.join(containing, file_name)
+    end
+
+    # Generate destination parameters
+    def destination
+      unless Scan.cache[:destination]
+        Scan.cache[:destination] = [*Scan.config[:destination]].map { |dst| "-destination '#{dst}'" }.join(' ')
       end
+      Scan.cache[:destination]
+    end
 
-      # The path to set the Derived Data to
-      def build_path
-        unless Scan.cache[:build_path]
-          day = Time.now.strftime("%F") # e.g. 2015-08-07
+    # The path to set the Derived Data to
+    def build_path
+      unless Scan.cache[:build_path]
+        day = Time.now.strftime("%F") # e.g. 2015-08-07
 
-          Scan.cache[:build_path] = File.expand_path("~/Library/Developer/Xcode/Archives/#{day}/")
-          FileUtils.mkdir_p Scan.cache[:build_path]
-        end
-        Scan.cache[:build_path]
+        Scan.cache[:build_path] = File.expand_path("~/Library/Developer/Xcode/Archives/#{day}/")
+        FileUtils.mkdir_p Scan.cache[:build_path]
       end
+      Scan.cache[:build_path]
+    end
 
-      def result_bundle_path
-        unless Scan.cache[:result_bundle_path]
-          Scan.cache[:result_bundle_path] = File.join(Scan.config[:output_directory], Scan.config[:scheme]) + ".test_result"
-        end
-        return Scan.cache[:result_bundle_path]
+    def result_bundle_path
+      unless Scan.cache[:result_bundle_path]
+        Scan.cache[:result_bundle_path] = File.join(Scan.config[:output_directory], Scan.config[:scheme]) + ".test_result"
       end
+      return Scan.cache[:result_bundle_path]
     end
   end
 end

data/scan/lib/scan/test_result_parser.rb

@@ -14,7 +14,10 @@ module Scan
         }
       else
         UI.error("Couldn't parse the number of tests from the output")
-        return {}
+        return {
+          tests: 0,
+          failures: 0
+        }
       end
     end
   end

data/scan/lib/scan/xcpretty_reporter_options_generator.rb

@@ -45,7 +45,7 @@ module Scan
         type = raw_type.strip
         output_path = File.join(File.expand_path(@output_directory), determine_output_file_name(type))
         reporter << "--report #{type}"
-        reporter << "--output #{output_path}"
+        reporter << "--output '#{output_path}'"
 
         if type == "html" && @open_report
           Scan.cache[:open_html_report_path] = output_path
@@ -55,9 +55,10 @@ module Scan
       # adds another junit reporter in case the user does not specify one
       # this will be used to generate a results table and then discarded
       require 'tempfile'
-      Scan.cache[:temp_junit_report] = Tempfile.new("junit_report").path
+      @temp_junit_report = Tempfile.new("junit_report")
+      Scan.cache[:temp_junit_report] = @temp_junit_report.path
       reporter << "--report junit"
-      reporter << "--output #{Scan.cache[:temp_junit_report]}"
+      reporter << "--output '#{Scan.cache[:temp_junit_report]}'"
       return reporter
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.36.0.beta.20170525010052
+  version: 2.36.0.beta.20170526010038
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-25 00:00:00.000000000 Z
+date: 2017-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1368,23 +1368,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
+- deliver/lib
+- sigh/lib
+- match/lib
 - scan/lib
+- cert/lib
 - credentials_manager/lib
-- pilot/lib
-- fastlane_core/lib
 - fastlane/lib
-- match/lib
-- cert/lib
-- sigh/lib
 - spaceship/lib
-- pem/lib
-- screengrab/lib
-- gym/lib
-- deliver/lib
+- fastlane_core/lib
 - snapshot/lib
+- pilot/lib
 - frameit/lib
 - produce/lib
 - supply/lib
+- pem/lib
+- screengrab/lib
+- gym/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="