fastlane 2.30.0.beta.20170511010018 → 2.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f76caf3bad75d5177b285ac8624feb1846b0c1b
-  data.tar.gz: 08261f81ffc2c03739618c2715d78bfbfbcd38be
+  metadata.gz: b24de7dca69e16aea8b48239f2eb105cf61d42e4
+  data.tar.gz: abee9d945caa12cec5f5b84736e196db6ed6270e
 SHA512:
-  metadata.gz: 620042f62d93632a9233fd88151a6dd3d3668a523a67a1d06437cfbcc1a8c1f292492daeab0a0b8409dd22c70f82438702ab17e90f7f5ec8ab78f4116642d003
-  data.tar.gz: 6650fb6d808951233134d7ed4eaa0708ce8cd8f4b37fc810cadcc1eb4601d5eeb661b036ffab00b26f2efb2156742e5e448b3bf75141729b9f6af17d77a67b85
+  metadata.gz: 108860da51b20af99859e93b50f377797d6991f2fbd18b91c07f56c70905c6c4429b02a84e510f96c146a72f8289f4ea198f06fe26cf58d261a4c055c8362234
+  data.tar.gz: b7c2b1d67ed298ca2424eadede430719972b3a6e86a03365b4619cbfd5980afe937f6a1c90bd6e00c8cccf757086a794704cb3800359cf53713fae8272742a29

data/README.md

@@ -154,6 +154,12 @@ We have recently changed the destination service to which these metrics are repo
 
 You can easily opt-out of metrics collection by adding `opt_out_usage` at the top of your `Fastfile` or by setting the environment variable `FASTLANE_OPT_OUT_USAGE`. Participating helps us provide the best possible support for _fastlane_, so we hope you'll consider it a plus! :heavy_plus_sign:
 
+## Crash Reporting
+
+In order to continuously improve stability, _fastlane_ will record crash reports with sanitized stacktraces. Sanitization removes personal information from the stacktrace and error message (including home directories, _fastlane_ path, gem paths, environment variables, and parameters).
+
+You can easily opt-out of crash reporting by adding `opt_out_crash_reporting` at the top of your `Fastfile` or by setting the environment variable `FASTLANE_OPT_OUT_CRASH_REPORTING`. Just like metrics mentioned above, participating helps us provide the best possible support for _fastlane_, so we hope you'll consider it a plus! :heavy_plus_sign:
+
 ## Need Help?
 
 Please [submit an issue](https://github.com/fastlane/fastlane/issues) on GitHub and provide information about your setup.

data/deliver/lib/deliver/upload_metadata.rb

@@ -250,7 +250,7 @@ module Deliver
       UI.user_error!("`trade_representative_contact_information` must be a hash", show_github_issues: true) unless info.kind_of?(Hash)
 
       TRADE_REPRESENTATIVE_CONTACT_INFORMATION_VALUES.each do |key, option_name|
-        v.send("#{key}=", info[option_name].chomp) if info[option_name].chomp
+        v.send("#{key}=", info[option_name].to_s.chomp) if info[option_name]
       end
     end
 

data/fastlane/lib/fastlane/actions/opt_out_crash_reporting.rb

@@ -0,0 +1,41 @@
+module Fastlane
+  module Actions
+    class OptOutCrashReportingAction < Action
+      def self.run(params)
+        ENV['FASTLANE_OPT_OUT_CRASH_REPORTING'] = "YES"
+        UI.message("Disabled crash reporting")
+      end
+
+      def self.description
+        "This will prevent reports from being uploaded when _fastlane_ crashes"
+      end
+
+      def self.details
+        [
+          "By default, fastlane will send a report when it crashes",
+          "The stacktrace is sanitized so no personal information is sent.",
+          "Learn more at https://github.com/fastlane/fastlane#crash-reporting",
+          "Add `opt_out_crash_reporting` at the top of your Fastfile to disable crash reporting"
+        ].join(' ')
+      end
+
+      def self.authors
+        ['mpirri', 'ohayon']
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+
+      def self.example_code
+        [
+          'opt_out_crash_reporting # add this to the top of your Fastfile'
+        ]
+      end
+
+      def self.category
+        :misc
+      end
+    end
+  end
+end

data/fastlane/lib/fastlane/actions/update_fastlane.rb

@@ -57,8 +57,7 @@ module Fastlane
         update_needed.each do |tool_info|
           tool = tool_info[0]
           local_version = Gem::Version.new(highest_versions[tool].version)
-          update_url = FastlaneCore::UpdateChecker.generate_fetch_url(tool)
-          latest_version = FastlaneCore::UpdateChecker.fetch_latest(update_url)
+          latest_version = FastlaneCore::UpdateChecker.fetch_latest(tool)
           UI.message("Updating #{tool} from #{local_version} to #{latest_version} ... 🚀")
 
           # Approximate_recommendation will create a string like "~> 0.10" from a version 0.10.0, e.g. one that is valid for versions >= 0.10 and <1.0

data/fastlane/lib/fastlane/environment_printer.rb

@@ -62,17 +62,16 @@ module Fastlane
         table << "|--------|---------|\n"
         plugin_manager.available_plugins.each do |plugin|
           begin
-          installed_version = Fastlane::ActionCollector.determine_version(plugin)
-          update_url = FastlaneCore::UpdateChecker.generate_fetch_url(plugin)
-          latest_version = FastlaneCore::UpdateChecker.fetch_latest(update_url)
-          if Gem::Version.new(installed_version) == Gem::Version.new(latest_version)
-            update_status = "✅ Up-To-Date"
-          else
-            update_status = "🚫 Update available"
+            installed_version = Fastlane::ActionCollector.determine_version(plugin)
+            latest_version = FastlaneCore::UpdateChecker.fetch_latest(plugin)
+            if Gem::Version.new(installed_version) == Gem::Version.new(latest_version)
+              update_status = "✅ Up-To-Date"
+            else
+              update_status = "🚫 Update available"
+            end
+          rescue
+            update_status = "💥 Check failed"
           end
-        rescue
-          update_status = "💥 Check failed"
-        end
           table << "| #{plugin} | #{installed_version} | #{update_status} |\n"
         end
 
@@ -107,9 +106,8 @@ module Fastlane
 
         next unless fastlane_tools.include?(current_gem.name.to_sym)
         begin
-          update_url = FastlaneCore::UpdateChecker.generate_fetch_url(current_gem.name)
-          latest_version = FastlaneCore::UpdateChecker.fetch_latest(update_url)
-          if Gem::Version.new(current_gem.version) == Gem::Version.new(latest_version)
+          latest_version = FastlaneCore::UpdateChecker.fetch_latest(current_gem.name)
+          if Gem::Version.new(current_gem.version) >= Gem::Version.new(latest_version)
             update_status = "✅ Up-To-Date"
           else
             update_status = "🚫 Update available"

data/fastlane/lib/fastlane/runner.rb

@@ -253,6 +253,7 @@ module Fastlane
           end
         end
       rescue FastlaneCore::Interface::FastlaneError => e # user_error!
+        FastlaneCore::CrashReporter.report_crash(type: :user_error, exception: e, action: method_sym)
         collector.did_raise_error(method_sym)
         raise e
       rescue FastlaneCore::Interface::FastlaneTestFailure => e # test_failure!
@@ -260,6 +261,8 @@ module Fastlane
       rescue Exception => e # rubocop:disable Lint/RescueException
         # high chance this is actually FastlaneCore::Interface::FastlaneCrash, but can be anything else
         # Catches all exceptions, since some plugins might use system exits to get out
+        type = e.kind_of?(FastlaneCore::Interface::FastlaneCrash) ? :crash : :exception
+        FastlaneCore::CrashReporter.report_crash(type: type, exception: e, action: method_sym)
         collector.did_crash(method_sym)
         raise e
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.30.0.beta.20170511010018'.freeze
+  VERSION = '2.30.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core.rb

@@ -31,6 +31,9 @@ require 'fastlane_core/fastlane_folder'
 require 'fastlane_core/keychain_importer'
 require 'fastlane_core/swag'
 require 'fastlane_core/build_watcher'
+require 'fastlane_core/crash_reporter/crash_reporter'
+require 'fastlane_core/crash_reporter/crash_report_generator'
+require 'fastlane_core/crash_reporter/backtrace_sanitizer'
 
 # Third Party code
 require 'colored'

data/fastlane_core/lib/fastlane_core/configuration/configuration_file.rb

@@ -4,10 +4,14 @@ module FastlaneCore
     # A reference to the actual configuration
     attr_accessor :config
 
+    # Path to the config file represented by the current object
+    attr_accessor :configfile_path
+
     # @param config [FastlaneCore::Configuration] is stored to save the resulting values
     # @param path [String] The path to the configuration file to use
     def initialize(config, path, block_for_missing)
       self.config = config
+      self.configfile_path = path
 
       @block_for_missing = block_for_missing
       content = File.read(path)
@@ -25,20 +29,20 @@ module FastlaneCore
         eval(content) # this is okay in this case
         # rubocop:enable Security/Eval
 
-        print_resulting_config_values(path) # only on success
+        print_resulting_config_values # only on success
       rescue SyntaxError => ex
         line = ex.to_s.match(/\(eval\):(\d+)/)[1]
         UI.user_error!("Syntax error in your configuration file '#{path}' on line #{line}: #{ex}")
       end
     end
 
-    def print_resulting_config_values(path)
+    def print_resulting_config_values
       require 'terminal-table'
-      UI.success("Successfully loaded '#{File.expand_path(path)}' 📄")
+      UI.success("Successfully loaded '#{File.expand_path(self.configfile_path)}' 📄")
 
       # Show message when self.modified_values is empty
       if self.modified_values.empty?
-        UI.important("No values defined in '#{path}'")
+        UI.important("No values defined in '#{self.configfile_path}'")
         return
       end
 
@@ -48,7 +52,7 @@ module FastlaneCore
 
       puts ""
       puts Terminal::Table.new(rows: FastlaneCore::PrintTable.transform_output(rows),
-                              title: "Detected Values from '#{path}'")
+                              title: "Detected Values from '#{self.configfile_path}'")
       puts ""
     end
 
@@ -66,7 +70,24 @@ module FastlaneCore
         value = arguments.first
         value = yield if value.nil? && block_given?
 
-        return if value.nil?
+        if value.nil?
+          unless block_given?
+            # The config file has something like this:
+            #
+            #   clean
+            #
+            # without specifying a value for the method call
+            # or a block. This is most likely a user error
+            # So we tell the user that they can provide a value
+            warning = ["In the config file '#{self.configfile_path}'"]
+            warning << "you have the line #{method_sym}, but didn't provide"
+            warning << "any value. Make sure to append a value rght after the"
+            warning << "option name. Make sure to check the docs for more information"
+            UI.important(warning.join(" "))
+          end
+          return
+        end
+
         self.modified_values[method_sym] = value
 
         # to support frozen strings (e.g. ENV variables) too

data/fastlane_core/lib/fastlane_core/crash_reporter/backtrace_sanitizer.rb

@@ -0,0 +1,42 @@
+module FastlaneCore
+  class BacktraceSanitizer
+    class << self
+      def sanitize(type: :unknown, backtrace: nil)
+        if type == :user_error || type == :crash
+          # If the crash is from `UI` we only want to include the stack trace
+          # up to the point where the crash was initiated.
+          # The two stack frames we are dropping are `method_missing` and
+          # the call to `crash!` or `user_error!`.
+          stack = backtrace.drop(2)
+        else
+          stack = backtrace
+        end
+
+        stack = remove_fastlane_gem_path(backtrace: stack)
+        stack = remove_gem_home_path(backtrace: stack)
+        remove_home_dir_mentions(backtrace: stack)
+      end
+
+      def remove_fastlane_gem_path(backtrace: nil)
+        fastlane_path = Gem.loaded_specs['fastlane'].full_gem_path
+        return backtrace unless fastlane_path
+        backtrace.map do |frame|
+          frame.gsub(fastlane_path, '[fastlane_path]')
+        end
+      end
+
+      def remove_gem_home_path(backtrace: nil)
+        return backtrace unless Gem.dir
+        backtrace.map do |frame|
+          frame.gsub(Gem.dir, '[gem_home]')
+        end
+      end
+
+      def remove_home_dir_mentions(backtrace: nil)
+        backtrace.map do |frame|
+          frame.gsub(Dir.home, '~')
+        end
+      end
+    end
+  end
+end

data/fastlane_core/lib/fastlane_core/crash_reporter/crash_report_generator.rb

@@ -0,0 +1,50 @@
+module FastlaneCore
+  class CrashReportGenerator
+    class << self
+      def types
+        {
+          user_error: '[USER_ERROR]',
+          crash: '[FASTLANE_CRASH]',
+          exception: '[EXCEPTION]',
+          connection_failure: '[CONNECTION_FAILURE]',
+          system: '[SYSTEM_ERROR]',
+          option_parser: '[OPTION_PARSER]',
+          invalid_command: '[INVALID_COMMAND]',
+          unknown: '[UNKNOWN]'
+        }
+      end
+
+      def generate(type: :unknown, exception: nil, action: nil)
+        message = crash_report_message(type: type, exception: exception)
+        crash_report_payload(message: message, action: action)
+      end
+
+      private
+
+      def crash_report_message(type: :unknown, exception: nil)
+        return if exception.nil?
+        backtrace = FastlaneCore::BacktraceSanitizer.sanitize(type: type, backtrace: exception.backtrace).join("\n")
+        message = types[type]
+        if type == :user_error
+          message += ': '
+        else
+          message += ": #{exception.message}"
+        end
+        message = message[0..100]
+        message += "\n" unless type == :user_error
+        message + backtrace
+      end
+
+      def crash_report_payload(message: '', action: nil)
+        {
+          'eventTime' => Time.now.utc.to_datetime.rfc3339,
+          'serviceContext' => {
+            'service' => action || 'fastlane',
+            'version' => Fastlane::VERSION
+          },
+          'message' => message
+        }.to_json
+      end
+    end
+  end
+end

data/fastlane_core/lib/fastlane_core/crash_reporter/crash_reporter.rb

@@ -0,0 +1,82 @@
+require 'faraday'
+require 'json'
+
+module FastlaneCore
+  class CrashReporter
+    class << self
+      @did_report_crash = false
+
+      @explitly_enabled_for_testing = false
+
+      def crash_report_path
+        File.join(FastlaneCore.fastlane_user_dir, 'latest_crash.json')
+      end
+
+      def enabled?
+        !FastlaneCore::Env.truthy?("FASTLANE_OPT_OUT_CRASH_REPORTING")
+      end
+
+      def report_crash(type: :unknown, exception: nil, action: nil)
+        return unless enabled?
+        return if @did_report_crash
+
+        # Do not run the crash reporter while tests are happening (it might try to send
+        # a crash report), unless we have explictly turned on the crash reporter because
+        # we want to test it
+        return if Helper.test? && !@explitly_enabled_for_testing
+
+        payload = CrashReportGenerator.generate(type: type, exception: exception, action: action)
+        send_report(payload: payload)
+        save_file(payload: payload)
+        show_message unless did_show_message?
+        @did_report_crash = true
+      end
+
+      def reset_crash_reporter_for_testing
+        @did_report_crash = false
+      end
+
+      def enable_for_testing
+        @explitly_enabled_for_testing = true
+      end
+
+      def disable_for_testing
+        @explitly_enabled_for_testing = false
+      end
+
+      private
+
+      def show_message
+        UI.message("Sending crash report...")
+        UI.message("The stacktrace is sanitized so no personal information is sent.")
+        UI.message("To see what we are sending, look here: #{crash_report_path}")
+        UI.message("Learn more at https://github.com/fastlane/fastlane#crash-reporting")
+        UI.message("You can disable crash reporting by adding `opt_out_crash_reporting` at the top of your Fastfile")
+      end
+
+      def did_show_message?
+        file_name = ".did_show_opt_out_crash_info"
+
+        path = File.join(FastlaneCore.fastlane_user_dir, file_name)
+        did_show = File.exist?(path)
+
+        return did_show if did_show
+
+        File.write(path, '1')
+        false
+      end
+
+      def save_file(payload: "{}")
+        File.write(crash_report_path, payload)
+      end
+
+      def send_report(payload: "{}")
+        connection = Faraday.new(url: "https://clouderrorreporting.googleapis.com/v1beta1/projects/fastlane-166414/events:report?key=AIzaSyAMACPfuI-wi4grJWEZjcPvhfV2Rhmddwo")
+        connection.post do |request|
+          request.headers['Content-Type'] = 'application/json'
+          request.body = payload
+        end
+      end
+    end
+  end
+end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -48,6 +48,7 @@ module Commander
         if FastlaneCore::Helper.test?
           raise e
         else
+          FastlaneCore::CrashReporter.report_crash(type: :invalid_command, exception: e, action: @program[:name])
           abort "#{e}. Use --help for more information"
         end
       rescue Interrupt => e
@@ -66,11 +67,13 @@ module Commander
         if FastlaneCore::Helper.test?
           raise e
         else
+          FastlaneCore::CrashReporter.report_crash(type: :option_parser, exception: e, action: @program[:name])
           abort e.to_s
         end
       rescue FastlaneCore::Interface::FastlaneError => e # user_error!
         collector.did_raise_error(@program[:name])
         show_github_issues(e.message) if e.show_github_issues
+        FastlaneCore::CrashReporter.report_crash(type: :user_error, exception: e, action: @program[:name])
         display_user_error!(e, e.message)
       rescue Errno::ENOENT => e
         # We're also printing the new-lines, as otherwise the message is not very visible in-between the error and the stacktrace
@@ -78,6 +81,7 @@ module Commander
         FastlaneCore::UI.important("Error accessing file, this might be due to fastlane's directory handling")
         FastlaneCore::UI.important("Check out https://docs.fastlane.tools/advanced/#directory-behavior for more details")
         puts ""
+        FastlaneCore::CrashReporter.report_crash(type: :system, exception: e, action: @program[:name])
         raise e
       rescue FastlaneCore::Interface::FastlaneTestFailure => e # test_failure!
         display_user_error!(e, e.to_s)
@@ -87,9 +91,12 @@ module Commander
         if e.message.include? 'Connection reset by peer - SSL_connect'
           handle_tls_error!(e)
         else
+          FastlaneCore::CrashReporter.report_crash(type: :connection_failure, exception: e, action: @program[:name])
           handle_unknown_error!(e)
         end
       rescue => e # high chance this is actually FastlaneCore::Interface::FastlaneCrash, but can be anything else
+        type = e.kind_of?(FastlaneCore::Interface::FastlaneCrash) ? :crash : :exception
+        FastlaneCore::CrashReporter.report_crash(type: type, exception: e, action: @program[:name])
         collector.did_crash(@program[:name])
         handle_unknown_error!(e)
       ensure

data/fastlane_core/lib/fastlane_core/update_checker/update_checker.rb

@@ -112,7 +112,11 @@ module FastlaneCore
     end
 
     def self.fetch_latest(gem_name)
-      JSON.parse(Excon.get("https://rubygems.org/api/v1/gems/#{gem_name}.json").body)["version"]
+      JSON.parse(Excon.get(generate_fetch_url(gem_name)).body)["version"]
+    end
+
+    def self.generate_fetch_url(gem_name)
+      "https://rubygems.org/api/v1/gems/#{gem_name}.json"
     end
 
     # (optional) Returns the app identifier for the current tool

data/match/lib/match/encrypt.rb

@@ -16,7 +16,9 @@ module Match
 
       unless password
         if !UI.interactive?
-          UI.error "No password found neither in environment nor in local keychain. Bailing out as in non interactive mode."
+          UI.error "Neither the MATCH_PASSWORD environment variable nor the local keychain contained a password."
+          UI.error "Bailing out instead of asking for a password, since this is non-interactive mode."
+          UI.user_error!("Try setting the MATCH_PASSWORD environment variable, or temporarily enable interactive mode to store a password.")
         else
           UI.important "Enter the passphrase that should be used to encrypt/decrypt your certificates"
           UI.important "This passphrase is specific per repository and will be stored in your local keychain"

data/snapshot/lib/assets/SnapshotHelper.swift

@@ -6,6 +6,13 @@
 //  Copyright © 2015 Felix Krause. All rights reserved.
 //
 
+// -----------------------------------------------------
+// IMPORTANT: When modifying this file, make sure to 
+//            increment the version number at the very
+//            bottom of the file to notify users about
+//            the new SnapshotHelper.swift
+// -----------------------------------------------------
+
 import Foundation
 import XCTest
 
@@ -163,4 +170,4 @@ extension XCUIElement {
 
 // Please don't remove the lines below
 // They are used to detect outdated configuration files
-// SnapshotHelperVersion [1.3]
+// SnapshotHelperVersion [1.4]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.30.0.beta.20170511010018
+  version: 2.30.0
 platform: ruby
 authors:
 - Felix Krause
@@ -922,6 +922,7 @@ files:
 - fastlane/lib/fastlane/actions/number_of_commits.rb
 - fastlane/lib/fastlane/actions/oclint.rb
 - fastlane/lib/fastlane/actions/onesignal.rb
+- fastlane/lib/fastlane/actions/opt_out_crash_reporting.rb
 - fastlane/lib/fastlane/actions/opt_out_usage.rb
 - fastlane/lib/fastlane/actions/pem.rb
 - fastlane/lib/fastlane/actions/pilot.rb
@@ -1082,6 +1083,9 @@ files:
 - fastlane_core/lib/fastlane_core/configuration/configuration.rb
 - fastlane_core/lib/fastlane_core/configuration/configuration_file.rb
 - fastlane_core/lib/fastlane_core/core_ext/string.rb
+- fastlane_core/lib/fastlane_core/crash_reporter/backtrace_sanitizer.rb
+- fastlane_core/lib/fastlane_core/crash_reporter/crash_report_generator.rb
+- fastlane_core/lib/fastlane_core/crash_reporter/crash_reporter.rb
 - fastlane_core/lib/fastlane_core/device_manager.rb
 - fastlane_core/lib/fastlane_core/env.rb
 - fastlane_core/lib/fastlane_core/fastlane_folder.rb
@@ -1357,23 +1361,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- pem/lib
-- produce/lib
-- gym/lib
-- snapshot/lib
-- sigh/lib
-- pilot/lib
-- supply/lib
 - cert/lib
+- credentials_manager/lib
 - deliver/lib
-- match/lib
-- fastlane_core/lib
-- spaceship/lib
 - fastlane/lib
+- fastlane_core/lib
 - frameit/lib
-- screengrab/lib
-- credentials_manager/lib
+- gym/lib
+- match/lib
+- pem/lib
+- pilot/lib
+- produce/lib
 - scan/lib
+- screengrab/lib
+- sigh/lib
+- snapshot/lib
+- spaceship/lib
+- supply/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -1381,14 +1385,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and
   Android apps
 test_files: []
+has_rdoc: