fastlane 2.28.8 → 2.28.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 29a3514e4db5119fe553985626131a7f6a12e171
-  data.tar.gz: 2df13870e6ee1050f49376bc6150cf27b4fb2945
+  metadata.gz: 3186c50a7d29fce28650a28f133b5612b848ec1f
+  data.tar.gz: 71c9ec36764d97635a28d1b8a1dfa4a668810e57
 SHA512:
-  metadata.gz: ca79028fae92c0f929acf8434d8eff2cd738c537ffd04cf9b9c2b440f2a2894992acb2c95370ae7ca068cd3151657f6410c34558e4a26bd8a92bb27ba2593c3d
-  data.tar.gz: 9bcb75145d22202c195ec3bb945faee587ddee389e28693985cf82c0fc9449e9c2e34d0c4da0119b80e7073e7241b8ea013cd31c51c78a74bf2d4de79233d63c
+  metadata.gz: 2c9bfb2132277f93c86859aafd2f1121c8a8348b719262450f66a7d3e0856e01b793adb2c937b4c2aa43906e3e1341077fb229813630190a6365f1c37fe421d9
+  data.tar.gz: 447f4bb6b4fe48a593e83b1c2008fa55aa23bd94f9808387ebe3d7147589be38701f0d366786708d093e59bf28b4225586f52bd2241d1665f97249105c1a8d90

data/deliver/lib/deliver/upload_metadata.rb

@@ -116,7 +116,7 @@ module Deliver
       end
 
       # Check folder list (an empty folder signifies a language is required)
-      Dir.glob(File.join(options[:metadata_path], "*")).each do |lng_folder|
+      Loader.language_folders(options[:metadata_path]).each do |lng_folder|
         next unless File.directory?(lng_folder) # We don't want to read txt as they are non localised
 
         language = File.basename(lng_folder)
@@ -233,6 +233,7 @@ module Deliver
         UI.error(ex.to_s)
         UI.user_error!("Error parsing JSON file at path '#{options[:app_rating_config_path]}'")
       end
+      UI.message("Setting the app's age rating...")
       v.update_rating(json)
     end
   end

data/fastlane/lib/fastlane/actions/artifactory.rb

@@ -1,5 +1,10 @@
 module Fastlane
   module Actions
+    module SharedValues
+      ARTIFACTORY_DOWNLOAD_URL = :ARTIFACTORY_DOWNLOAD_URL
+      ARTIFACTORY_DOWNLOAD_SIZE = :ARTIFACTORY_DOWNLOAD_SIZE
+    end
+
     class ArtifactoryAction < Action
       def self.run(params)
         Actions.verify_gem!('artifactory')
@@ -17,6 +22,10 @@ module Fastlane
           }
           UI.message("Uploading file: #{artifact.local_path} ...")
           upload = artifact.upload(params[:repo], params[:repo_path], params[:properties])
+
+          Actions.lane_context[SharedValues::ARTIFACTORY_DOWNLOAD_URL] = upload.uri
+          Actions.lane_context[SharedValues::ARTIFACTORY_DOWNLOAD_SIZE] = upload.size
+
           UI.message("Uploaded Artifact:")
           UI.message("Repo: #{upload.repo}")
           UI.message("URI: #{upload.uri}")
@@ -44,7 +53,14 @@ module Fastlane
       end
 
       def self.author
-        ["koglinjg"]
+        ["koglinjg", "tommeier"]
+      end
+
+      def self.output
+        [
+          ['ARTIFACTORY_DOWNLOAD_URL', 'The download url for file uploaded'],
+          ['ARTIFACTORY_DOWNLOAD_SIZE', 'The reported file size for file uploaded']
+        ]
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/ensure_git_status_clean.rb

@@ -7,13 +7,16 @@ module Fastlane
     # Raises an exception and stop the lane execution if the repo is not in a clean state
     class EnsureGitStatusCleanAction < Action
       def self.run(params)
-        repo_clean = `git status --porcelain`.empty?
+        repo_status = Actions.sh("git status --porcelain")
+        repo_clean = repo_status.empty?
 
         if repo_clean
           UI.success('Git status is clean, all good! 💪')
           Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START] = true
         else
-          UI.user_error!("Git repository is dirty! Please ensure the repo is in a clean state by committing/stashing/discarding all changes first.")
+          error_message = "Git repository is dirty! Please ensure the repo is in a clean state by committing/stashing/discarding all changes first."
+          error_message += "\nUncommitted changes:\n#{repo_status}" if params[:show_uncommitted_changes]
+          UI.user_error!(error_message)
         end
       end
 
@@ -38,13 +41,24 @@ module Fastlane
       end
 
       def self.author
-        "lmirosevic"
+        ["lmirosevic", "antondomashnev"]
       end
 
       def self.example_code
         ['ensure_git_status_clean']
       end
 
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :show_uncommitted_changes,
+                                       env_name: "FL_ENSURE_GIT_STATUS_CLEAN_SHOW_UNCOMMITTED_CHANGES",
+                                       description: "The flag whether to show uncommitted changes if the repo is dirty",
+                                       optional: true,
+                                       default_value: false,
+                                       is_string: false)
+        ]
+      end
+
       def self.category
         :source_control
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.28.8'.freeze
+  VERSION = '2.28.9'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -376,7 +376,10 @@ module FastlaneCore
     def load_password_for_transporter
       # 3 different sources for the password
       #   1) ENV variable for application specific password
-      return ENV[TWO_FACTOR_ENV_VARIABLE] if ENV[TWO_FACTOR_ENV_VARIABLE].to_s.length > 0
+      if ENV[TWO_FACTOR_ENV_VARIABLE].to_s.length > 0
+        UI.message("Fetching password for transporter from environment variable named `#{TWO_FACTOR_ENV_VARIABLE}`")
+        return ENV[TWO_FACTOR_ENV_VARIABLE]
+      end
       #   2) TWO_STEP_HOST_PREFIX from keychain
       account_manager = CredentialsManager::AccountManager.new(user: @user,
                                                              prefix: TWO_STEP_HOST_PREFIX,

data/pilot/lib/pilot/build_manager.rb

@@ -51,7 +51,7 @@ module Pilot
         UI.user_error!("No build to distribute!")
       end
 
-      if should_update_app_test_information(options)
+      if should_update_app_test_information?(options)
         app_test_info = Spaceship::TestFlight::AppTestInfo.find(app_id: build.app_id)
         app_test_info.test_info.feedback_email = options[:beta_app_feedback_email] if options[:beta_app_feedback_email]
         app_test_info.test_info.description = options[:beta_app_description] if options[:beta_app_description]
@@ -63,7 +63,7 @@ module Pilot
         end
       end
 
-      if should_update_build_information(options)
+      if should_update_build_information?(options)
         begin
           build.update_build_information!(whats_new: options[:changelog])
           UI.success "Successfully set the changelog for build"
@@ -120,11 +120,11 @@ module Pilot
       return row
     end
 
-    def should_update_build_information(options)
-      options[:changelog].to_s.length
+    def should_update_build_information?(options)
+      options[:changelog].to_s.length > 0
     end
 
-    def should_update_app_test_information(options)
+    def should_update_app_test_information?(options)
       options[:beta_app_description].to_s.length > 0 || options[:beta_app_feedback_email].to_s.length > 0
     end
 

data/spaceship/lib/spaceship/spaceauth_runner.rb

@@ -22,7 +22,7 @@ module Spaceship
         puts "This could be an issue with iTunes Connect,".yellow
         puts "Please try unsetting the FASTLANE_SESSION environment variable".yellow
         puts "and re-run `fastlane spaceauth`".yellow
-        UI.crash!("Problem connecting to iTunes Connect")
+        raise "Problem connecting to iTunes Connect"
       end
 
       itc_cookie_content = Spaceship::Tunes.client.store_cookie

data/spaceship/lib/spaceship/test_flight/group.rb

@@ -84,7 +84,7 @@ module Spaceship::TestFlight
       if groups.nil?
         default_external_group = app.default_external_group
         if default_external_group.nil?
-          UI.user_error!("The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option.")
+          raise "The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option."
         end
         test_flight_groups = [default_external_group]
       else
@@ -92,7 +92,7 @@ module Spaceship::TestFlight
           groups.include?(group.name)
         end
 
-        UI.user_error!("There are no groups available matching the names passed to the `:groups` option.") if test_flight_groups.empty?
+        raise "There are no groups available matching the names passed to the `:groups` option." if test_flight_groups.empty?
       end
 
       test_flight_groups.each(&block)

data/spaceship/lib/spaceship/tunes/application.rb

@@ -78,7 +78,7 @@ module Spaceship
         #  should it be an ios or an osx app
 
         def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil)
-          UI.deprecated("The `version` parameter is deprecated. Use `ensure_version!` method instead") if version
+          puts "The `version` parameter is deprecated. Use `ensure_version!` method instead" if version
           client.create_application!(name: name,
                          primary_language: primary_language,
                                       sku: sku,

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -265,7 +265,7 @@ module Spaceship
     # @param bundle_id (String): The bundle ID must match the one you used in Xcode. It
     #   can't be changed after you submit your first build.
     def create_application!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil)
-      UI.deprecated("The `version` parameter is deprecated. Use `Spaceship::Tunes::Application.ensure_version!` method instead") if version
+      puts "The `version` parameter is deprecated. Use `Spaceship::Tunes::Application.ensure_version!` method instead" if version
 
       # First, we need to fetch the data from Apple, which we then modify with the user's values
       primary_language ||= "English"

data/supply/lib/supply/setup.rb

@@ -44,7 +44,7 @@ module Supply
       IMAGES_TYPES.each do |image_type|
         if ['featureGraphic'].include?(image_type)
           # we don't get all files in full resolution :(
-          UI.message("Due to the limit of the Google Play API `supply` can't download your existing feature graphics...")
+          UI.message("Due to a limitation of the Google Play API, there is no way for `supply` to download your existing feature graphics. Please copy your feature graphics into `metadata/android/en-US/images/`")
           next
         end
 
@@ -71,7 +71,7 @@ module Supply
         FileUtils.mkdir_p(File.join(containing, IMAGES_FOLDER_NAME, screenshot_type))
       end
 
-      UI.message("Due to the limit of the Google Play API `supply` can't download your existing screenshots...")
+      UI.message("Due to a limitation of the Google Play API, there is no way for `supply` to download your existing screenshots. Please copy your screenshots into `metadata/android/en-US/images/`")
     end
 
     def store_apk_listing(apk_listing)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.28.8
+  version: 2.28.9
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-03 00:00:00.000000000 Z
+date: 2017-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier