fastlane 2.28.7 → 2.28.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d83ba3a1a5cbf46c20a7345ee9338d7edf820eb0
-  data.tar.gz: 06bf105a4da2b924ad8984bc23185d12241ec37a
+  metadata.gz: 29a3514e4db5119fe553985626131a7f6a12e171
+  data.tar.gz: 2df13870e6ee1050f49376bc6150cf27b4fb2945
 SHA512:
-  metadata.gz: 484b90412dd54a95dc2c9c177bec13c1e04a57fa42d8b66717d8f264a161a6b7a448413a8c8191386274258b2508c85d2dfc893ee07f31eba0cbb39b6fd586f6
-  data.tar.gz: 6dd3407bf129dc2269848af33f1f67b3a380c5dc3b486840085a4c825990a3672bfba37e78868ef748dd76d88630b2f1bf33382a71087f01d339a2c3bdbf9c0c
+  metadata.gz: ca79028fae92c0f929acf8434d8eff2cd738c537ffd04cf9b9c2b440f2a2894992acb2c95370ae7ca068cd3151657f6410c34558e4a26bd8a92bb27ba2593c3d
+  data.tar.gz: 9bcb75145d22202c195ec3bb945faee587ddee389e28693985cf82c0fc9449e9c2e34d0c4da0119b80e7073e7241b8ea013cd31c51c78a74bf2d4de79233d63c

data/README.md

@@ -48,7 +48,7 @@ Then to deploy a new 'beta' version of your app just run
 :ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show output directly in test results
 :book: | Automatically generate Markdown documentation of your lane configurations
 :hatching_chick: | Over 170 built-in integrations available
-:computer: | Support for iOS, macOS, and Android apps
+:computer: | Support for iOS and Android apps
 :octocat: | Full Git and Mercurial support
 
 <hr />

data/fastlane/README.md

@@ -91,7 +91,7 @@ fastlane release
 :ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show the output directly in the Jenkins test results
 :book: | Automatically generate a markdown documentation of your lane config
 :hatching_chick: | Over 170 built-in integrations available
-:computer: | Support for iOS, macOS and Android apps
+:computer: | Support for iOS and Android apps
 :octocat: | Full git and mercurial support
 
 
@@ -138,7 +138,11 @@ The setup assistant will create all the necessary files for you, using the exist
 - Follow the setup assistant, which will set up ```fastlane``` for you
 - Further customise the ```Fastfile``` with [actions](https://docs.fastlane.tools/actions).
 
-For more details, please follow the [fastlane guide](https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Guide.md) or [documentation](https://github.com/fastlane/fastlane/tree/master/fastlane/docs).
+For more details, follow our new Getting Started guides:
+
+- [Getting Started fastlane guide for iOS](https://docs.fastlane.tools/getting-started/ios/setup/)
+- [Getting Started fastlane guide for Android](https://docs.fastlane.tools/getting-started/android/setup/)
+
 
 There are also 2 Japanese fastlane guides available: [qiita](http://qiita.com/gin0606/items/a8573b582752de0c15e1) and [mercari](http://tech.mercari.com/entry/2015/07/13/143000)
 

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -166,7 +166,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        platform == :ios
+        [:ios, :appletvos].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/actions/hockey.rb

@@ -250,7 +250,7 @@ module Fastlane
                                        default_value: "1"),
           FastlaneCore::ConfigItem.new(key: :status,
                                        env_name: "FL_HOCKEY_STATUS",
-                                       description: "Download status: \"1\" = No user can download; \"2\" = Available for download",
+                                       description: "Download status: \"1\" = No user can download; \"2\" = Available for download (only possible with full-access token)",
                                        default_value: "2"),
           FastlaneCore::ConfigItem.new(key: :notes_type,
                                       env_name: "FL_HOCKEY_NOTES_TYPE",

data/fastlane/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -128,10 +128,10 @@ module Fastlane
                                        end),
           FastlaneCore::ConfigItem.new(key: :platform,
                                        env_name: "FL_UPLOAD_SYMBOLS_TO_CRASHLYTICS_PLATFORM",
-                                       description: "The platform of the app (ios, tvos, mac)",
+                                       description: "The platform of the app (ios, appletvos, mac)",
                                        default_value: "ios",
                                        verify_block: proc do |value|
-                                         available = ['ios', 'tvos', 'mac']
+                                         available = ['ios', 'appletvos', 'mac']
                                          UI.user_error!("Invalid platform '#{value}', must be #{available.join(', ')}") unless available.include?(value)
                                        end)
         ]
@@ -150,7 +150,7 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        platform == :ios
+        [:ios, :appletvos].include?(platform)
       end
 
       def self.example_code

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.28.7'.freeze
+  VERSION = '2.28.8'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/project.rb

@@ -296,9 +296,16 @@ module FastlaneCore
     # @param [String] The key of which we want the value for (e.g. "PRODUCT_NAME")
     def build_settings(key: nil, optional: true)
       unless @build_settings
+        if is_workspace
+          if schemes.count == 0
+            UI.user_error!("Could not find any schemes for Xcode workspace at path '#{self.path}'. Please make sure that the schemes you want to use are marked as `Shared` from Xcode.")
+          end
+          options[:scheme] ||= schemes.first
+        end
+
         command = build_xcodebuild_showbuildsettings_command
 
-        # xcode might hang here and retrying fixes the problem, see fastlane#4059
+        # Xcode might hang here and retrying fixes the problem, see fastlane#4059
         begin
           timeout = FastlaneCore::Project.xcode_build_settings_timeout
           retries = FastlaneCore::Project.xcode_build_settings_retries
@@ -332,7 +339,7 @@ module FastlaneCore
 
     # Returns the build settings and sets the default scheme to the options hash
     def default_build_settings(key: nil, optional: true)
-      options[:scheme] = schemes.first if is_workspace
+      options[:scheme] ||= schemes.first if is_workspace
       build_settings(key: key, optional: optional)
     end
 

data/fastlane_core/lib/fastlane_core/ui/implementations/shell.rb

@@ -20,6 +20,8 @@ module FastlaneCore
         "#{format_string(datetime, severity)}#{msg}\n"
       end
 
+      require 'fastlane_core/ui/disable_colors' if FastlaneCore::Helper.colors_disabled?
+
       @log
     end
 

data/fastlane_core/lib/fastlane_core/ui/ui.rb

@@ -22,5 +22,3 @@ require 'fastlane_core/ui/interface'
 Dir[File.expand_path('implementations/*.rb', File.dirname(__FILE__))].each do |file|
   require file
 end
-
-require 'fastlane_core/ui/disable_colors' if FastlaneCore::Helper.colors_disabled?

data/gym/lib/gym/generators/build_command_generator.rb

@@ -41,6 +41,7 @@ module Gym
         options << "-derivedDataPath '#{config[:derived_data_path]}'" if config[:derived_data_path]
         options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
         options << config[:xcargs] if config[:xcargs]
+        options << "OTHER_SWIFT_FLAGS=\"\$(inherited) -Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time]
 
         options
       end
@@ -64,6 +65,7 @@ module Gym
       def pipe
         pipe = []
         pipe << "| tee #{xcodebuild_log_path.shellescape}"
+        pipe << "| grep .[0-9]ms | grep -v ^0.[0-9]ms | sort -nr > culprits.txt" if Gym.config[:analyze_build_time]
         unless Gym.config[:disable_xcpretty]
           formatter = Gym.config[:xcpretty_formatter]
           pipe << "| xcpretty"

data/gym/lib/gym/options.rb

@@ -277,6 +277,11 @@ module Gym
                                      verify_block: proc do |value|
                                        UI.user_error!("Report output location not found at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                      end),
+        FastlaneCore::ConfigItem.new(key: :analyze_build_time,
+                                     env_name: "GYM_ANALYZE_BUILD_TIME",
+                                     description: "Analyze the project build time and store the output in culprits.txt file",
+                                     optional: true,
+                                     is_string: false),
         FastlaneCore::ConfigItem.new(key: :xcpretty_utf,
                                      env_name: "XCPRETTY_UTF",
                                      description: "Have xcpretty use unicode encoding when reporting builds",

data/pilot/lib/pilot/build_manager.rb

@@ -51,9 +51,25 @@ module Pilot
         UI.user_error!("No build to distribute!")
       end
 
+      if should_update_app_test_information(options)
+        app_test_info = Spaceship::TestFlight::AppTestInfo.find(app_id: build.app_id)
+        app_test_info.test_info.feedback_email = options[:beta_app_feedback_email] if options[:beta_app_feedback_email]
+        app_test_info.test_info.description = options[:beta_app_description] if options[:beta_app_description]
+        begin
+          app_test_info.save_for_app!(app_id: build.app_id)
+          UI.success "Successfully set the beta_app_feedback_email and/or beta_app_description"
+        rescue => ex
+          UI.user_error!("Could not set beta_app_feedback_email and/or beta_app_description: #{ex}")
+        end
+      end
+
       if should_update_build_information(options)
-        build.update_build_information!(whats_new: options[:changelog], description: options[:beta_app_description], feedback_email: options[:beta_app_feedback_email])
-        UI.success "Successfully set the changelog and/or description for build"
+        begin
+          build.update_build_information!(whats_new: options[:changelog])
+          UI.success "Successfully set the changelog for build"
+        rescue => ex
+          UI.user_error!("Could not set changelog: #{ex}")
+        end
       end
 
       return if config[:skip_submission]
@@ -105,7 +121,11 @@ module Pilot
     end
 
     def should_update_build_information(options)
-      options[:changelog].to_s.length > 0 or options[:beta_app_description].to_s.length > 0 or options[:beta_app_feedback_email].to_s.length > 0
+      options[:changelog].to_s.length
+    end
+
+    def should_update_app_test_information(options)
+      options[:beta_app_description].to_s.length > 0 || options[:beta_app_feedback_email].to_s.length > 0
     end
 
     def distribute_build(uploaded_build, options)

data/spaceship/lib/spaceship/test_flight.rb

@@ -1,6 +1,7 @@
 
 require 'spaceship/test_flight/client'
 require 'spaceship/test_flight/base'
+require 'spaceship/test_flight/app_test_info'
 require 'spaceship/test_flight/build'
 require 'spaceship/test_flight/build_trains'
 require 'spaceship/test_flight/beta_review_info'

data/spaceship/lib/spaceship/test_flight/app_test_info.rb

@@ -0,0 +1,27 @@
+module Spaceship::TestFlight
+  class AppTestInfo < Base
+    # AppTestInfo wraps a test_info and beta_review_info in the format required to manage test_info
+    # for an application. Note that this structure, although looking similar to build test_info
+    # is test information about the application
+
+    attr_accessor :test_info
+
+    def self.find(app_id: nil)
+      raw_app_test_info = client.get_app_test_info(app_id: app_id)
+      self.new(raw_app_test_info)
+    end
+
+    def test_info
+      Spaceship::TestFlight::TestInfo.new(raw_data['details'])
+    end
+
+    def test_info=(value)
+      raw_data.set(['details'], value.raw_data)
+    end
+
+    # saves the changes to the App Test Info object to TestFlight
+    def save_for_app!(app_id: nil)
+      client.put_app_test_info(app_id: app_id, app_test_info: self)
+    end
+  end
+end

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -34,20 +34,6 @@ module Spaceship::TestFlight
       handle_response(response)
     end
 
-    def testers_for_app(app_id: nil)
-      assert_required_params(__method__, binding)
-      url = "providers/#{team_id}/apps/#{app_id}/testers"
-      response = request(:get, url)
-      handle_response(response)
-    end
-
-    def delete_tester_from_app(app_id: nil, tester_id: nil)
-      assert_required_params(__method__, binding)
-      url = "providers/#{team_id}/apps/#{app_id}/testers/#{tester_id}"
-      response = request(:delete, url)
-      handle_response(response)
-    end
-
     ##
     # @!group Builds API
     ##
@@ -111,6 +97,20 @@ module Spaceship::TestFlight
     # @!group Testers API
     ##
 
+    def testers_for_app(app_id: nil)
+      assert_required_params(__method__, binding)
+      url = "providers/#{team_id}/apps/#{app_id}/testers?limit=10000"
+      response = request(:get, url)
+      handle_response(response)
+    end
+
+    def delete_tester_from_app(app_id: nil, tester_id: nil)
+      assert_required_params(__method__, binding)
+      url = "providers/#{team_id}/apps/#{app_id}/testers/#{tester_id}"
+      response = request(:delete, url)
+      handle_response(response)
+    end
+
     def post_tester(app_id: nil, tester: nil)
       assert_required_params(__method__, binding)
 
@@ -156,15 +156,22 @@ module Spaceship::TestFlight
     end
 
     ##
-    # @!group TestInfo
+    # @!group AppTestInfo
     ##
 
-    def put_testinfo(app_id: nil, testinfo: nil)
+    def get_app_test_info(app_id: nil)
+      assert_required_params(__method__, binding)
+
+      response = request(:get, "providers/#{team_id}/apps/#{app_id}/testInfo")
+      handle_response(response)
+    end
+
+    def put_app_test_info(app_id: nil, app_test_info: nil)
       assert_required_params(__method__, binding)
 
       response = request(:put) do |req|
         req.url "providers/#{team_id}/apps/#{app_id}/testInfo"
-        req.body = testinfo.to_json
+        req.body = app_test_info.to_json
         req.headers['Content-Type'] = 'application/json'
       end
       handle_response(response)

data/spaceship/lib/spaceship/tunes/app_ratings.rb

@@ -47,9 +47,81 @@ module Spaceship
         instance_variable_set(:@store_fronts, unfolded_store_fronts)
       end
 
-      # @return (Array) of raw hashes representing user reviews for the given store front (and optional versionId)
+      # @return (Array) of Review Objects
       def reviews(store_front, versionId = '')
-        client.get_reviews(application.apple_id, application.platform, store_front, versionId)
+        raw_reviews = client.get_reviews(application.apple_id, application.platform, store_front, versionId)
+        raw_reviews.map do |review|
+          review["value"]["application"] = self.application
+          AppReview.factory(review["value"])
+        end
+      end
+    end
+
+    class DeveloperResponse < TunesBase
+      attr_reader :id
+      attr_reader :response
+      attr_reader :last_modified
+      attr_reader :hidden
+      attr_reader :state
+      attr_accessor :application
+      attr_accessor :review_id
+
+      attr_mapping({
+        'responseId' => :id,
+        'response' => :response,
+        'lastModified' => :last_modified,
+        'isHidden' => :hidden,
+        'pendingState' => :state
+      })
+    end
+
+    class AppReview < TunesBase
+      attr_accessor :application
+      attr_reader :rating
+      attr_reader :id
+      attr_reader :title
+      attr_reader :review
+      attr_reader :nickname
+      attr_reader :store_front
+      attr_reader :app_version
+      attr_reader :last_modified
+      attr_reader :helpful_views
+      attr_reader :total_views
+      attr_reader :edited
+      attr_reader :raw_developer_response
+      attr_accessor :developer_response
+
+      attr_mapping({
+        'id' => :id,
+        'rating' => :rating,
+        'title' => :title,
+        'review' => :review,
+        'nickname' => :nickname,
+        'storeFront' => :store_front,
+        'appVersionString' => :app_version,
+        'lastModified' => :last_modified,
+        'helpfulViews' => :helpful_views,
+        'totalViews' => :total_views,
+        'developerResponse' => :raw_developer_response,
+        'edited' => :edited
+      })
+      class << self
+        # Create a new object based on a hash.
+        # This is used to create a new object based on the server response.
+        def factory(attrs)
+          obj = self.new(attrs)
+          response_attrs = {}
+          response_attrs = obj.raw_developer_response if obj.raw_developer_response
+          response_attrs[:application] = obj.application
+          response_attrs[:review_id] = obj.id
+          obj.developer_response = DeveloperResponse.factory(response_attrs)
+          return obj
+        end
+      end
+
+      def responded?
+        return true if raw_developer_response
+        false
       end
     end
 

data/spaceship/lib/spaceship/tunes/app_status.rb

@@ -33,7 +33,7 @@ module Spaceship
       PROCESSING_FOR_APP_STORE = "Processing for App Store"
       # WAITING_FOR_EXPORT_COMPLIANCE = "Waiting For Export Compliance"
       METADATA_REJECTED = "Metadata Rejected"
-      # REMOVED_FROM_SALE = "Removed From Sale"
+      REMOVED_FROM_SALE = "Removed From Sale"
       # INVALID_BINARY = "Invalid Binary"
 
       # Get the app status matching based on a string (given by iTunes Connect)
@@ -48,7 +48,8 @@ module Spaceship
           'inReview' => IN_REVIEW,
           'rejected' => REJECTED,
           'pendingDeveloperRelease' => PENDING_DEVELOPER_RELEASE,
-          'metadataRejected' => METADATA_REJECTED
+          'metadataRejected' => METADATA_REJECTED,
+          'removedFromSale' => REMOVED_FROM_SALE
         }
 
         mapping.each do |k, v|

data/spaceship/lib/spaceship/tunes/iap_detail.rb

@@ -70,6 +70,43 @@ module Spaceship
         return parsed_versions
       end
 
+      # transforms user-set versions to iTC ones
+      def versions=(value = {})
+        if value.kind_of?(Array)
+          # input that comes from iTC api
+          return
+        end
+        new_versions = []
+        value.each do |language, current_version|
+          new_versions << {
+            "value" =>   {
+              "name" =>  { "value" => current_version[:name] },
+              "description" =>  { "value" => current_version[:description] },
+              "localeCode" =>  language.to_s
+            }
+          }
+        end
+
+        raw_data.set(["versions"], [{ reviewNotes: { value: @review_notes }, contentHosting: raw_data['versions'].first['contentHosting'], "details" => { "value" => new_versions }, "id" => raw_data["versions"].first["id"] }])
+      end
+
+      # transforms user-set intervals to iTC ones
+      def pricing_intervals=(value = [])
+        new_intervals = []
+        value.each do |current_interval|
+          new_intervals << {
+            "value" =>   {
+              "tierStem" =>  current_interval[:tier],
+              "priceTierEndDate" =>  current_interval[:end_date],
+              "priceTierEffectiveDate" =>  current_interval[:begin_date],
+              "grandfathered" =>  current_interval[:grandfathered],
+              "country" => current_interval[:country]
+            }
+          }
+        end
+        raw_data.set(["pricingIntervals"], new_intervals)
+      end
+
       # @return (Array) pricing intervals
       # @example:
       #  [
@@ -110,26 +147,26 @@ module Spaceship
         versions_array = []
         versions.each do |language, value|
           versions_array << {
-                    value: {
-                      description: { value: value[:description] },
-                      name: { value: value[:name] },
-                      localeCode: language.to_s
+                    "value" =>  {
+                      "description" => { "value" => value[:description] },
+                      "name" => { "value" => value[:name] },
+                      "localeCode" => language.to_s
                     }
           }
         end
 
-        raw_data.set(["versions"], [{ reviewNotes: @review_notes, details: { value: versions_array } }])
+        raw_data.set(["versions"], [{ reviewNotes: { value: @review_notes }, contentHosting: raw_data['versions'].first[:contentHosting], "details" => { "value" => versions_array }, id: raw_data["versions"].first["id"] }])
 
         # transform pricingDetails
         intervals_array = []
         pricing_intervals.each do |interval|
           intervals_array << {
-            value: {
-              tierStem: interval[:tier],
-              priceTierEffectiveDate: interval[:begin_date],
-              priceTierEndDate: interval[:end_date],
-              country: interval[:country] || "WW",
-              grandfathered: interval[:grandfathered]
+            "value" =>  {
+              "tierStem" =>  interval[:tier],
+              "priceTierEffectiveDate" =>  interval[:begin_date],
+              "priceTierEndDate" =>  interval[:end_date],
+              "country" =>  interval[:country] || "WW",
+              "grandfathered" =>  interval[:grandfathered]
             }
           }
         end

data/spaceship/lib/spaceship/tunes/iap_family_details.rb

@@ -22,6 +22,25 @@ module Spaceship
         end
       end
 
+      def versions=(value = {})
+        if value.kind_of?(Array)
+          # input that comes from iTC api
+          return
+        end
+        new_versions = []
+        value.each do |language, current_version|
+          new_versions << {
+            "value" =>   {
+              "subscriptionName" =>  { "value" => current_version[:subscription_name] },
+              "name" =>  { "value" => current_version[:name] },
+              "localeCode" => { "value" => language }
+            }
+          }
+        end
+
+        raw_data.set(["details"], { "value" => new_versions })
+      end
+
       # @return (Hash) localized names
       def versions
         parsed_versions = {}
@@ -42,15 +61,15 @@ module Spaceship
         versions_array = []
         versions.each do |language_code, value|
           versions_array << {
-                               value: {
-                                 subscriptionName: { value: value[:subscription_name] },
-                                 name: { value: value[:name] },
-                                 localeCode: { value: language_code.to_s }
+                               "value" => {
+                                 "subscriptionName" => { "value" => value[:subscription_name] },
+                                 "name" => { "value" => value[:name] },
+                                 "localeCode" => { "value" => language_code.to_s }
                                }
                             }
         end
 
-        raw_data.set(["details"], { value: versions_array })
+        raw_data.set(["details"], { "value" => versions_array })
 
         client.update_iap_family!(app_id: application.apple_id, family_id: self.family_id, data: raw_data)
       end

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -324,8 +324,19 @@ module Spaceship
     end
 
     def get_reviews(app_id, platform, storefront, versionId = '')
-      r = request(:get, "ra/apps/#{app_id}/reviews?platform=#{platform}&storefront=#{storefront}&versionId=#{versionId}")
-      parse_response(r, 'data')['reviews']
+      index = 0
+      per_page = 100 # apple default
+      all_reviews = []
+      loop do
+        r = request(:get, "ra/apps/#{app_id}/platforms/#{platform}/reviews?storefront=#{storefront}&versionId=#{versionId}&index=#{index}")
+        all_reviews.concat(parse_response(r, 'data')['reviews'])
+        if all_reviews.count < parse_response(r, 'data')['reviewCount']
+          index += per_page
+        else
+          break
+        end
+      end
+      all_reviews
     end
 
     #####################################################

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.28.7
+  version: 2.28.8
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-29 00:00:00.000000000 Z
+date: 2017-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1285,6 +1285,7 @@ files:
 - spaceship/lib/spaceship/portal/website_push.rb
 - spaceship/lib/spaceship/spaceauth_runner.rb
 - spaceship/lib/spaceship/test_flight.rb
+- spaceship/lib/spaceship/test_flight/app_test_info.rb
 - spaceship/lib/spaceship/test_flight/base.rb
 - spaceship/lib/spaceship/test_flight/beta_review_info.rb
 - spaceship/lib/spaceship/test_flight/build.rb