fastlane 2.28.2 → 2.28.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8bc110a25ada7ed90b962155121451a2dada56cc
-  data.tar.gz: 1bba629e783315e0a35241346f52f99befa2cf0c
+  metadata.gz: 132c1e0c8db40d3853f4576395288e72daa87566
+  data.tar.gz: 7ee3eda821ffa5c322b26e71353ddc85f88762db
 SHA512:
-  metadata.gz: d4d17ea68a83a530910d5eb2f08cec09fe1f76858790f9be0f31694482380ecc332aa68ee76a5a82feaf284c0ee99e1b3672aca1152215460ca4251e3669aabc
-  data.tar.gz: a6308319bbf37809c7f33f292587a6ca0ca88cb38f1bb97126d62d6815db9cf8e12d2a27f5aebd3dce8cfa7fb7aaac027cb2ee18f4a97339b627b30eec3443d2
+  metadata.gz: c6c0218b29725f2712368bb9509dbfaac34ec395f97025cf9d8d61b22d310449b77496e17d17ccd03524b55aab62c96cc0c3ca29e958bdeaf06bd03c675f9141
+  data.tar.gz: 3ac754b83ddcea678f21538cc171c05072668cb8ceed8c315f56452d2dcfe2f65d9a364847a67aff55ab0135de5a1004819eb5953543b0aca52dd100043ce4c9

data/deliver/lib/assets/summary.html.erb

@@ -107,6 +107,9 @@
               margin-left: 10px;
               margin-right: 10px;
           }
+          .app-icons {
+            overflow: hidden;
+          }
           .app-icons img {
             width: 150px;
           }

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -1,6 +1,6 @@
 Style/PercentLiteralDelimiters:
   Enabled: false
-  
+
 # kind_of? is a good way to check a type
 Style/ClassCheck:
   EnforcedStyle: kind_of?
@@ -16,6 +16,12 @@ Style/SafeNavigation:
 Performance/RegexpMatch:
   Enabled: false
 
+# This suggests use of `tr` instead of `gsub`. While this might be more performant,
+# these methods are not at all interchangable, and behave very differently. This can
+# lead to people making the substitution without considering the differences.
+Performance/StringReplacement:
+  Enabled: false
+
 # .length == 0 is also good, we don't always want .zero?
 Style/NumericPredicate:
   Enabled: false
@@ -23,7 +29,7 @@ Style/NumericPredicate:
 # this would cause errors with long lanes
 Metrics/BlockLength:
   Enabled: false
-  
+
 # this is a bit buggy
 Metrics/ModuleLength:
   Enabled: false
@@ -36,23 +42,23 @@ Style/VariableNumber:
 Style/MethodMissing:
   Enabled: false
 
-# 
+#
 #   File.chmod(0777, f)
-# 
+#
 # is easier to read than
-# 
+#
 #   File.chmod(0o777, f)
-# 
+#
 Style/NumericLiteralPrefix:
   Enabled: false
 
-# 
+#
 # command = (!clean_expired.nil? || !clean_pattern.nil?) ? CLEANUP : LIST
-# 
+#
 # is easier to read than
-# 
+#
 # command = !clean_expired.nil? || !clean_pattern.nil? ? CLEANUP : LIST
-# 
+#
 Style/TernaryParentheses:
   Enabled: false
 

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.28.2'.freeze
+  VERSION = '2.28.3'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -213,6 +213,13 @@ module FastlaneCore
       keychain_path
     end
 
+    # @return true if XCode version is higher than 8.3
+    def self.xcode_at_least?(version)
+      FastlaneCore::UI.user_error!("Unable to locate Xcode. Please make sure to have Xcode installed on your machine") if xcode_version.nil?
+      v = xcode_version
+      Gem::Version.new(v) >= Gem::Version.new(version)
+    end
+
     # @return the full path to the iTMSTransporter executable
     def self.itms_path
       return ENV["FASTLANE_ITUNES_TRANSPORTER_PATH"] if FastlaneCore::Env.truthy?("FASTLANE_ITUNES_TRANSPORTER_PATH")

data/fastlane_core/lib/fastlane_core/print_table.rb

@@ -44,7 +44,7 @@ module FastlaneCore
         value = ""
         array.each do  |l|
           colored_line = l
-          colored_line = "#{colors.first[0]}#{l}#{colors.last[0]}" if colors.length > 0
+          colored_line = "#{colors.first}#{l}#{colors.last}" if colors.length > 0
           value << colored_line
           value << "\n"
         end
@@ -68,15 +68,10 @@ module FastlaneCore
           return value.middle_truncate(max_value_length)
         elsif transform == :newline
           # remove all fixed newlines as it may mess up the output
-          value.tr!("\n", " ") if value.kind_of?(String)
+          value.gsub!("\n", " ") if value.kind_of?(String)
           if value.length >= max_value_length
-            colors = value.scan(/(\e\[.*?m)/)
-            if colors && colors.length > 0
-              colors.each do |color|
-                value.delete!(color.first)
-                value.delete!(color.last)
-              end
-            end
+            colors = value.scan(/\e\[.*?m/)
+            colors.each { |color| value.gsub!(color, '') }
             lines = value.wordwrap(max_value_length)
             return  colorize_array(lines, colors)
           end

data/fastlane_core/lib/fastlane_core/project.rb

@@ -279,9 +279,14 @@ module FastlaneCore
     def build_xcodebuild_showbuildsettings_command
       # We also need to pass the workspace and scheme to this command.
       #
-      # The 'clean' portion of this command is a workaround for an xcodebuild bug with Core Data projects.
+      # The 'clean' portion of this command was a workaround for an xcodebuild bug with Core Data projects.
+      # This xcodebuild bug is fixed in Xcode 8.3 so 'clean' it's not necessary anymore
       # See: https://github.com/fastlane/fastlane/pull/5626
-      command = "xcodebuild clean -showBuildSettings #{xcodebuild_parameters.join(' ')}"
+      if FastlaneCore::Helper.xcode_at_least?('8.3')
+        command = "xcodebuild -showBuildSettings #{xcodebuild_parameters.join(' ')}"
+      else
+        command = "xcodebuild clean -showBuildSettings #{xcodebuild_parameters.join(' ')}"
+      end
       command += " 2> /dev/null" if xcodebuild_suppress_stderr
       command
     end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -103,18 +103,18 @@ module Commander
       FastlaneCore::UI.important("pilot crashed")
       FastlaneCore::UI.important("-------------")
       FastlaneCore::UI.error("Unfortunately the TestFlight update from 11th April 2017 changed")
-      FastlaneCore::UI.error("the way Testers, Groups and Builds are managed on iTunes connect.")
-      FastlaneCore::UI.error("We're busy working on migrating _pilot_ to work with the new system")
-      FastlaneCore::UI.error("however it requires lots of changes and refactors from our side")
-      FastlaneCore::UI.error("to ensure that everything keeps working for you as it did before")
+      FastlaneCore::UI.error("the way Testers, Groups, and Builds are managed on iTunesConnect.")
+      FastlaneCore::UI.error("We have already fixed a number of features including submitting")
+      FastlaneCore::UI.error("builds for testing, adding and removing testers from groups, and")
+      FastlaneCore::UI.error("waiting for builds to process.")
       FastlaneCore::UI.error("")
-      FastlaneCore::UI.error("Please follow the WIP pull request on GitHub to stay up to date: https://github.com/fastlane/fastlane/pull/8871")
+      FastlaneCore::UI.error("Please stay tuned for more updates from _fastlane_ as we fix more issues!")
       FastlaneCore::UI.error("")
-      FastlaneCore::UI.error("Original error message: #{e}")
       if FastlaneCore::Globals.verbose?
         raise e # on verbose mode, we want to show the original stack trace
       else
-        FastlaneCore::UI.user_error!("pilot doesn't work with the latest TestFlight yet, we're busy working on upgrading it!")
+        FastlaneCore::UI.error("Original error message:")
+        FastlaneCore::UI.user_error!(e.message)
       end
     end
 

data/gym/lib/gym/options.rb

@@ -100,6 +100,11 @@ module Gym
                                      env_name: "GYM_CODE_SIGNING_IDENTITY",
                                      description: "The name of the code signing identity to use. It has to match the name exactly. e.g. 'iPhone Distribution: SunApps GmbH'",
                                      optional: true),
+        FastlaneCore::ConfigItem.new(key: :skip_package_ipa,
+                                     env_name: "GYM_SKIP_PACKAGE_IPA",
+                                     description: "Should we skip packaging the ipa?",
+                                     is_string: false,
+                                     default_value: false),
         FastlaneCore::ConfigItem.new(key: :include_symbols,
                                      short_option: "-m",
                                      env_name: "GYM_INCLUDE_SYMBOLS",

data/gym/lib/gym/runner.rb

@@ -16,6 +16,8 @@ module Gym
 
       if Gym.project.ios? || Gym.project.tvos?
         fix_generic_archive # See https://github.com/fastlane/fastlane/pull/4325
+        return BuildCommandGenerator.archive_path if Gym.config[:skip_package_ipa]
+
         package_app
         fix_package
         compress_and_move_dsym

data/gym/lib/gym/xcode.rb

@@ -18,9 +18,7 @@ module Gym
       end
 
       def legacy_api_deprecated?
-        UI.user_error!("Unable to locate Xcode. Please make sure to have Xcode installed on your machine") if xcode_version.nil?
-        v = xcode_version
-        Gem::Version.new(v) >= Gem::Version.new('8.3.0')
+        FastlaneCore::Helper.xcode_at_least?('8.3')
       end
     end
   end

data/pilot/lib/pilot/commands_generator.rb

@@ -29,7 +29,8 @@ module Pilot
         begin
           mgr.public_send(action, config)
         rescue => ex
-          message = "[#{address}]: #{ex}"
+          # no need to show the email address in the message if only one specified
+          message = (args.count > 1) ? "[#{address}]: #{ex}" : ex
           failures << message
           UI.error(message)
         end

data/pilot/lib/pilot/tester_manager.rb

@@ -7,40 +7,39 @@ module Pilot
     def add_tester(options)
       start(options)
 
-      if config[:groups]
-        UI.important("Currently pilot doesn't support groups yet, we're working on restoring that functionality")
-        config[:groups] = nil
-      end
-
       begin
-        tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
-        tester ||= Spaceship::Tunes::Tester::External.find(config[:email])
-
+        tester = Spaceship::Tunes::Tester::External.find(config[:email])
         if tester
           UI.success("Existing tester #{tester.email}")
         else
+          # make sure the user isn't already an internal tester, because we don't support those
+          internal_tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
+          UI.user_error!("#{internal_tester.email} is an internal tester; pilot does not support internal testers") unless internal_tester.nil?
+
           tester = Spaceship::Tunes::Tester::External.create!(email: config[:email],
                                                               first_name: config[:first_name],
                                                               last_name: config[:last_name])
-          UI.success("Successfully invited tester: #{tester.email}")
-        end
-
-        app_filter = (config[:apple_id] || config[:app_identifier])
-        if app_filter
-          begin
-            app = Spaceship::Application.find(app_filter)
-            UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
-            app.default_external_group.add_tester!(tester)
-            UI.success("Successfully added tester to app #{app_filter}")
-          rescue => ex
-            UI.error("Could not add #{tester.email} to app: #{ex}")
-            raise ex
-          end
+          UI.success("Successfully added tester: #{tester.email} to your account")
         end
       rescue => ex
         UI.error("Could not create tester #{config[:email]}")
         raise ex
       end
+
+      app_filter = (config[:apple_id] || config[:app_identifier])
+      if app_filter
+        begin
+          app = Spaceship::Application.find(app_filter)
+          UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
+
+          groups = add_tester_to_groups!(tester: tester, app: app, groups: config[:groups])
+          group_names = groups.map(&:name).join(", ")
+          UI.success("Successfully added tester to app #{app_filter} in group(s) #{group_names}")
+        rescue => ex
+          UI.error("Could not add #{tester.email} to app: #{app.name}")
+          raise ex
+        end
+      end
     end
 
     def find_tester(options)
@@ -59,7 +58,6 @@ module Pilot
       start(options)
 
       tester = Spaceship::Tunes::Tester::External.find(config[:email])
-      tester ||= Spaceship::Tunes::Tester::Internal.find(config[:email])
 
       if tester
         app_filter = (config[:apple_id] || config[:app_identifier])
@@ -67,8 +65,9 @@ module Pilot
           begin
             app = Spaceship::Application.find(app_filter)
             UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
-            app.default_external_group.remove_tester!(tester)
-            UI.success("Successfully removed tester #{tester.email} from app #{app_filter}")
+            groups = remove_tester_from_groups!(tester: tester, app: app, groups: config[:groups])
+            group_names = groups.map(&:name).join(", ")
+            UI.success("Successfully removed tester #{tester.email} from app #{app_filter} in group(s) #{group_names}")
           rescue => ex
             UI.error("Could not remove #{tester.email} from app: #{ex}")
             raise ex
@@ -78,7 +77,10 @@ module Pilot
           UI.success("Successfully removed tester #{tester.email}")
         end
       else
-        UI.error("Tester not found: #{config[:email]}")
+        internal_tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
+        UI.user_error!("#{internal_tester.email} is an internal tester; pilot does not support internal testers") unless internal_tester.nil?
+
+        UI.user_error!("Tester not found: #{config[:email]}")
       end
     end
 
@@ -93,7 +95,33 @@ module Pilot
       end
     end
 
-    # private
+    private
+
+    def perform_for_groups_in_app(app: nil, groups: nil, &block)
+      if groups.nil?
+        default_external_group = app.default_external_group
+        if default_external_group.nil?
+          UI.user_error!("The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option.")
+        end
+        test_flight_groups = [default_external_group]
+      else
+        test_flight_groups = Spaceship::TestFlight::Group.filter_groups(app_id: app.apple_id) do |group|
+          groups.include?(group.name)
+        end
+
+        UI.user_error!("There are no groups available matching the names passed to the `:groups` option.") if test_flight_groups.empty?
+      end
+
+      test_flight_groups.each(&block)
+    end
+
+    def add_tester_to_groups!(tester: nil, app: nil, groups: nil)
+      perform_for_groups_in_app(app: app, groups: groups) { |group| group.add_tester!(tester) }
+    end
+
+    def remove_tester_from_groups!(tester: nil, app: nil, groups: nil)
+      perform_for_groups_in_app(app: app, groups: groups) { |group| group.remove_tester!(tester) }
+    end
 
     def list_testers_by_app(app_filter)
       app = Spaceship::Application.find(app_filter)

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -27,8 +27,8 @@ module Spaceship::TestFlight
         req.url url
         req.body = {
           "email" => tester.email,
-          "firstName" => tester.last_name,
-          "lastName" => tester.first_name
+          "firstName" => tester.first_name,
+          "lastName" => tester.last_name
         }.to_json
         req.headers['Content-Type'] = 'application/json'
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.28.2
+  version: 2.28.3
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-20 00:00:00.000000000 Z
+date: 2017-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier