fastlane 2.28.1 → 2.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c843f9c86c6cb45c10f16dc428c57ac8000fff2
-  data.tar.gz: 78c756df5e94768e7c5191bc96d7da9d39083a8b
+  metadata.gz: 8bc110a25ada7ed90b962155121451a2dada56cc
+  data.tar.gz: 1bba629e783315e0a35241346f52f99befa2cf0c
 SHA512:
-  metadata.gz: 3b7b556ddb92b9acd664c8b1e513be918d52bc9bdb74a90f87b79bfc80714f656b65a1005fc681d34af4593a816142807aa2a95b196e64326fa3e834f10e9672
-  data.tar.gz: 1760f670b07d76ac8a2c996e50f36032194e2aa12f72e9d8d2cb1b4dfce4b919be21c1992cfd496489725a6f09065ba894947231864136af51e9954bfa9a58d5
+  metadata.gz: d4d17ea68a83a530910d5eb2f08cec09fe1f76858790f9be0f31694482380ecc332aa68ee76a5a82feaf284c0ee99e1b3672aca1152215460ca4251e3669aabc
+  data.tar.gz: a6308319bbf37809c7f33f292587a6ca0ca88cb38f1bb97126d62d6815db9cf8e12d2a27f5aebd3dce8cfa7fb7aaac027cb2ee18f4a97339b627b30eec3443d2

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.28.1'.freeze
+  VERSION = '2.28.2'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -22,11 +22,6 @@ module Spaceship::TestFlight
 
     def post_tester(app_id: nil, tester: nil)
       assert_required_params(__method__, binding)
-      # First we need to add the tester to the app
-      # It's ok if the tester already exists, we just have to do this... don't ask
-      # This will enable testing for the tester for a given app, as just creating the tester on an account-level
-      # is not enough to add the tester to a group. If this isn't done the next request would fail.
-      # This is a bug we reported to the iTunes Connect team, as it also happens on the iTunes Connect UI on 18. April 2017
       url = "providers/#{team_id}/apps/#{app_id}/testers"
       response = request(:post) do |req|
         req.url url
@@ -40,7 +35,7 @@ module Spaceship::TestFlight
       handle_response(response)
     end
 
-    def put_test_to_group(app_id: nil, tester_id: nil, group_id: nil)
+    def put_tester_to_group(app_id: nil, tester_id: nil, group_id: nil)
       assert_required_params(__method__, binding)
       # Then we can add the tester to the group that allows the app to test
       # This is easy enough, we already have all this data. We don't need any response from the previous request
@@ -56,7 +51,6 @@ module Spaceship::TestFlight
       handle_response(response)
     end
 
-    # def remove_tester_from_group!(group: nil, tester: nil, app_id: nil)
     def delete_tester_from_group(group_id: nil, tester_id: nil, app_id: nil)
       assert_required_params(__method__, binding)
       url = "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/testers/#{tester_id}"

data/spaceship/lib/spaceship/test_flight/group.rb

@@ -36,12 +36,20 @@ module Spaceship::TestFlight
       groups.select(&block)
     end
 
+    # First we need to add the tester to the app
+    # It's ok if the tester already exists, we just have to do this... don't ask
+    # This will enable testing for the tester for a given app, as just creating the tester on an account-level
+    # is not enough to add the tester to a group. If this isn't done the next request would fail.
+    # This is a bug we reported to the iTunes Connect team, as it also happens on the iTunes Connect UI on 18. April 2017
     def add_tester!(tester)
-      client.add_tester_to_group!(group: self, tester: tester, app_id: self.app_id)
+      # This post request makes the account-level tester available to the app
+      client.post_tester(app_id: self.app_id, tester: tester)
+      # This put request adds the tester to the group
+      client.put_tester_to_group(group_id: self.id, tester_id: tester.tester_id, app_id: self.app_id)
     end
 
     def remove_tester!(tester)
-      client.remove_tester_from_group!(group: self, tester: tester, app_id: self.app_id)
+      client.delete_tester_from_group(group_id: self.id, tester_id: tester.tester_id, app_id: self.app_id)
     end
 
     def default_external_group?

data/spaceship/lib/spaceship/tunes/application.rb

@@ -371,7 +371,7 @@ module Spaceship
       #####################################################
 
       def default_external_group
-        TestFlight::Group.default_external_group(self.apple_id)
+        TestFlight::Group.default_external_group(app_id: self.apple_id)
       end
 
       #####################################################

data/spaceship/lib/spaceship/tunes/tester.rb

@@ -106,8 +106,9 @@ module Spaceship
                             first_name: first_name,
                              last_name: last_name,
                                 groups: groups)
-          # We don't need to do additional parsing here, as `create_tester!` automatically
-          # re-fetches the newly created tester
+          # The response of the client request is a hash but doesn't contain all of the necessary data (like testerId, etc)
+          # use #find to get an instance of Tester with all of the data.
+          find(email)
         end
 
         #####################################################

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.28.1
+  version: 2.28.2
 platform: ruby
 authors:
 - Felix Krause
@@ -1370,7 +1370,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and