fastlane 2.24.0.beta.20170325010032 → 2.24.0.beta.20170326010023

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4da0188d70f1c82ed98e961d6000101cc022fa64
-  data.tar.gz: 7d6ddc6fbbc017bc190e8714d3dfdc9cc2b72690
+  metadata.gz: ee5443da2a8d0d17ca3794615aaa3db73b8057fa
+  data.tar.gz: 9fa5e789cbb425128d2cf8f35fcc321b3f06c9f8
 SHA512:
-  metadata.gz: 20890b23d73343e1306dea19afa46a752481e0043ef22e3fabe2b3f5896c8401f84ec1780d10ec304502d0483c24a75432401eb9cce015e7afcfd3fdc8cde1ba
-  data.tar.gz: c91d1a60513d3cbd4d9a6ff5a5f6d4bb771339316ea10b504d8cc2d1a87f40c00c31ea813030eab9fdfde5c356a2a85eb300defc3041fe4eed814acd5d099446
+  metadata.gz: a7212cc10b5bb3147ab2c469669ec6bdc5697a1a6d9eba871919b9696afffa02a9a1266a2bbcbc3819f776c281c4f9addfa7a052295e6ee58f377dad9a678197
+  data.tar.gz: 23cad7f6277fc2888fd6f46b4b32eed878d4ef53c555e861c833903204008882c2a712fc313e23174a3797f916931c69dde8f4dd82ca4d3e6de4553e3b4e0759

data/fastlane/lib/fastlane/runner.rb

@@ -255,6 +255,8 @@ module Fastlane
       rescue FastlaneCore::Interface::FastlaneError => e # user_error!
         collector.did_raise_error(method_sym)
         raise e
+      rescue FastlaneCore::Interface::FastlaneTestFailure => e # test_failure!
+        raise e
       rescue Exception => e # rubocop:disable Lint/RescueException
         # high chance this is actually FastlaneCore::Interface::FastlaneCrash, but can be anything else
         # Catches all exceptions, since some plugins might use system exits to get out

data/fastlane/lib/fastlane/setup/setup.rb

@@ -14,6 +14,11 @@ module Fastlane
       elsif is_android?
         UI.message("Detected Android project in current directory...")
         platform = :android
+      elsif is_react_native?
+        UI.important("Detected react-native app. To set up fastlane, please run")
+        UI.command("fastlane init")
+        UI.important("in the sub-folder for each platform (\"ios\" or \"android\")")
+        UI.user_error!("Please navigate to the platform subfolder and run `fastlane init` again")
       else
         UI.important("Couldn't automatically detect the platform")
         val = UI.confirm("Is this project an iOS project?")
@@ -37,6 +42,10 @@ module Fastlane
       Dir["*.gradle"].count > 0
     end
 
+    def is_react_native?
+      SetupIos.project_uses_react_native?(path: "./ios")
+    end
+
     def show_analytics
       UI.message("fastlane will send the number of errors for each action to")
       UI.message("https://github.com/fastlane/enhancer to detect integration issues")

data/fastlane/lib/fastlane/setup/setup_ios.rb

@@ -23,9 +23,11 @@ module Fastlane
       FastlaneCore::FastlaneFolder.create_folder! unless Helper.is_test?
       is_manual_setup = false
 
+      setup_project
+      react_native_pre_checks
+      ask_for_apple_id
+
       begin
-        setup_project
-        ask_for_apple_id
         if self.project.mac?
           UI.important("Generating apps on the Apple Developer Portal and iTunes Connect is not currently available for Mac apps")
         else
@@ -36,6 +38,7 @@ module Fastlane
           default_setup
         else
           is_manual_setup = true
+          UI.message("Falling back to manual onboarding")
           manual_setup
         end
         UI.success('Successfully finished setting up fastlane')
@@ -72,6 +75,29 @@ module Fastlane
       handle_exception(exception: ex)
     end
 
+    # React Native specific code
+    # Make it easy for people to onboard
+    def react_native_pre_checks
+      return unless self.class.project_uses_react_native?
+      if app_identifier.to_s.length == 0
+        error_message = []
+        error_message << "Could not detect bundle identifier of your react-native app."
+        error_message << "Make sure to open the Xcode project and update the bundle identifier"
+        error_message << "in the `General` section of your project settings."
+        error_message << "Restart `fastlane init` once you're done!"
+        UI.user_error!(error_message.join(" "))
+      end
+    end
+
+    def self.project_uses_react_native?(path: Dir.pwd)
+      package_json = File.join(path, "..", "package.json")
+      return false unless File.basename(path) == "ios"
+      return false unless File.exist?(package_json)
+      package_content = File.read(package_json)
+      return true if package_content.include?("react-native")
+      false
+    end
+
     def default_setup
       copy_existing_files
       generate_appfile(manually: false)

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.24.0.beta.20170325010032'.freeze
+  VERSION = '2.24.0.beta.20170326010023'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -66,6 +66,8 @@ module Commander
         collector.did_raise_error(@program[:name])
         show_github_issues(e.message) if e.show_github_issues
         display_user_error!(e, e.message)
+      rescue FastlaneCore::Interface::FastlaneTestFailure => e # test_failure!
+        display_user_error!(e, e.to_s)
       rescue Faraday::SSLError => e # SSL issues are very common
         handle_ssl_error!(e)
       rescue Faraday::ConnectionFailed => e

data/fastlane_core/lib/fastlane_core/ui/interface.rb

@@ -126,6 +126,10 @@ module FastlaneCore
       end
     end
 
+    # raised from test_failure!
+    class FastlaneTestFailure < StandardError
+    end
+
     # Pass an exception to this method to exit the program
     #   using the given exception
     # Use this method instead of user_error! if this error is
@@ -146,6 +150,15 @@ module FastlaneCore
       raise FastlaneError.new(options), error_message.to_s
     end
 
+    # Use this method to exit the program because of a test failure
+    # that's caused by the source code of the user. Example for this
+    # is that scan will fail when the tests fail.
+    # By using this method we'll get more accurate results on the
+    # fastlane failures on enhancer
+    def test_failure!(error_message)
+      raise FastlaneTestFailure.new, error_message
+    end
+
     #####################################################
     # @!group Helpers
     #####################################################

data/match/lib/match/change_password.rb

@@ -7,6 +7,7 @@ module Match
       from ||= ChangePassword.ask_password(message: "Old passphrase for Git Repo: ", confirm: true)
       GitHelper.clear_changes
       workspace = GitHelper.clone(params[:git_url], params[:shallow_clone], manual_password: from, skip_docs: params[:skip_docs], branch: params[:git_branch])
+      GitHelper.check_push_repo_permission(workspace, params[:git_branch])
       Encrypt.new.clear_password(params[:git_url])
       Encrypt.new.store_password(params[:git_url], to)
 

data/match/lib/match/git_helper.rb

@@ -156,5 +156,28 @@ module Match
         end
       end
     end
+
+    # Checks push permission to git repo
+    def self.repo_pushable?(path, branch = "master")
+      Dir.chdir(path) do
+        command = "GIT_TERMINAL_PROMPT=0 git push origin #{branch.shellescape} --dry-run"
+        FastlaneCore::CommandExecutor.execute(command: command,
+                                              print_all: FastlaneCore::Globals.verbose?,
+                                              print_command: FastlaneCore::Globals.verbose?)
+      end
+      return true
+    rescue => ex
+      UI.error("No permission to push...")
+      UI.error(ex)
+      return false
+    end
+
+    def self.check_push_repo_permission(path, branch = "master")
+      unless repo_pushable?(path, branch)
+        UI.error("You do not have push permission to git repository provided")
+        UI.error("_match_ needs to create a new certificate or provisioning profile, however without push access to the git repo, the generated certificate can't be stored properly, resulting in an unused certificate")
+        UI.user_error!("Please grant push access for the current git user to the git repo, so that _match_ can update and create certificates for you")
+      end
+    end
   end
 end

data/match/lib/match/nuke.rb

@@ -26,6 +26,8 @@ module Match
         UI.user_error!("`fastlane match nuke` doesn't delete anything when running with --readonly enabled")
       end
 
+      GitHelper.check_push_repo_permission(params[:workspace], params[:git_branch])
+
       if (self.certs + self.profiles + self.files).count > 0
         unless params[:skip_confirmation]
           UI.error "---"

data/match/lib/match/runner.rb

@@ -74,6 +74,7 @@ module Match
       if certs.count == 0 or keys.count == 0
         UI.important "Couldn't find a valid code signing identity in the git repo for #{cert_type}... creating one for you now"
         UI.crash!("No code signing identity found and can not create a new one because you enabled `readonly`") if params[:readonly]
+        GitHelper.check_push_repo_permission(params[:workspace], params[:git_branch])
         cert_path = Generator.generate_certificate(params, cert_type)
         self.changes_to_commit = true
       else
@@ -127,6 +128,8 @@ module Match
           UI.error "If you are certain that a profile should exist, double-check the recent changes to your match repository"
           UI.user_error! "No matching provisioning profiles found and can not create a new one because you enabled `readonly`. Check the output above for more information."
         end
+
+        GitHelper.check_push_repo_permission(params[:workspace], params[:git_branch])
         profile = Generator.generate_provisioning_profile(params: params,
                                                        prov_type: prov_type,
                                                   certificate_id: certificate_id,

data/scan/lib/scan/runner.rb

@@ -83,12 +83,12 @@ module Scan
 
       report_collector.parse_raw_file(TestCommandGenerator.xcodebuild_log_path)
 
-      unless tests_exit_status == 0
-        UI.user_error!("Test execution failed. Exit status: #{tests_exit_status}")
+      if result[:failures] > 0
+        UI.test_failure!("Tests have failed")
       end
 
-      unless result[:failures] == 0
-        UI.user_error!("Tests failed")
+      unless tests_exit_status == 0
+        UI.test_failure!("Test execution failed. Exit status: #{tests_exit_status}")
       end
     end
 

data/snapshot/lib/snapshot/runner.rb

@@ -59,7 +59,7 @@ module Snapshot
 
       print_results(results)
 
-      UI.user_error!(self.collected_errors.join('; ')) if self.collected_errors.count > 0
+      UI.test_failure!(self.collected_errors.join('; ')) if self.collected_errors.count > 0
 
       # Generate HTML report
       ReportsGenerator.new.generate

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.24.0.beta.20170325010032
+  version: 2.24.0.beta.20170326010023
 platform: ruby
 authors:
 - Felix Krause
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-25 00:00:00.000000000 Z
+date: 2017-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1296,23 +1296,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- frameit/lib
-- produce/lib
-- sigh/lib
+- scan/lib
 - supply/lib
-- fastlane_core/lib
-- snapshot/lib
-- deliver/lib
-- cert/lib
-- fastlane/lib
-- credentials_manager/lib
-- spaceship/lib
 - gym/lib
+- fastlane/lib
 - match/lib
+- deliver/lib
 - pilot/lib
+- produce/lib
+- credentials_manager/lib
 - screengrab/lib
-- scan/lib
+- sigh/lib
+- spaceship/lib
+- snapshot/lib
 - pem/lib
+- fastlane_core/lib
+- cert/lib
+- frameit/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="