fastlane 2.22.0.beta.20170321010023 → 2.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b9f80b580abe043efd2338aca85a321ab86c672
-  data.tar.gz: fb22f8621800221d634a49bc01c8951aa367a191
+  metadata.gz: cc85c3d22a331b29160c003ee7b6eebd036602f6
+  data.tar.gz: 16c1810bd73be99209335cc62e74d07e44be16c3
 SHA512:
-  metadata.gz: ededb87eef0d17179a2ab0d547d906eb64e7f77b88de7c459e4678ba8572850daf74b988dd69be43d02d47afaefe68fc75698b2354c163941b1ff684cd9643bb
-  data.tar.gz: ac135baae6ba2b0ea28141eabb896369feef5410fe52338e1c9c93ff01b2004a4ea6af6f6824ad17d73c9d4337242adb02241da08dcff8e28d01575a0b05b904
+  metadata.gz: 80ebbeb5b7f3f160a095e04b91417cfd8d1d6dd5418c6b1af396c91bdfff26a632e3bf860a54dc892ac05d1ad5a92f36221f4b55b3c118364cee1fec2883655a
+  data.tar.gz: 83d5ef7998fb3cbc6bcc6321f8a9ffb57f83cc989ceae2d73a664c2515607ec2852d8fca585e2dc221b7e6d2995fbc2a679640dd2eb5e7d53ce22fc0e777848e

data/fastlane/lib/fastlane/commands_generator.rb

@@ -111,6 +111,8 @@ module Fastlane
         c.syntax = 'fastlane init'
         c.description = 'Helps you with your initial fastlane setup'
 
+        c.option '-u STRING', '--user STRING', String, 'iOS projects only: Your Apple ID'
+
         CrashlyticsBetaCommandLineHandler.apply_options(c)
 
         c.action do |args, options|
@@ -118,7 +120,7 @@ module Fastlane
             beta_info = CrashlyticsBetaCommandLineHandler.info_from_options(options)
             Fastlane::CrashlyticsBeta.new(beta_info, Fastlane::CrashlyticsBetaUi.new).run
           else
-            Fastlane::Setup.new.run
+            Fastlane::Setup.new.run(user: options.user)
           end
         end
       end
@@ -309,7 +311,7 @@ module Fastlane
     def ensure_fastfile
       return true if FastlaneCore::FastlaneFolder.setup?
 
-      create = UI.confirm('Could not find fastlane in current directory. Would you like to set it up?')
+      create = UI.confirm('Could not find fastlane in current directory. Make sure to have your fastlane configuration files inside a folder called "fastlane". Would you like to set fastlane up?')
       Fastlane::Setup.new.run if create
       return false
     end

data/fastlane/lib/fastlane/setup/setup.rb

@@ -1,7 +1,7 @@
 module Fastlane
   class Setup
     # Start the setup process
-    def run
+    def run(user: nil)
       if FastlaneCore::FastlaneFolder.setup? and !Helper.is_test?
         UI.important("fastlane is already set up at path #{FastlaneCore::FastlaneFolder.path}")
         return
@@ -21,7 +21,7 @@ module Fastlane
       end
 
       if platform == :ios
-        SetupIos.new.run
+        SetupIos.new.run(user: user)
       elsif platform == :android
         SetupAndroid.new.run
       else

data/fastlane/lib/fastlane/setup/setup_ios.rb

@@ -14,7 +14,8 @@ module Fastlane
     attr_accessor :app_identifier
     attr_accessor :app_name
 
-    def run
+    def run(user: nil)
+      self.apple_id = user
       show_infos
 
       FastlaneCore::FastlaneFolder.create_folder! unless Helper.is_test?
@@ -36,7 +37,15 @@ module Fastlane
           manual_setup
         end
         UI.success('Successfully finished setting up fastlane')
+      rescue Spaceship::Client::InsufficientPermissions, Spaceship::Client::ProgramLicenseAgreementUpdated => ex
+        # We don't want to fallback to manual onboarding for this
+        # as the user needs to first accept the agreement / get more permissions
+        # Let's re-raise the exception to properly show the error message
+        raise ex
       rescue => ex # this will also be caused by Ctrl + C
+        UI.message("Ran into error while trying to connect to iTunes Connect / Dev Portal: #{ex}")
+        UI.message("Falling back to manual onboarding")
+
         if is_manual_setup
           handle_exception(exception: ex)
         else
@@ -45,7 +54,6 @@ module Fastlane
           try_manual_setup
         end
       end
-      # rubocop:enable Lint/RescueException
     end
 
     def handle_exception(exception: nil)
@@ -178,7 +186,7 @@ module Fastlane
     def detect_if_app_is_available
       require 'spaceship'
 
-      UI.important "Verifying if app is available on the Apple Developer Portal and iTunes Connect..."
+      UI.important "Verifying that app is available on the Apple Developer Portal and iTunes Connect..."
       UI.message "Starting login with user '#{self.apple_id}'"
       Spaceship.login(self.apple_id, nil)
       self.dev_portal_team = Spaceship.select_team

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.22.0.beta.20170321010023'.freeze
+  VERSION = '2.22.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/fastlane_folder.rb

@@ -13,7 +13,9 @@ module FastlaneCore
 
     # Path to the Fastfile inside the fastlane folder. This is nil when none is available
     def self.fastfile_path
-      path = File.join(self.path || '.', 'Fastfile')
+      return nil if self.path.nil?
+
+      path = File.join(self.path, 'Fastfile')
       return path if File.exist?(path)
       return nil
     end

data/spaceship/lib/spaceship/client.rb

@@ -51,6 +51,12 @@ module Spaceship
     # Raised when no user credentials were passed at all
     class NoUserCredentialsError < BasicPreferredInfoError; end
 
+    class ProgramLicenseAgreementUpdated < BasicPreferredInfoError
+      def show_github_issues
+        false
+      end
+    end
+
     # User doesn't have enough permission for given action
     class InsufficientPermissions < BasicPreferredInfoError
       TITLE = 'Insufficient permissions for your Apple ID:'.freeze
@@ -446,10 +452,7 @@ module Spaceship
         content = expected_key ? response.body[expected_key] : response.body
       end
       if content.nil?
-        # Check if the failure is due to missing permissions (iTunes Connect)
-        if response.body && response.body["messages"] && response.body["messages"]["error"].include?("Forbidden")
-          raise_insuffient_permission_error!
-        end
+        detect_most_common_errors_and_raise_exceptions(response.body) if response.body
         raise UnexpectedResponse, response.body
       elsif content.kind_of?(Hash) && (content["resultString"] || "").include?("NotAllowed")
         # example content when doing a Developer Portal action with not enough permission
@@ -469,6 +472,15 @@ module Spaceship
       end
     end
 
+    def detect_most_common_errors_and_raise_exceptions(body)
+      # Check if the failure is due to missing permissions (iTunes Connect)
+      if body["messages"] && body["messages"]["error"].include?("Forbidden")
+        raise_insuffient_permission_error!
+      elsif (body["resultString"] || "").include?("Program License Agreement")
+        raise ProgramLicenseAgreementUpdated, "#{body['userString']} Please manually log into iTunes Connect to review and accept the updated agreement."
+      end
+    end
+
     # This also gets called from subclasses
     def raise_insuffient_permission_error!(additional_error_string: nil)
       # get the method name of the request that failed

data/spaceship/lib/spaceship/portal/app.rb

@@ -107,6 +107,7 @@ module Spaceship
         # @param mac [Bool] Searches Mac apps if true
         # @return (App) The app you're looking for. This is nil if the app can't be found.
         def find(bundle_id, mac: false)
+          raise "`bundle_id` parameter must not be nil" if bundle_id.nil?
           all(mac: mac).find do |app|
             return app if app.bundle_id.casecmp(bundle_id) == 0
           end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.22.0.beta.20170321010023
+  version: 2.22.0
 platform: ruby
 authors:
 - Felix Krause
@@ -1296,23 +1296,23 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- snapshot/lib
+- cert/lib
+- credentials_manager/lib
+- deliver/lib
+- fastlane/lib
+- fastlane_core/lib
 - frameit/lib
-- scan/lib
+- gym/lib
+- match/lib
 - pem/lib
-- credentials_manager/lib
-- spaceship/lib
+- pilot/lib
 - produce/lib
+- scan/lib
 - screengrab/lib
 - sigh/lib
+- snapshot/lib
+- spaceship/lib
 - supply/lib
-- fastlane/lib
-- gym/lib
-- fastlane_core/lib
-- cert/lib
-- deliver/lib
-- match/lib
-- pilot/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -1320,14 +1320,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and
   Android apps
 test_files: []
+has_rdoc: