fastlane 2.18.1 → 2.18.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9d3c96a177ba6a9c1dee9d00010f9dfe7ef58ea
-  data.tar.gz: c54cb232450a7a3c6d3713d19175f41c38df0735
+  metadata.gz: f95259118de35e5f0bf061d30a5fef49137b2837
+  data.tar.gz: 4a9ef9be67de346ec9334f2a77907d75d5d56b8f
 SHA512:
-  metadata.gz: 2f5b27fee4f39d82d36024196cd7d8310de46e75c7d10f0bb8eca16240c7dc1131d142f21928b38170133b6f69e5999efa0a8cdb2494f7250631bb8006effa39
-  data.tar.gz: 69b350cc9901f2439b15531109eacfe49936ba1998a1bcb441aacd8be29a2178cb07a83fac6d3dc3924437772ef5cf987c517244a0b660449a265c0f552533ca
+  metadata.gz: 3649cbb7a9bc0bcf97e2592610a3812b37a04c955c437ec9ff363c983d4cc233d894b0b449d962df58f62a74fd833669ec56198179951caa2641fab911a87ec7
+  data.tar.gz: 42ca182fd45131c07990be51b864696a8b1b7b2fbf924a38202592e2039b1a55f987e26bf2e9c623dee73c85ac1f1e2caaa905a9a71eef6530185682e6ac35c9

data/deliver/lib/deliver/submit_for_review.rb

@@ -39,7 +39,7 @@ module Deliver
         end
       else
         UI.message("Selecting the latest build...")
-        build = FastlaneCore::BuildWatcher.wait_for_build(app, options[:app_platform], sleep_time)
+        build = wait_for_build(app)
       end
       UI.message("Selecting build #{build.train_version} (#{build.build_version})...")
 
@@ -48,5 +48,40 @@ module Deliver
 
       UI.success("Successfully selected build")
     end
+
+    def wait_for_build(app)
+      UI.user_error!("Could not find app with app identifier") unless app
+
+      start = Time.now
+
+      loop do
+        build = find_build(app.latest_version.candidate_builds)
+        return build if build.processing == false
+
+        UI.message("Waiting iTunes Connect processing for build #{build.train_version} (#{build.build_version})... this might take a while...")
+        if (Time.now - start) > (60 * 5)
+          UI.message("")
+          UI.message("You can tweet: \"iTunes Connect #iosprocessingtime #{((Time.now - start) / 60).round} minutes\"")
+        end
+        sleep 30
+      end
+      nil
+    end
+
+    def find_build(candidate_builds)
+      build = nil
+      candidate_builds.each do |b|
+        if !build or b.upload_date > build.upload_date
+          build = b
+        end
+      end
+
+      unless build
+        UI.error(candidate_builds)
+        UI.crash!("Could not find build")
+      end
+
+      return build
+    end
   end
 end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.18.1'.freeze
+  VERSION = '2.18.2'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core.rb

@@ -5,7 +5,6 @@ require 'fastlane_core/globals'
 # Ruby monkey-patches - should be before almost all else
 require 'fastlane_core/core_ext/string'
 
-require 'fastlane_core/build_watcher'
 require 'fastlane_core/env'
 require 'fastlane_core/feature/feature'
 require 'fastlane_core/features'

data/pilot/lib/pilot/build_manager.rb

@@ -31,7 +31,8 @@ module Pilot
       end
 
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
-      uploaded_build = FastlaneCore::BuildWatcher.wait_for_build(app, platform, config[:wait_processing_interval].to_i)
+      uploaded_build = wait_for_processing_build(options, platform) # this might take a while
+
       distribute(options, uploaded_build)
     end
 
@@ -123,6 +124,71 @@ module Pilot
       options[:changelog].to_s.length > 0 or options[:beta_app_description].to_s.length > 0 or options[:beta_app_feedback_email].to_s.length > 0
     end
 
+    # This method will takes care of checking for the processing builds every few seconds
+    # @return [Build] The build that we just uploaded
+    def wait_for_processing_build(options, platform)
+      # the upload date of the new buid
+      # we use it to identify the build
+      start = Time.now
+      wait_processing_interval = config[:wait_processing_interval].to_i
+      latest_build = nil
+      UI.message("Waiting for iTunes Connect to process the new build")
+      must_update_build_info = config[:update_build_info_on_upload]
+      loop do
+        sleep(wait_processing_interval)
+
+        # before we look for processing builds, we need to ensure that there
+        #  is a build train for this application; new applications don't
+        #  build trains right away, and if we don't do this check, we will
+        #  get break out of this loop and then generate an error later when we
+        #  have a nil build
+        if app.build_trains(platform: platform).count == 0
+          UI.message("New application; waiting for build train to appear on iTunes Connect")
+        else
+          builds = app.all_processing_builds(platform: platform)
+          break if builds.count == 0
+          latest_build = builds.last
+
+          if latest_build.valid and must_update_build_info
+            # Set the changelog and/or description if necessary
+            if should_update_build_information(options)
+              latest_build.update_build_information!(whats_new: options[:changelog], description: options[:beta_app_description], feedback_email: options[:beta_app_feedback_email])
+              UI.success "Successfully set the changelog and/or description for build"
+            end
+            must_update_build_info = false
+          end
+
+          UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
+        end
+      end
+
+      UI.user_error!("Error receiving the newly uploaded binary, please check iTunes Connect") if latest_build.nil?
+      full_build = nil
+
+      while full_build.nil? || full_build.processing
+        # The build's processing state should go from true to false, and be done. But sometimes it goes true -> false ->
+        # true -> false, where the second true is transient. This causes a spurious failure. Find build by build_version
+        # and ensure it's not processing before proceeding - it had to have already been false before, to get out of the
+        # previous loop.
+        full_build = app.build_trains(platform: platform)[latest_build.train_version].builds.find do |b|
+          b.build_version == latest_build.build_version
+        end
+
+        UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
+        sleep(wait_processing_interval)
+      end
+
+      if full_build && !full_build.processing && full_build.valid
+        minutes = ((Time.now - start) / 60).round
+        UI.success("Successfully finished processing the build")
+        UI.message("You can now tweet: ")
+        UI.important("iTunes Connect #iosprocessingtime #{minutes} minutes")
+        return full_build
+      else
+        UI.user_error!("Error: Seems like iTunes Connect didn't properly pre-process the binary")
+      end
+    end
+
     def distribute_build(uploaded_build, options)
       UI.message("Distributing new build to testers")
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.18.1
+  version: 2.18.2
 platform: ruby
 authors:
 - Felix Krause
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-21 00:00:00.000000000 Z
+date: 2017-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1023,7 +1023,6 @@ files:
 - fastlane_core/README.md
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
-- fastlane_core/lib/fastlane_core/build_watcher.rb
 - fastlane_core/lib/fastlane_core/cert_checker.rb
 - fastlane_core/lib/fastlane_core/command_executor.rb
 - fastlane_core/lib/fastlane_core/configuration/commander_generator.rb

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -1,80 +0,0 @@
-module FastlaneCore
-  class BuildWatcher
-    def self.find_build(app = nil)
-      build = nil
-      app.latest_version.candidate_builds.each do |b|
-        if !build or b.upload_date > build.upload_date
-          build = b
-        end
-      end
-      unless build
-        UI.user_error!("No processing builds available for app #{app.bundle_id}")
-      end
-      return build
-    end
-
-    def self.wait_for_train(app = nil, platform = "ios", sleep_time = 30)
-      loop do
-        sleep(sleep_time)
-        if app.build_trains(platform: platform).count == 0
-          UI.message("New application; waiting for build train to appear on iTunes Connect")
-        else
-          break
-        end
-      end
-    end
-
-    def self.wait_for_build(app = nil, platform = "ios", sleep_time = 0)
-      start_time = Time.now
-      UI.user_error!("Could not find app with app identifier #{app.bundle_id}") unless app
-      # if this is a new version/app wait for train to show up.
-      if app.build_trains(platform: platform).count == 0
-        self.class.wait_for_train(app, platform, sleep_time)
-      end
-
-      latest_build = nil
-      loop do
-        if sleep_time > 0
-          sleep(sleep_time)
-        else
-          return nil
-        end
-        builds = app.all_processing_builds(platform: platform)
-        break if builds.count == 0
-        latest_build = builds.last
-        UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
-      end
-
-      UI.user_error!("Error receiving the newly uploaded binary, please check iTunes Connect") if latest_build.nil?
-      full_build = nil
-
-      while full_build.nil? || full_build.processing
-        # The build's processing state should go from true to false, and be done. But sometimes it goes true -> false ->
-        # true -> false, where the second true is transient. This causes a spurious failure. Find build by build_version
-        # and ensure it's not processing before proceeding - it had to have already been false before, to get out of the
-        # previous loop.
-        full_build = app.build_trains(platform: platform)[latest_build.train_version].builds.find do |b|
-          b.build_version == latest_build.build_version
-        end
-        if sleep_time > 0
-          UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
-          sleep(sleep_time)
-        else
-          return nil
-        end
-      end
-
-      if full_build && !full_build.processing && full_build.valid
-        minutes = ((Time.now - start_time) / 60).round
-        UI.success("Successfully finished processing the build")
-        UI.message("You can now tweet: ")
-        UI.important("iTunes Connect #iosprocessingtime #{minutes} minutes")
-        return full_build
-      else
-        UI.user_error!("Error: Seems like iTunes Connect didn't properly pre-process the binary")
-      end
-    end
-
-    private_class_method :wait_for_train
-  end
-end