fastlane 2.18.0.beta.20170221010026 → 2.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5724a459e0f5dceee7b944c6a7d8cc24edd09347
-  data.tar.gz: ac696c73dda9a1c4e38ac3f856dca8c1ac492bd7
+  metadata.gz: 1a29078a37207ab9214712b179c10bd4e19a2230
+  data.tar.gz: 0806a47c7d815b2d295cfe379c58a309f902c407
 SHA512:
-  metadata.gz: 6bb3ae47b11d4bc4379be883da0ff82f3ffb0a45ba835894303a8299f7f8cc00308f81d471aa99cfecdbb61a4ed2c3fd1d45fd85717e21dbd565934c099bc051
-  data.tar.gz: 608b1c0364901e657e5902e23adf7866a8b56f1a13f788b8b62a007d46459b756cd779122ddb4fa2a99c77f87a1b319a91a8a8781d750c2be83b5388eada4cd4
+  metadata.gz: afe8839af19b3dae4cc5b523060cf93d7b47bb029d1a2501ebed6db716121d1fdfa23db2fe6c260e234f30aa38173f602c100a1d357c1cfda0a383cddfcbca81
+  data.tar.gz: 55e9c61cd96f60a790c5940dc00f871042a18d5ea34cc2430ba3c6ac4b64f8663f99bd5d806e294bad1f4660e61983436641b009d5f1f7bdf19361d11961f73c

data/deliver/lib/deliver/submit_for_review.rb

@@ -39,7 +39,7 @@ module Deliver
         end
       else
         UI.message("Selecting the latest build...")
-        build = wait_for_build(app)
+        build = FastlaneCore::BuildWatcher.wait_for_build(app, options[:app_platform], sleep_time)
       end
       UI.message("Selecting build #{build.train_version} (#{build.build_version})...")
 
@@ -48,40 +48,5 @@ module Deliver
 
       UI.success("Successfully selected build")
     end
-
-    def wait_for_build(app)
-      UI.user_error!("Could not find app with app identifier") unless app
-
-      start = Time.now
-
-      loop do
-        build = find_build(app.latest_version.candidate_builds)
-        return build if build.processing == false
-
-        UI.message("Waiting iTunes Connect processing for build #{build.train_version} (#{build.build_version})... this might take a while...")
-        if (Time.now - start) > (60 * 5)
-          UI.message("")
-          UI.message("You can tweet: \"iTunes Connect #iosprocessingtime #{((Time.now - start) / 60).round} minutes\"")
-        end
-        sleep 30
-      end
-      nil
-    end
-
-    def find_build(candidate_builds)
-      build = nil
-      candidate_builds.each do |b|
-        if !build or b.upload_date > build.upload_date
-          build = b
-        end
-      end
-
-      unless build
-        UI.error(candidate_builds)
-        UI.crash!("Could not find build")
-      end
-
-      return build
-    end
   end
 end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.18.0.beta.20170221010026'.freeze
+  VERSION = '2.18.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core.rb

@@ -5,6 +5,7 @@ require 'fastlane_core/globals'
 # Ruby monkey-patches - should be before almost all else
 require 'fastlane_core/core_ext/string'
 
+require 'fastlane_core/build_watcher'
 require 'fastlane_core/env'
 require 'fastlane_core/feature/feature'
 require 'fastlane_core/features'

data/fastlane_core/lib/fastlane_core/build_watcher.rb

@@ -0,0 +1,80 @@
+module FastlaneCore
+  class BuildWatcher
+    def self.find_build(app = nil)
+      build = nil
+      app.latest_version.candidate_builds.each do |b|
+        if !build or b.upload_date > build.upload_date
+          build = b
+        end
+      end
+      unless build
+        UI.user_error!("No processing builds available for app #{app.bundle_id}")
+      end
+      return build
+    end
+
+    def self.wait_for_train(app = nil, platform = "ios", sleep_time = 30)
+      loop do
+        sleep(sleep_time)
+        if app.build_trains(platform: platform).count == 0
+          UI.message("New application; waiting for build train to appear on iTunes Connect")
+        else
+          break
+        end
+      end
+    end
+
+    def self.wait_for_build(app = nil, platform = "ios", sleep_time = 0)
+      start_time = Time.now
+      UI.user_error!("Could not find app with app identifier #{app.bundle_id}") unless app
+      # if this is a new version/app wait for train to show up.
+      if app.build_trains(platform: platform).count == 0
+        self.class.wait_for_train(app, platform, sleep_time)
+      end
+
+      latest_build = nil
+      loop do
+        if sleep_time > 0
+          sleep(sleep_time)
+        else
+          return nil
+        end
+        builds = app.all_processing_builds(platform: platform)
+        break if builds.count == 0
+        latest_build = builds.last
+        UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
+      end
+
+      UI.user_error!("Error receiving the newly uploaded binary, please check iTunes Connect") if latest_build.nil?
+      full_build = nil
+
+      while full_build.nil? || full_build.processing
+        # The build's processing state should go from true to false, and be done. But sometimes it goes true -> false ->
+        # true -> false, where the second true is transient. This causes a spurious failure. Find build by build_version
+        # and ensure it's not processing before proceeding - it had to have already been false before, to get out of the
+        # previous loop.
+        full_build = app.build_trains(platform: platform)[latest_build.train_version].builds.find do |b|
+          b.build_version == latest_build.build_version
+        end
+        if sleep_time > 0
+          UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
+          sleep(sleep_time)
+        else
+          return nil
+        end
+      end
+
+      if full_build && !full_build.processing && full_build.valid
+        minutes = ((Time.now - start_time) / 60).round
+        UI.success("Successfully finished processing the build")
+        UI.message("You can now tweet: ")
+        UI.important("iTunes Connect #iosprocessingtime #{minutes} minutes")
+        return full_build
+      else
+        UI.user_error!("Error: Seems like iTunes Connect didn't properly pre-process the binary")
+      end
+    end
+
+    private_class_method :wait_for_train
+  end
+end

data/frameit/lib/frameit/config_parser.rb

@@ -83,6 +83,8 @@ module Frameit
             unless value.kind_of?(Integer) || value.split('x').length == 2 || (value.end_with?('%') && value.to_f > 0)
               UI.user_error!("padding must be type integer or pair of integers of format 'AxB' or a percentage of screen size")
             end
+          when 'show_complete_frame'
+            UI.user_error! "show_complete_frame must be a Boolean" unless [true, false].include?(value)
           when 'font_scale_factor'
             UI.user_error!("font_scale_factor must be numeric") unless value.kind_of?(Numeric)
           end

data/frameit/lib/frameit/editor.rb

@@ -117,9 +117,19 @@ module Frameit
         # Decrease the size of the framed screenshot to fit into the defined padding + background
         frame_width = background.width - horizontal_frame_padding * 2
         frame_height = background.height - top_space_above_device - vertical_frame_padding
-        @image.resize "#{frame_width}x"
-        if @image.height > frame_height
-          @image.resize "x#{frame_height.to_i}"
+
+        if fetch_config['show_complete_frame']
+          # calculate the final size of the screenshot to resize in one go
+          # it may be limited either by the width or height of the frame
+          image_aspect_ratio = @image.width.to_f / @image.height.to_f
+          image_width = [frame_width, @image.width].min
+          image_height = [frame_height, image_width / image_aspect_ratio].min
+          image_width = image_height * image_aspect_ratio
+          @image.resize "#{image_width}x#{image_height}" if image_width < @image.width || image_height < @image.height
+        else
+          # the screenshot size is only limited by width.
+          # If higher than the frame, the screenshot is cut off at the bottom
+          @image.resize "#{frame_width}x" if frame_width < @image.width
         end
       end
 
@@ -166,12 +176,6 @@ module Frameit
     end
 
     def put_device_into_background(background)
-      show_complete_frame = fetch_config['show_complete_frame']
-      if show_complete_frame
-        max_height = background.height - top_space_above_device
-        image.resize "x#{max_height}>"
-      end
-
       left_space = (background.width / 2.0 - image.width / 2.0).round
 
       @image = background.composite(image, "png") do |c|

data/pilot/lib/pilot/build_manager.rb

@@ -31,8 +31,7 @@ module Pilot
       end
 
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
-      uploaded_build = wait_for_processing_build(options, platform) # this might take a while
-
+      uploaded_build = FastlaneCore::BuildWatcher.wait_for_build(app, platform, config[:wait_processing_interval].to_i)
       distribute(options, uploaded_build)
     end
 
@@ -124,71 +123,6 @@ module Pilot
       options[:changelog].to_s.length > 0 or options[:beta_app_description].to_s.length > 0 or options[:beta_app_feedback_email].to_s.length > 0
     end
 
-    # This method will takes care of checking for the processing builds every few seconds
-    # @return [Build] The build that we just uploaded
-    def wait_for_processing_build(options, platform)
-      # the upload date of the new buid
-      # we use it to identify the build
-      start = Time.now
-      wait_processing_interval = config[:wait_processing_interval].to_i
-      latest_build = nil
-      UI.message("Waiting for iTunes Connect to process the new build")
-      must_update_build_info = config[:update_build_info_on_upload]
-      loop do
-        sleep(wait_processing_interval)
-
-        # before we look for processing builds, we need to ensure that there
-        #  is a build train for this application; new applications don't
-        #  build trains right away, and if we don't do this check, we will
-        #  get break out of this loop and then generate an error later when we
-        #  have a nil build
-        if app.build_trains(platform: platform).count == 0
-          UI.message("New application; waiting for build train to appear on iTunes Connect")
-        else
-          builds = app.all_processing_builds(platform: platform)
-          break if builds.count == 0
-          latest_build = builds.last
-
-          if latest_build.valid and must_update_build_info
-            # Set the changelog and/or description if necessary
-            if should_update_build_information(options)
-              latest_build.update_build_information!(whats_new: options[:changelog], description: options[:beta_app_description], feedback_email: options[:beta_app_feedback_email])
-              UI.success "Successfully set the changelog and/or description for build"
-            end
-            must_update_build_info = false
-          end
-
-          UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
-        end
-      end
-
-      UI.user_error!("Error receiving the newly uploaded binary, please check iTunes Connect") if latest_build.nil?
-      full_build = nil
-
-      while full_build.nil? || full_build.processing
-        # The build's processing state should go from true to false, and be done. But sometimes it goes true -> false ->
-        # true -> false, where the second true is transient. This causes a spurious failure. Find build by build_version
-        # and ensure it's not processing before proceeding - it had to have already been false before, to get out of the
-        # previous loop.
-        full_build = app.build_trains(platform: platform)[latest_build.train_version].builds.find do |b|
-          b.build_version == latest_build.build_version
-        end
-
-        UI.message("Waiting for iTunes Connect to finish processing the new build (#{latest_build.train_version} - #{latest_build.build_version})")
-        sleep(wait_processing_interval)
-      end
-
-      if full_build && !full_build.processing && full_build.valid
-        minutes = ((Time.now - start) / 60).round
-        UI.success("Successfully finished processing the build")
-        UI.message("You can now tweet: ")
-        UI.important("iTunes Connect #iosprocessingtime #{minutes} minutes")
-        return full_build
-      else
-        UI.user_error!("Error: Seems like iTunes Connect didn't properly pre-process the binary")
-      end
-    end
-
     def distribute_build(uploaded_build, options)
       UI.message("Distributing new build to testers")
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.18.0.beta.20170221010026
+  version: 2.18.0
 platform: ruby
 authors:
 - Felix Krause
@@ -1023,6 +1023,7 @@ files:
 - fastlane_core/README.md
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
+- fastlane_core/lib/fastlane_core/build_watcher.rb
 - fastlane_core/lib/fastlane_core/cert_checker.rb
 - fastlane_core/lib/fastlane_core/command_executor.rb
 - fastlane_core/lib/fastlane_core/configuration/commander_generator.rb
@@ -1294,23 +1295,23 @@ metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
-- deliver/lib
-- scan/lib
-- gym/lib
-- spaceship/lib
-- snapshot/lib
-- pem/lib
-- screengrab/lib
-- frameit/lib
+- cert/lib
 - credentials_manager/lib
+- deliver/lib
 - fastlane/lib
-- match/lib
-- cert/lib
 - fastlane_core/lib
-- supply/lib
+- frameit/lib
+- gym/lib
+- match/lib
+- pem/lib
+- pilot/lib
 - produce/lib
+- scan/lib
+- screengrab/lib
 - sigh/lib
-- pilot/lib
+- snapshot/lib
+- spaceship/lib
+- supply/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -1318,14 +1319,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and
   Android apps
 test_files: []
+has_rdoc: