fastlane 2.11.0 → 2.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 727fe731430e8c06f7b4a0c66d044714c879ccaf
-  data.tar.gz: c65677292ad39144080c5bdef78de0aea6b82961
+  metadata.gz: 4b1b63ff2fa7ae1f6bb83ee77cdd83530f36a7be
+  data.tar.gz: 4a03adb249cc48ad1eb0ce05a0857162d03ea8fd
 SHA512:
-  metadata.gz: 3f90f8dbb9649502c8300d957e5535db5ebdcc6abe900489be9173b44be4c55b91fb39f210b8a58d048517d6115f55fc3c0e7c17187bb3097d55234d5a7f2388
-  data.tar.gz: 73591c45604420668dddaf8ba46227fd6f44ab517e781bea5db8d1355e02c82a973680683740e55bbb5ad1088b24736e7a8d1aaf0c534283134bf0bae0b66c80
+  metadata.gz: 58cdcf0f0b64a3b56de09792a95b686fdcc4c9d6caa45cc16af7462de6f0f0f7605fe3323389c0ae6b97b87e6caa48d7dc57fcb9734c940e1dbc96a2c29b5e1b
+  data.tar.gz: d32509f435ad25c115a469686ee4a7faace5bbaa4313180f12d5908d2aa6185390b66522ce0330ba1abae9c0394d2722aaa77fa88eb931707600ab4bf015880e

data/fastlane/lib/fastlane/actions/opt_out_usage.rb

@@ -12,11 +12,11 @@ module Fastlane
 
       def self.details
         [
-          "By default, fastlane will share the used actions. ",
-          "No personal information is shard. More information available on ",
-          "https://github.com/fastlane/enhancer\n",
-          "Using this action you can opt out"
-        ].join('')
+          "By default, fastlane will track what actions are being used",
+          "No personal information is shared. More information available on",
+          "https://github.com/fastlane/enhancer",
+          "Add `opt_out_usage` at the top of your Fastfile"
+        ].join(' ')
       end
 
       def self.author
@@ -29,7 +29,7 @@ module Fastlane
 
       def self.example_code
         [
-          'opt_out_usage'
+          'opt_out_usage # add this to the top of your Fastfile'
         ]
       end
 

data/fastlane/lib/fastlane/documentation/docs_generator.rb

@@ -36,8 +36,8 @@ module Fastlane
       end
 
       output << "This README.md is auto-generated and will be re-generated every time [fastlane](https://fastlane.tools) is run."
-      output << "More information about fastlane can be found on [https://fastlane.tools](https://fastlane.tools)."
-      output << "The documentation of fastlane can be found on [https://docs.fastlane.tools](https://docs.fastlane.tools)."
+      output << "More information about fastlane can be found on [fastlane.tools](https://fastlane.tools)."
+      output << "The documentation of fastlane can be found on [docs.fastlane.tools](https://docs.fastlane.tools)."
       output << ""
 
       File.write(output_path, output.join("\n"))

data/fastlane/lib/fastlane/fastlane_require.rb

@@ -2,7 +2,7 @@ module Fastlane
   class FastlaneRequire
     class << self
       def install_gem_if_needed(gem_name: nil, require_gem: true)
-        gem_require_name = gem_name.tr("-", "/") # from "fastlane-plugin-xcversion" to "fastlane/plugin/xcversion"
+        gem_require_name = format_gem_require_name(gem_name)
 
         # check if it's installed
         if gem_installed?(gem_name)
@@ -62,6 +62,13 @@ module Fastlane
 
         return gems.first
       end
+
+      def format_gem_require_name(gem_name)
+        # from "fastlane-plugin-xcversion" to "fastlane/plugin/xcversion"
+        gem_name = gem_name.tr("-", "/") if gem_name.start_with? "fastlane-plugin-"
+
+        return gem_name
+      end
     end
   end
 end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.11.0'.freeze
+  VERSION = '2.12.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -140,16 +140,17 @@ module Commander
       # use a bit of Ruby duck-typing to check whether the unknown exception type implements the right
       # method. If so, we'll present any returned error info in the manner of a user_error!
       error_info = e.respond_to?(:preferred_error_info) ? e.preferred_error_info : nil
+      should_show_github_issues = e.respond_to?(:show_github_issues) ? e.show_github_issues : true
 
       if error_info
         error_info = error_info.join("\n\t") if error_info.kind_of?(Array)
 
-        show_github_issues(error_info)
+        show_github_issues(error_info) if should_show_github_issues
 
         display_user_error!(e, error_info)
       else
         # Pass the error instead of a message so that the inspector can do extra work to simplify the query
-        show_github_issues(e)
+        show_github_issues(e) if should_show_github_issues
 
         # From https://stackoverflow.com/a/4789702/445598
         # We do this to make the actual error message red and therefore more visible

data/fastlane_core/lib/fastlane_core/ui/github_issue_inspector_reporter.rb

@@ -29,7 +29,6 @@ module Fastlane
       puts "Found no similar issues. To create a new issue, please visit:"
       puts "https://github.com/#{inspector.repo_owner}/#{inspector.repo_name}/issues/new"
       puts "Run `fastlane env` to append the fastlane environment to your issue"
-      print_open_link_hint(true)
     end
 
     # Called when there have been networking issues in creating the report.
@@ -37,7 +36,6 @@ module Fastlane
       puts "Could not access the GitHub API, you may have better luck via the website."
       puts "https://github.com/#{inspector.repo_owner}/#{inspector.repo_name}/search?q=#{query}&type=Issues&utf8=✓"
       puts "Error: #{error.name}"
-      print_open_link_hint(true)
     end
 
     private
@@ -54,7 +52,7 @@ module Fastlane
 
     def print_open_link_hint(newline = false)
       puts "" if newline
-      puts "🔗 You can ⌘ + double-click on links to open them directly in your browser." if Helper.mac?
+      puts "🔗  You can ⌘ + double-click on links to open them directly in your browser." if Helper.mac?
     end
   end
 end

data/fastlane_core/lib/fastlane_core/update_checker/update_checker.rb

@@ -79,7 +79,7 @@ module FastlaneCore
     def self.update_command(gem_name: "fastlane")
       if Helper.bundler?
         "bundle update #{gem_name.downcase}"
-      elsif Helper.contained_fastlane?
+      elsif Helper.contained_fastlane? || Helper.homebrew?
         "fastlane update_fastlane"
       else
         "sudo gem update #{gem_name.downcase}"

data/pilot/lib/pilot/commands_generator.rb

@@ -31,11 +31,12 @@ module Pilot
         begin
           mgr.public_send(action, config)
         rescue => ex
-          failures.push(address)
-          UI.message("[#{address}]: #{ex}")
+          message = "[#{address}]: #{ex}"
+          failures << message
+          UI.error(message)
         end
       end
-      UI.user_error!("Some operations failed: #{failures}") unless failures.empty?
+      UI.user_error!("Some operations failed: #{failures.join(', ')}") unless failures.empty?
     end
 
     def run

data/pilot/lib/pilot/tester_manager.rb

@@ -118,12 +118,8 @@ module Pilot
       begin
         int_testers = Spaceship::Tunes::Tester::Internal.all
         ext_testers = Spaceship::Tunes::Tester::External.all
-      rescue => ex
-        if ex.to_s.include?("Forbidden")
-          UI.user_error!("You don't have the permission to list the testers of your whole team. Please provide an app identifier to list all testers of a specific application.")
-        else
-          raise ex
-        end
+      rescue Spaceship::Client::InsufficientPermissions
+        UI.user_error!("You don't have the permission to list the testers of your whole team. Please provide an app identifier to list all testers of a specific application.")
       end
 
       list_global(int_testers, "Internal Testers")

data/scan/lib/scan/detect_values.rb

@@ -36,9 +36,24 @@ module Scan
 
       default_derived_data
 
+      coerce_to_array_of_strings(:only_testing)
+      coerce_to_array_of_strings(:skip_testing)
+
       return config
     end
 
+    def self.coerce_to_array_of_strings(config_key)
+      config_value = Scan.config[config_key]
+
+      return if config_value.nil?
+
+      # splitting on comma allows us to support comma-separated lists of values
+      # from the command line, even though the ConfigItem is not defined as an
+      # Array type
+      config_value = config_value.split(',') unless config_value.kind_of?(Array)
+      Scan.config[config_key] = config_value.map(&:to_s)
+    end
+
     def self.default_derived_data
       return unless Scan.config[:derived_data_path].to_s.empty?
       default_path = Scan.project.build_settings(key: "BUILT_PRODUCTS_DIR")

data/scan/lib/scan/options.rb

@@ -3,6 +3,11 @@ require "credentials_manager"
 
 module Scan
   class Options
+    def self.verify_type(item_name, acceptable_types, value)
+      type_ok = [Array, String].any? { |type| value.kind_of?(type) }
+      UI.user_error!("'#{item_name}' should be of type #{acceptable_types.join(' or ')} but found: #{value.class.name}") unless type_ok
+    end
+
     def self.available_options
       containing = Helper.fastlane_enabled? ? './fastlane' : '.'
 
@@ -166,6 +171,22 @@ module Scan
                                      verify_block: proc do |value|
                                        UI.user_error!("File not found at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                      end),
+        FastlaneCore::ConfigItem.new(key: :only_testing,
+                                     env_name: "SCAN_ONLY_TESTING",
+                                     description: "Array of strings matching Test Bundle/Test Suite/Test Cases to run",
+                                     optional: true,
+                                     is_string: false,
+                                     verify_block: proc do |value|
+                                       verify_type('only_testing', [Array, String], value)
+                                     end),
+        FastlaneCore::ConfigItem.new(key: :skip_testing,
+                                     env_name: "SCAN_SKIP_TESTING",
+                                     description: "Array of strings matching Test Bundle/Test Suite/Test Cases to skip",
+                                     optional: true,
+                                     is_string: false,
+                                     verify_block: proc do |value|
+                                       verify_type('skip_testing', [Array, String], value)
+                                     end),
         FastlaneCore::ConfigItem.new(key: :slack_url,
                                      short_option: "-i",
                                      env_name: "SLACK_URL",

data/scan/lib/scan/slack_poster.rb

@@ -51,7 +51,10 @@ module Scan
 
       if result.code.to_i == 200
         UI.success('Successfully sent Slack notification')
+      elsif result.code.to_i == 404
+        UI.error("The Slack URL you provided could not be reached (404)")
       else
+        UI.error("The Slack notification could not be sent:")
         UI.error(result.to_s)
       end
     end

data/scan/lib/scan/test_command_generator.rb

@@ -41,6 +41,11 @@ module Scan
         options << "-xcconfig '#{config[:xcconfig]}'" if config[:xcconfig]
         options << config[:xcargs] if config[:xcargs]
 
+        # detect_values will ensure that these values are present as Arrays if
+        # they are present at all
+        options += config[:only_testing].map { |test_id| "-only-testing:#{test_id}" } if config[:only_testing]
+        options += config[:skip_testing].map { |test_id| "-skip-testing:#{test_id}" } if config[:skip_testing]
+
         options
       end
 

data/screengrab/lib/screengrab/runner.rb

@@ -187,16 +187,14 @@ module Screengrab
 
     def uninstall_apks(device_serial, app_package_name, tests_package_name)
       UI.message 'Uninstalling app APK'
-      apk_uninstall_output = run_adb_command("adb -s #{device_serial} uninstall #{app_package_name}",
-                                             print_all: true,
-                                             print_command: true)
-      UI.user_error! "App APK could not be uninstalled" if apk_uninstall_output.include?("Failure [")
+      run_adb_command("adb -s #{device_serial} uninstall #{app_package_name}",
+                      print_all: true,
+                      print_command: true)
 
       UI.message 'Uninstalling tests APK'
-      apk_uninstall_output = run_adb_command("adb -s #{device_serial} uninstall -r #{tests_package_name}",
-                                             print_all: true,
-                                             print_command: true)
-      UI.user_error! "Tests APK could not be uninstalled" if apk_uninstall_output.include?("Failure [")
+      run_adb_command("adb -s #{device_serial} uninstall #{tests_package_name}",
+                      print_all: true,
+                      print_command: true)
     end
 
     def grant_permissions(device_serial)

data/snapshot/README.md

@@ -334,7 +334,7 @@ _snapshot_ finds all these entries using a regex. The number of _snapshot_ outpu
 
 If you find a better way to do any of this, please submit an issue on GitHub or even a pull request :+1:
 
-Also, feel free to duplicate radar [23062925](https://openradar.appspot.com/radar?id=5056366381105152).
+Radar [23062925](https://openradar.appspot.com/radar?id=5056366381105152) has been resolved with Xcode 8.3, so it's now possible to actually take screenshots from the simulator. We'll keep using the old approach for now, since many of you still want to use older versions of Xcode.
 
 # Tips
 

data/snapshot/lib/snapshot/fixes/README.md

@@ -1,5 +1,5 @@
 ### Fixes
 
 This directory contains all the files we don't actually want to have, but are necessary due to open radars, e.g.
-- [rdar://23062925](https://openradar.appspot.com/radar?id=5056366381105152): Trigger screenshots from UI Tests
+
 - [rdar://23323159](https://openradar.appspot.com/radar?id=6127019184095232): Screenshots are broken when simulator is not scaled at 100%

data/snapshot/lib/snapshot/reports_generator.rb

@@ -53,6 +53,7 @@ module Snapshot
         'iPhone6' => "iPhone6 (4.7-Inch)",
         'iPhone5' => "iPhone5 (4-Inch)",
         'iPhone4' => "iPhone4 (3.5-Inch)",
+        'iPhone SE' => "iPhone SE",
         'iPad2' => "iPad2",
         'iPadAir2' => 'iPad Air 2',
         'iPadPro(12.9-inch)' => 'iPad Air Pro (12.9 inch)',

data/spaceship/lib/spaceship/client.rb

@@ -50,6 +50,21 @@ module Spaceship
     # Raised when no user credentials were passed at all
     class NoUserCredentialsError < BasicPreferredInfoError; end
 
+    # User doesn't have enough permission for given action
+    class InsufficientPermissions < BasicPreferredInfoError
+      TITLE = 'Insufficient permissions for your Apple ID:'.freeze
+
+      def preferred_error_info
+        message ? [TITLE, message] : nil
+      end
+
+      # We don't want to show similar GitHub issues, as the error message
+      # should be pretty clear
+      def show_github_issues
+        false
+      end
+    end
+
     class UnexpectedResponse < StandardError
       attr_reader :error_info
 
@@ -426,13 +441,50 @@ module Spaceship
       end
 
       if content.nil?
+        # Check if the failure is due to missing permissions (iTunes Connect)
+        if response.body && response.body["messages"] && response.body["messages"]["error"].include?("Forbidden")
+          raise_insuffient_permission_error!
+        end
+
         raise UnexpectedResponse, response.body
+      elsif content.kind_of?(Hash) && (content["resultString"] || "").include?("NotAllowed")
+        # example content when doing a Developer Portal action with not enough permission
+        # => {"responseId"=>"e5013d83-c5cb-4ba0-bb62-734a8d56007f",
+        #    "resultCode"=>1200,
+        #    "resultString"=>"webservice.certificate.downloadNotAllowed",
+        #    "userString"=>"You are not permitted to download this certificate.",
+        #    "creationTimestamp"=>"2017-01-26T22:44:13Z",
+        #    "protocolVersion"=>"QH65B2",
+        #    "userLocale"=>"en_US",
+        #    "requestUrl"=>"https://developer.apple.com/services-account/QH65B2/account/ios/certificate/downloadCertificateContent.action",
+        #    "httpCode"=>200}
+        raise_insuffient_permission_error!(additional_error_string: content["userString"])
       else
         store_csrf_tokens(response)
         content
       end
     end
 
+    # This also gets called from subclasses
+    def raise_insuffient_permission_error!(additional_error_string: nil)
+      # get the method name of the request that failed
+      # `block in` is used very often for requests when surrounded for paging or retrying blocks
+      # The ! is part of some methods when they modify or delete a resource, so we don't want to show it
+      # Using `sub` instead of `delete` as we don't want to allow multiple matches
+      calling_method_name = caller_locations(2, 2).first.label.sub("block in", "").delete("!").strip
+      begin
+        team_id = "(Team ID #{self.team_id}) "
+      rescue
+        # Showing the team ID is something that's nice to have, however it might cause an exception
+        # when the user doesn't have any permission at all (e.g. failing at login)
+        # we still want the error message to show the actual string, but without the team_id in that case
+        team_id = ""
+      end
+      error_message = "User #{self.user} #{team_id}doesn't have enough permission for the following action: #{calling_method_name}"
+      error_message += " (#{additional_error_string})" if additional_error_string.to_s.length > 0
+      raise InsufficientPermissions, error_message
+    end
+
     private
 
     def directory_accessible?(path)

data/spaceship/lib/spaceship/spaceauth_runner.rb

@@ -33,7 +33,12 @@ module Spaceship
       # Example:
       # name: DES5c148586daa451e55afb017aa62418f91
       # value: HSARMTKNSRVTWFlaF/ek8asaa9lymMA0dN8JQ6pY7B3F5kdqTxJvMT19EVEFX8EQudB/uNwBHOHzaa30KYTU/eCP/UF7vGTgxs6PAnlVWKscWssOVHfP2IKWUPaa4Dn+I6ilA7eAFQsiaaVT
-      cookies = YAML.safe_load(itc_cookie_content)
+      cookies = YAML.safe_load(
+        itc_cookie_content,
+        [HTTP::Cookie, Time], # classes whitelist
+        [],                   # symbols whitelist
+        true                  # allow YAML aliases
+      )
 
       # We remove all the un-needed cookies
       cookies.select! do |cookie|

data/spaceship/lib/spaceship/tunes/app_version.rb

@@ -45,6 +45,11 @@ module Spaceship
       # @return (Bool) Should the app automatically be released once it's approved?
       attr_accessor :release_on_approval
 
+      # @return (Fixnum) Milliseconds for releasing in GMT (e.g. 1480435200000 = Tue, 29 Nov 2016 16:00:00 GMT).
+      #   Use nil to unset. Setting this will supercede the release_on_approval field, so this field must be nil
+      #   for release_on_approval to be used.
+      attr_accessor :auto_release_date
+
       # @return (Bool)
       attr_accessor :can_beta_test
 
@@ -135,6 +140,7 @@ module Spaceship
         'largeAppIcon.value.originalFileName' => :app_icon_original_name,
         'largeAppIcon.value.url' => :app_icon_url,
         'releaseOnApproval.value' => :release_on_approval,
+        'autoReleaseDate.value' => :auto_release_date,
         'status' => :raw_status,
         'preReleaseBuild.buildVersion' => :build_version,
         'supportsAppleWatch' => :supports_apple_watch,

data/spaceship/lib/spaceship/tunes/tester.rb

@@ -104,7 +104,7 @@ module Spaceship
         # @param last_name (String) (optional): The last name of the new tester
         # @param groups (Array) (option): Names/IDs of existing groups for the new tester
         # @example
-        #   Spaceship::Tunes::Tester.external.create!(email: "tester@mathiascarignani.com", first_name: "Cary", last_name:"Bennett", groups:["Testers"])
+        #   Spaceship::Tunes::Tester.external.create!(email: "tester@mathiascarignani.com", first_name: "Cary", last_name: "Bennett", groups: ["Testers"])
         # @return (Tester): The newly created tester
         def create!(email: nil, first_name: nil, last_name: nil, groups: nil)
           data = client.create_tester!(tester: self,

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -46,9 +46,7 @@ module Spaceship
 
     # @return (Array) A list of all available teams
     def teams
-      return @teams if @teams
-      r = request(:get, "ra/user/detail")
-      @teams = parse_response(r, 'data')['associatedAccounts'].sort_by do |team|
+      user_details_data['associatedAccounts'].sort_by do |team|
         [
           team['contentProvider']['name'],
           team['contentProvider']['contentProviderId']
@@ -214,10 +212,13 @@ module Spaceship
       errors << different_error if different_error
 
       if errors.count > 0 # they are separated by `.` by default
+        # Sample `error` content: [["Forbidden"]]
         if errors.count == 1 and errors.first == "You haven't made any changes."
           # This is a special error which we really don't care about
         elsif errors.count == 1 and errors.first.include?("try again later")
           raise ITunesConnectTemporaryError.new, errors.first
+        elsif errors.count == 1 and errors.first.include?("Forbidden")
+          raise_insuffient_permission_error!
         else
           raise ITunesConnectError.new, errors.join(' ')
         end
@@ -596,14 +597,61 @@ module Spaceship
       Spaceship::Tunes::AppVersionRef.factory(data)
     end
 
+    # Fetch the general information of the user, is used by various methods across spaceship
+    # Sample return value
+    # => {"associatedAccounts"=>
+    #   [{"contentProvider"=>{"contentProviderId"=>11142800, "name"=>"Felix Krause", "contentProviderTypes"=>["Purple Software"]}, "roles"=>["Developer"], "lastLogin"=>1468784113000}],
+    #  "sessionToken"=>{"dsId"=>"8501011116", "contentProviderId"=>18111111, "expirationDate"=>nil, "ipAddress"=>nil},
+    #  "permittedActivities"=>
+    #   {"EDIT"=>
+    #     ["UserManagementSelf",
+    #      "GameCenterTestData",
+    #      "AppAddonCreation"],
+    #    "REPORT"=>
+    #     ["UserManagementSelf",
+    #      "AppAddonCreation"],
+    #    "VIEW"=>
+    #     ["TestFlightAppExternalTesterManagement",
+    #      ...
+    #      "HelpGeneral",
+    #      "HelpApplicationLoader"]},
+    #  "preferredCurrencyCode"=>"EUR",
+    #  "preferredCountryCode"=>nil,
+    #  "countryOfOrigin"=>"AT",
+    #  "isLocaleNameReversed"=>false,
+    #  "feldsparToken"=>nil,
+    #  "feldsparChannelName"=>nil,
+    #  "hasPendingFeldsparBindingRequest"=>false,
+    #  "isLegalUser"=>false,
+    #  "userId"=>"1771111155",
+    #  "firstname"=>"Detlef",
+    #  "lastname"=>"Mueller",
+    #  "isEmailInvalid"=>false,
+    #  "hasContractInfo"=>false,
+    #  "canEditITCUsersAndRoles"=>false,
+    #  "canViewITCUsersAndRoles"=>true,
+    #  "canEditIAPUsersAndRoles"=>false,
+    #  "transporterEnabled"=>false,
+    #  "contentProviderFeatures"=>["APP_SILOING", "PROMO_CODE_REDESIGN", ...],
+    #  "contentProviderType"=>"Purple Software",
+    #  "displayName"=>"Detlef",
+    #  "contentProviderId"=>"18742800",
+    #  "userFeatures"=>[],
+    #  "visibility"=>true,
+    #  "DYCVisibility"=>false,
+    #  "contentProvider"=>"Felix Krause",
+    #  "userName"=>"detlef@krausefx.com"}
+    def user_details_data
+      return @_cached_user_details if @_cached_user_details
+      r = request(:get, '/WebObjects/iTunesConnect.woa/ra/user/detail')
+      @_cached_user_details = parse_response(r, 'data')
+    end
+
     # Fetches the User Detail information from ITC. This gets called often and almost never changes
     # so we cache it
     # @return [UserDetail] the response
     def user_detail_data
-      return @cached if @cached
-      r = request(:get, '/WebObjects/iTunesConnect.woa/ra/user/detail')
-      data = parse_response(r, 'data')
-      @cached = Spaceship::Tunes::UserDetail.factory(data)
+      @_cached_user_detail_data ||= Spaceship::Tunes::UserDetail.factory(user_details_data)
     end
 
     #####################################################
@@ -631,7 +679,13 @@ module Spaceship
       # Build trains fail randomly very often
       # we need to catch those errors and retry
       # https://github.com/fastlane/fastlane/issues/6419
-      if ex.to_s.include?("ITC.response.error.OPERATION_FAILED")
+      retry_error_messages = [
+        "ITC.response.error.OPERATION_FAILED",
+        "Internal Server Error",
+        "Service Unavailable"
+      ].freeze
+
+      if retry_error_messages.any? { |message| ex.to_s.include?(message) }
         tries -= 1
         if tries > 0
           logger.warn("Received temporary server error from iTunes Connect. Retrying the request...")
@@ -870,6 +924,10 @@ module Spaceship
       parse_response(r, 'data')['users']
     end
 
+    # Returns a list of available testing groups
+    # e.g.
+    #   {"b6f65dbd-c845-4d91-bc39-0b661d608970" => "Boarding",
+    #    "70402368-9deb-409f-9a26-bb3f215dfee3" => "Automatic"}
     def groups
       return @cached_groups if @cached_groups
       r = request(:get, '/WebObjects/iTunesConnect.woa/ra/users/pre/ext')
@@ -881,21 +939,42 @@ module Spaceship
       raise "Action not provided for this tester type." unless url
 
       tester_data = {
-            emailAddress: {
-              value: email
-            },
-            firstName: {
-              value: first_name || ""
-            },
-            lastName: {
-              value: last_name || ""
-            },
-            testing: {
-              value: true
+        emailAddress: {
+          value: email
+        },
+        firstName: {
+          value: first_name || ""
+        },
+        lastName: {
+          value: last_name || ""
+        },
+        testing: {
+          value: true
+        }
+      }
+
+      if groups
+        tester_data[:groups] = groups.map do |group_name_or_group_id|
+          if self.groups.value?(group_name_or_group_id)
+            # This is an existing group, let's use that, the user specified the group name
+            group_name = group_name_or_group_id
+            group_id = self.groups.key(group_name_or_group_id)
+          elsif self.groups.key?(group_name_or_group_id)
+            # This is an existing group, let's use that, the user specified the group ID
+            group_name = self.groups[group_name_or_group_id]
+            group_id = group_name_or_group_id
+          else
+            group_name = group_name_or_group_id
+            group_id = nil # this is expected by the iTC API
+          end
+
+          {
+            "id" => group_id,
+            "name" => {
+              "value" => group_name
             }
           }
-      if groups
-        tester_data[:groups] = groups.map { |x| { "id" => x } }
+        end
       end
 
       data = { testers: [tester_data] }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.11.0
+  version: 2.12.0
 platform: ruby
 authors:
 - Felix Krause
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-25 00:00:00.000000000 Z
+date: 2017-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -739,15 +739,12 @@ files:
 - deliver/lib/deliver/upload_price_tier.rb
 - deliver/lib/deliver/upload_screenshots.rb
 - fastlane/README.md
-- fastlane/lib/.DS_Store
-- fastlane/lib/assets/.DS_Store
 - fastlane/lib/assets/Actions.md.erb
 - fastlane/lib/assets/AppfileTemplate
 - fastlane/lib/assets/AppfileTemplateAndroid
 - fastlane/lib/assets/AvailablePlugins.md.erb
 - fastlane/lib/assets/DefaultFastfileTemplate
 - fastlane/lib/assets/FastfileTemplateAndroid
-- fastlane/lib/assets/completions/.DS_Store
 - fastlane/lib/assets/completions/completion.bash
 - fastlane/lib/assets/completions/completion.sh
 - fastlane/lib/assets/completions/completion.zsh
@@ -758,10 +755,8 @@ files:
 - fastlane/lib/assets/s3_plist_template.erb
 - fastlane/lib/assets/s3_version_template.erb
 - fastlane/lib/fastlane.rb
-- fastlane/lib/fastlane/.DS_Store
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
-- fastlane/lib/fastlane/actions/.DS_Store
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb
@@ -802,7 +797,6 @@ files:
 - fastlane/lib/fastlane/actions/delete_keychain.rb
 - fastlane/lib/fastlane/actions/deliver.rb
 - fastlane/lib/fastlane/actions/deploygate.rb
-- fastlane/lib/fastlane/actions/device_grid/.DS_Store
 - fastlane/lib/fastlane/actions/device_grid/README.md
 - fastlane/lib/fastlane/actions/dotgpg_environment.rb
 - fastlane/lib/fastlane/actions/download.rb
@@ -1013,10 +1007,8 @@ files:
 - fastlane/lib/fastlane/tools.rb
 - fastlane/lib/fastlane/version.rb
 - fastlane_core/README.md
-- fastlane_core/lib/.DS_Store
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
-- fastlane_core/lib/fastlane_core/.DS_Store
 - fastlane_core/lib/fastlane_core/cert_checker.rb
 - fastlane_core/lib/fastlane_core/command_executor.rb
 - fastlane_core/lib/fastlane_core/configuration/commander_generator.rb
@@ -1172,7 +1164,6 @@ files:
 - sigh/lib/sigh/resign.rb
 - sigh/lib/sigh/runner.rb
 - snapshot/README.md
-- snapshot/lib/.DS_Store
 - snapshot/lib/assets/SnapfileTemplate
 - snapshot/lib/assets/SnapshotHelper.swift
 - snapshot/lib/assets/SnapshotHelper2-3.swift
@@ -1197,11 +1188,9 @@ files:
 - snapshot/lib/snapshot/test_command_generator.rb
 - snapshot/lib/snapshot/update.rb
 - spaceship/README.md
-- spaceship/lib/.DS_Store
 - spaceship/lib/assets/languageMapping.json
 - spaceship/lib/assets/languageMappingReadable.json
 - spaceship/lib/spaceship.rb
-- spaceship/lib/spaceship/.DS_Store
 - spaceship/lib/spaceship/babosa_fix.rb
 - spaceship/lib/spaceship/base.rb
 - spaceship/lib/spaceship/client.rb
@@ -1305,7 +1294,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and