fastlane 2.112.0.beta.20181216200018 → 2.112.0.beta.20181217200025

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8589634ba5507345799416a1e8ccd4a291a6e5ee
-  data.tar.gz: fd9d891edd1377436edb624d8038683c0f488e96
+  metadata.gz: a2babe236d0e507ad2badf3fee491a8a84ba4c29
+  data.tar.gz: 40f597b30544013f6fc6b2560f85e1ad87935f90
 SHA512:
-  metadata.gz: 98ebb5688724ab2c2eaa7af6ed66fb83cccc6c48d298a3f2659d44589fe040d0e949d72402c10af4710d3d9f2153fa1f8815e3bd59d0954b574180da27536155
-  data.tar.gz: 9ba1aed33a03196b8852b4227fe7605f71945fc560d1d7aa25920ad4c456aff1c61a0a24e12078e0634a8383a8cf962fd4bfed6fdc724021c8aae19330829559
+  metadata.gz: 8373b7f1581f6ed32237b90d13b1368ee9b8f4e59eb403e941fe2ee3ffe5ef0200ca0024c72ae50ccdb89d310e32e8648916c714235a0e15421c46e1a1b7b3d3
+  data.tar.gz: df62c4dee1e2a5a75b5281d686877374aebc9199e9925c713bbec5ba612b46ad5241eddde90a9ccf9833a6a2da2bfbc42d2944e21055d2e3dc2983d2ac5a4a98

data/deliver/lib/deliver/html_generator.rb

@@ -9,7 +9,8 @@ module Deliver
 
     def run(options, screenshots)
       begin
-        fastlane_path = FastlaneCore::FastlaneFolder.path
+        # Use fastlane folder or default to current directory
+        fastlane_path = FastlaneCore::FastlaneFolder.path || "."
         html_path = self.render(options, screenshots, fastlane_path)
       rescue => ex
         UI.error(ex.inspect)

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.112.0.beta.20181216200018'.freeze
+  VERSION = '2.112.0.beta.20181217200025'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/spaceship/lib/spaceship.rb

@@ -12,6 +12,7 @@ require_relative 'spaceship/portal/spaceship'
 require_relative 'spaceship/tunes/tunes'
 require_relative 'spaceship/tunes/spaceship'
 require_relative 'spaceship/test_flight'
+require_relative 'spaceship/connect_api'
 
 require_relative 'spaceship/module'
 

data/spaceship/lib/spaceship/connect_api.rb

@@ -0,0 +1,2 @@
+require 'spaceship/connect_api/client'
+require 'spaceship/connect_api/base'

data/spaceship/lib/spaceship/connect_api/base.rb

@@ -0,0 +1,39 @@
+require_relative '../base'
+require_relative '../tunes/tunes_client'
+
+module Spaceship
+  module ConnectAPI
+    class Base < Spaceship::Base
+      def self.client
+        # Verify there is a client that can be used
+        if Spaceship::Tunes.client
+          # Initialize new client if new or if team changed
+          if @client.nil? || @client.team_id != Spaceship::Tunes.client.team_id
+            @client = Client.client_with_authorization_from(Spaceship::Tunes.client)
+          end
+        end
+
+        # Need to handle not having a client but this shouldn't ever happen
+        raise "Please login using `Spaceship::Tunes.login('user', 'password')`" unless @client
+
+        @client
+      end
+
+      ##
+      # Have subclasses inherit the client from their superclass
+      #
+      # Essentially, we are making a class-inheritable-accessor as described here:
+      # https://apidock.com/rails/v4.2.7/Class/class_attribute
+      def self.inherited(subclass)
+        this_class = self
+        subclass.define_singleton_method(:client) do
+          this_class.client
+        end
+      end
+
+      def to_json
+        raw_data.to_json
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/connect_api/client.rb

@@ -0,0 +1,141 @@
+require_relative '../client'
+
+module Spaceship
+  module ConnectAPI
+    class Client < Spaceship::Client
+      ##
+      # Spaceship HTTP client for the App Store Connect API.
+      #
+      # This client is solely responsible for the making HTTP requests and
+      # parsing their responses. Parameters should be either named parameters, or
+      # for large request data bodies, pass in anything that can resond to
+      # `to_json`.
+      #
+      # Each request method should validate the required parameters. A required parameter is one that would result in 400-range response if it is not supplied.
+      # Each request method should make only one request. For more high-level logic, put code in the data models.
+
+      def self.hostname
+        'https://appstoreconnect.apple.com/iris/v1/'
+      end
+
+      def build_url(path: nil, filter: nil, includes: nil, limit: nil, sort: nil)
+        filters = filter.keys.map do |key|
+          "&filter[#{key}]=#{filter[key]}"
+        end.join("")
+        return "#{path}?&include=#{includes}&limit=#{limit}&sort=#{sort}#{filters}"
+      end
+
+      def get_builds(filter: {}, includes: "buildBetaDetail,betaBuildMetrics", limit: 10, sort: "uploadedDate")
+        assert_required_params(__method__, binding)
+
+        # GET
+        # https://appstoreconnect.apple.com/iris/v1/builds
+        url = build_url(path: "builds", filter: filter, includes: includes, limit: limit, sort: sort)
+
+        response = request(:get, url)
+        handle_response(response)
+      end
+
+      def post_for_testflight_review(build_id: nil)
+        assert_required_params(__method__, binding)
+
+        # POST
+        # https://appstoreconnect.apple.com/iris/v1/betaAppReviewSubmissions
+        #
+        # {"data":{"type":"betaAppReviewSubmissions","relationships":{"build":{"data":{"type":"builds","id":"6f90f04a-3b48-4d4a-9bbd-9475c294a579"}}}}}
+
+        body = {
+          data: {
+            type: "betaAppReviewSubmissions",
+            relationships: {
+              build: {
+                data: {
+                  type: "builds",
+                  id: build_id
+                }
+              }
+            }
+          }
+        }
+
+        response = request(:post) do |req|
+          req.url("betaAppReviewSubmissions")
+          req.body = body.to_json
+          req.headers['Content-Type'] = 'application/json'
+        end
+        handle_response(response)
+      end
+
+      protected
+
+      def handle_response(response)
+        if (200...300).cover?(response.status) && (response.body.nil? || response.body.empty?)
+          return
+        end
+
+        raise InternalServerError, "Server error got #{response.status}" if (500...600).cover?(response.status)
+
+        unless response.body.kind_of?(Hash)
+          raise UnexpectedResponse, response.body
+        end
+
+        raise UnexpectedResponse, response.body['error'] if response.body['error']
+
+        raise UnexpectedResponse, handle_errors(response) if response.body['errors']
+
+        raise UnexpectedResponse, "Temporary App Store Connect error: #{response.body}" if response.body['statusCode'] == 'ERROR'
+
+        return response.body['data'] if response.body['data']
+
+        return response.body
+      end
+
+      def handle_errors(response)
+        # Example error format
+        # {
+        #   "errors" : [ {
+        #     "id" : "ce8c391e-f858-411b-a14b-5aa26e0915f2",
+        #     "status" : "400",
+        #     "code" : "PARAMETER_ERROR.INVALID",
+        #     "title" : "A parameter has an invalid value",
+        #     "detail" : "'uploadedDate3' is not a valid field name",
+        #     "source" : {
+        #       "parameter" : "sort"
+        #     }
+        #   } ]
+        # }
+
+        return response.body['errors'].map do |error|
+          "#{error['title']} - #{error['detail']}"
+        end.join(" ")
+      end
+
+      private
+
+      # used to assert all of the named parameters are supplied values
+      #
+      # @raises NameError if the values are nil
+      def assert_required_params(method_name, binding)
+        parameter_names = method(method_name).parameters.map { |_, v| v }
+        parameter_names.each do |name|
+          if local_variable_get(binding, name).nil?
+            raise NameError, "`#{name}' is a required parameter"
+          end
+        end
+      end
+
+      def local_variable_get(binding, name)
+        if binding.respond_to?(:local_variable_get)
+          binding.local_variable_get(name)
+        else
+          binding.eval(name.to_s)
+        end
+      end
+
+      def provider_id
+        return team_id if self.provider.nil?
+        self.provider.provider_id
+      end
+    end
+  end
+end

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -6,6 +6,8 @@ require_relative 'export_compliance'
 require_relative 'beta_review_info'
 require_relative 'build_trains'
 
+require_relative '../connect_api/base'
+
 module Spaceship
   module TestFlight
     class Build < Base
@@ -214,7 +216,11 @@ module Spaceship
       def submit_for_testflight_review!
         return if ready_to_test?
         return if approved?
-        client.post_for_testflight_review(app_id: app_id, build_id: id, build: self)
+
+        resp = Spaceship::ConnectAPI::Base.client.get_builds(filter: { expired: false, processingState: "PROCESSING,VALID", version: self.build_version })
+        build = resp.first
+
+        Spaceship::ConnectAPI::Base.client.post_for_testflight_review(build_id: build["id"])
       end
 
       def expire!

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -61,17 +61,6 @@ module Spaceship
         handle_response(response)
       end
 
-      def post_for_testflight_review(app_id: nil, build_id: nil, build: nil)
-        assert_required_params(__method__, binding)
-
-        response = request(:post) do |req|
-          req.url("providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review")
-          req.body = build.to_json
-          req.headers['Content-Type'] = 'application/json'
-        end
-        handle_response(response)
-      end
-
       def expire_build(app_id: nil, build_id: nil, build: nil)
         assert_required_params(__method__, binding)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.112.0.beta.20181216200018
+  version: 2.112.0.beta.20181217200025
 platform: ruby
 authors:
 - Kohki Miki
@@ -27,7 +27,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-16 00:00:00.000000000 Z
+date: 2018-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -1561,6 +1561,9 @@ files:
 - spaceship/lib/spaceship/base.rb
 - spaceship/lib/spaceship/client.rb
 - spaceship/lib/spaceship/commands_generator.rb
+- spaceship/lib/spaceship/connect_api.rb
+- spaceship/lib/spaceship/connect_api/base.rb
+- spaceship/lib/spaceship/connect_api/client.rb
 - spaceship/lib/spaceship/du/du_client.rb
 - spaceship/lib/spaceship/du/upload_file.rb
 - spaceship/lib/spaceship/du/utilities.rb
@@ -1679,24 +1682,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
+- cert/lib
+- fastlane/lib
+- screengrab/lib
+- fastlane_core/lib
 - match/lib
 - pilot/lib
 - sigh/lib
+- produce/lib
+- snapshot/lib
+- precheck/lib
+- frameit/lib
 - spaceship/lib
 - scan/lib
-- credentials_manager/lib
-- snapshot/lib
-- produce/lib
-- supply/lib
-- fastlane/lib
-- screengrab/lib
-- cert/lib
-- fastlane_core/lib
 - pem/lib
-- precheck/lib
 - gym/lib
+- supply/lib
+- credentials_manager/lib
 - deliver/lib
-- frameit/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="