fastlane 2.9.0 → 2.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ddf8e122e7e3948fd7f44a06a78246dadd138daf
-  data.tar.gz: 26120e30269fafeec613d788d47367fa4c250639
+  metadata.gz: c750b0e8526d5e3e4d0d064a214ddcbf30fda96e
+  data.tar.gz: 341bebabdf36d4edacbd49c5275da7c42d0e9664
 SHA512:
-  metadata.gz: f056debe3fab1e7f3453a782298445068420f03600ee078879437c3a4f45cab725e7ce81751e7734dc32e5ed248e4068c96b49e4aefe876d75bed109cb422271
-  data.tar.gz: bc2db5d2e4ae33241ea26ca166f16f7be039b4fc35bd0e18cd785e5ce6c80c6a470531f6ee9283ee9ad48ba0853d688041dee0784f9ff54f4abcf704e9743550
+  metadata.gz: 389af2d4b9bf553315cc479f8997de9464729ce67d28c19ca020f56934b138a4f17d2fab362daf23a217b7a07f7273588329ac04adabd71aeee2bb79ea2adf46
+  data.tar.gz: 4e2e5b357ce222b78c4fee27fecd527d162bec3e6954f32451898b819e4eda3a6a5547b33a177f017d0b8be5a3b73ad0d9707a36826b4277ab8e7581d7a685ac

data/README.md

@@ -46,7 +46,7 @@ Then to deploy a new 'beta' version of your app just run
 :ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show output directly in test results
 :book: | Automatically generate Markdown documentation of your lane configurations
 :hatching_chick: | Over 170 built-in integrations available
-:computer: | Support for iOS, Mac, and Android apps
+:computer: | Support for iOS, macOS, and Android apps
 :octocat: | Full Git and Mercurial support
 
 <hr />

data/cert/lib/cert/options.rb

@@ -60,7 +60,17 @@ module Cert
                                      env_name: "CERT_KEYCHAIN_PASSWORD",
                                      sensitive: true,
                                      description: "This might be required the first time you access certificates on a new mac. For the login/default keychain this is your account password",
-                                     optional: true)
+                                     optional: true),
+        FastlaneCore::ConfigItem.new(key: :platform,
+                                     env_name: "CERT_PLATFORM",
+                                     description: "Set the provisioning profile's platform (ios, macos)",
+                                     is_string: false,
+                                     default_value: "ios",
+                                     verify_block: proc do |value|
+                                       value = value.to_s
+                                       pt = %w(macos ios)
+                                       UI.user_error!("Unsupported platform, must be: #{pt}") unless pt.include?(value)
+                                     end)
       ]
     end
   end

data/cert/lib/cert/runner.rb

@@ -123,9 +123,17 @@ module Cert
 
     # The kind of certificate we're interested in
     def certificate_type
-      cert_type = Spaceship.certificate.production
-      cert_type = Spaceship.certificate.in_house if Spaceship.client.in_house?
-      cert_type = Spaceship.certificate.development if Cert.config[:development]
+      case Cert.config[:platform].to_s
+      when 'ios', 'tvos'
+        cert_type = Spaceship.certificate.production
+        cert_type = Spaceship.certificate.in_house if Spaceship.client.in_house?
+        cert_type = Spaceship.certificate.development if Cert.config[:development]
+
+      when 'macos'
+        cert_type = Spaceship.certificate.mac_app_distribution
+        cert_type = Spaceship.certificate.mac_development if Cert.config[:development]
+
+      end
 
       cert_type
     end

data/credentials_manager/lib/credentials_manager/account_manager.rb

@@ -101,7 +101,7 @@ module CredentialsManager
 
     def ask_for_login
       puts "-------------------------------------------------------------------------------------".green
-      puts "The login information you enter will be stored in your Mac OS Keychain".green
+      puts "The login information you enter will be stored in your macOS Keychain".green
       if default_prefix?
         # We don't want to show this message, if we ask for the application specific password
         # which has a different prefix

data/credentials_manager/lib/credentials_manager/appfile_config.rb

@@ -40,9 +40,9 @@ module CredentialsManager
                  'you should turn off smart quotes in your editor of choice.'.red
           end
 
-          # rubocop:disable Lint/Eval
+          # rubocop:disable Security/Eval
           eval(content)
-          # rubocop:enable Lint/Eval
+          # rubocop:enable Security/Eval
 
           print_debug_information(path: full_path) if $verbose
         end

data/fastlane/README.md

@@ -89,7 +89,7 @@ fastlane release
 :ghost: | [Jenkins Integration](https://docs.fastlane.tools/best-practices/continuous-integration/#jenkins-integration): Show the output directly in the Jenkins test results
 :book: | Automatically generate a markdown documentation of your lane config
 :hatching_chick: | Over 170 built-in integrations available
-:computer: | Support for both iOS, Mac OS and Android apps
+:computer: | Support for iOS, macOS and Android apps
 :octocat: | Full git and mercurial support
 
 

data/fastlane/lib/assets/completions/completion.bash

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 _fastlane_complete() {
   COMPREPLY=()
   local word="${COMP_WORDS[COMP_CWORD]}"
@@ -13,7 +15,7 @@ _fastlane_complete() {
   fi
 
   # parse 'beta' out of 'lane :beta do', etc
-  completions=`cat $file | grep "^\s*lane \:" | awk -F ':' '{print $2}' | awk -F ' ' '{print $1}'`
+  completions=$(grep "^\s*lane \:" $file | awk -F ':' '{print $2}' | awk -F ' ' '{print $1}')
 
   COMPREPLY=( $(compgen -W "$completions" -- "$word") )
 }

data/fastlane/lib/assets/completions/completion.sh

@@ -1,7 +1,10 @@
 #!/bin/sh
+# shellcheck disable=SC2155
+# shellcheck disable=SC1090
+# shellcheck disable=SC2039
+
 if [ -n "$BASH_VERSION" ]; then
   source ~/.fastlane/completions/completion.bash
-
 elif [ -n "$ZSH_VERSION" ]; then
   source ~/.fastlane/completions/completion.zsh
 fi

data/fastlane/lib/assets/completions/completion.zsh

@@ -1,3 +1,5 @@
+#!/bin/zsh
+
 _fastlane_complete() {
   local word completions
   word="$1"

data/fastlane/lib/fastlane/actions/actions_helper.rb

@@ -118,13 +118,13 @@ module Fastlane
             UI.success "Successfully loaded custom action '#{file}'." if $verbose
           else
             UI.error "Could not find method 'run' in class #{class_name}."
-            UI.error 'For more information, check out the docs: https://github.com/fastlane/fastlane/tree/master/fastlane'
+            UI.error 'For more information, check out the docs: https://docs.fastlane.tools/'
             UI.user_error!("Action '#{file_name}' is damaged!", show_github_issues: true)
           end
         rescue NameError
           # Action not found
           UI.error "Could not find '#{class_name}' class defined."
-          UI.error 'For more information, check out the docs: https://github.com/fastlane/fastlane/tree/master/fastlane'
+          UI.error 'For more information, check out the docs: https://docs.fastlane.tools/'
           UI.user_error!("Action '#{file_name}' is damaged!", show_github_issues: true)
         end
       end

data/fastlane/lib/fastlane/actions/clipboard.rb

@@ -33,7 +33,7 @@ module Fastlane
 
       def self.example_code
         [
-          'clipboard(value: "https://github.com/fastlane/fastlane/tree/master/fastlane")',
+          'clipboard(value: "https://docs.fastlane.tools/")',
           'clipboard(value: lane_context[SharedValues::HOCKEY_DOWNLOAD_LINK] || "")'
         ]
       end

data/fastlane/lib/fastlane/actions/deploygate.rb

@@ -48,7 +48,7 @@ module Fastlane
           [:message, :distribution_key, :release_note, :disable_notify].include? key
         end
 
-        raise 'missing `ipa` and `apk`. deploygate action needs least one.' unless binary
+        UI.user_error!('missing `ipa` and `apk`. deploygate action needs least one.') unless binary
 
         return binary if Helper.test?
 
@@ -122,7 +122,7 @@ module Fastlane
                                        env_name: "DEPLOYGATE_USER",
                                        description: "Target username or organization name",
                                        verify_block: proc do |value|
-                                         UI.user_error!("No User for app given, pass using `user: 'user'`") unless value.to_s.length > 0
+                                         UI.user_error!("No User for DeployGate given, pass using `user: 'user'`") unless value.to_s.length > 0
                                        end),
           FastlaneCore::ConfigItem.new(key: :ipa,
                                        env_name: "DEPLOYGATE_IPA_PATH",

data/fastlane/lib/fastlane/actions/ipa.rb

@@ -77,7 +77,7 @@ module Fastlane
             "Original Error:",
             " => " + ex.to_s,
             "A build error occured. You are using legacy `shenzhen` for building",
-            "it is recommended to upgrade to `gym`: ",
+            "it is recommended to upgrade to _gym_: ",
             "https://github.com/fastlane/fastlane/tree/master/gym",
             core_command,
             "-------------------------------------------------------"
@@ -227,7 +227,7 @@ module Fastlane
 
       def self.deprecated_notes
         "You are using legacy `shenzhen` to build your app, which will be removed soon!\n" \
-        "It is recommended to upgrade to `gym`\n" \
+        "It is recommended to upgrade to _gym_\n" \
         "To do so, just replace `ipa(...)` with `gym(...)` in your Fastfile\n" \
         "To make code signing work, follow https://docs.fastlane.tools/codesigning/xcode-project/#"
       end

data/fastlane/lib/fastlane/actions/sonar.rb

@@ -18,6 +18,7 @@ module Fastlane
         sonar_scanner_args << "-Dsonar.sources=\"#{params[:sources_path]}\"" if params[:sources_path]
         sonar_scanner_args << "-Dsonar.language=\"#{params[:project_language]}\"" if params[:project_language]
         sonar_scanner_args << "-Dsonar.sourceEncoding=\"#{params[:source_encoding]}\"" if params[:source_encoding]
+        sonar_scanner_args << "-Dsonar.login=\"#{params[:sonar_login]}\"" if params[:sonar_login]
         sonar_scanner_args << params[:sonar_runner_args] if params[:sonar_runner_args]
 
         command = [
@@ -25,8 +26,8 @@ module Fastlane
           'sonar-scanner',
           sonar_scanner_args
         ].join(' ')
-
-        Action.sh command
+        # hide command, as it may contain credentials
+        Fastlane::Actions.sh_control_output(command, print_command: false, print_command_output: true)
       end
 
       def self.verify_sonar_scanner_binary
@@ -84,7 +85,13 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :sonar_runner_args,
                                        env_name: "FL_SONAR_RUNNER_ARGS",
                                        description: "Pass additional arguments to sonar-scanner. Be sure to provide the arguments with a leading `-D` e.g. FL_SONAR_RUNNER_ARGS=\"-Dsonar.verbose=true\"",
-                                       optional: true)
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :sonar_login,
+                                       env_name: "FL_SONAR_LOGIN",
+                                       description: "Pass the Sonar Login token (e.g: xxxxxxprivate_token_XXXXbXX7e)",
+                                       optional: true,
+                                       is_string: true,
+                                       sensitive: true)
         ]
       end
 

data/fastlane/lib/fastlane/actions/update_project_provisioning.rb

@@ -78,7 +78,7 @@ module Fastlane
 
       def self.details
         [
-          "You should check out the code signing gide before using this action: https://github.com/fastlane/fastlane/tree/master/fastlane/docs/Codesigning",
+          "You should check out the code signing gide before using this action: https://docs.fastlane.tools/codesigning/getting-started/",
           "This action retrieves a provisioning profile UUID from a provisioning profile (.mobileprovision) to set",
           "up the xcode projects' code signing settings in *.xcodeproj/project.pbxproj",
           "The `target_filter` value can be used to only update code signing for specified targets",

data/fastlane/lib/fastlane/actions/xcodebuild.rb

@@ -29,6 +29,7 @@ module Fastlane
         destination_timeout: "-destination-timeout",
         dry_run: "-dry-run",
         enableAddressSanitizer: "-enableAddressSanitizer",
+        enableThreadSanitizer: "-enableThreadSanitizer",
         enableCodeCoverage: "-enableCodeCoverage",
         export_archive: "-exportArchive",
         export_format: "-exportFormat",
@@ -98,11 +99,15 @@ module Fastlane
         # By default we use xcpretty
         raw_buildlog = false
 
+        # By default we don't pass the utf flag
+        xcpretty_utf = false
+
         if params
           # Operation bools
           archiving    = params.key? :archive
           exporting    = params.key? :export_archive
           testing      = params.key? :test
+          xcpretty_utf = params[:xcpretty_utf]
 
           if params.key? :raw_buildlog
             raw_buildlog = params[:raw_buildlog]
@@ -147,6 +152,9 @@ module Fastlane
           if params.key? :enable_address_sanitizer
             params[:enableAddressSanitizer] = params[:enable_address_sanitizer] ? 'YES' : 'NO'
           end
+          if params.key? :enable_thread_sanitizer
+            params[:enableThreadSanitizer] = params[:enable_thread_sanitizer] ? 'YES' : 'NO'
+          end
           if params.key? :enable_code_coverage
             params[:enableCodeCoverage] = params[:enable_code_coverage] ? 'YES' : 'NO'
           end
@@ -248,6 +256,9 @@ module Fastlane
 
         xcpretty_command = ""
         xcpretty_command = "| xcpretty #{xcpretty_args}" unless raw_buildlog
+        unless raw_buildlog
+          xcpretty_command = "#{xcpretty_command} --utf" if xcpretty_utf
+        end
 
         pipe_command = "| tee '#{buildlog_path}/xcodebuild.log' #{xcpretty_command}"
 
@@ -365,7 +376,8 @@ module Fastlane
           ['output_style', 'Set the output format to one of: :standard (Colored UTF8 output, default), :basic (black & white ASCII output)'],
           ['buildlog_path', 'The path where the xcodebuild.log will be created, by default it is created in ~/Library/Logs/fastlane/xcbuild'],
           ['raw_buildlog', 'Set to true to see xcodebuild raw output. Default value is false'],
-          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\'']
+          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\''],
+          ['xcpretty_utf', 'Specifies xcpretty should use utf8 when reporting builds. This has no effect when raw_buildlog is specified.']
         ]
       end
 
@@ -417,7 +429,8 @@ module Fastlane
           ['output_style', 'Set the output format to one of: :standard (Colored UTF8 output, default), :basic (black & white ASCII output)'],
           ['buildlog_path', 'The path where the xcodebuild.log will be created, by default it is created in ~/Library/Logs/fastlane/xcbuild'],
           ['raw_buildlog', 'Set to true to see xcodebuild raw output. Default value is false'],
-          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\'']
+          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\''],
+          ['xcpretty_utf', 'Specifies xcpretty should use utf8 when reporting builds. This has no effect when raw_buildlog is specified.']
         ]
       end
     end
@@ -462,7 +475,8 @@ module Fastlane
           ['output_style', 'Set the output format to one of: :standard (Colored UTF8 output, default), :basic (black & white ASCII output)'],
           ['buildlog_path', 'The path where the xcodebuild.log will be created, by default it is created in ~/Library/Logs/fastlane/xcbuild'],
           ['raw_buildlog', 'Set to true to see xcodebuild raw output. Default value is false'],
-          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\'']
+          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\''],
+          ['xcpretty_utf', 'Specifies xcpretty should use utf8 when reporting builds. This has no effect when raw_buildlog is specified.']
         ]
       end
     end
@@ -507,7 +521,8 @@ module Fastlane
           ['output_style', 'Set the output format to one of: :standard (Colored UTF8 output, default), :basic (black & white ASCII output)'],
           ['buildlog_path', 'The path where the xcodebuild.log will be created, by default it is created in ~/Library/Logs/fastlane/xcbuild'],
           ['raw_buildlog', 'Set to true to see xcodebuild raw output. Default value is false'],
-          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\'']
+          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\''],
+          ['xcpretty_utf', 'Specifies xcpretty should use utf8 when reporting builds. This has no effect when raw_buildlog is specified.']
         ]
       end
     end
@@ -548,7 +563,8 @@ module Fastlane
           ['output_style', 'Set the output format to one of: :standard (Colored UTF8 output, default), :basic (black & white ASCII output)'],
           ['buildlog_path', 'The path where the xcodebuild.log will be created, by default it is created in ~/Library/Logs/fastlane/xcbuild'],
           ['raw_buildlog', 'Set to true to see xcodebuild raw output. Default value is false'],
-          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\'']
+          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\''],
+          ['xcpretty_utf', 'Specifies xcpretty should use utf8 when reporting builds. This has no effect when raw_buildlog is specified.']
         ]
       end
 
@@ -597,7 +613,8 @@ module Fastlane
           ['output_style', 'Set the output format to one of: :standard (Colored UTF8 output, default), :basic (black & white ASCII output)'],
           ['buildlog_path', 'The path where the xcodebuild.log will be created, by default it is created in ~/Library/Logs/fastlane/xcbuild'],
           ['raw_buildlog', 'Set to true to see xcodebuild raw output. Default value is false'],
-          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\'']
+          ['xcpretty_output', 'specifies the output type for xcpretty. eg. \'test\', or \'simple\''],
+          ['xcpretty_utf', 'Specifies xcpretty should use utf8 when reporting builds. This has no effect when raw_buildlog is specified.']
         ]
       end
 

data/fastlane/lib/fastlane/documentation/docs_generator.rb

@@ -37,7 +37,7 @@ module Fastlane
 
       output << "This README.md is auto-generated and will be re-generated every time [fastlane](https://fastlane.tools) is run."
       output << "More information about fastlane can be found on [https://fastlane.tools](https://fastlane.tools)."
-      output << "The documentation of fastlane can be found on [GitHub](https://github.com/fastlane/fastlane/tree/master/fastlane)."
+      output << "The documentation of fastlane can be found on [https://docs.fastlane.tools](https://docs.fastlane.tools)."
       output << ""
 
       File.write(output_path, output.join("\n"))

data/fastlane/lib/fastlane/fast_file.rb

@@ -50,9 +50,9 @@ module Fastlane
           # is this always clear and safe to declare any local variables we want, because the eval function uses the instance scope
           # instead of local.
 
-          # rubocop:disable Lint/Eval
+          # rubocop:disable Security/Eval
           eval(data, parsing_binding, relative_path) # using eval is ok for this case
-          # rubocop:enable Lint/Eval
+          # rubocop:enable Security/Eval
         rescue SyntaxError => ex
           line = ex.to_s.match(/#{Regexp.escape(relative_path)}:(\d+)/)[1]
           UI.user_error!("Syntax error in your Fastfile on line #{line}: #{ex}")

data/fastlane/lib/fastlane/lane_manager.rb

@@ -162,8 +162,11 @@ module Fastlane
     end
 
     def self.load_dot_env(env)
-      # search for dotenvs in either fastlane or the current dir
-      search_paths = [FastlaneCore::FastlaneFolder.path, '.'].compact
+      # find the first directory of [fastlane, its parent] containing dotenv files
+      path = FastlaneCore::FastlaneFolder.path
+      search_paths = [path]
+      search_paths << path + "/.." unless path.nil?
+      search_paths.compact!
       base_path = search_paths.find do |dir|
         Dir.glob(File.join(dir, '*.env*'), File::FNM_DOTMATCH).count > 0
       end

data/fastlane/lib/fastlane/plugins/plugin_manager.rb

@@ -1,3 +1,5 @@
+require "fastlane/cli_tools_distributor"
+
 module Fastlane
   class PluginManager
     require "bundler"

data/fastlane/lib/fastlane/runner.rb

@@ -153,7 +153,7 @@ module Fastlane
           else
             # So there is no plugin under that name, so just show the error message generated by the lane switch
             UI.verbose(caller.join("\n"))
-            UI.user_error!("Could not find action or lane '#{method_sym}'. Check out the README for more details: https://github.com/fastlane/fastlane/tree/master/fastlane")
+            UI.user_error!("Could not find action, lane or variable '#{method_sym}'. Check out the documentation for more details: https://docs.fastlane.tools/actions")
           end
         end
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '2.9.0'.freeze
+  VERSION = '2.10.0'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
 end

data/fastlane_core/lib/fastlane_core/cert_checker.rb

@@ -26,7 +26,7 @@ module FastlaneCore
           "You can run `security find-identity -v -p codesigning` to get this output.",
           "This Stack Overflow thread has more information: https://stackoverflow.com/q/35390072/774.",
           "(Check in Keychain Access for an expired WWDR certificate: https://stackoverflow.com/a/35409835/774 has more info.)"
-        ].join(' '))
+        ].join("\n"))
       end
 
       ids = []

data/fastlane_core/lib/fastlane_core/configuration/configuration_file.rb

@@ -21,9 +21,9 @@ module FastlaneCore
       end
 
       begin
-        # rubocop:disable Lint/Eval
+        # rubocop:disable Security/Eval
         eval(content) # this is okay in this case
-        # rubocop:enable Lint/Eval
+        # rubocop:enable Security/Eval
 
         print_resulting_config_values(path) # only on success
       rescue SyntaxError => ex

data/fastlane_core/lib/fastlane_core/print_table.rb

@@ -10,6 +10,12 @@ module FastlaneCore
         options = {}
         unless config.nil?
           if config.kind_of?(FastlaneCore::Configuration)
+            # find sensitive options and mask them by default
+            config.available_options.each do |config_item|
+              if config_item.sensitive
+                mask_keys << config_item.key.to_s
+              end
+            end
             options = config.values(ask: false)
           else
             options = config

data/frameit/lib/frameit/strings_parser.rb

@@ -8,7 +8,7 @@ module Frameit
       result = {}
 
       # A .strings file is UTF-16 encoded. We only want to deal with UTF-8
-      content = `iconv -f UTF-16 -t UTF-8 '#{path}'`
+      content = `iconv -f UTF-16 -t UTF-8 '#{path}' 2>&1`
 
       content.split("\n").each_with_index do |line, index|
         begin