fastlane 1.94.1 → 1.95.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: abf2d538974356a73617e41436eb67634f85d4b0
-  data.tar.gz: 6961e6571d33c1c4571d7bdd8d8b7cbc3b4d7933
+  metadata.gz: 921b590defcf803931c86f58eb658a2133171b63
+  data.tar.gz: 3a0dcb95d7536cdefed5914fa7f1f875d87a1d67
 SHA512:
-  metadata.gz: 266797b99984e870246cffd0c3e74e169d1ada85fd64680d78f6e7679636d870249924c5ab0b8b9e2bf3a35a9b2454f9abccd0d8989a04080d6a9ab4e34923b2
-  data.tar.gz: aa658aec59566239ec75ea4868c2dbb6b03a00a2c2c9368b27adfdb2c00ce639c7b1c41c24f8395a81f7cd228cc5f0c1a1b01cf8045ff0da5720c7557a9ed94e
+  metadata.gz: 5a60703c30be8c8a4342f56f08ebce38978aca3e2458494671526c2befec9cca6b9e961b476a52c0f6dc20d23423885cbb765309946903e7095c423acb15d2d1
+  data.tar.gz: bf5ed67015613981439d17fe4fc89f9a5fe2d9527fa8544eabe59607b84df54591494b65b356c456c8251c659b018eb11d4468f82a3c83b17859244bcc85ed39

data/lib/fastlane/actions/device_grid/README.md

@@ -24,6 +24,7 @@ Create a `Gemfile` in your project's directory with the following content
 ```ruby
 gem "fastlane"
 gem "danger"
+gem "danger-device_grid"
 ```
 
 and run
@@ -66,9 +67,7 @@ require 'fastlane'
 result = Fastlane::OneOff.run(action: "build_and_upload_to_appetize",
                           parameters: options)
 
-require 'fastlane/actions/device_grid/device_grid'
-
-device_grid(
+device_grid.run(
   public_key: result,
   languages: ["en", "de"],
   devices: ["iphone5s", "iphone6splus", "ipadair"]

data/lib/fastlane/actions/download_dsyms.rb

@@ -41,7 +41,13 @@ module Fastlane
             if build_number && build.build_version != build_number
               next
             end
-            download_url = build.details.dsym_url
+
+            begin
+              download_url = build.details.dsym_url
+            rescue Spaceship::TunesClient::ITunesConnectError => ex
+              UI.error("Error accessing dSYM file for build\n\n#{build}\n\nException: #{ex}")
+            end
+
             if download_url
               result = self.download download_url
               file_name = "#{app.bundle_id}-#{train_number}-#{build.build_version}.dSYM.zip"

data/lib/fastlane/actions/prompt.rb

@@ -5,7 +5,7 @@ module Fastlane
         params[:text] += " (y/n)" if params[:boolean]
         UI.message(params[:text])
 
-        return params[:ci_input] if Helper.is_ci?
+        return params[:ci_input] unless UI.interactive?
 
         if params[:multi_line_end_keyword]
           # Multi line

data/lib/fastlane/actions/push_to_git_remote.rb

@@ -14,10 +14,12 @@ module Fastlane
           'git',
           'push',
           params[:remote],
-          "#{local_branch}:#{remote_branch}",
-          '--tags'
+          "#{local_branch}:#{remote_branch}"
         ]
 
+        # optionally add the tags component
+        command << '--tags' if params[:tags]
+
         # optionally add the force component
         command << '--force' if params[:force]
 
@@ -48,6 +50,11 @@ module Fastlane
                                        description: "Force push to remote. Defaults to false",
                                        is_string: false,
                                        default_value: false),
+          FastlaneCore::ConfigItem.new(key: :tags,
+                                       env_name: "FL_PUSH_GIT_TAGS",
+                                       description: "Wether tags are pushed to remote. Defaults to true",
+                                       is_string: false,
+                                       default_value: true),
           FastlaneCore::ConfigItem.new(key: :remote,
                                        env_name: "FL_GIT_PUSH_REMOTE",
                                        description: "The remote to push to. Defaults to `origin`",

data/lib/fastlane/actions/upload_symbols_to_sentry.rb

@@ -2,12 +2,18 @@ module Fastlane
   module Actions
     class UploadSymbolsToSentryAction < Action
       def self.run(params)
+        # Warning about usinging new plugin
+        UI.important("It's recommended to use the official Sentry Fastlane plugin")
+        UI.important("Github: https://github.com/getsentry/fastlane-plugin-sentry")
+        UI.important("Installation: fastlane add_plugin sentry")
+
         Actions.verify_gem!('rest-client')
         require 'rest-client'
 
         # Params - API
         host = params[:api_host]
         api_key = params[:api_key]
+        auth_token = params[:auth_token]
         org = params[:org_slug]
         project = params[:project_slug]
 
@@ -15,9 +21,24 @@ module Fastlane
         dsym_path = params[:dsym_path]
         dsym_paths = params[:dsym_paths] || []
 
+        has_api_key = !api_key.to_s.empty?
+        has_auth_token = !auth_token.to_s.empty?
+
+        # Will fail if none or both authentication methods are provided
+        if !has_api_key && !has_auth_token
+          UI.user_error!("No API key or authentication token found for SentryAction given, pass using `api_key: 'key'` or `auth_token: 'token'`")
+        elsif has_api_key && has_auth_token
+          UI.user_error!("Both API key and authentication token found for SentryAction given, please only give one")
+        end
+
         # Url to post dSYMs to
         url = "#{host}/projects/#{org}/#{project}/files/dsyms/"
-        resource = RestClient::Resource.new(url, api_key, '')
+
+        if has_api_key
+          resource = RestClient::Resource.new(url, api_key, '')
+        else
+          resource = RestClient::Resource.new(url, headers: { Authorization: "Bearer #{auth_token}" })
+        end
 
         UI.message "Will upload dSYM(s) to #{url}"
 
@@ -67,10 +88,12 @@ module Fastlane
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :api_key,
                                        env_name: "SENTRY_API_KEY",
-                                       description: "API Key for Sentry",
-                                       verify_block: proc do |value|
-                                         UI.user_error!("No API token for SentryAction given, pass using `api_key: 'key'`") unless value and !value.empty?
-                                       end),
+                                       description: "API key for Sentry",
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :auth_token,
+                                       env_name: "SENTRY_AUTH_TOKEN",
+                                       description: "Authentication token for Sentry",
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :org_slug,
                                        env_name: "SENTRY_ORG_SLUG",
                                        description: "Organization slug for Sentry project",

data/lib/fastlane/commands_generator.rb

@@ -15,9 +15,12 @@ module Fastlane
       FastlaneCore::UpdateChecker.start_looking_for_update('fastlane')
       Fastlane.load_actions
       Fastlane.plugin_manager.load_plugins
+      # *after* loading the plugins
+      Fastlane::PluginUpdateManager.start_looking_for_updates
       self.new.run
     ensure
       FastlaneCore::UpdateChecker.show_update_status('fastlane', Fastlane::VERSION)
+      Fastlane::PluginUpdateManager.show_update_status
     end
 
     # rubocop:disable Metrics/AbcSize
@@ -76,9 +79,9 @@ module Fastlane
         c.option "-j", "--json", "Output the lanes in JSON instead of text"
 
         c.action do |args, options|
-          if ensure_fastfile
+          if options.json || ensure_fastfile
             require 'fastlane/lane_list'
-            path = File.join(Fastlane::FastlaneFolder.fastfile_path)
+            path = Fastlane::FastlaneFolder.fastfile_path
 
             if options.json
               Fastlane::LaneList.output_json(path)

data/lib/fastlane/documentation/actions_list.rb

@@ -161,7 +161,7 @@ module Fastlane
             UI.user_error!("Invalid number of elements in this row: #{current}. Must be 2 or 3") unless [2, 3].include? current.count
             rows << current
             rows.last[0] = rows.last.first.yellow # color it yellow :)
-            rows.last << nil while fill_all and rows.last.count < 3 # to have a nice border in the table
+            rows.last << nil while fill_all && rows.last.count < 4 # to have a nice border in the table
           end
         end
       end

data/lib/fastlane/lane_list.rb

@@ -45,8 +45,9 @@ module Fastlane
 
     # Returns a hash
     def self.generate_json(path)
-      ff = Fastlane::FastFile.new(path)
       output = {}
+      return output if path.nil?
+      ff = Fastlane::FastFile.new(path)
 
       all_keys = ff.runner.lanes.keys
 

data/lib/fastlane/lane_manager.rb

@@ -73,6 +73,8 @@ module Fastlane
       Fastlane::JUnitGenerator.generate(Fastlane::Actions.executed_actions)
       print_table(Fastlane::Actions.executed_actions)
 
+      Fastlane::PluginUpdateManager.show_update_status
+
       if error
         UI.error 'fastlane finished with errors'
         raise error

data/lib/fastlane/plugins/plugin_manager.rb

@@ -79,6 +79,11 @@ module Fastlane
       UI.user_error!("fastlane is not setup for this project, make sure you have a fastlane folder") unless pluginfile_path
       plugin_name = self.class.plugin_prefix + plugin_name unless plugin_name.start_with?(self.class.plugin_prefix)
 
+      if plugin_name.gsub(self.class.plugin_prefix, '').include?("-")
+        # e.g. "fastlane-plugin-ya_tu-sabes" (which is invalid)
+        UI.user_error!("Plugin name must not contain a '-', did you mean '_'?")
+      end
+
       unless plugin_is_added_as_dependency?(plugin_name)
         content = pluginfile_content || AUTOGENERATED_LINE
 

data/lib/fastlane/plugins/plugin_update_manager.rb

@@ -0,0 +1,69 @@
+module Fastlane
+  # Alert the user when updates for plugins are available
+  class PluginUpdateManager
+    def self.start_looking_for_updates
+      return if ENV["FASTLANE_SKIP_UPDATE_CHECK"]
+
+      Thread.new do
+        self.plugin_references.each do |plugin_name, current_plugin|
+          begin
+            self.server_results[plugin_name] = fetch_latest_version(plugin_name)
+          rescue
+          end
+        end
+      end
+    end
+
+    def self.show_update_status
+      return if ENV["FASTLANE_SKIP_UPDATE_CHECK"]
+
+      # We set self.server_results to be nil
+      # this way the table is not printed twice
+      # (next to the summary table or when an exception happens)
+      return unless self.server_results.count > 0
+
+      rows = []
+      self.plugin_references.each do |plugin_name, current_plugin|
+        latest_version = self.server_results[plugin_name]
+        next if latest_version.nil?
+        current_version = Gem::Version.new(current_plugin[:version_number])
+        next if current_version >= latest_version
+
+        rows << [
+          plugin_name.gsub(PluginManager.plugin_prefix, ''),
+          current_version.to_s.red,
+          latest_version.to_s.green
+        ]
+      end
+
+      if rows.empty?
+        UI.verbose("All plugins are up to date")
+        return
+      end
+
+      puts Terminal::Table.new({
+        rows: rows,
+        title: "Plugin updates available".yellow,
+        headings: ["Plugin", "Your Version", "Latest Version"]
+      })
+      UI.message "To update all plugins, just run"
+      UI.command "fastlane update_plugins"
+      puts ''
+      @server_results = nil
+    end
+
+    def self.plugin_references
+      Fastlane.plugin_manager.plugin_references
+    end
+
+    def self.fetch_latest_version(gem_name)
+      Gem::Version.new(PluginManager.fetch_gem_info_from_rubygems(gem_name)["version"])
+    rescue
+      nil
+    end
+
+    def self.server_results
+      @server_results ||= {}
+    end
+  end
+end

data/lib/fastlane/plugins/plugins.rb

@@ -9,3 +9,4 @@ require 'fastlane/plugins/plugin_info_collector'
 require 'fastlane/plugins/plugin_manager'
 require 'fastlane/plugins/plugin_search'
 require 'fastlane/plugins/plugin_fetcher'
+require 'fastlane/plugins/plugin_update_manager'

data/lib/fastlane/version.rb

@@ -1,4 +1,4 @@
 module Fastlane
-  VERSION = '1.94.1'.freeze
+  VERSION = '1.95.0'.freeze
   DESCRIPTION = "The easiest way to automate building and releasing your iOS and Android apps"
 end

metadata

@@ -1,14 +1,21 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 1.94.1
+  version: 1.95.0
 platform: ruby
 authors:
 - Felix Krause
+- Michael Furtak
+- Andrea Falcone
+- Sam Phillips
+- David Ohayon
+- Sam Robbins
+- Mark Pirri
+- Hemal Shah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-06 00:00:00.000000000 Z
+date: 2016-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: krausefx-shenzhen
@@ -176,7 +183,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.46.2
+        version: 0.46.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -186,7 +193,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.46.2
+        version: 0.46.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -230,7 +237,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.27.1
+        version: 0.27.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -240,7 +247,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.27.1
+        version: 0.27.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -733,15 +740,8 @@ files:
 - lib/fastlane/actions/delete_keychain.rb
 - lib/fastlane/actions/deliver.rb
 - lib/fastlane/actions/deploygate.rb
+- lib/fastlane/actions/device_grid/.DS_Store
 - lib/fastlane/actions/device_grid/README.md
-- lib/fastlane/actions/device_grid/assets/GridExampleScreenshot.png
-- lib/fastlane/actions/device_grid/assets/README.md
-- lib/fastlane/actions/device_grid/assets/ipadair.png
-- lib/fastlane/actions/device_grid/assets/iphone4s.png
-- lib/fastlane/actions/device_grid/assets/iphone5s.png
-- lib/fastlane/actions/device_grid/assets/iphone6s.png
-- lib/fastlane/actions/device_grid/assets/iphone6splus.png
-- lib/fastlane/actions/device_grid/device_grid.rb
 - lib/fastlane/actions/dotgpg_environment.rb
 - lib/fastlane/actions/download.rb
 - lib/fastlane/actions/download_dsyms.rb
@@ -910,6 +910,7 @@ files:
 - lib/fastlane/plugins/plugin_info_collector.rb
 - lib/fastlane/plugins/plugin_manager.rb
 - lib/fastlane/plugins/plugin_search.rb
+- lib/fastlane/plugins/plugin_update_manager.rb
 - lib/fastlane/plugins/plugins.rb
 - lib/fastlane/plugins/template/%gem_name%.gemspec.erb
 - lib/fastlane/plugins/template/.gitignore

data/lib/fastlane/actions/device_grid/assets/README.md

@@ -1,6 +0,0 @@
-#### Disclaimer
-
-All product names, logos, and brands are property of their respective owners.  
-The used device frames were provided by Facebook via the [Facebook Design Resources](https://facebook.github.io/design/devices.html). `fastlane` is in no way affiliated with Facebook.
-
-> While Facebook has redrawn and shares these assets for the benefit of the design community, Facebook does not own any of the underlying product or user interface designs. By accessing these assets, you agree to obtain all necessary permissions from the underlying rights holders and/or adhere to any applicable brand use guidelines before using them. Facebook disclaims all express or implied warranties with respect to these assets, including non-infringement of intellectual property rights.

data/lib/fastlane/actions/device_grid/device_grid.rb

@@ -1,109 +0,0 @@
-# rubocop:disable Style/IndentationConsistency
-# We disable this rule since we intend opening HTML labels
-module Danger
-  class Dangerfile
-    module DSL
-      # A danger plugin: https://github.com/danger/danger
-      class DeviceGrid < Plugin
-        # @param public_key: The key for the Appetize.io
-        # @param languages: Array of languages you want to see (e.g. [en, de])
-        # @param devices: Array of deviecs you want to see (e.g. ["iphone4s", "ipadair"])
-        # @param prefix_command: Prefix the `fastlane run appetize_viewing_url_generator` command with something
-        #   this can be used to use `bundle exec`
-        def run(public_key: nil, languages: nil, devices: nil, prefix_command: nil)
-          # since we fetch the URL from the output we don't need colors
-          # this will only be changed in the danger sub-process
-          fastlane_colors_env = "FASTLANE_DISABLE_COLORS"
-          fastlane_colors_were_disabled = ENV.key?(fastlane_colors_env)
-          ENV[fastlane_colors_env] = "true"
-
-          devices ||= %w(iphone4s iphone5s iphone6s iphone6splus ipadair)
-          languages ||= ["en"]
-
-          prefix_command ||= ""
-          prefix_command += " bundle exec " if File.exist?("Gemfile")
-
-          # To use the local fastlane intead of bundle
-          prefix_command = "./bin/" if FastlaneCore::Helper.test?
-
-          deep_link_matches = pr_body.match(/:link:\s(.*)/) # :link: emoji
-          deep_link = deep_link_matches[1] if deep_link_matches
-
-          markdown("<table>")
-          languages.each do |current_language|
-            markdown("<tr>")
-              markdown("<td>")
-                markdown("<b>#{current_language[0..1]}</b>")
-              markdown("</td>")
-
-              devices.each do |current_device|
-                markdown("<td>")
-
-                params = {
-                  public_key: public_key,
-                  language: current_language,
-                  device: current_device
-                }
-                params[:launch_url] = deep_link if deep_link
-                params_str = params.collect { |k, v| "#{k}:\"#{v}\"" }.join(" ")
-                url = Fastlane::Helper.backticks("#{prefix_command}fastlane run appetize_viewing_url_generator #{params_str}")
-                url = url.match(%r{Result:.*(https\:\/\/.*)})[1].strip
-
-                markdown("<a href='#{url}'>")
-                  markdown("<p align='center'>")
-                    markdown("<img height='130' src='#{url_for_device(current_device)}' />")
-                    markdown("<br />")
-                    markdown(beautiful_device_name(current_device))
-                  markdown("</p>")
-                markdown("</a>")
-
-                markdown("</td>")
-              end
-            markdown("</tr>")
-          end
-          markdown("</table>")
-        ensure
-          ENV.delete(fastlane_colors_env) unless fastlane_colors_were_disabled
-        end
-
-        def beautiful_device_name(str)
-          return {
-            iphone4s: "iPhone 4s",
-            iphone5s: "iPhone 5s",
-            iphone6s: "iPhone 6s",
-            iphone6splus: "iPhone 6s Plus",
-            ipadair: "iPad Air",
-            iphone6: "iPhone 6",
-            iphone6plus: "iPhone 6 Plus",
-            ipadair2: "iPad Air 2",
-            nexus5: "Nexus 5",
-            nexus7: "Nexus 7",
-            nexus9: "Nexus 9"
-          }[str.to_sym] || str.to_s
-        end
-
-        def url_for_device(str)
-          str = str.to_sym
-          host = "https://raw.githubusercontent.com/fastlane/fastlane/#{Fastlane::VERSION}/fastlane/lib/fastlane/actions/device_grid/assets/"
-          return {
-            iphone4s: host + "iphone4s.png",
-            iphone5s: host + "iphone5s.png",
-            iphone6: host + "iphone6s.png",
-            iphone6s: host + "iphone6s.png",
-            iphone6plus: host + "iphone6splus.png",
-            iphone6splus: host + "iphone6splus.png",
-            ipadair: host + "ipadair.png",
-            ipadair2: host + "ipadair.png"
-          }[str] || ""
-        end
-
-        def self.description
-          [
-            "Render a grid of devices"
-          ].join(" ")
-        end
-      end
-    end
-  end
-end
-# rubocop:enable Style/IndentationConsistency