fastlane 1.92.0.beta2 → 1.92.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c3df4da6dc8c9ee2ccfa9f3e95d63e96f06605a7
-  data.tar.gz: b028cada1e65640eb971b978040c11426305bcdc
+  metadata.gz: f5a8f36b44fdba28a2384ebaaf3ed6c19640e4ed
+  data.tar.gz: 97d37d0093e30964336a875e744ddc468b1ebdd9
 SHA512:
-  metadata.gz: 8b42aa0057c904cc4f3b092ad8ed7f26d8a59d18063e94cd20b7e24b5617de2250d793cccadb5e2e6f51860e49c134b038dacf235e1705255407bbcaee13a783
-  data.tar.gz: 8ff2d00e187efba10444c0ef12aba55e4f962df7d2a7634bb29576c2b3185e85857d8158d9388922c29778e30f424ca8c91928cc47a91dbfbbf65807a3dd3b79
+  metadata.gz: 9b767890903852e42d1a7a56b0ce9cb18649934ae69ed719534f6f3178f1595e3feeef445bd59f89c860d6a4e028878ce5359ec156627e9c12d58d01b5930270
+  data.tar.gz: c55a8e615c2e69bb69388316c3618a58d8156d3ecd86b9da53ee9ea8d6f0816e16cf400b4ac9bf1929d3f1a89b68f7181c74221d06a3929e2e9a165d67758671

data/README.md

@@ -173,8 +173,6 @@ See how [Wikipedia](https://github.com/fastlane/examples#wikipedia-by-wikimedia-
 
 You can easily opt-out by adding `opt_out_usage` to your `Fastfile` or by setting the environment variable `FASTLANE_OPT_OUT_USAGE`. To also disable update checks, set the `FASTLANE_SKIP_UPDATE_CHECK` variable.
 
-You can optionally submit crash reports, run `fastlane enable_crash_reporting` to get started. This makes resolving issues much easier and helps improve fastlane. [More information](https://github.com/fastlane/fastlane/releases/tag/1.33.3)
-
 ## Credentials
 A detailed description about how `fastlane` stores your credentials is available on a [separate repo](https://github.com/fastlane/fastlane/tree/master/credentials_manager).
 

data/lib/fastlane.rb

@@ -18,7 +18,6 @@ require 'fastlane/one_off'
 require 'fastlane/command_line_handler'
 require 'fastlane/documentation/docs_generator'
 require 'fastlane/other_action'
-require 'fastlane/plugins/plugins'
 
 module Fastlane
   Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore

data/lib/fastlane/action_collector.rb

@@ -1,19 +1,8 @@
 module Fastlane
   class ActionCollector < FastlaneCore::ToolCollector
-    # Is this an official fastlane action, that is bundled with fastlane?
     def is_official?(name)
       return true if name == :lane_switch
-      Actions.get_all_official_actions.include?(name)
-    end
-
-    def name_to_track(name)
-      return name if is_official?(name)
-
-      PluginManager.plugin_references.each do |plugin_name, value|
-        return "#{plugin_name}/#{name}" if value[:actions].include?(name)
-      end
-
-      return nil
+      Actions.get_all_official_actions.include? name
     end
 
     def show_message
@@ -26,28 +15,7 @@ module Fastlane
     end
 
     def determine_version(name)
-      self.class.determine_version(name)
-    end
-
-    # e.g.
-    #   :gym
-    #   :xcversion
-    #   "fastlane-plugin-my_plugin/xcversion"
-    def self.determine_version(name)
-      return super(name) if super(name)
-
-      if name.to_s.include?(PluginManager.plugin_prefix)
-        # That's an action from a plugin, we need to fetch its version number
-        begin
-          plugin_name = name.split("/").first.gsub(PluginManager.plugin_prefix, '')
-          return Fastlane.const_get(plugin_name.fastlane_class)::VERSION
-        rescue => ex
-          UI.verbose(ex)
-          return "undefined"
-        end
-      end
-
-      return Fastlane::VERSION # that's the case for all built-in actions
+      super(name) || Fastlane::VERSION
     end
   end
 end

data/lib/fastlane/actions/actions_helper.rb

@@ -101,9 +101,5 @@ module Fastlane
         end
       end
     end
-
-    def self.formerly_bundled_actions
-      ["xcake"]
-    end
   end
 end

data/lib/fastlane/actions/appium.rb

@@ -11,7 +11,7 @@ module Fastlane
         Actions.verify_gem!('appium_lib')
 
         require 'rspec'
-        require 'appium_lib'
+        require 'appium_lib' unless Helper.test?
 
         FastlaneCore::PrintTable.print_values(
           config: params,

data/lib/fastlane/actions/changelog_from_git_commits.rb

@@ -37,6 +37,10 @@ module Fastlane
         changelog = changelog.gsub("\n\n", "\n") if changelog # as there are duplicate newlines
         Actions.lane_context[SharedValues::FL_CHANGELOG] = changelog
 
+        puts ""
+        puts changelog
+        puts ""
+
         changelog
       end
 

data/lib/fastlane/actions/copy_artifacts.rb

@@ -1,26 +1,38 @@
+require 'fileutils'
+require 'shellwords'
+
 module Fastlane
   module Actions
     class CopyArtifactsAction < Action
       def self.run(params)
         # we want to make sure that our target folder exist already
-        target_folder_command = 'mkdir -p ' + params[:target_path]
-        Actions.sh(target_folder_command)
+        FileUtils.mkdir_p(params[:target_path])
+
+        # Ensure that artifacts is an array
+        artifacts_to_search = [params[:artifacts]].flatten
 
-        # construct the main command that will do the copying/moving for us
-        base_command = params[:keep_original] ? 'cp' : 'mv'
-        options = []
-        options << '-f'
-        options << '-R' if params[:keep_original] # we only want the -R flag for the cp command, which we get when the user asks to keep the original
-        options << params[:artifacts].map { |e| e.tr(' ', '\ ') }
-        options << params[:target_path]
+        # If any of the paths include "*", we assume that we are referring to the Unix entries
+        # e.g /tmp/fastlane/* refers to all the files in /tmp/fastlane
+        # We use Dir.glob to expand all those paths, this would create an array of arrays though, so flatten
+        # Lastly, we shell escape everything in case they contain incompatible symbols (e.g. spaces)
+        artifacts = artifacts_to_search.map { |f| f.include?("*") ? Dir.glob(f) : f }.flatten.map(&:shellescape)
 
-        command = ([base_command] + options).join(' ')
+        UI.verbose("Copying artifacts #{artifacts.join(', ')} to #{params[:target_path]}")
+        UI.verbose(params[:keep_original] ? "Keeping original files" : "Not keeping original files")
 
-        # if we don't want to fail on missing files, then we need to swallow the error from our command, by ORing with the nil command, guaranteeing a 0 status code
-        command += ' || :' unless params[:fail_on_missing]
+        if params[:fail_on_missing]
+          missing = artifacts.select { |a| !File.exist?(a) }
+          UI.user_error! "Not all files were present in copy artifacts. Missing #{missing.join(', ')}" unless missing.empty?
+        else
+          # If we don't fail on non-existant files, don't try to copy non-existant files
+          artifacts.reject! { |artifact| !File.exist?(artifact) }
+        end
 
-        # call our command
-        Actions.sh(command)
+        if params[:keep_original]
+          FileUtils.cp_r(artifacts, params[:target_path], remove_destination: true)
+        else
+          FileUtils.mv(artifacts, params[:target_path], force: true)
+        end
 
         UI.success('Build artifacts successfully copied!')
       end

data/lib/fastlane/actions/gradle.rb

@@ -35,7 +35,7 @@ module Fastlane
         # Construct our flags
         flags = []
         flags << "-p #{project_dir.shellescape}"
-        flags << params[:properties].map { |k, v| "-P#{k}=#{v}" }.join(' ') unless params[:properties].nil?
+        flags << params[:properties].map { |k, v| "-P#{k.to_s.shellescape}=#{v.to_s.shellescape}" }.join(' ') unless params[:properties].nil?
         flags << params[:flags] unless params[:flags].nil?
 
         # Run the actual gradle task

data/lib/fastlane/actions/increment_build_number.rb

@@ -33,7 +33,7 @@ module Fastlane
         command = [
           command_prefix,
           'agvtool',
-          params[:build_number] ? "new-version -all #{params[:build_number]}" : 'next-version -all',
+          params[:build_number] ? "new-version -all #{params[:build_number].to_s.strip}" : 'next-version -all',
           command_suffix
         ].join(' ')
 

data/lib/fastlane/actions/increment_version_number.rb

@@ -58,7 +58,7 @@ module Fastlane
 
         command = [
           command_prefix,
-          "agvtool new-marketing-version #{next_version_number}"
+          "agvtool new-marketing-version #{next_version_number.to_s.strip}"
         ].join(' ')
 
         if Helper.test?

data/lib/fastlane/actions/jira.rb

@@ -3,7 +3,7 @@ module Fastlane
     class JiraAction < Action
 
       def self.run(params)
-        Actions.verify_gem!('jira')
+        Actions.verify_gem!('jira-ruby')
         require 'jira'
 
         site         = params[:url]

data/lib/fastlane/actions/onesignal.rb

@@ -23,7 +23,7 @@ module Fastlane
         unless params[:apns_p12].nil?
           data = File.read(params[:apns_p12])
           apns_p12 = Base64.encode64(data)
-          payload["apns_env"] = [:apns_env]
+          payload["apns_env"] = params[:apns_env]
           payload["apns_p12"] = apns_p12
           # we need to have something for the p12 password, even if it's an empty string
           payload["apns_p12_password"] = apns_p12_password || ""

data/lib/fastlane/actions/pod_lib_lint.rb

@@ -23,6 +23,11 @@ module Fastlane
           command << "--allow-warnings"
         end
 
+        command << "--use-libraries" if params[:use_libraries]
+        command << "--fail-fast" if params[:fail_fast]
+        command << "--private" if params[:private]
+        command << "--quick" if params[:quick]
+
         result = Actions.sh(command.join(' '))
         UI.success("Pod lib lint Successfully ⬆️ ")
         return result
@@ -60,7 +65,23 @@ module Fastlane
                                          is_string: false,
                                          verify_block: proc do |value|
                                            UI.user_error!("Sources must be an array.") unless value.kind_of?(Array)
-                                         end)
+                                         end),
+          FastlaneCore::ConfigItem.new(key: :use_libraries,
+                                       description: "Lint uses static libraries to install the spec",
+                                       is_string: false,
+                                       default_value: false),
+          FastlaneCore::ConfigItem.new(key: :fail_fast,
+                                       description: "Lint stops on the first failing platform or subspec",
+                                       is_string: false,
+                                       default_value: false),
+          FastlaneCore::ConfigItem.new(key: :private,
+                                       description: "Lint skips checks that apply only to public specs",
+                                       is_string: false,
+                                       default_value: false),
+          FastlaneCore::ConfigItem.new(key: :quick,
+                                       description: "Lint skips checks that would require to download and build the spec",
+                                       is_string: false,
+                                       default_value: false)
         ]
       end
 

data/lib/fastlane/actions/push_to_git_remote.rb

@@ -1,6 +1,6 @@
 module Fastlane
   module Actions
-    # Adds a git tag to the current commit
+    # Push local changes to the remote branch
     class PushToGitRemoteAction < Action
       def self.run(params)
         local_branch = params[:local_branch]

data/lib/fastlane/actions/slather.rb

@@ -5,27 +5,34 @@ module Fastlane
     end
 
     class SlatherAction < Action
-
+      # https://github.com/SlatherOrg/slather/blob/cbc5099cd25beb43fd978b7a3e5428f02230122d/lib/slather/command/coverage_command.rb#L24
       ARGS_MAP = {
-        build_directory: "--build-directory",
-        input_format: "--input-format",
-        scheme: "--scheme",
-        buildkite: "--buildkite",
-        jenkins: "--jenkins",
-        travis: "--travis",
-        circleci: "--circleci",
-        coveralls: "--coveralls",
-        simple_output: "--simple-output",
-        gutter_json: "--gutter-json",
-        cobertura_xml: "--cobertura-xml",
-        html: "--html",
-        show: "--show",
-        source_directory: "--source-directory",
-        output_directory: "--output-directory",
-        binary_basename: "--binary-basename",
-        binary_file: "--binary-file",
-        ignore: "--ignore",
-        workspace: "--workspace"
+          travis: '--travis',
+          circleci: '--circleci',
+          jenkins: '--jenkins',
+          buildkite: '--buildkite',
+          teamcity: '--teamcity',
+
+          coveralls: '--coveralls',
+          simple_output: '--simple-output',
+          gutter_json: '--gutter-json',
+          cobertura_xml: '--cobertura-xml',
+          html: '--html',
+          show: '--show',
+
+          build_directory: '--build-directory',
+          source_directory: '--source-directory',
+          output_directory: '--output-directory',
+          ignore: '--ignore',
+          verbose: '--verbose',
+
+          input_format: '--input-format',
+          scheme: '--scheme',
+          workspace: '--workspace',
+          binary_file: '--binary-file',
+          binary_basename: '--binary-basename',
+          source_files: '--source-files',
+          decimals: '--decimals'
       }.freeze
 
       def self.run(params)
@@ -127,6 +134,11 @@ Slather is available at https://github.com/SlatherOrg/slather
                                        description: "Tell slather that it is running on Buildkite",
                                        is_string: false,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :teamcity,
+                                       env_name: "FL_SLATHER_TEAMCITY_ENABLED", # The name of the environment variable
+                                       description: "Tell slather that it is running on TeamCity",
+                                       is_string: false,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :jenkins,
                                        env_name: "FL_SLATHER_JENKINS_ENABLED", # The name of the environment variable
                                        description: "Tell slather that it is running on Jenkins",
@@ -185,6 +197,11 @@ Slather is available at https://github.com/SlatherOrg/slather
                                        description: "Tell slather to ignore files matching a path or any path from an array of paths",
                                        is_string: false,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :verbose,
+                                       env_name: "FL_SLATHER_VERBOSE",
+                                       description: "Tell slather to enable verbose mode",
+                                       is_string: false,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :use_bundle_exec,
                                       env_name: "FL_SLATHER_USE_BUNDLE_EXEC",
                                       description: "Use bundle exec to execute slather. Make sure it is in the Gemfile",
@@ -197,7 +214,18 @@ Slather is available at https://github.com/SlatherOrg/slather
           FastlaneCore::ConfigItem.new(key: :binary_file,
                                       env_name: "FL_SLATHER_BINARY_FILE",
                                       description: "Binary file name to be used for code coverage",
-                                      default_value: false)
+                                      default_value: false),
+          FastlaneCore::ConfigItem.new(key: :source_files,
+                                       env_name: "FL_SLATHER_SOURCE_FILES",
+                                       description: "A Dir.glob compatible pattern used to limit the lookup to specific source files. Ignored in gcov mode",
+                                       default_value: false,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :decimals,
+                                      env_name: "FL_SLATHER_DECIMALS",
+                                      description: "The amount of decimals to use for % coverage reporting",
+                                      is_string: false,
+                                      default_value: false,
+                                      optional: true)
         ]
       end
 

data/lib/fastlane/actions/upload_symbols_to_sentry.rb

@@ -2,6 +2,7 @@ module Fastlane
   module Actions
     class UploadSymbolsToSentryAction < Action
       def self.run(params)
+        Actions.verify_gem!('rest-client')
         require 'rest-client'
 
         # Params - API

data/lib/fastlane/actions/xcake.rb

@@ -0,0 +1,35 @@
+module Fastlane
+  module Actions
+    class XcakeAction < Action
+      def self.run(params)
+        Actions.verify_gem!('xcake')
+        require 'xcake'
+
+        if defined? Xcake::Command::Make
+          # New `xcake make` command
+          Xcake::Command::Make.run
+        else
+          # Legacy `xcake` command
+          Xcake::Command.run
+        end
+      end
+
+      def self.description
+        "Runs `xcake` for the project"
+      end
+
+      def self.available_options
+        [
+        ]
+      end
+
+      def self.is_supported?(platform)
+        [:ios, :mac].include? platform
+      end
+
+      def self.authors
+        ["jcampbell05"]
+      end
+    end
+  end
+end

data/lib/fastlane/commands_generator.rb

@@ -10,7 +10,6 @@ module Fastlane
     def self.start
       FastlaneCore::UpdateChecker.start_looking_for_update('fastlane')
       Fastlane.load_actions
-      Fastlane::PluginManager.load_plugins
       self.new.run
     ensure
       FastlaneCore::UpdateChecker.show_update_status('fastlane', Fastlane::VERSION)
@@ -147,17 +146,17 @@ module Fastlane
 
       command :enable_crash_reporting do |c|
         c.syntax = 'fastlane enable_crash_reporting'
-        c.description = 'Enable crash reporting to improve fastlane'
+        c.description = "Deprecated: fastlane doesn't use a crash reporter any more"
         c.action do |args, options|
-          FastlaneCore::CrashReporting.enable
+          show_crashreporter_note
         end
       end
 
       command :disable_crash_reporting do |c|
         c.syntax = 'fastlane disable_crash_reporting'
-        c.description = 'Disable crash reporting'
+        c.description = "Deprecated: fastlane doesn't use a crash reporter any more"
         c.action do |args, options|
-          FastlaneCore::CrashReporting.disable
+          show_crashreporter_note
         end
       end
 
@@ -171,64 +170,8 @@ module Fastlane
         end
       end
 
-      #####################################################
-      # @!group Plugins
-      #####################################################
-
-      command :new_plugin do |c|
-        c.syntax = 'fastlane create_plugin [plugin_name]'
-        c.description = 'Create a new plugin that can be used with fastlane'
-
-        c.action do |args, options|
-          PluginGenerator.new.generate args.shift
-        end
-      end
-
-      command :add_plugin do |c|
-        c.syntax = 'fastlane add_plugin [plugin_name]'
-        c.description = 'Add a new plugin to your fastlane setup'
-
-        c.action do |args, options|
-          pm = PluginManager.new
-          args << UI.input("Enter the name of the plugin to install: ") if args.empty?
-          args.each do |plugin_name|
-            pm.add_dependency(plugin_name)
-          end
-
-          UI.important("Make sure to commit your Gemfile, Gemfile.lock and #{PluginManager::PLUGINFILE_NAME} to version control")
-          pm.install_dependencies!
-        end
-      end
-
-      command :install_plugins do |c|
-        c.syntax = 'fastlane install_plugins'
-        c.description = 'Install all plugins for this project'
-
-        c.action do |args, options|
-          PluginManager.new.install_dependencies!
-        end
-      end
-
-      command :update_plugins do |c|
-        c.syntax = 'fastlane update_plugins'
-        c.description = 'Update all plugin dependencies'
-
-        c.action do |args, options|
-          PluginManager.new.update_dependencies!
-        end
-      end
-
-      command :search_plugins do |c|
-        c.syntax = 'fastlane search_plugins [search_query]'
-        c.description = 'Search for plugins, search query is optional'
-
-        c.action do |args, options|
-          search_query = args.last
-          PluginSearch.print_plugins(search_query: search_query)
-        end
-      end
-
       default_command :trigger
+
       run!
     end
 
@@ -244,6 +187,12 @@ module Fastlane
       return false
     end
 
+    def show_crashreporter_note
+      UI.important("fastlane doesn't use a crash reporter any more")
+      UI.important("Instead please submit an issue on GitHub: https://github.com/fastlane/fastlane/issues")
+      UI.important("This command will be removed in one of the next releases")
+    end
+
     # rubocop:enable Metrics/AbcSize
     # rubocop:enable Metrics/MethodLength
   end