fastlane 1.69.0 → 1.70.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d29b7501225e604d391ffd243a2749404958456
-  data.tar.gz: ec1bac264e401af22eaaa8e92373296aa37c1fdf
+  metadata.gz: 92368e189d0fabe6140e11af939ca965f80dd279
+  data.tar.gz: aec475dc75f8c8ec48b321772226b08a59792822
 SHA512:
-  metadata.gz: b5495fdc7b764fa11edf7845aab397165a676ae8a25c401bcd23adf6ae04de0ea46138d90429ebc10b1b218e1e89cc7b2f6589e1656536e0fcc4a7509d8ea34b
-  data.tar.gz: 388a06e91c69148dad378c7466f7455a2d687c0cf623fb205548866a81c5f3e657b9b0af81780435ed1fc33c4b2a47037401784575360e4bcac425dea7166066
+  metadata.gz: c9a426c73fd4edcd1559259d9f10df844d67b7679463c0dd9d4a97657eddfd628451aad63dbbcfdc8a3b10b3d115fafd1348eaf749421524c8c973225d2c9641
+  data.tar.gz: 191d9e1609fb2eb5c54dc666c11aa4e62f332ec9e7530735728fdf5782238ac158aed5a67018cb4199dfe1183796eec2d4d5bdd5d21d15c66441c079e2615b33

data/lib/fastlane/actions/download_dsyms.rb

@@ -29,6 +29,10 @@ module Fastlane
 
         UI.message(message.join(" "))
         app = Spaceship::Application.find(params[:app_identifier])
+        unless app
+          UI.user_error!("Could not find app with bundle identifier '#{params[:app_identifier]}' on account #{params[:username]}")
+        end
+
         app.all_build_train_numbers.each do |train_number|
           if version && version != train_number
             next

data/lib/fastlane/actions/supply.rb

@@ -8,7 +8,7 @@ module Fastlane
         begin
           FastlaneCore::UpdateChecker.start_looking_for_update('supply') unless Helper.is_test?
 
-          all_apk_paths = Actions.lane_context[SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS]
+          all_apk_paths = Actions.lane_context[SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS] || []
           if all_apk_paths.length > 1
             params[:apk_paths] ||= all_apk_paths
           else

data/lib/fastlane/actions/upload_symbols_to_crashlytics.rb

@@ -2,9 +2,68 @@ module Fastlane
   module Actions
     class UploadSymbolsToCrashlyticsAction < Action
       def self.run(params)
-        params[:binary_path] ||= (Dir["/Applications/Fabric.app/**/upload-symbols"] + Dir["./Pods/**/upload-symbols"]).last
-        UI.user_error!("Please provide a path to the binary using binary_path:") unless params[:binary_path]
+        require 'tmpdir'
+
+        find_binary_path(params)
+        find_api_token(params)
+
+        dsym_paths = []
+        dsym_paths << params[:dsym_path]
+        dsym_paths += Actions.lane_context[SharedValues::DSYM_PATHS] if Actions.lane_context[SharedValues::DSYM_PATHS]
+
+        if dsym_paths.count == 0
+          UI.error("Couldn't find any dSYMs, please pass them using the dsym_path option")
+          return nil
+        end
 
+        # Get rid of duplicates (which might occur when both passed and detected)
+        dsym_paths = dsym_paths.collect { |a| File.expand_path(a) }
+        dsym_paths.uniq!
+
+        dsym_paths.each do |current_path|
+          handle_dsym(params, current_path)
+        end
+
+        UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
+      end
+
+      # @param current_path this is a path to either a dSYM or a zipped dSYM
+      #   this might also be either nested or not, we're flexible
+      def self.handle_dsym(params, current_path)
+        if current_path.end_with?(".dSYM")
+          upload_dsym(params, current_path)
+        elsif current_path.end_with?(".zip")
+          UI.message("Extracting '#{current_path}'...")
+
+          current_path = File.expand_path(current_path)
+          Dir.mktmpdir do |dir|
+            Dir.chdir(dir) do
+              Actions.sh("unzip -qo #{current_path.shellescape}")
+              Dir["*.dSYM"].each do |sub|
+                handle_dsym(params, sub)
+              end
+            end
+          end
+        else
+          UI.error "Don't know how to handle '#{current_path}'"
+        end
+      end
+
+      def self.upload_dsym(params, path)
+        UI.message("Uploading '#{path}'...")
+        command = []
+        command << params[:binary_path]
+        command << "-a #{params[:api_token]}"
+        command << "-p #{params[:platform]}"
+        command << File.expand_path(path).shellescape
+        begin
+          Actions.sh(command.join(" "), log: false)
+        rescue => ex
+          UI.error ex.to_s # it fails, however we don't want to fail everything just for this
+        end
+      end
+
+      def self.find_api_token(params)
         unless params[:api_token].to_s.length > 0
           Dir["./**/Info.plist"].each do |current|
             result = Actions::GetInfoPlistValueAction.run(path: current, key: "Fabric")
@@ -14,23 +73,13 @@ module Fastlane
           end
         end
         UI.user_error!("Please provide an api_token using api_token:") unless params[:api_token]
+      end
 
-        dsym_paths = []
-        dsym_paths << params[:dsym_path]
-        dsym_paths += Actions.lane_context[SharedValues::DSYM_PATHS] if Actions.lane_context[SharedValues::DSYM_PATHS]
-
-        UI.error("Couldn't find any dSYMs, please pass them using the dsym_path option") if dsym_paths.count == 0
-
-        dsym_paths.each do |current_path|
-          command = []
-          command << File.expand_path(params[:binary_path])
-          command << "-a #{params[:api_token]}"
-          command << "-p #{params[:platform]}"
-          command << File.expand_path(current_path)
-          Actions.sh(command.join(" "))
-        end
+      def self.find_binary_path(params)
+        params[:binary_path] ||= (Dir["/Applications/Fabric.app/**/upload-symbols"] + Dir["./Pods/**/upload-symbols"]).last
+        UI.user_error!("Please provide a path to the binary using binary_path:") unless params[:binary_path]
 
-        UI.success("Successfully uploaded dSYM files to Crashlytics 💯")
+        params[:binary_path] = File.expand_path(params[:binary_path])
       end
 
       #####################################################
@@ -58,7 +107,7 @@ module Fastlane
                                        optional: true,
                                        verify_block: proc do |value|
                                          UI.user_error!("Couldn't find file at path '#{File.expand_path(value)}'") unless File.exist?(value)
-                                         UI.user_error!("Symbolication file needs to be dSYM or zip") unless value.end_with?("dSYM.zip", ".dSYM")
+                                         UI.user_error!("Symbolication file needs to be dSYM or zip") unless value.end_with?(".zip", ".dSYM")
                                        end),
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "CRASHLYTICS_API_TOKEN",

data/lib/fastlane/version.rb

@@ -1,3 +1,3 @@
 module Fastlane
-  VERSION = '1.69.0'.freeze
+  VERSION = '1.70.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 1.69.0
+  version: 1.70.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-31 00:00:00.000000000 Z
+date: 2016-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: krausefx-shenzhen
@@ -388,7 +388,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.6.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -398,7 +398,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.6.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0