fastlane 1.42.0 → 1.43.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c03722df09da95510991ab9eea200d5d7c55e7b
-  data.tar.gz: 4e927ca836a174e46e5e458f31e46f9bd6bbdacc
+  metadata.gz: 95994f49466294aa1e7ef950d47a5a9788e59617
+  data.tar.gz: d6adab25fe8157c89a419147fbd77ba2c91c740e
 SHA512:
-  metadata.gz: 6dac74d4c244047309f411deeabf2fe600bb059eea4fa5e07625c4e8573e777e31f3f5c690b6a80e19219d9ea66a9e4efe89e1315de07c6061e46cdaf8fde2b8
-  data.tar.gz: 0af452b64822bd790c9f4d48cb33c1d652f54f48c9e66ffc25a0f2611903cc67273a6d53b8d685f61fc23e3398691f925051971f53cac252333179ffe549cd6a
+  metadata.gz: ea9c34530dd8289efae9ee733ba0f0d59286956088bf058564c8371cb1108cf41ff7bf64f06b0fef1e0d129ae29758f64179b2abaa8d5e3be509c87950b39f3c
+  data.tar.gz: 80aad4ac9589e98c826a0ac1382f8a026fab6550d8259e495dc967c55e6321780c9a4af1581c6149cf8f0dfe051dd978fa29fede661ae943b2aa26c63b00f038

data/lib/fastlane/actions/create_pull_request.rb

@@ -0,0 +1,96 @@
+module Fastlane
+  module Actions
+    module SharedValues
+      CREATE_PULL_REQUEST_HTML_URL = :CREATE_PULL_REQUEST_HTML_URL
+    end
+
+    class CreatePullRequestAction < Action
+      def self.run(params)
+        require 'excon'
+        require 'base64'
+
+        Helper.log.info "Creating new pull request from '#{params[:head]}' to branch '#{params[:base]}' of '#{params[:repo]}'"
+
+        url = "https://api.github.com/repos/#{params[:repo]}/pulls"
+        headers = { 'User-Agent' => 'fastlane-create_pull_request' }
+        headers['Authorization'] = "Basic #{Base64.strict_encode64(params[:api_token])}" if params[:api_token]
+
+        data = {
+          'title' => params[:title],
+          'head' => params[:head],
+          'base' => params[:base]
+        }
+
+        data['body'] = params[:body] if params[:body]
+
+        response = Excon.post(url, headers: headers, body: data.to_json)
+
+        if response[:status] == 201
+          body = JSON.parse(response.body)
+          number = body['number']
+          html_url = body['html_url']
+          Helper.log.info "Successfully created pull request ##{number}. You can see it at '#{html_url}'".green
+
+          Actions.lane_context[SharedValues::CREATE_PULL_REQUEST_HTML_URL] = html_url
+        else
+          if response[:status] != 200
+            Helper.log.error "GitHub responded with #{response[:status]}: #{response[:body]}".red
+          end
+        end
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "This will create a new pull request on GitHub"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :api_token,
+                                       env_name: "GITHUB_PULL_REQUEST_API_TOKEN",
+                                       description: "Personal API Token for GitHub - generate one at https://github.com/settings/tokens",
+                                       is_string: true,
+                                       optional: false),
+          FastlaneCore::ConfigItem.new(key: :repo,
+                                       env_name: "GITHUB_PULL_REQUEST_REPO",
+                                       description: "The name of the repository you want to submit the pull request to",
+                                       is_string: true,
+                                       optional: false),
+          FastlaneCore::ConfigItem.new(key: :title,
+                                       env_name: "GITHUB_PULL_REQUEST_TITLE",
+                                       description: "The title of the pull request",
+                                       is_string: true,
+                                       optional: false),
+          FastlaneCore::ConfigItem.new(key: :body,
+                                       env_name: "GITHUB_PULL_REQUEST_BODY",
+                                       description: "The contents of the pull request",
+                                       is_string: true,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :head,
+                                       env_name: "GITHUB_PULL_REQUEST_HEAD",
+                                       description: "The name of the branch where your changes are implemented (defaults to the current branch name)",
+                                       is_string: true,
+                                       default_value: Actions.git_branch,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :base,
+                                       env_name: "GITHUB_PULL_REQUEST_BASE",
+                                       description: "The name of the branch you want your changes pulled into (defaults to `master`)",
+                                       is_string: true,
+                                       default_value: 'master',
+                                       optional: true)
+        ]
+      end
+
+      def self.author
+        ["seei"]
+      end
+
+      def self.is_supported?(platform)
+        return true
+      end
+    end
+  end
+end

data/lib/fastlane/actions/push_to_git_remote.rb

@@ -26,7 +26,7 @@ module Fastlane
         return command.join(' ') if Helper.is_test?
 
         Actions.sh(command.join(' '))
-        Helper.log.info 'Sucesfully pushed to remote.'
+        Helper.log.info 'Successfully pushed to remote.'
       end
 
       def self.description

data/lib/fastlane/actions/slather.rb

@@ -5,10 +5,18 @@ module Fastlane
     end
 
     class SlatherAction < Action
+      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/PerceivedComplexity
       def self.run(params)
-        Actions.verify_gem!('slather')
+        # This will fail if using Bundler. Skip the check rather than needing to
+        # require bundler
+        unless params[:use_bundle_exec]
+          Actions.verify_gem!('slather')
+        end
 
-        command = "slather coverage "
+        command = ""
+        command += "bundle exec " if params[:use_bundle_exec]
+        command += "slather coverage "
         command += " --build-directory #{params[:build_directory]}" if params[:build_directory]
         command += " --input-format #{params[:input_format]}" if params[:input_format]
         command += " --scheme #{params[:scheme]}" if params[:scheme]
@@ -128,7 +136,12 @@ Slather is available at https://github.com/venmo/slather
           FastlaneCore::ConfigItem.new(key: :ignore,
                                        env_name: "FL_SLATHER_IGNORE",
                                        description: "Tell slather to ignore files matching a path",
-                                       optional: true)
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :use_bundle_exec,
+                                      env_name: "FL_SLATHER_USE_BUNDLE_EXEC",
+                                      description: "Use bundle exec to execute slather. Make sure it is in the Gemfile",
+                                      is_string: false,
+                                      default_value: false)
         ]
       end
 

data/lib/fastlane/actions/update_app_identifier.rb

@@ -0,0 +1,86 @@
+module Fastlane
+  module Actions
+    class UpdateAppIdentifierAction < Action
+      def self.run(params)
+        require 'plist'
+        require 'xcodeproj'
+
+        identifier_key = 'PRODUCT_BUNDLE_IDENTIFIER'
+
+        # Read existing plist file
+        info_plist_path = File.join(params[:xcodeproj], '..', params[:plist_path])
+        raise "Couldn't find info plist file at path '#{params[:plist_path]}'".red unless File.exist?(info_plist_path)
+        plist = Plist.parse_xml(info_plist_path)
+
+        # Check if current app identifier product bundle identifier
+        if plist['CFBundleIdentifier'] == "$(#{identifier_key})"
+          # Load .xcodeproj
+          project_path = params[:xcodeproj]
+          project = Xcodeproj::Project.open(project_path)
+
+          # Fetch the build configuration objects
+          configs = project.objects.select { |obj| obj.isa == 'XCBuildConfiguration' && !obj.build_settings[identifier_key].nil? }
+          raise "Info plist uses $(#{identifier_key}), but xcodeproj does not".red unless configs.count > 0
+
+          # For each of the build configurations, set app identifier
+          configs.each do |c|
+            c.build_settings[identifier_key] = params[:app_identifier]
+          end
+
+          # Write changes to the file
+          project.save
+
+          Helper.log.info "Updated #{params[:xcodeproj]} 💾.".green
+        else
+          # Update plist value
+          plist['CFBundleIdentifier'] = params[:app_identifier]
+
+          # Write changes to file
+          plist_string = Plist::Emit.dump(plist)
+          File.write(info_plist_path, plist_string)
+
+          Helper.log.info "Updated #{params[:plist_path]} 💾.".green
+        end
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.is_supported?(platform)
+        [:ios].include?(platform)
+      end
+
+      def self.description
+        "Update the project's bundle identifier"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :xcodeproj,
+                                       env_name: "FL_UPDATE_APP_IDENTIFIER_PROJECT_PATH",
+                                       description: "Path to your Xcode project",
+                                       default_value: Dir['*.xcodeproj'].first,
+                                       verify_block: proc do |value|
+                                         raise "Please pass the path to the project, not the workspace".red if value.include? "workspace"
+                                         raise "Could not find Xcode project".red unless File.exist?(value)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :plist_path,
+                                       env_name: "FL_UPDATE_APP_IDENTIFIER_PLIST_PATH",
+                                       description: "Path to info plist, relative to your Xcode project",
+                                       verify_block: proc do |value|
+                                         raise "Invalid plist file".red unless value[-6..-1].downcase == ".plist"
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :app_identifier,
+                                       env_name: 'FL_UPDATE_APP_IDENTIFIER',
+                                       description: 'The app Identifier you want to set',
+                                       default_value: ENV['PRODUCE_APP_IDENTIFIER'])
+        ]
+      end
+
+      def self.authors
+        ['squarefrog', 'tobiasstrebitzer']
+      end
+    end
+  end
+end

data/lib/fastlane/helper/sh_helper.rb

@@ -3,6 +3,7 @@ module Fastlane
     # Execute a shell command
     # This method will output the string and execute it
     # Just an alias for sh_no_action
+    # When running this in tests, it will return the actual command instead of executing it
     # @param log [boolean] should fastlane print out the executed command
     def self.sh(command, log: true)
       sh_no_action(command, log: log)
@@ -25,6 +26,7 @@ module Fastlane
         IO.popen(command, err: [:child, :out]) do |io|
           io.sync = true
           io.each do |line|
+            next unless log
             Helper.log.info ['[SHELL]', line.strip].join(': ')
             result << line
           end

data/lib/fastlane/version.rb

@@ -1,3 +1,3 @@
 module Fastlane
-  VERSION = '1.42.0'
+  VERSION = '1.43.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 1.42.0
+  version: 1.43.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-30 00:00:00.000000000 Z
+date: 2015-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: krausefx-shenzhen
@@ -580,6 +580,7 @@ files:
 - lib/fastlane/actions/copy_artifacts.rb
 - lib/fastlane/actions/crashlytics.rb
 - lib/fastlane/actions/create_keychain.rb
+- lib/fastlane/actions/create_pull_request.rb
 - lib/fastlane/actions/debug.rb
 - lib/fastlane/actions/default_platform.rb
 - lib/fastlane/actions/delete_keychain.rb
@@ -663,6 +664,7 @@ files:
 - lib/fastlane/actions/typetalk.rb
 - lib/fastlane/actions/unlock_keychain.rb
 - lib/fastlane/actions/update_app_group_identifiers.rb
+- lib/fastlane/actions/update_app_identifier.rb
 - lib/fastlane/actions/update_fastlane.rb
 - lib/fastlane/actions/update_info_plist.rb
 - lib/fastlane/actions/update_project_code_signing.rb