fastlane 1.27.0 → 1.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6ca78ddda11ac15341e1c44f7dd3f837acc56afe
-  data.tar.gz: 699ec3ba81ef637af439b04cad7ddc981e6f6e79
+  metadata.gz: 801fcf882415279031545480f46097c3af458ae2
+  data.tar.gz: 8c7f3068f19f4e20035ff95a976bef494b8ebb68
 SHA512:
-  metadata.gz: 3fd5456248d1d5a955315e035d60367012ab8cbe5c8469b653a337c5dd2db0e838b088ef5f365b03213d930ecc32f74eb72492fd461f12eebc22c93df1119ba1
-  data.tar.gz: b7e0196d7f2703133ac5a80bbfb9fdad537c13ff379b878df9b08b766a74734565f848eaed05fc549ddf6593353def1f7b50174f471dccc6386143ccfe660efe
+  metadata.gz: bd5cc1c1c89af9a374654f55a70bd9bf948fa79b0a3c6ab224fe0770a2908cf00b54fca83f8ccf3c2342e2132d3fba5c8b5ced7b9f75135b61e0336c35f7c078
+  data.tar.gz: 797bf7f700e41fd277431217c5622e661d138db797272f92b3cb2b2a801b6ecbcdf20826ef743d96701b58a59cdc8d36c2f559a4b94b9950f49d5d10d46982bf

data/lib/fastlane/actions/crashlytics.rb

@@ -1,64 +1,37 @@
-# Workaround, since crashlytics.rb from shenzhen includes the code for commander.
-def command(_param)
-end
-
 module Fastlane
   module Actions
     class CrashlyticsAction < Action
-
-      def self.is_supported?(platform)
-        [:ios, :mac].include? platform
-      end
-
       def self.run(params)
-        require 'shenzhen'
-        require 'shenzhen/plugins/crashlytics'
+        Helper.log.info 'Uploading the IPA to Crashlytics Beta. Time for some ☕️.'.green
 
-        # can pass groups param either as an Array or a String
-        case params[:groups]
-        when NilClass
-          groups = nil
-        when Array
-          groups = params[:groups].join(',')
-        when String
-          groups = params[:groups]
-        end
+        params[:groups] = params[:groups].join(",") if params[:groups].kind_of?(Array)
+        params[:emails] = params[:emails].join(",") if params[:emails].kind_of?(Array)
 
-        # Normalized notification to Crashlytics notification parameter requirement
-        # 'YES' or 'NO' - String
-        case params[:notifications]
-        when String
-          if params[:notifications] == 'YES' || params[:notifications] == 'NO'
-            notifications = params[:notifications]
-          else
-            notifications = 'YES' if params[:notifications] == 'true'
-            notifications = 'NO' if params[:notifications] == 'false'
-          end
-        when TrueClass
-          notifications = 'YES'
-        when FalseClass
-          notifications = 'NO'
-        else
-          notifications = nil
-        end
+        if params[:notes]
+          # We need to store it in a file, because the crashlytics CLI says so
+          Helper.log.error "Overwriting :notes_path, because you specified :notes" if params[:notes_path]
 
-        Helper.log.info 'Uploading the IPA to Crashlytics. Go for a coffee ☕️.'.green
-
-        if Helper.test?
-          # Access all values, to do the verify
-          return params[:crashlytics_path], params[:api_token], params[:build_secret], params[:ipa_path], params[:build_secret], params[:ipa_path], params[:notes_path], params[:emails], groups, notifications
+          notes_path = File.join("/tmp", "#{Time.now.to_i}_changelog.txt")
+          File.write(notes_path, params[:notes])
+          params[:notes_path] = notes_path # we can only set it *after* writing the file there
         end
 
-        client = Shenzhen::Plugins::Crashlytics::Client.new(params[:crashlytics_path], params[:api_token], params[:build_secret])
+        command = []
+        command << File.join(params[:crashlytics_path], 'submit')
+        command << params[:api_token]
+        command << params[:build_secret]
+        command << "-ipaPath '#{params[:ipa_path]}'"
+        command << "-emails '#{params[:emails]}'" if params[:emails]
+        command << "-notesPath '#{params[:notes_path]}'" if params[:notes_path]
+        command << "-groupAliases '#{params[:groups]}'" if params[:groups]
+        command << "-notifications #{(params[:notifications] ? 'YES' : 'NO')}"
 
-        response = client.upload_build(params[:ipa_path], file: params[:ipa_path], notes: params[:notes_path], emails: params[:emails], groups: groups, notifications: notifications)
+        Helper.log.debug command.join(" ") if $verbose
+        Actions.sh command.join(" ")
 
-        if response
-          Helper.log.info 'Build successfully uploaded to Crashlytics'.green
-        else
-          Helper.log.fatal 'Error uploading to Crashlytics.'
-          raise 'Error when trying to upload ipa to Crashlytics'.red
-        end
+        return command if Helper.test?
+
+        Helper.log.info 'Build successfully uploaded to Crashlytics Beta 🌷'.green
       end
 
       def self.description
@@ -70,6 +43,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :crashlytics_path,
                                        env_name: "CRASHLYTICS_FRAMEWORK_PATH",
                                        description: "Path to the submit binary in the Crashlytics bundle",
+                                       default_value: Dir["./Pods/Crashlytics/Crashlytics.framework"].last,
                                        verify_block: proc do |value|
                                          raise "No Crashlytics path given or found, pass using `crashlytics_path: 'path'`".red unless File.exist?(value)
                                        end),
@@ -88,7 +62,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :ipa_path,
                                        env_name: "CRASHLYTICS_IPA_PATH",
                                        description: "Path to your IPA file. Optional if you use the `ipa` or `xcodebuild` action",
-                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
+                                       default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] || Dir["*.ipa"].last,
                                        verify_block: proc do |value|
                                          raise "Couldn't find ipa file at path '#{value}'".red unless File.exist?(value)
                                        end),
@@ -99,28 +73,35 @@ module Fastlane
                                        verify_block: proc do |value|
                                          raise "Path '#{value}' not found".red unless File.exist?(value)
                                        end),
+          FastlaneCore::ConfigItem.new(key: :notes,
+                                       env_name: "CRASHLYTICS_NOTES",
+                                       description: "The release notes as string - uses :notes_path under the hood",
+                                       optional: true,
+                                       is_string: true),
           FastlaneCore::ConfigItem.new(key: :groups,
                                        env_name: "CRASHLYTICS_GROUPS",
-                                       description: "The groups used for distribution",
+                                       description: "The groups used for distribution, separated by commas",
                                        optional: true,
                                        is_string: false),
           FastlaneCore::ConfigItem.new(key: :emails,
                                        env_name: "CRASHLYTICS_EMAILS",
-                                       description: "Pass email addresses, separated by commas",
-                                       optional: true),
+                                       description: "Pass email addresses of testers, separated by commas",
+                                       optional: true,
+                                       is_string: false),
           FastlaneCore::ConfigItem.new(key: :notifications,
                                        env_name: "CRASHLYTICS_NOTIFICATIONS",
                                        description: "Crashlytics notification option (true/false)",
-                                       optional: true,
-                                       is_string: false,
-                                       verify_block: proc do |value|
-                                         raise "Crashlytics supported notifications options: TrueClass, FalseClass, 'true', 'false', 'YES', 'NO'".red unless value.kind_of?(TrueClass) || value.kind_of?(FalseClass) || value.kind_of?(String)
-                                       end)
+                                       default_value: true,
+                                       is_string: false)
         ]
       end
 
+      def self.is_supported?(platform)
+        [:ios, :mac].include?(platform)
+      end
+
       def self.author
-        "pedrogimenez"
+        ["KrauseFx", "pedrogimenez"]
       end
     end
   end

data/lib/fastlane/actions/prompt.rb

@@ -14,7 +14,7 @@ module Fastlane
           user_input = STDIN.gets(end_tag).chomp.gsub(end_tag, "").strip
         else
           # Standard one line input
-          user_input = STDIN.gets.chomp.strip
+          user_input = STDIN.gets.chomp.strip while (user_input || "").length == 0
         end
 
         user_input = (user_input.downcase == 'y') if params[:boolean]

data/lib/fastlane/actions/set_github_release.rb

@@ -18,8 +18,8 @@ module Fastlane
           'tag_name' => params[:tag_name],
           'name' => params[:name],
           'body' => params[:description],
-          'draft' => params[:is_draft],
-          'prerelease' => params[:is_prerelease]
+          'draft' => !!params[:is_draft],
+          'prerelease' => !!params[:is_prerelease]
         }
         body_obj['target_commitish'] = params[:commitish] if params[:commitish]
         body = body_obj.to_json
@@ -43,7 +43,6 @@ module Fastlane
 
           assets = params[:upload_assets]
           if assets && assets.count > 0
-
             # upload assets
             self.upload_assets(assets, body['upload_url'], api_token)
 
@@ -62,10 +61,13 @@ module Fastlane
             return body
           end
         when 422
+          Helper.log.error response.body
           Helper.log.error "Release on tag #{params[:tag_name]} already exists!".red
         when 404
+          Helper.log.error response.body
           raise "Repository #{params[:repository_name]} cannot be found, please double check its name and that you provided a valid API token (if it's a private repository).".red
         when 401
+          Helper.log.error response.body
           raise "You are not authorized to access #{params[:repository_name]}, please make sure you provided a valid API token.".red
         else
           if response[:status] != 200

data/lib/fastlane/actions/verify_xcode.rb

@@ -0,0 +1,98 @@
+module Fastlane
+  module Actions
+    module SharedValues
+    end
+
+    class VerifyXcodeAction < Action
+      def self.run(params)
+        Helper.log.info "Verifying your Xcode installation at path '#{params[:xcode_path]}'...".green
+
+        # Check 1/2
+
+        Helper.log.info "Verifying Xcode was signed by Apple Inc.".green
+        command = "codesign --display --verbose=4 '#{params[:xcode_path]}'"
+
+        must_includes = [
+          "Identifier=com.apple.dt.Xcode",
+          "Authority=Apple Mac OS Application Signing",
+          "Authority=Apple Worldwide Developer Relations Certification Authority",
+          "Authority=Apple Root CA",
+          "TeamIdentifier=59GAB85EFG"
+        ]
+
+        verify(command: command, must_includes: must_includes, params: params)
+
+        Helper.log.info "Successfully verified the code signature".green
+
+        # Check 2/2
+
+        Helper.log.info "Verifying the signature of Xcode...".green
+        Helper.log.info "This will take up to a few minutes, now is a great time to go for a coffee ☕...".green
+        command = "codesign --verify --deep --verbose '#{params[:xcode_path]}'"
+
+        must_includes = [
+          "valid on disk",
+          "satisfies its Designated Requirement"
+        ]
+
+        verify(command: command, must_includes: must_includes, params: params)
+
+        Helper.log.info "Successfully verified Xcode installation at path '#{params[:xcode_path]}' 🎧".green
+      end
+
+      def self.verify(command: nil, must_includes: nil, params: nil)
+        output = Actions.sh(command)
+
+        errors = []
+        must_includes.each do |current|
+          next if output.include?(current)
+          errors << current
+        end
+
+        if errors.count > 0
+          Helper.log.fatal "Attention: Your Xcode Installation might be hacked.".red
+          Helper.log.fatal "This might be a false alarm, if so, please submit an issue on GitHub".red
+          Helper.log.fatal "The following information couldn't be found:".red
+          Helper.log.fatal errors.join("\n").yellow
+          raise "The Xcode installation at path '#{params[:xcode_path]}' might be compromised."
+        end
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Verifies that the Xcode installation is properly signed by Apple"
+      end
+
+      def self.details
+        [
+          "This action was implemented after the recent Xcode attacked to make sure",
+          "you're not using a hacked Xcode installation.",
+          "http://researchcenter.paloaltonetworks.com/2015/09/novel-malware-xcodeghost-modifies-xcode-infects-apple-ios-apps-and-hits-app-store/"
+        ].join("\n")
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :xcode_path,
+                                       env_name: "FL_VERIFY_XCODE_XCODE_PATH",
+                                       description: "The path to the Xcode installation to test",
+                                       default_value: File.expand_path('../../', FastlaneCore::Helper.xcode_path),
+                                       verify_block: proc do |value|
+                                         raise "Couldn't find Xcode at path '#{value}'".red unless File.exist?(value)
+                                       end)
+        ]
+      end
+
+      def self.authors
+        ["KrauseFx"]
+      end
+
+      def self.is_supported?(platform)
+        [:ios, :mac].include?(platform)
+      end
+    end
+  end
+end

data/lib/fastlane/version.rb

@@ -1,3 +1,3 @@
 module Fastlane
-  VERSION = '1.27.0'
+  VERSION = '1.28.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 1.27.0
+  version: 1.28.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-18 00:00:00.000000000 Z
+date: 2015-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -190,7 +190,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.2
+        version: 0.17.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -200,7 +200,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.16.2
+        version: 0.17.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -270,7 +270,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: 0.10.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -280,7 +280,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: 0.10.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -290,7 +290,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.2.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -300,7 +300,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.2.1
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -390,7 +390,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -400,7 +400,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -410,7 +410,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.7
+        version: 0.2.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -420,7 +420,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.7
+        version: 0.2.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -690,6 +690,7 @@ files:
 - lib/fastlane/actions/update_info_plist.rb
 - lib/fastlane/actions/update_project_code_signing.rb
 - lib/fastlane/actions/update_project_provisioning.rb
+- lib/fastlane/actions/verify_xcode.rb
 - lib/fastlane/actions/version_bump_podspec.rb
 - lib/fastlane/actions/version_get_podspec.rb
 - lib/fastlane/actions/xcode_select.rb