fastlane 1.25.0 → 1.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3dfcedf5ac0b272b5a1c08e2db5cc401152f748
-  data.tar.gz: 9c552d89e71e93de66eb151e95d2cb1d31128da8
+  metadata.gz: 25bfd11d222373cfec33fe9af38642f5683e89c8
+  data.tar.gz: bccbfa52efc2954838e8e3335651fa7b998cc35e
 SHA512:
-  metadata.gz: c2839d75b434b3f866be56449b9d4f579bb31ccf901d43aa238842d1e5665007d975067fd7eb5ffee2b93b9f316dccf01b0808644a1b3ed41033b9eec588c02f
-  data.tar.gz: 76f073a6ed2428e1ca28b32d0e389825f4e471ca2a1edc331197046614c1e111661c263a581ef7309d0cd65a1730006e5047a98a5bf34dfc296e72c109d7fd2e
+  metadata.gz: 9b8afd57ce3eedb2fc4b26542403ef95c31997b4e9ad27e7419c11b74122eff55434e78a2e51ab9f6c7cfe4cfce51bd6f3c4f3f838b7b93964536ee8939cd805
+  data.tar.gz: 56fbeca07c76fd8749018050e188131071b2201c31783a0843ba1c534a070bcb3919ef7e5cc175cca8c217b98b7d5cf9ba6e572e4613a5c816eb07158d2fb496

data/bin/fastlane

@@ -94,7 +94,7 @@ class FastlaneApplication
 
         ff = Fastlane::FastFile.new(File.join(Fastlane::FastlaneFolder.path || '.', 'Fastfile'))
 
-        require 'fastlane/docs_generator'
+        require 'fastlane/documentation/docs_generator'
         Fastlane::DocsGenerator.run(path, ff)
       end
     end
@@ -106,7 +106,7 @@ class FastlaneApplication
       c.option '--platform STRING', String, 'Only show actions available on the given platform'
 
       c.action do |args, options|
-        require 'fastlane/actions_list'
+        require 'fastlane/documentation/actions_list'
         Fastlane::ActionsList.run(filter: args.first, platform: options.platform)
       end
     end
@@ -115,7 +115,7 @@ class FastlaneApplication
       c.syntax = 'fastlane action [tool_name]'
       c.description = 'Shows more information for a specific command'
       c.action do |args, options|
-        require 'fastlane/actions_list'
+        require 'fastlane/documentation/actions_list'
         Fastlane::ActionsList.run(filter: args.first)
       end
     end

data/lib/assets/custom_action_template.rb

@@ -61,6 +61,10 @@ module Fastlane
         ]
       end
 
+      def self.return_value
+        # If you method provides a return value, you can describe here what it does
+      end
+
       def self.authors
         # So no one will ever forget your contribution to fastlane :) You are awesome btw!
         ["Your GitHub/Twitter Name"]

data/lib/fastlane/action.rb

@@ -32,6 +32,11 @@ module Fastlane
       nil
     end
 
+    def self.return_value
+      # Describes what this method returns
+      nil
+    end
+
     def self.author
       nil
     end

data/lib/fastlane/actions/crashlytics.rb

@@ -102,7 +102,8 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :groups,
                                        env_name: "CRASHLYTICS_GROUPS",
                                        description: "The groups used for distribution",
-                                       optional: true),
+                                       optional: true,
+                                       is_string: false),
           FastlaneCore::ConfigItem.new(key: :emails,
                                        env_name: "CRASHLYTICS_EMAILS",
                                        description: "Pass email addresses, separated by commas",

data/lib/fastlane/actions/hipchat.rb

@@ -18,6 +18,8 @@ module Fastlane
         channel = options[:channel]
         color = (options[:success] ? 'green' : 'red')
 
+        from = options[:from]
+
         message = options[:message]
         if message_format == "html"
           message = "<table><tr><td><img src='https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png' width='50' height='50'></td><td>#{message[0..9999]}</td></tr></table>"
@@ -29,7 +31,7 @@ module Fastlane
             raise 'HipChat private message not working with API V1 please use API V2 instead'.red
           else
             uri = URI.parse("https://#{api_host}/v1/rooms/message")
-            response = Net::HTTP.post_form(uri, { 'from' => 'fastlane',
+            response = Net::HTTP.post_form(uri, { 'from' => from,
                                                   'auth_token' => api_token,
                                                   'color' => color,
                                                   'message_format' => message_format,
@@ -55,7 +57,7 @@ module Fastlane
             check_response_code(response, channel)
           else
             uri = URI.parse("https://#{api_host}/v2/room/#{channel}/notification")
-            response = Net::HTTP.post_form(uri, { 'from' => 'fastlane',
+            response = Net::HTTP.post_form(uri, { 'from' => from,
                                                   'auth_token' => api_token,
                                                   'color' => color,
                                                   'message_format' => message_format,
@@ -142,7 +144,12 @@ module Fastlane
                                            Helper.log.fatal "Please specify the message format as either 'html' or 'text'.".red
                                            raise 'Unrecognized message_format.'.red
                                          end
-                                       end)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :from,
+                                       env_name: "FL_HIPCHAT_FROM",
+                                       description: "Name the message will appear be sent from",
+                                       default_value: "fastlane",
+                                       optional: true)
         ]
       end
 

data/lib/fastlane/actions/increment_version_number.rb

@@ -68,6 +68,7 @@ module Fastlane
           Actions.lane_context[SharedValues::VERSION_NUMBER] = next_version_number
         end
 
+        return Actions.lane_context[SharedValues::VERSION_NUMBER]
       rescue => ex
         Helper.log.error 'Make sure to to follow the steps to setup your Xcode project: https://developer.apple.com/library/ios/qa/qa1827/_index.html'.yellow
         raise ex
@@ -82,7 +83,7 @@ module Fastlane
           "This action will increment the version number. ",
           "You first have to set up your Xcode project, if you haven't done it already:",
           "https://developer.apple.com/library/ios/qa/qa1827/_index.html"
-        ].join(' ')
+        ].join("\n")
       end
 
       def self.available_options

data/lib/fastlane/actions/set_github_release.rb

@@ -230,6 +230,13 @@ module Fastlane
         ]
       end
 
+      def self.return_value
+        [
+          "A hash containing all relevant information of this release",
+          "Access things like 'html_url', 'tag_name', 'name', 'body'"
+        ].join("\n")
+      end
+
       def self.authors
         ["czechboy0"]
       end

data/lib/fastlane/{actions_list.rb → documentation/actions_list.rb}

@@ -1,3 +1,5 @@
+# rubocop:disable Metrics/AbcSize
+# rubocop:disable Metrics/MethodLength
 module Fastlane
   class ActionsList
     def self.run(filter: nil, platform: nil)
@@ -75,6 +77,18 @@ module Fastlane
             headings: ['Key', 'Description', 'Env Var'],
             rows: options
           )
+          required_count = action.available_options.count do |o|
+            if o.kind_of?(FastlaneCore::ConfigItem)
+              o.optional == false
+            else
+              false
+            end
+          end
+
+          if required_count > 0
+            puts "#{required_count} of the available parameters are required".magenta
+            puts "They are marked using an asterix *".magenta
+          end
         else
           puts "No available options".yellow
         end
@@ -91,6 +105,15 @@ module Fastlane
           puts ""
         end
 
+        if action.return_value
+          puts Terminal::Table.new(
+            title: "Return Value".green,
+            headings: [],
+            rows: [[action.return_value]]
+          )
+          puts ""
+        end
+
         puts "More information can be found on https://github.com/KrauseFx/fastlane/blob/master/docs/Actions.md"
         puts "\n"
 
@@ -123,8 +146,13 @@ module Fastlane
       if options.kind_of? Array
         options.each do |current|
           if current.kind_of? FastlaneCore::ConfigItem
-            rows << [current.key.to_s.yellow, current.description, current.env_name]
+            key_name = (current.optional ? "" : "* ") + current.key.to_s
+            description = current.description + (current.default_value ? " (default: '#{current.default_value}')" : "")
+
+            rows << [key_name.yellow, description, current.env_name]
+
           elsif current.kind_of? Array
+            # Legacy actions that don't use the new config manager
             raise "Invalid number of elements in this row: #{current}. Must be 2 or 3".red unless [2, 3].include? current.count
             rows << current
             rows.last[0] = rows.last.first.yellow # color it yellow :)
@@ -137,3 +165,5 @@ module Fastlane
     end
   end
 end
+# rubocop:enable Metrics/AbcSize
+# rubocop:enable Metrics/MethodLength

data/lib/fastlane/helper/sh_helper.rb

@@ -21,24 +21,19 @@ module Fastlane
       if Helper.test?
         result << command # only for the tests
       else
-        begin
-          PTY.spawn(command) do |r, w, pid|
-            begin
-              r.each_line do |line|
-                Helper.log.info ['[SHELL]', line.strip].join(': ')
-                result << line
-              end
-            rescue Errno::EIO
-            end
-            Process.wait(pid)
+        exit_status = nil
+        IO.popen(command, err: [:child, :out]) do |io|
+          io.each do |line|
+            Helper.log.info ['[SHELL]', line.strip].join(': ')
+            result << line
           end
-          exit_status = $?.to_i
-        rescue PTY::ChildExited => e
-          exit_status = e.status.to_i
+          io.close
+          exit_status = $?.exitstatus
         end
 
         if exit_status != 0
-          raise "Exit status of command '#{command}' was #{exit_status} instead of 0.\n#{result}"
+          # this will also append the output to the exception
+          raise "Exit status of command '#{command}' was #{exit_status} instead of 0. \n#{result}"
         end
       end
 

data/lib/fastlane/version.rb

@@ -1,3 +1,3 @@
 module Fastlane
-  VERSION = '1.25.0'
+  VERSION = '1.25.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 1.25.0
+  version: 1.25.1
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-08 00:00:00.000000000 Z
+date: 2015-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -672,12 +672,12 @@ files:
 - lib/fastlane/actions/xcode_server_get_assets.rb
 - lib/fastlane/actions/xcodebuild.rb
 - lib/fastlane/actions/xctool.rb
-- lib/fastlane/actions_list.rb
 - lib/fastlane/command_line_handler.rb
 - lib/fastlane/configuration_helper.rb
 - lib/fastlane/core_ext/string.rb
 - lib/fastlane/dependency_checker.rb
-- lib/fastlane/docs_generator.rb
+- lib/fastlane/documentation/actions_list.rb
+- lib/fastlane/documentation/docs_generator.rb
 - lib/fastlane/erb_template_helper.rb
 - lib/fastlane/fast_file.rb
 - lib/fastlane/fastlane_folder.rb
@@ -712,7 +712,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Connect all iOS deployment tools into one streamlined workflow