fastlane 1.66.0 → 1.67.0

data/lib/fastlane/actions/scan.rb

@@ -20,7 +20,7 @@ module Fastlane
       end
 
       def self.details
-        "More information: https://github.com/fastlane/scan"
+        "More information: https://github.com/fastlane/fastlane/tree/master/scan"
       end
 
       def self.author

data/lib/fastlane/actions/scp.rb

@@ -12,12 +12,12 @@ module Fastlane
         Net::SCP.start(params[:host], params[:username], {port: params[:port].to_i, password: params[:password]}) do |scp|
           if params[:upload]
             scp.upload! params[:upload][:src], params[:upload][:dst], recursive: true
-            Helper.log.info ['[SCP COMMAND]', "Successfully Uploaded", params[:upload][:src], params[:upload][:dst]].join(': ')
+            UI.message(['[SCP COMMAND]', "Successfully Uploaded", params[:upload][:src], params[:upload][:dst]].join(': '))
           end
           if params[:download]
 
             t_ret = scp.download! params[:download][:src], params[:download][:dst], recursive: true
-            Helper.log.info ['[SCP COMMAND]', "Successfully Downloaded", params[:upload][:src], params[:upload][:dst]].join(': ')
+            UI.message(['[SCP COMMAND]', "Successfully Downloaded", params[:upload][:src], params[:upload][:dst]].join(': '))
             unless params[:download][:dst]
               ret = t_ret
             end

data/lib/fastlane/actions/set_changelog.rb

@@ -10,43 +10,43 @@ module Fastlane
         version_number = params[:version]
         unless version_number
           # Automatically fetch the latest version
-          Helper.log.info "Fetching the latest version for this app"
+          UI.message("Fetching the latest version for this app")
           if app.edit_version and app.edit_version.version
             version_number = app.edit_version.version
           else
-            Helper.log.info "You have to specify a new version number: "
+            UI.message("You have to specify a new version number: ")
             version_number = STDIN.gets.strip
           end
         end
 
-        Helper.log.info "Going to update version #{version_number}"
+        UI.message("Going to update version #{version_number}")
 
         changelog = params[:changelog]
         unless changelog
           path = "./fastlane/changelog.txt"
-          Helper.log.info "Looking for changelog in '#{path}'..."
+          UI.message("Looking for changelog in '#{path}'...")
           if File.exist? path
             changelog = File.read(path)
           else
-            Helper.log.error "Couldn't find changelog.txt"
-            Helper.log.info "Please enter the changelog here:"
+            UI.error("Couldn't find changelog.txt")
+            UI.message("Please enter the changelog here:")
             changelog = STDIN.gets
           end
         end
 
-        Helper.log.info "Going to update the changelog to:\n\n#{changelog.yellow}\n\n"
+        UI.important("Going to update the changelog to:\n\n#{changelog}\n\n")
 
         if (v = app.edit_version)
           if v.version != version_number
             # Version is already there, make sure it matches the one we want to create
-            Helper.log.info "Changing existing version number from '#{v.version}' to '#{version_number}'"
+            UI.message("Changing existing version number from '#{v.version}' to '#{version_number}'")
             v.version = version_number
             v.save!
           else
-            Helper.log.info "Updating changelog for existing version #{v.version}"
+            UI.message("Updating changelog for existing version #{v.version}")
           end
         else
-          Helper.log.info "Creating the new version: #{version_number}"
+          UI.message("Creating the new version: #{version_number}")
           app.create_version!(version_number)
           app = Spaceship::Application.find(params[:app_identifier]) # Replace with .reload method once available
           v = app.edit_version
@@ -55,10 +55,10 @@ module Fastlane
         v.release_notes.languages.each do |lang|
           v.release_notes[lang] = changelog
         end
-        Helper.log.info "Uploading changes to iTunes Connect..."
+        UI.message("Uploading changes to iTunes Connect...")
         v.save!
 
-        Helper.log.info "👼 Successfully pushed the new changelog to #{v.url}".green
+        UI.success("👼 Successfully pushed the new changelog to #{v.url}")
       end
 
       #####################################################

data/lib/fastlane/actions/set_github_release.rb

@@ -10,8 +10,8 @@ module Fastlane
 
     class SetGithubReleaseAction < Action
       def self.run(params)
-        Helper.log.info "Creating release of #{params[:repository_name]} on tag \"#{params[:tag_name]}\" with name \"#{params[:name]}\".".yellow
-        Helper.log.info "Will also upload assets #{params[:upload_assets]}.".yellow if params[:upload_assets]
+        UI.important("Creating release of #{params[:repository_name]} on tag \"#{params[:tag_name]}\" with name \"#{params[:name]}\".")
+        UI.important("Will also upload assets #{params[:upload_assets]}.") if params[:upload_assets]
 
         require 'json'
         body_obj = {
@@ -34,11 +34,11 @@ module Fastlane
 
         case response[:status]
         when 201
-          Helper.log.info "Successfully created release at tag \"#{params[:tag_name]}\" on GitHub".green
+          UI.success("Successfully created release at tag \"#{params[:tag_name]}\" on GitHub")
           body = JSON.parse(response.body)
           html_url = body['html_url']
           release_id = body['id']
-          Helper.log.info "See release at \"#{html_url}\"".yellow
+          UI.important("See release at \"#{html_url}\"")
           Actions.lane_context[SharedValues::SET_GITHUB_RELEASE_HTML_LINK] = html_url
           Actions.lane_context[SharedValues::SET_GITHUB_RELEASE_RELEASE_ID] = release_id
           Actions.lane_context[SharedValues::SET_GITHUB_RELEASE_JSON] = body
@@ -51,29 +51,29 @@ module Fastlane
             # fetch the release again, so that it contains the uploaded assets
             get_response = self.call_releases_endpoint("get", server_url, repo_name, "/releases/#{release_id}", api_token, nil)
             if get_response[:status] != 200
-              Helper.log.error "GitHub responded with #{response[:status]}:#{response[:body]}".red
+              UI.error("GitHub responded with #{response[:status]}:#{response[:body]}")
               raise "Failed to fetch the newly created release, but it *has been created* successfully.".red
             end
 
             get_body = JSON.parse(get_response.body)
             Actions.lane_context[SharedValues::SET_GITHUB_RELEASE_JSON] = get_body
-            Helper.log.info "Successfully uploaded assets #{assets} to release \"#{html_url}\"".green
+            UI.success("Successfully uploaded assets #{assets} to release \"#{html_url}\"")
             return get_body
           else
             return body
           end
         when 422
-          Helper.log.error response.body
-          Helper.log.error "Release on tag #{params[:tag_name]} already exists!".red
+          UI.error(response.body)
+          UI.error("Release on tag #{params[:tag_name]} already exists!")
         when 404
-          Helper.log.error response.body
+          UI.error(response.body)
           raise "Repository #{params[:repository_name]} cannot be found, please double check its name and that you provided a valid API token (if it's a private repository).".red
         when 401
-          Helper.log.error response.body
+          UI.error(response.body)
           raise "You are not authorized to access #{params[:repository_name]}, please make sure you provided a valid API token.".red
         else
           if response[:status] != 200
-            Helper.log.error "GitHub responded with #{response[:status]}:#{response[:body]}".red
+            UI.error("GitHub responded with #{response[:status]}:#{response[:body]}")
           end
         end
         return nil
@@ -114,16 +114,16 @@ module Fastlane
         headers = self.headers(api_token)
         headers['Content-Type'] = 'application/zip' # how do we detect other types e.g. other binary files? file extensions?
 
-        Helper.log.info "Uploading #{name}".yellow
+        UI.important("Uploading #{name}")
         response = self.call_endpoint(expanded_url, "post", headers, File.read(file))
 
         # inspect the response
         case response.status
         when 201
           # all good in the hood
-          Helper.log.info "Successfully uploaded #{name}.".green
+          UI.success("Successfully uploaded #{name}.")
         else
-          Helper.log.error "GitHub responded with #{response[:status]}:#{response[:body]}".red
+          UI.error("GitHub responded with #{response[:status]}:#{response[:body]}")
           raise "Failed to upload asset #{name} to GitHub."
         end
       end

data/lib/fastlane/actions/set_info_plist_value.rb

@@ -16,8 +16,8 @@ module Fastlane
 
           return params[:value]
         rescue => ex
-          Helper.log.error ex
-          Helper.log.error "Unable to set value to plist file at '#{path}'".red
+          UI.error(ex)
+          UI.error("Unable to set value to plist file at '#{path}'")
         end
       end
 

data/lib/fastlane/actions/sigh.rb

@@ -38,7 +38,7 @@ module Fastlane
         profile_type = "development" if values[:development]
         profile_type = "enterprise" if enterprise
 
-        Helper.log.info "Setting Provisioning Profile type to '#{profile_type}'"
+        UI.message("Setting Provisioning Profile type to '#{profile_type}'")
 
         Actions.lane_context[SharedValues::SIGH_PROFILE_TYPE] = profile_type
       end

data/lib/fastlane/actions/slack.rb

@@ -44,9 +44,9 @@ module Fastlane
                                attachments: [slack_attachment]
 
         if result.code.to_i == 200
-          Helper.log.info 'Successfully sent Slack notification'.green
+          UI.success('Successfully sent Slack notification')
         else
-          Helper.log.debug result
+          UI.verbose(result)
           raise 'Error pushing Slack message, maybe the integration has no permission to post on this channel? Try removing the channel parameter in your Fastfile.'.red
         end
       end

data/lib/fastlane/actions/ssh.rb

@@ -48,17 +48,17 @@ module Fastlane
 
         Net::SSH.start(params[:host], params[:username], {port: params[:port].to_i, password: params[:password]}) do |ssh|
           params[:commands].each do |cmd|
-            Helper.log.info ['[SSH COMMAND]', cmd.yellow].join(': ') if params[:log]
+            UI.important(['[SSH COMMAND]', cmd].join(': ')) if params[:log]
             return_value = ssh_exec!(ssh, cmd)
-            Helper.log.error "SSH Command failed '#{cmd}' Exit-Code: #{return_value[:exit_code]}" if return_value[:exit_code] > 0
+            UI.error("SSH Command failed '#{cmd}' Exit-Code: #{return_value[:exit_code]}") if return_value[:exit_code] > 0
             raise "SSH Command failed" if return_value[:exit_code] > 0
 
             stderr << return_value[:stderr]
             stdout << return_value[:stdout]
           end
         end
-        Helper.log.info "Succesfully executed #{params[:commands].count} commands on host: #{params[:host]}"
-        Helper.log.info "\n########### \n #{stdout} \n###############".magenta if params[:log]
+        UI.message("Succesfully executed #{params[:commands].count} commands on host: #{params[:host]}")
+        UI.message("\n########### \n #{stdout} \n###############".magenta) if params[:log]
         Actions.lane_context[SharedValues::SSH_STDOUT_VALUE] = stdout
         Actions.lane_context[SharedValues::SSH_STDERR_VALUE] = stderr
         return {stdout: Actions.lane_context[SharedValues::SSH_STDOUT_VALUE], stderr: Actions.lane_context[SharedValues::SSH_STDERR_VALUE]}

data/lib/fastlane/actions/supply.rb

@@ -27,7 +27,7 @@ module Fastlane
       end
 
       def self.details
-        "More information: https://github.com/fastlane/supply"
+        "More information: https://github.com/fastlane/fastlane/tree/master/supply"
       end
 
       def self.available_options

data/lib/fastlane/actions/team_id.rb

@@ -9,7 +9,7 @@ module Fastlane
         team = (params || []).first
         raise "Please pass your Team ID (e.g. team_id 'Q2CBPK58CA')".red unless team.to_s.length > 0
 
-        Helper.log.info "Setting Team ID to '#{team}' for all build steps"
+        UI.message("Setting Team ID to '#{team}' for all build steps")
 
         [:CERT_TEAM_ID, :SIGH_TEAM_ID, :PEM_TEAM_ID, :PRODUCE_TEAM_ID, :SIGH_TEAM_ID, :FASTLANE_TEAM_ID].each do |current|
           ENV[current.to_s] = team

data/lib/fastlane/actions/team_name.rb

@@ -9,7 +9,7 @@ module Fastlane
         team = (params || []).first
         raise "Please pass your Team Name (e.g. team_name 'Felix Krause')".red unless team.to_s.length > 0
 
-        Helper.log.info "Setting Team Name to '#{team}' for all build steps"
+        UI.message("Setting Team Name to '#{team}' for all build steps")
 
         [:FASTLANE_TEAM_NAME, :PRODUCE_TEAM_NAME].each do |current|
           ENV[current.to_s] = team

data/lib/fastlane/actions/testfairy.rb

@@ -9,7 +9,7 @@ module Fastlane
         require 'shenzhen'
         require 'shenzhen/plugins/testfairy'
 
-        Helper.log.info 'Starting with ipa upload to TestFairy...'.green
+        UI.success('Starting with ipa upload to TestFairy...')
 
         client = Shenzhen::Plugins::TestFairy::Client.new(
           params[:api_key]
@@ -19,8 +19,8 @@ module Fastlane
 
         response = client.upload_build(params[:ipa], params.values)
         if parse_response(response)
-          Helper.log.info "Build URL: #{Actions.lane_context[SharedValues::TESTFAIRY_BUILD_URL]}".green
-          Helper.log.info "Build successfully uploaded to TestFairy.".green
+          UI.success("Build URL: #{Actions.lane_context[SharedValues::TESTFAIRY_BUILD_URL]}")
+          UI.success("Build successfully uploaded to TestFairy.")
         else
           raise 'Error when trying to upload ipa to TestFairy'.red
         end
@@ -38,7 +38,7 @@ module Fastlane
 
           return true
         else
-          Helper.log.fatal "Error uploading to TestFairy: #{response.body}".red
+          UI.error("Error uploading to TestFairy: #{response.body}")
 
           return false
         end

data/lib/fastlane/actions/testmunk.rb

@@ -13,9 +13,9 @@ module Fastlane
   module Actions
     class TestmunkAction < Action
       def self.run(config)
-        Helper.log.info 'Testmunk: Uploading the .ipa and starting your tests'.green
+        UI.success('Testmunk: Uploading the .ipa and starting your tests')
 
-        Helper.log.info 'Zipping features/ to features.zip'.green
+        UI.success('Zipping features/ to features.zip')
         zipped_features_path = File.expand_path('features.zip')
         Actions.sh(%(zip -r "features" "features/"))
 
@@ -26,7 +26,7 @@ module Fastlane
             " https://#{config[:api]}@api.testmunk.com/apps/#{config[:app]}/testruns")
 
         if response
-          Helper.log.info 'Your tests are being executed right now. Please wait for the mail with results and decide if you want to continue.'.green
+          UI.success('Your tests are being executed right now. Please wait for the mail with results and decide if you want to continue.')
         else
           raise 'Something went wrong while uploading your app to Testmunk'.red
         end

data/lib/fastlane/actions/tryouts.rb

@@ -9,15 +9,15 @@ module Fastlane
       TRYOUTS_API_BUILD_RELEASE_TEMPLATE = "https://api.tryouts.io/v1/applications/%s/releases/"
 
       def self.run(params)
-        Helper.log.info 'Upload to Tryouts has been started. This may take some time.'.green
+        UI.success('Upload to Tryouts has been started. This may take some time.')
 
         response = self.upload_build(params)
 
         case response.status
         when 200...300
           Actions.lane_context[SharedValues::TRYOUTS_BUILD_INFORMATION] = response.body
-          Helper.log.info 'Build successfully uploaded to Tryouts!'.green
-          Helper.log.info "Release download url: #{response.body['download_url']}" if response.body["download_url"]
+          UI.success('Build successfully uploaded to Tryouts!')
+          UI.message("Release download url: #{response.body['download_url']}") if response.body["download_url"]
         else
           raise "Error when trying to upload build file to Tryouts: #{response.body}".red
         end

data/lib/fastlane/actions/twitter.rb

@@ -11,7 +11,7 @@ module Fastlane
           config.access_token_secret = params[:access_token_secret]
         end
         client.update(params[:message])
-        Helper.log.info ['[TWITTER]', "Successfully tweeted ", params[:message]].join(': ')
+        UI.message(['[TWITTER]', "Successfully tweeted ", params[:message]].join(': '))
       end
 
       #####################################################

data/lib/fastlane/actions/typetalk.rb

@@ -28,7 +28,7 @@ module Fastlane
 
         self.post_to_typetalk(message, topic_id, typetalk_token)
 
-        Helper.log.info 'Successfully sent Typetalk notification'.green
+        UI.success('Successfully sent Typetalk notification')
       end
 
       def self.post_to_typetalk(message, topic_id, typetalk_token)

data/lib/fastlane/actions/update_app_group_identifiers.rb

@@ -8,8 +8,8 @@ module Fastlane
       require 'plist'
 
       def self.run(params)
-        Helper.log.info "Entitlements File: #{params[:entitlements_file]}"
-        Helper.log.info "New App Group Identifiers: #{params[:app_group_identifiers]}"
+        UI.message("Entitlements File: #{params[:entitlements_file]}")
+        UI.message("New App Group Identifiers: #{params[:app_group_identifiers]}")
 
         entitlements_file = params[:entitlements_file]
         raise "Could not find entitlements file at path '#{entitlements_file}'".red unless File.exist?(entitlements_file)
@@ -23,12 +23,12 @@ module Fastlane
         raise 'No existing App group field specified. Please specify an App Group in the entitlements file.'.red unless app_group_field
 
         # set new app group identifiers
-        Helper.log.info "Old App Group Identifiers: #{app_group_field}"
+        UI.message("Old App Group Identifiers: #{app_group_field}")
         result['com.apple.security.application-groups'] = params[:app_group_identifiers]
 
         # save entitlements file
         result.save_plist(entitlements_file)
-        Helper.log.info "New App Group Identifiers set: #{result['com.apple.security.application-groups']}"
+        UI.message("New App Group Identifiers set: #{result['com.apple.security.application-groups']}")
 
         Actions.lane_context[SharedValues::APP_GROUP_IDENTIFIERS] = result['com.apple.security.application-groups']
       end

data/lib/fastlane/actions/update_app_identifier.rb

@@ -34,7 +34,7 @@ module Fastlane
           # Write changes to the file
           project.save
 
-          Helper.log.info "Updated #{params[:xcodeproj]} 💾.".green
+          UI.success("Updated #{params[:xcodeproj]} 💾.")
         else
           # Update plist value
           plist['CFBundleIdentifier'] = params[:app_identifier]
@@ -43,7 +43,7 @@ module Fastlane
           plist_string = Plist::Emit.dump(plist)
           File.write(info_plist_path, plist_string)
 
-          Helper.log.info "Updated #{params[:plist_path]} 💾.".green
+          UI.success("Updated #{params[:plist_path]} 💾.")
         end
       end
 
@@ -66,14 +66,14 @@ module Fastlane
                                        description: "Path to your Xcode project",
                                        default_value: Dir['*.xcodeproj'].first,
                                        verify_block: proc do |value|
-                                         raise "Please pass the path to the project, not the workspace".red if value.include? "workspace"
+                                         raise "Please pass the path to the project, not the workspace".red unless value.end_with?(".xcodeproj")
                                          raise "Could not find Xcode project".red unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :plist_path,
                                        env_name: "FL_UPDATE_APP_IDENTIFIER_PLIST_PATH",
                                        description: "Path to info plist, relative to your Xcode project",
                                        verify_block: proc do |value|
-                                         raise "Invalid plist file".red unless value[-6..-1].downcase == ".plist"
+                                         raise "Invalid plist file".red unless value[-6..-1].casecmp(".plist").zero?
                                        end),
           FastlaneCore::ConfigItem.new(key: :app_identifier,
                                        env_name: 'FL_UPDATE_APP_IDENTIFIER',

data/lib/fastlane/actions/update_fastlane.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Metrics/AbcSize
 require 'rubygems/spec_fetcher'
 require 'rubygems/command_manager'
 
@@ -28,6 +27,7 @@ module Fastlane
         "match"
       ]
 
+      # rubocop:disable Metrics/AbcSize
       def self.run(options)
         if options[:no_update]
           return
@@ -37,11 +37,11 @@ module Fastlane
         tools_to_update ||= all_installed_tools
 
         if tools_to_update.count == 0
-          Helper.log.error "No tools specified or couldn't find any installed fastlane.tools".red
+          UI.error("No tools specified or couldn't find any installed fastlane.tools")
           return
         end
 
-        Helper.log.info "Looking for updates for #{tools_to_update.join(', ')}..."
+        UI.message("Looking for updates for #{tools_to_update.join(', ')}...")
 
         updater = Gem::CommandManager.instance[:update]
         cleaner = Gem::CommandManager.instance[:cleanup]
@@ -49,9 +49,18 @@ module Fastlane
         sudo_needed = !File.writable?(Gem.dir)
 
         if sudo_needed
-          Helper.log.warn "It seems that your Gem directory is not writable by your current User."
-          Helper.log.warn "Fastlane would need sudo rights to update itself, however, running 'sudo fastlane' is not recommended."
-          Helper.log.warn "If you still want to use this action, please read the Actions.md documentation on a guide how to set this up."
+          UI.important("It seems that your Gem directory is not writable by your current User.")
+          UI.important("Fastlane would need sudo rights to update itself, however, running 'sudo fastlane' is not recommended.")
+          UI.important("If you still want to use this action, please read the Actions.md documentation on a guide how to set this up.")
+          return
+        end
+
+        if updater.respond_to? :highest_installed_gems
+          UI.important "The update_fastlane action requires rubygems version 2.1.0 or greater."
+          UI.important "Please update your version of ruby gems before proceeding."
+          UI.command "gem install rubygems-update"
+          UI.command "update_rubygems"
+          UI.command "gem update --system"
           return
         end
 
@@ -59,7 +68,7 @@ module Fastlane
         update_needed = updater.which_to_update(highest_versions, tools_to_update)
 
         if update_needed.count == 0
-          Helper.log.info "Nothing to update ✅".green
+          UI.success("Nothing to update ✅")
           return
         end
 
@@ -71,12 +80,12 @@ module Fastlane
           local_version = Gem::Version.new(highest_versions[tool].version)
           update_url = FastlaneCore::UpdateChecker.generate_fetch_url(tool)
           latest_version = FastlaneCore::UpdateChecker.fetch_latest(update_url)
-          Helper.log.info "Updating #{tool} from #{local_version} to #{latest_version} ... 🚀"
+          UI.message("Updating #{tool} from #{local_version} to #{latest_version} ... 🚀")
 
           # Approximate_recommendation will create a string like "~> 0.10" from a version 0.10.0, e.g. one that is valid for versions >= 0.10 and <1.0
           updater.update_gem tool, Gem::Requirement.new(local_version.approximate_recommendation)
 
-          Helper.log.info "Finished updating #{tool}"
+          UI.message("Finished updating #{tool}")
         end
 
         all_updated_tools = updater.installer.installed_gems.select do |updated_tool|
@@ -84,17 +93,18 @@ module Fastlane
         end
 
         if all_updated_tools.empty?
-          Helper.log.info "All fastlane tools are up-to-date!"
+          UI.message("All fastlane tools are up-to-date!")
         else
-          Helper.log.info "Cleaning up old versions..."
+          UI.message("Cleaning up old versions...")
           cleaner.options[:args] = all_updated_tools.map(&:name)
           cleaner.execute
-          Helper.log.info "fastlane.tools successfully updated! I will now restart myself... 😴"
+          UI.message("fastlane.tools successfully updated! I will now restart myself... 😴")
 
           # Set no_update to true so we don't try to update again
           exec "FL_NO_UPDATE=true #{$PROGRAM_NAME} #{ARGV.join ' '}"
         end
       end
+      # rubocop:enable Metrics/AbcSize
 
       def self.all_installed_tools
         Gem::Specification.select { |s| ALL_TOOLS.include? s.name }.map(&:name).uniq
@@ -128,4 +138,3 @@ module Fastlane
     end
   end
 end
-# rubocop:enable Metrics/AbcSize