fastlane 1.66.0 → 1.67.0

data/lib/fastlane/actions/notify.rb

@@ -3,7 +3,7 @@ module Fastlane
     class NotifyAction < Action
       def self.run(params)
         require 'terminal-notifier'
-        Helper.log.warn "It's recommended to use the new 'notification' method instead of 'notify'".yellow
+        UI.important("It's recommended to use the new 'notification' method instead of 'notify'")
 
         text = params.join(' ')
         TerminalNotifier.notify(text, title: 'fastlane')

data/lib/fastlane/actions/oclint.rb

@@ -16,7 +16,7 @@ module Fastlane
         raise "Could not find json compilation database at path '#{compile_commands}'".red unless File.exist?(compile_commands)
 
         if params[:select_reqex]
-          Helper.log.warn "'select_reqex' paramter is deprecated. Please use 'select_regex' instead.".yellow
+          UI.important("'select_reqex' paramter is deprecated. Please use 'select_regex' instead.")
           select_regex = params[:select_reqex]
         end
 
@@ -46,7 +46,7 @@ module Fastlane
         oclint_args << "-list-enabled-rules" if params[:list_enabled_rules]
 
         if params[:rc]
-          Helper.log.warn "It's recommended to use 'thresholds' instead of deprecated 'rc' parameter".yellow
+          UI.important("It's recommended to use 'thresholds' instead of deprecated 'rc' parameter")
           oclint_args << "-rc=#{params[:rc]}" if params[:rc] # Deprecated
         end
 

data/lib/fastlane/actions/onesignal.rb

@@ -11,7 +11,7 @@ module Fastlane
         require 'uri'
         require 'base64'
 
-        Helper.log.info "Parameter App name: #{params[:app_name]}"
+        UI.message("Parameter App name: #{params[:app_name]}")
         auth_token = params[:auth_token]
         app_name = params[:app_name]
         apns_p12_password = params[:apns_p12_password]
@@ -70,7 +70,7 @@ module Fastlane
                                       description: "OneSignal Authorization Key",
                                       verify_block: proc do |value|
                                         unless value.to_s.length > 0
-                                          Helper.log.fatal "Please add 'ENV[\"ONE_SIGNAL_AUTH_KEY\"] = \"your token\"' to your Fastfile's `before_all` section.".red
+                                          UI.error("Please add 'ENV[\"ONE_SIGNAL_AUTH_KEY\"] = \"your token\"' to your Fastfile's `before_all` section.")
                                           raise 'No ONE_SIGNAL_AUTH_KEY given.'.red
                                         end
                                       end),
@@ -80,7 +80,7 @@ module Fastlane
                                        description: "OneSignal App Name",
                                        verify_block: proc do |value|
                                          unless value.to_s.length > 0
-                                           Helper.log.fatal "Please add 'ENV[\"ONE_SIGNAL_APP_NAME\"] = \"Your app name\"' to your Fastfile's `before_all` section.".red
+                                           UI.error("Please add 'ENV[\"ONE_SIGNAL_APP_NAME\"] = \"Your app name\"' to your Fastfile's `before_all` section.")
                                            raise 'No ONE_SIGNAL_APP_NAME given.'.red
                                          end
                                        end),

data/lib/fastlane/actions/opt_out_usage.rb

@@ -3,7 +3,7 @@ module Fastlane
     class OptOutUsageAction < Action
       def self.run(params)
         ENV['FASTLANE_OPT_OUT_USAGE'] = "YES"
-        Helper.log.info "Disabled upload of used actions"
+        UI.message("Disabled upload of used actions")
       end
 
       def self.description

data/lib/fastlane/actions/pilot.rb

@@ -31,7 +31,7 @@ module Fastlane
 
       def self.details
         [
-          "More details can be found on https://github.com/fastlane/pilot",
+          "More details can be found on https://github.com/fastlane/fastlane/tree/master/pilot",
           "This integration will only do the TestFlight upload"
         ].join("\n")
       end

data/lib/fastlane/actions/pod_push.rb

@@ -22,8 +22,8 @@ module Fastlane
           command << " --allow-warnings"
         end
 
-        result = Actions.sh("#{command}")
-        Helper.log.info "Successfully pushed Podspec ⬆️ ".green
+        result = Actions.sh(command.to_s)
+        UI.success("Successfully pushed Podspec ⬆️ ")
         return result
       end
 

data/lib/fastlane/actions/produce.rb

@@ -33,7 +33,7 @@ module Fastlane
       def details
         [
           'For more information about produce, visit its GitHub page:',
-          'https://github.com/fastlane/produce'
+          'https://github.com/fastlane/fastlane/tree/master/produce'
         ].join(' ')
       end
 

data/lib/fastlane/actions/prompt.rb

@@ -3,21 +3,21 @@ module Fastlane
     class PromptAction < Action
       def self.run(params)
         params[:text] += " (y/n)" if params[:boolean]
-        Helper.log.info params[:text]
+        UI.message(params[:text])
 
         return params[:ci_input] if Helper.is_ci?
 
         if params[:multi_line_end_keyword]
           # Multi line
           end_tag = params[:multi_line_end_keyword]
-          Helper.log.info "Submit inputs using \"#{params[:multi_line_end_keyword]}\"".yellow
+          UI.important("Submit inputs using \"#{params[:multi_line_end_keyword]}\"")
           user_input = STDIN.gets(end_tag).chomp.gsub(end_tag, "").strip
         else
           # Standard one line input
           user_input = STDIN.gets.chomp.strip while (user_input || "").length == 0
         end
 
-        user_input = (user_input.downcase == 'y') if params[:boolean]
+        user_input = user_input.casecmp('y').zero? if params[:boolean]
         return user_input
       end
 

data/lib/fastlane/actions/push_git_tags.rb

@@ -9,7 +9,7 @@ module Fastlane
         ]
 
         result = Actions.sh(command.join(' '))
-        Helper.log.info 'Tags pushed to remote'.green
+        UI.success('Tags pushed to remote')
         result
       end
 

data/lib/fastlane/actions/push_to_git_remote.rb

@@ -26,7 +26,7 @@ module Fastlane
         return command.join(' ') if Helper.is_test?
 
         Actions.sh(command.join(' '))
-        Helper.log.info 'Successfully pushed to remote.'
+        UI.message('Successfully pushed to remote.')
       end
 
       def self.description

data/lib/fastlane/actions/read_podspec.rb

@@ -13,7 +13,7 @@ module Fastlane
         require 'cocoapods-core'
         spec = Pod::Spec.from_file(path).to_hash
 
-        Helper.log.info "Reading podspec from file #{path}".green
+        UI.success("Reading podspec from file #{path}")
 
         Actions.lane_context[SharedValues::READ_PODSPEC_JSON] = spec
         return spec

data/lib/fastlane/actions/recreate_schemes.rb

@@ -4,7 +4,7 @@ module Fastlane
       def self.run(params)
         require 'xcodeproj'
 
-        Helper.log.info "Recreate schemes for project: #{params[:project]}"
+        UI.message("Recreate schemes for project: #{params[:project]}")
 
         project = Xcodeproj::Project.open(params[:project])
         project.recreate_user_schemes

data/lib/fastlane/actions/register_devices.rb

@@ -31,7 +31,7 @@ module Fastlane
           devices_file = CSV.read(File.expand_path(File.join(devices_file)), col_sep: "\t")
           raise 'Please provide a file according to the Apple Sample UDID file (https://devimages.apple.com.edgekey.net/downloads/devices/Multiple-Upload-Samples.zip)'.red unless devices_file.first == ['Device ID', 'Device Name']
 
-          Helper.log.info "Fetching list of currently registered devices..."
+          UI.message("Fetching list of currently registered devices...")
           existing_devices = Spaceship::Device.all
 
           device_objs = devices_file.drop(1).map do |device|
@@ -46,7 +46,7 @@ module Fastlane
           raise 'You must pass either a valid `devices` or `devices_file`. Please check the readme.'.red
         end
 
-        Helper.log.info "Successfully registered new devices.".green
+        UI.success("Successfully registered new devices.")
         return device_objs
       end
 

data/lib/fastlane/actions/reset_git_repo.rb

@@ -27,13 +27,13 @@ module Fastlane
 
             Actions.sh(clean_command) unless params[:skip_clean]
 
-            Helper.log.info 'Git repo was reset and cleaned back to a pristine state.'.green
+            UI.success('Git repo was reset and cleaned back to a pristine state.')
           else
             paths.each do |path|
-              Helper.log.warn("Couldn't find file at path '#{path}'") unless File.exist?(path)
+              UI.important("Couldn't find file at path '#{path}'") unless File.exist?(path)
               Actions.sh("git checkout -- '#{path}'")
             end
-            Helper.log.info "Git cleaned up #{paths.count} files.".green
+            UI.success("Git cleaned up #{paths.count} files.")
           end
         else
           raise 'This is a destructive and potentially dangerous action. To protect from data loss, please add the `ensure_git_status_clean` action to the beginning of your lane, or if you\'re absolutely sure of what you\'re doing then call this action with the :force option.'.red

data/lib/fastlane/actions/resign.rb

@@ -6,8 +6,8 @@ module Fastlane
         require 'sigh'
 
         # try to resign the ipa
-        if Sigh::Resign.resign(params[:ipa], params[:signing_identity], params[:provisioning_profile], params[:entitlements], params[:version])
-          Helper.log.info 'Successfully re-signed .ipa 🔏.'.green
+        if Sigh::Resign.resign(params[:ipa], params[:signing_identity], params[:provisioning_profile], params[:entitlements], params[:version], params[:display_name])
+          UI.success('Successfully re-signed .ipa 🔏.')
         else
           raise 'Failed to re-sign .ipa'.red
         end
@@ -67,6 +67,11 @@ module Fastlane
                                        env_name: "FL_RESIGN_VERSION",
                                        description: "Version number to force resigned ipa to use",
                                        is_string: true,
+                                       optional: true),
+          FastlaneCore::ConfigItem.new(key: :display_name,
+                                       env_name: "FL_DISPLAY_NAME",
+                                       description: "Display name to force resigned ipa to use",
+                                       is_string: true,
                                        optional: true)
         ]
       end

data/lib/fastlane/actions/restore_file.rb

@@ -7,7 +7,7 @@ module Fastlane
         raise "Could not find file '#{backup_path}'" unless File.exist? backup_path
         FileUtils.cp(backup_path, path, {preserve: true})
         FileUtils.rm(backup_path)
-        Helper.log.info "Successfully restored backup 📤"
+        UI.message("Successfully restored backup 📤")
       end
 
       def self.description

data/lib/fastlane/actions/rocket.rb

@@ -0,0 +1,64 @@
+module Fastlane
+  module Actions
+    class RocketAction < Action
+      def self.run(params)
+        puts "
+        ____
+       /    \\
+      |      |
+      |      |
+      |      |
+       \\____/
+       |    |
+       |    |
+       |    |
+       |____|
+      {|    |}
+       |    |
+       |    |
+       | F  |
+       | A  |
+       | S  |
+       | T  |
+       | L  |
+       | A  |
+      /| N  |\\
+      || E  ||
+      ||    ||
+      \\|____|/
+       /_\\/_\\
+       ######
+      ########
+       ######
+        ####
+        ####
+         ##
+         ##
+         ##
+         ##
+         "
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Outputs ascii-art for a rocket 🚀"
+      end
+
+      def self.available_options
+        [
+        ]
+      end
+
+      def self.authors
+        ["JaviSoto", "radex"]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/actions/s3.rb

@@ -26,7 +26,6 @@ module Fastlane
 
     class S3Action < Action
       def self.run(config)
-        require 'shenzhen'
         # Calling fetch on config so that default values will be used
         params = {}
         params[:ipa] = config[:ipa]
@@ -45,9 +44,6 @@ module Fastlane
         params[:version_template_path] = config[:version_template_path]
         params[:version_file_name] = config[:version_file_name]
 
-        # Maps nice developer build parameters to Shenzhen args
-        build_args = params_to_build_args(params)
-
         # Pulling parameters for other uses
         s3_region = params[:region]
         s3_subdomain = params[:region] ? "s3-#{params[:region]}" : "s3"
@@ -69,21 +65,16 @@ module Fastlane
         version_template_path = params[:version_template_path]
         version_file_name = params[:version_file_name]
 
-        if Helper.is_test?
-          return build_args
-        end
+        s3_client = self.s3_client(s3_access_key, s3_secret_access_key, s3_region)
+        bucket = s3_client.buckets[s3_bucket]
 
-        # Joins args into space delimited string
-        build_args = build_args.join(' ')
+        url_part = self.expand_path_with_substitutions_from_ipa_plist(ipa_file, s3_path)
 
-        command = "krausefx-ipa distribute:s3 #{build_args}"
-        Helper.log.debug command
-        Actions.sh command
+        ipa_file_basename = File.basename(ipa_file)
+        ipa_file_name = "#{url_part}#{ipa_file_basename}"
+        ipa_file_data = File.open(ipa_file, 'rb')
 
-        # Gets URL for IPA file
-        url_part = expand_path_with_substitutions_from_ipa_plist( ipa_file, s3_path )
-        ipa_file_name = File.basename(ipa_file)
-        ipa_url = "https://#{s3_subdomain}.amazonaws.com/#{s3_bucket}/#{url_part}#{ipa_file_name}"
+        ipa_url = self.upload_file(bucket, ipa_file_name, ipa_file_data)
 
         # Setting action and environment variables
         Actions.lane_context[SharedValues::S3_IPA_OUTPUT_PATH] = ipa_url
@@ -94,14 +85,11 @@ module Fastlane
           dsym_file_name = "#{url_part}#{dsym_file_basename}"
           dsym_file_data = File.open(dsym_file, 'rb')
 
-          upload_dsym(
-            s3_access_key,
-            s3_secret_access_key,
-            s3_bucket,
-            s3_region,
-            dsym_file_name,
-            dsym_file_data
-          )
+          dsym_url = self.upload_file(bucket, dsym_file_name, dsym_file_data)
+
+          # Setting action and environment variables
+          Actions.lane_context[SharedValues::S3_DSYM_OUTPUT_PATH] = dsym_url
+          ENV[SharedValues::S3_DSYM_OUTPUT_PATH.to_s] = dsym_url
 
         end
 
@@ -187,82 +175,26 @@ module Fastlane
         #
         #####################################
 
-        upload_plist_and_html_to_s3(
-          s3_access_key,
-          s3_secret_access_key,
-          s3_bucket,
-          s3_region,
-          plist_file_name,
-          plist_render,
-          html_file_name,
-          html_render,
-          version_file_name,
-          version_render
-        )
-
-        return true
-      end
-
-      def self.params_to_build_args(params)
-        # Remove nil value params unless :clean or :archive
-        params = params.delete_if { |k, v| (k != :clean && k != :archive ) && v.nil? }
-
-        # Maps nice developer param names to Shenzhen's `ipa build` arguments
-        params.collect do |k, v|
-          v ||= ''
-          if S3_ARGS_MAP[k]
-            value = (v.to_s.length > 0 ? "\"#{v}\"" : "")
-            "#{S3_ARGS_MAP[k]} #{value}".strip
-          end
-        end.compact
-      end
-
-      def self.upload_plist_and_html_to_s3(s3_access_key, s3_secret_access_key, s3_bucket, s3_region, plist_file_name, plist_render, html_file_name, html_render, version_file_name, version_render)
-        Actions.verify_gem!('aws-sdk')
-        require 'aws-sdk'
-        if s3_region
-          s3_client = AWS::S3.new(
-            access_key_id: s3_access_key,
-            secret_access_key: s3_secret_access_key,
-            region: s3_region
-          )
-        else
-          s3_client = AWS::S3.new(
-            access_key_id: s3_access_key,
-            secret_access_key: s3_secret_access_key
-          )
-        end
-
-        bucket = s3_client.buckets[s3_bucket]
-
-        plist_obj = bucket.objects.create(plist_file_name, plist_render.to_s, acl: :public_read)
-        html_obj = bucket.objects.create(html_file_name, html_render.to_s, acl: :public_read)
-        version_obj = bucket.objects.create(version_file_name, version_render.to_s, acl: :public_read)
-
-        # When you enable versioning on a S3 bucket,
-        # writing to an object will create an object version
-        # instead of replacing the existing object.
-        # http://docs.aws.amazon.com/AWSRubySDK/latest/AWS/S3/ObjectVersion.html
-        if plist_obj.kind_of? AWS::S3::ObjectVersion
-          plist_obj = plist_obj.object
-          html_obj = html_obj.object
-          version_obj = version_obj.object
-        end
+        plist_url = self.upload_file(bucket, plist_file_name, plist_render)
+        html_url = self.upload_file(bucket, html_file_name, html_render)
+        version_url = self.upload_file(bucket, version_file_name, version_render)
 
         # Setting action and environment variables
-        Actions.lane_context[SharedValues::S3_PLIST_OUTPUT_PATH] = plist_obj.public_url.to_s
-        ENV[SharedValues::S3_PLIST_OUTPUT_PATH.to_s] = plist_obj.public_url.to_s
+        Actions.lane_context[SharedValues::S3_PLIST_OUTPUT_PATH] = plist_url
+        ENV[SharedValues::S3_PLIST_OUTPUT_PATH.to_s] = plist_url
+
+        Actions.lane_context[SharedValues::S3_HTML_OUTPUT_PATH] = html_url
+        ENV[SharedValues::S3_HTML_OUTPUT_PATH.to_s] = html_url
 
-        Actions.lane_context[SharedValues::S3_HTML_OUTPUT_PATH] = html_obj.public_url.to_s
-        ENV[SharedValues::S3_HTML_OUTPUT_PATH.to_s] = html_obj.public_url.to_s
+        Actions.lane_context[SharedValues::S3_VERSION_OUTPUT_PATH] = version_url
+        ENV[SharedValues::S3_VERSION_OUTPUT_PATH.to_s] = version_url
 
-        Actions.lane_context[SharedValues::S3_VERSION_OUTPUT_PATH] = version_obj.public_url.to_s
-        ENV[SharedValues::S3_VERSION_OUTPUT_PATH.to_s] = version_obj.public_url.to_s
+        UI.success("Successfully uploaded ipa file to '#{Actions.lane_context[SharedValues::S3_IPA_OUTPUT_PATH]}'")
 
-        Helper.log.info "Successfully uploaded ipa file to '#{Actions.lane_context[SharedValues::S3_IPA_OUTPUT_PATH]}'".green
+        return true
       end
 
-      def self.upload_dsym(s3_access_key, s3_secret_access_key, s3_bucket, s3_region, dsym_file_name, dsym_file_data)
+      def self.s3_client(s3_access_key, s3_secret_access_key, s3_region)
         Actions.verify_gem!('aws-sdk')
         require 'aws-sdk'
         if s3_region
@@ -277,22 +209,22 @@ module Fastlane
             secret_access_key: s3_secret_access_key
           )
         end
+        s3_client
+      end
 
-        bucket = s3_client.buckets[s3_bucket]
-
-        dsym_obj = bucket.objects.create(dsym_file_name, dsym_file_data, acl: :public_read)
+      def self.upload_file(bucket, file_name, file_data)
+        obj = bucket.objects.create(file_name, file_data, acl: :public_read)
 
         # When you enable versioning on a S3 bucket,
         # writing to an object will create an object version
         # instead of replacing the existing object.
         # http://docs.aws.amazon.com/AWSRubySDK/latest/AWS/S3/ObjectVersion.html
-        if dsym_obj.kind_of? AWS::S3::ObjectVersion
-          dsym_obj = dsym_obj.object
+        if obj.kind_of? AWS::S3::ObjectVersion
+          obj = obj.object
         end
 
-        # Setting action and environment variables
-        Actions.lane_context[SharedValues::S3_DSYM_OUTPUT_PATH] = dsym_obj.public_url.to_s
-        ENV[SharedValues::S3_DSYM_OUTPUT_PATH.to_s] = dsym_obj.public_url.to_s
+        # Return public url
+        obj.public_url.to_s
       end
 
       #