fastlane 1.66.0 → 1.67.0

data/lib/fastlane/actions/clear_derived_data.rb

@@ -3,9 +3,9 @@ module Fastlane
     class ClearDerivedDataAction < Action
       def self.run(options)
         path = File.expand_path(options[:derived_data_path])
-        Helper.log.info "Derived Data path located at: #{path}"
+        UI.message("Derived Data path located at: #{path}")
         FileUtils.rm_rf(path) if File.directory?(path)
-        Helper.log.info "Successfully cleared Derived Data ♻️".green
+        UI.success("Successfully cleared Derived Data ♻️")
       end
 
       #####################################################

data/lib/fastlane/actions/clipboard.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class ClipboardAction < Action
       def self.run(params)
-        Helper.log.info "Storing '#{params[:value]}' in the clipboard 🎨"
+        UI.message("Storing '#{params[:value]}' in the clipboard 🎨")
 
         `echo "#{params[:value]}" | tr -d '\n' | pbcopy` # we don't use `sh`, as the command looks ugly
       end

data/lib/fastlane/actions/commit_version_bump.rb

@@ -103,10 +103,10 @@ module Fastlane
 
           Actions.sh("git commit -m '#{params[:message]}'")
 
-          Helper.log.info "Committed \"#{params[:message]}\" 💾.".green
+          UI.success("Committed \"#{params[:message]}\" 💾.")
         rescue => ex
-          Helper.log.error ex
-          Helper.log.info "Didn't commit any changes.".yellow
+          UI.error(ex)
+          UI.important("Didn't commit any changes.")
         end
       end
 

data/lib/fastlane/actions/copy_artifacts.rb

@@ -10,7 +10,7 @@ module Fastlane
         base_command = params[:keep_original] ? 'cp' : 'mv'
         options = []
         options << '-f'
-        options << '-r' if params[:keep_original] # we only want the -r flag for the cp command, which we get when the user asks to keep the original
+        options << '-R' if params[:keep_original] # we only want the -R flag for the cp command, which we get when the user asks to keep the original
         options << params[:artifacts].map { |e| e.tr(' ', '\ ') }
         options << params[:target_path]
 
@@ -22,7 +22,7 @@ module Fastlane
         # call our command
         Actions.sh(command)
 
-        Helper.log.info 'Build artifacts sucesfully copied!'.green
+        UI.success('Build artifacts sucesfully copied!')
       end
 
       #####################################################

data/lib/fastlane/actions/crashlytics.rb

@@ -9,11 +9,11 @@ module Fastlane
 
         # We need to store notes in a file, because the crashlytics CLI (iOS) says so
         if params[:notes]
-          Helper.log.error "Overwriting :notes_path, because you specified :notes" if params[:notes_path]
+          UI.error("Overwriting :notes_path, because you specified :notes") if params[:notes_path]
 
           params[:notes_path] = Helper::CrashlyticsHelper.write_to_tempfile(params[:notes], 'changelog').path
         elsif Actions.lane_context[SharedValues::FL_CHANGELOG] && !params[:notes_path]
-          Helper.log.info "Sending FL_CHANGELOG as release notes to Beta by Crashlytics"
+          UI.message("Sending FL_CHANGELOG as release notes to Beta by Crashlytics")
 
           params[:notes_path] = Helper::CrashlyticsHelper.write_to_tempfile(
             Actions.lane_context[SharedValues::FL_CHANGELOG], 'changelog').path
@@ -27,13 +27,13 @@ module Fastlane
           raise "You have to either pass an ipa or an apk file to the Crashlytics action".red
         end
 
-        Helper.log.info 'Uploading the build to Crashlytics Beta. Time for some ☕️.'.green
-        Helper.log.debug command.join(" ") if $verbose
-        Actions.sh command.join(" ")
+        UI.success('Uploading the build to Crashlytics Beta. Time for some ☕️.')
+        UI.verbose(command.join(" ")) if $verbose
+        Actions.sh(command.join(" "), log: false)
 
         return command if Helper.test?
 
-        Helper.log.info 'Build successfully uploaded to Crashlytics Beta 🌷'.green
+        UI.success('Build successfully uploaded to Crashlytics Beta 🌷')
       end
 
       def self.description

data/lib/fastlane/actions/create_pull_request.rb

@@ -9,7 +9,7 @@ module Fastlane
         require 'excon'
         require 'base64'
 
-        Helper.log.info "Creating new pull request from '#{params[:head]}' to branch '#{params[:base]}' of '#{params[:repo]}'"
+        UI.message("Creating new pull request from '#{params[:head]}' to branch '#{params[:base]}' of '#{params[:repo]}'")
 
         url = "#{params[:api_url]}/repos/#{params[:repo]}/pulls"
         headers = { 'User-Agent' => 'fastlane-create_pull_request' }
@@ -29,11 +29,11 @@ module Fastlane
           body = JSON.parse(response.body)
           number = body['number']
           html_url = body['html_url']
-          Helper.log.info "Successfully created pull request ##{number}. You can see it at '#{html_url}'".green
+          UI.success("Successfully created pull request ##{number}. You can see it at '#{html_url}'")
 
           Actions.lane_context[SharedValues::CREATE_PULL_REQUEST_HTML_URL] = html_url
         elsif response[:status] != 200
-          Helper.log.error "GitHub responded with #{response[:status]}: #{response[:body]}".red
+          UI.error("GitHub responded with #{response[:status]}: #{response[:body]}")
         end
       end
 

data/lib/fastlane/actions/deploygate.rb

@@ -22,7 +22,7 @@ module Fastlane
         require 'shenzhen/plugins/deploygate'
 
         # Available options: https://deploygate.com/docs/api
-        Helper.log.info 'Starting with ipa upload to DeployGate... this could take some time ⏳'.green
+        UI.success('Starting with ipa upload to DeployGate... this could take some time ⏳')
 
         client = Shenzhen::Plugins::DeployGate::Client.new(
           options[:api_token],
@@ -33,8 +33,8 @@ module Fastlane
 
         response = client.upload_build(options[:ipa], options.values)
         if parse_response(response)
-          Helper.log.info "DeployGate URL: #{Actions.lane_context[SharedValues::DEPLOYGATE_URL]}"
-          Helper.log.info "Build successfully uploaded to DeployGate as revision \##{Actions.lane_context[SharedValues::DEPLOYGATE_REVISION]}!".green
+          UI.message("DeployGate URL: #{Actions.lane_context[SharedValues::DEPLOYGATE_URL]}")
+          UI.success("Build successfully uploaded to DeployGate as revision \##{Actions.lane_context[SharedValues::DEPLOYGATE_REVISION]}!")
         else
           raise 'Error when trying to upload ipa to DeployGate'.red
         end
@@ -44,7 +44,7 @@ module Fastlane
         if response.body && response.body.key?('error')
 
           if response.body['error']
-            Helper.log.error "Error uploading to DeployGate: #{response.body['message']}".red
+            UI.error("Error uploading to DeployGate: #{response.body['message']}")
             help_message(response)
             return
           else
@@ -56,7 +56,7 @@ module Fastlane
             Actions.lane_context[SharedValues::DEPLOYGATE_APP_INFO] = res
           end
         else
-          Helper.log.fatal "Error uploading to DeployGate: #{response.body}".red
+          UI.error("Error uploading to DeployGate: #{response.body}")
           return
         end
         true
@@ -73,7 +73,7 @@ module Fastlane
           when 'application create error: limit'
             'Plan limit: You have reached to the limit of current plan or your plan was expired.'
           end
-        Helper.log.error message.red if message
+        UI.error(message) if message
       end
       private_class_method :help_message
 

data/lib/fastlane/actions/dotgpg_environment.rb

@@ -8,7 +8,7 @@ module Fastlane
         Actions.verify_gem!('dotgpg')
         require 'dotgpg/environment'
 
-        Helper.log.info "Reading secrets from #{options[:dotgpg_file]}"
+        UI.message("Reading secrets from #{options[:dotgpg_file]}")
         Dotgpg::Environment.new(options[:dotgpg_file]).apply
       end
 

data/lib/fastlane/actions/download.rb

@@ -43,7 +43,7 @@ module Fastlane
                                        env_name: "FL_DOWNLOAD_URL",
                                        description: "The URL that should be downloaded",
                                        verify_block: proc do |value|
-                                         Helper.log.warn "The URL doesn't start with http or https" unless value.start_with?("http")
+                                         UI.important("The URL doesn't start with http or https") unless value.start_with?("http")
                                        end)
         ]
       end

data/lib/fastlane/actions/download_dsyms.rb

@@ -0,0 +1,117 @@
+module Fastlane
+  module Actions
+    module SharedValues
+      DSYM_PATHS = :DSYM_PATHS
+    end
+
+    class DownloadDsymsAction < Action
+      def self.run(params)
+        require 'spaceship'
+        require 'net/http'
+
+        UI.message("Login to iTunes Connect (#{params[:username]})")
+        Spaceship::Tunes.login(params[:username])
+        Spaceship::Tunes.select_team
+        UI.message("Login successful")
+
+        UI.message("Looking for dSYM files for #{params[:app_identifier]}...")
+        app = Spaceship::Application.find(params[:app_identifier])
+        app.all_build_train_numbers.each do |train_number|
+          app.all_builds_for_train(train: train_number).each do |build|
+            download_url = build.details.dsym_url
+            if download_url
+              result = self.download download_url
+              file_name = "#{app.bundle_id}-#{train_number}-#{build.build_version}.dSYM.zip"
+              File.write(file_name, result)
+              UI.success("🔑  Successfully downloaded dSYM file for #{train_number} - #{build.build_version} to '#{file_name}'")
+
+              Actions.lane_context[SharedValues::DSYM_PATHS] ||= []
+              Actions.lane_context[SharedValues::DSYM_PATHS] << File.expand_path(file_name)
+            else
+              UI.message("No dSYM URL for #{build.build_version} (#{build.train_version})")
+            end
+          end
+        end
+      end
+
+      def self.download(url)
+        uri = URI.parse(url)
+        http = Net::HTTP.new(uri.host, uri.port)
+        http.use_ssl = (uri.scheme == "https")
+        res = http.get(uri.request_uri)
+        res.body
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Download dSYM files from Apple iTunes Connect for Bitcode apps"
+      end
+
+      def self.details
+        [
+          "This action downloads dSYM files from Apple iTunes Connect after",
+          "the ipa got re-compiled by Apple. Useful if you have Bitcode enabled"
+        ].join(" ")
+      end
+
+      def self.available_options
+        user = CredentialsManager::AppfileConfig.try_fetch_value(:itunes_connect_id)
+        user ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
+
+        [
+          FastlaneCore::ConfigItem.new(key: :username,
+                                       short_option: "-u",
+                                       env_name: "DOWNLOAD_DSYMS_USERNAME",
+                                       description: "Your Apple ID Username for iTunes Connect",
+                                       default_value: user),
+          FastlaneCore::ConfigItem.new(key: :app_identifier,
+                                       short_option: "-a",
+                                       env_name: "DOWNLOAD_DSYMS_APP_IDENTIFIER",
+                                       description: "The bundle identifier of your app",
+                                       optional: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)),
+          FastlaneCore::ConfigItem.new(key: :team_id,
+                                       short_option: "-k",
+                                       env_name: "DOWNLOAD_DSYMS_TEAM_ID",
+                                       description: "The ID of your team if you're in multiple teams",
+                                       optional: true,
+                                       is_string: false, # as we also allow integers, which we convert to strings anyway
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_id),
+                                       verify_block: proc do |value|
+                                         ENV["FASTLANE_ITC_TEAM_ID"] = value.to_s
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :team_name,
+                                       short_option: "-e",
+                                       env_name: "DOWNLOAD_DSYMS_TEAM_NAME",
+                                       description: "The name of your team if you're in multiple teams",
+                                       optional: true,
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_name),
+                                       verify_block: proc do |value|
+                                         ENV["FASTLANE_ITC_TEAM_NAME"] = value
+                                       end)
+        ]
+      end
+
+      def self.output
+        [
+          ['DSYM_PATHS', 'An array to all the zipped dSYM files']
+        ]
+      end
+
+      def self.return_value
+        nil
+      end
+
+      def self.authors
+        ["KrauseFx"]
+      end
+
+      def self.is_supported?(platform)
+        platform == :ios
+      end
+    end
+  end
+end

data/lib/fastlane/actions/ensure_git_branch.rb

@@ -9,7 +9,7 @@ module Fastlane
         branch = params[:branch]
         branch_expr = /#{branch}/
         if Actions.git_branch =~ branch_expr
-          Helper.log.info "Git branch match `#{branch}`, all good! 💪".green
+          UI.success("Git branch match `#{branch}`, all good! 💪")
         else
           raise "Git is not on a branch matching `#{branch}`. Current branch is `#{Actions.git_branch}`! Please ensure the repo is checked out to the correct branch.".red
         end

data/lib/fastlane/actions/ensure_git_status_clean.rb

@@ -10,7 +10,7 @@ module Fastlane
         repo_clean = `git status --porcelain`.empty?
 
         if repo_clean
-          Helper.log.info 'Git status is clean, all good! 💪'.green
+          UI.success('Git status is clean, all good! 💪')
           Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START] = true
         else
           raise 'Git repository is dirty! Please ensure the repo is in a clean state by commiting/stashing/discarding all changes first.'.red

data/lib/fastlane/actions/ensure_no_debug_code.rb

@@ -2,10 +2,26 @@ module Fastlane
   module Actions
     class EnsureNoDebugCodeAction < Action
       def self.run(params)
-        command = "grep -R '#{params[:text]}' '#{File.absolute_path(params[:path])}'"
+        command = "grep -RE '#{params[:text]}' '#{File.absolute_path(params[:path])}'"
+
+        extensions = []
+        extensions << params[:extension] unless params[:extension].nil?
+
+        if params[:extensions]
+          params[:extensions].each do |extension|
+            extension.delete!('.') if extension.include? "."
+            extensions << extension
+          end
+        end
+
+        if extensions.count > 1
+          command << " --include=\\*.{#{extensions.join(',')}}"
+        elsif extensions.count > 0
+          command << " --include=\\*.#{extensions.join(',')}"
+        end
         return command if Helper.is_test?
 
-        Helper.log.info command.yellow
+        UI.important(command)
         results = `#{command}` # we don't use `sh` as the return code of grep is wrong for some reason
 
         # Example Output
@@ -14,18 +30,11 @@ module Fastlane
 
         found = []
         results.split("\n").each do |current_raw|
-          current = current_raw.strip
-          if params[:extension]
-            if current.include? ".#{params[:extension]}:"
-              found << current
-            end
-          else
-            found << current
-          end
+          found << current_raw.strip
         end
 
         raise "Found debug code '#{params[:text]}': \n\n#{found.join("\n")}" if found.count > 0
-        Helper.log.info "No debug code found in code base 🐛"
+        UI.message("No debug code found in code base 🐛")
       end
 
       #####################################################
@@ -62,7 +71,12 @@ module Fastlane
                                        optional: true,
                                        verify_block: proc do |value|
                                          value.delete!('.') if value.include? "."
-                                       end)
+                                       end),
+          FastlaneCore::ConfigItem.new(key: :extensions,
+                                       env_name: "FL_ENSURE_NO_DEBUG_CODE_EXTENSIONS",
+                                       description: "An array of file extensions that should be searched for",
+                                       optional: true,
+                                       is_string: false)
         ]
       end
 

data/lib/fastlane/actions/ensure_xcode_version.rb

@@ -13,10 +13,10 @@ module Fastlane
         versions_match = selected_version == "Xcode #{required_version}"
 
         if versions_match
-          Helper.log.info("Selected Xcode version is correct: #{selected_version}".green)
+          UI.success("Selected Xcode version is correct: #{selected_version}")
         else
-          Helper.log.info("Selected Xcode version is not correct: #{selected_version}. You expected #{required_version}.")
-          Helper.log.info("To correct this, use: `xcode_select(version: #{required_version})`.")
+          UI.message("Selected Xcode version is not correct: #{selected_version}. You expected #{required_version}.")
+          UI.message("To correct this, use: `xcode_select(version: #{required_version})`.")
 
           raise "Selected Xcode version doesn't match your requirement.\nExpected: Xcode #{required_version}\nActual: #{selected_version}\n"
         end

data/lib/fastlane/actions/erb.rb

@@ -5,7 +5,7 @@ module Fastlane
         template = File.read(params[:template])
         result =   ERB.new(template).result(OpenStruct.new(params[:placeholders]).instance_eval { binding })
         File.open(params[:destination], 'w') { |file| file.write(result) } if params[:destination]
-        Helper.log.info "Successfully parsed template: '#{params[:template]}' and rendered output to: #{params[:destination]}" if params[:destination]
+        UI.message("Successfully parsed template: '#{params[:template]}' and rendered output to: #{params[:destination]}") if params[:destination]
         result
       end
 

data/lib/fastlane/actions/fastlane_version.rb

@@ -15,7 +15,7 @@ module Fastlane
           raise "The Fastfile requires a fastlane version of >= #{defined_version}. You are on #{Fastlane::VERSION}. Please update using `sudo gem update fastlane`.".red
         end
 
-        Helper.log.info "fastlane version valid"
+        UI.message("fastlane version valid")
       end
 
       def self.step_text

data/lib/fastlane/actions/frameit.rb

@@ -11,7 +11,7 @@ module Fastlane
           color = Frameit::Color::BLACK
           color = Frameit::Color::SILVER if config[:white] || config[:silver]
 
-          Helper.log.info "Framing screenshots at path #{config[:path]}"
+          UI.message("Framing screenshots at path #{config[:path]}")
 
           Dir.chdir(config[:path]) do
             ENV["FRAMEIT_FORCE_DEVICE_TYPE"] = config[:force_device_type] if config[:force_device_type]

data/lib/fastlane/actions/gcovr.rb

@@ -78,8 +78,8 @@ module Fastlane
         gcovr_args = gcovr_args.join(" ")
 
         command = "gcovr #{gcovr_args}"
-        Helper.log.info "Generating code coverage.".green
-        Helper.log.debug command
+        UI.success("Generating code coverage.")
+        UI.verbose(command)
         Actions.sh command
       end
 

data/lib/fastlane/actions/get_build_number.rb

@@ -31,7 +31,7 @@ module Fastlane
           Actions.lane_context[SharedValues::BUILD_NUMBER] = build_number
         end
       rescue => ex
-        Helper.log.error 'Make sure to follow the steps to setup your Xcode project: https://developer.apple.com/library/ios/qa/qa1827/_index.html'.yellow
+        UI.error('Make sure to follow the steps to setup your Xcode project: https://developer.apple.com/library/ios/qa/qa1827/_index.html')
         raise ex
       end
 

data/lib/fastlane/actions/get_github_release.rb

@@ -6,7 +6,7 @@ module Fastlane
 
     class GetGithubReleaseAction < Action
       def self.run(params)
-        Helper.log.info "Getting release on GitHub (#{params[:server_url]}/#{params[:url]}: #{params[:version]})"
+        UI.message("Getting release on GitHub (#{params[:server_url]}/#{params[:url]}: #{params[:version]})")
         require 'excon'
         require 'base64'
 
@@ -19,14 +19,14 @@ module Fastlane
 
         case response[:status]
         when 404
-          Helper.log.error "Repository #{params[:url]} cannot be found, please double check its name and that you provided a valid API token (if it's a private repository).".red
+          UI.error("Repository #{params[:url]} cannot be found, please double check its name and that you provided a valid API token (if it's a private repository).")
           return nil
         when 401
-          Helper.log.error "You are not authorized to access #{params[:url]}, please make sure you provided a valid API token.".red
+          UI.error("You are not authorized to access #{params[:url]}, please make sure you provided a valid API token.")
           return nil
         else
           if response[:status] != 200
-            Helper.log.error "GitHub responded with #{response[:status]}:#{response[:body]}".red
+            UI.error("GitHub responded with #{response[:status]}:#{response[:body]}")
             return nil
           end
         end
@@ -37,11 +37,11 @@ module Fastlane
 
           # Found it
           Actions.lane_context[SharedValues::GET_GITHUB_RELEASE_INFO] = current
-          Helper.log.info "Version is already live on GitHub.com 🚁"
+          UI.message("Version is already live on GitHub.com 🚁")
           return current
         end
 
-        Helper.log.info "Couldn't find GitHub release #{params[:version]}".yellow
+        UI.important("Couldn't find GitHub release #{params[:version]}")
         return nil
       end