fastlane-plugin-xcconfig_actions 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 308efdc017fd28d18ce6134cd9212a3bda5fafb275a0b7ebaac1804ed78c8f18
-  data.tar.gz: e650b28da0a5af7a9bcea3e3ea5976f9506786bc3552fe0b2e3616e62aa95e71
+  metadata.gz: f4140013ca2ed02bd50fe835cdbaedf563a629c749bbc735f983ec674c45a5fe
+  data.tar.gz: 8ee98b8eb448bd27f568ae5c3451771963fbaf7b7fb71d207c740ddc2512d9cb
 SHA512:
-  metadata.gz: 95b1a3130f4b6fd4564c79b9331ad28758c34f576d550ea6893720cdc938782100900094b9c44a7c750967b46fe251904f02dd37a59d35007fa688ab79d24365
-  data.tar.gz: 48907de2bcc9f49f6d05fc15fccf7197215a90e28338f27f1f3321582d8b3d68e1ef8559903dca0cb513217f69ddc3dd4448e23953abc797b624bcbc01cb0715
+  metadata.gz: 57606e7e64e7a098761c554ce706a44e17564f27c7898b60e29d69960246d91f097d710e23e9be16ac95f802b8fcbe990933d225833a617bab6338ba451a200d
+  data.tar.gz: 746f8bb2736da3d396c6883284aadd82217a11d04b87071780e91502b5cc3797a696e2efb4162048f3d9c5a020596bce9e3270d627feb190da49d4ed00173861

data/README.md

@@ -1,10 +1,12 @@
 # xcconfig_actions plugin
 
+[![license](https://img.shields.io/github/license/mgrebenets/fastlane-plugin-xcconfig_actions.svg)](https://github.com/mgrebenets/fastlane-plugin-xcconfig_actions)
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-xcconfig_actions)
 [![version](https://img.shields.io/github/tag/mgrebenets/fastlane-plugin-xcconfig_actions.svg?color=green&label=version)](https://github.com/mgrebenets/fastlane-plugin-xcconfig_actions)
 [![CircleCI](https://circleci.com/gh/mgrebenets/fastlane-plugin-xcconfig_actions.svg?style=svg)](https://circleci.com/gh/mgrebenets/fastlane-plugin-xcconfig_actions)
 [![Travis CI](https://img.shields.io/travis/mgrebenets/fastlane-plugin-xcconfig_actions.svg?label=%20&logo=travis)](https://travis-ci.org/mgrebenets/fastlane-plugin-xcconfig_actions)
 [![Coverage Status](https://coveralls.io/repos/github/mgrebenets/fastlane-plugin-xcconfig_actions/badge.svg)](https://coveralls.io/github/mgrebenets/fastlane-plugin-xcconfig_actions)
+[![Inline docs](http://inch-ci.org/github/mgrebenets/fastlane-plugin-xcconfig_actions.svg)](http://inch-ci.org/github/mgrebenets/fastlane-plugin-xcconfig_actions)
 
 ## Getting Started
 
@@ -52,30 +54,36 @@ The result is a dictionary with following keys:
 - `swift_compiler_flags` for Swift compiler.
 - `linker_flags` for Clang linker.
 
-<!-- TODO: Add info on how it works. -->
+#### Unofficial Build Settings References
 
-References:
+The following are unofficial build settings references.
+Unlike official help page, these pages contain extra information, such as build settings cross-reference and compiler and linker flags mapping.
 
-- [Xcode 10.1 Build Settings](lib/fastlane/plugin/xcconfig_actions/helper/xcspecs/10.1/README.md)
+- [Xcode 11.0 Beta 2 Build Settings](lib/fastlane/plugin/xcconfig_actions/helper/xcspecs/11.0/README.md)
+- [Xcode 10.2.1 Build Settings](lib/fastlane/plugin/xcconfig_actions/helper/xcspecs/10.2.1/README.md)
 - [Xcode 10.2 Build Settings](lib/fastlane/plugin/xcconfig_actions/helper/xcspecs/10.2/README.md)
+- [Xcode 10.1 Build Settings](lib/fastlane/plugin/xcconfig_actions/helper/xcspecs/10.1/README.md)
+
+#### References
 
 - [Xcode Build Settings](https://help.apple.com/xcode/mac/10.2/#/itcaec37c2a6)
 - [LLVM Clang Command Line Options](https://clang.llvm.org/docs/ClangCommandLineReference.html)
 - [LLVM Clang Diagnostics](https://clang.llvm.org/docs/DiagnosticsReference.html)
 - [GCC Warning Options](https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html)
 - https://gist.github.com/fabiopelosin/4560417
-- https://pewpewthespells.com/blog/xcode_build_system.html
+- [Xcode Build System](https://pewpewthespells.com/blog/xcode_build_system.html)
 
 #### Caveats
 
-Flags like `-sdk iphoneos` and `-isysroot iphoneos` may not be suitable for all uses.
+Flags like `-sdk iphoneos` and `-isysroot iphoneos` may not be suitable for all use cases.
 These settings only get generated if you add `SDKROOT = iphoneos` to your xcconfigs, so don't define `SDKROOT` in xcconfigs and leave it to build tool.
 
 ##### Code Coverage
 
 Flags like `CLANG_ENABLE_CODE_COVERAGE` will not have effect if set to `YES`.
-This flag needs to be accompanied to changes in Xcode scheme UI to enable code coverage.
-When ran from command just settings `CLANG_ENABLE_CODE_COVERAGE=YES` has no effect either, instead the `-enableCodeCoverage YES` option has to be used.
+This flag needs to be accompanied by changes in Xcode scheme UI to enable code coverage.
+
+When used from command just setting `CLANG_ENABLE_CODE_COVERAGE=YES` has no effect either, instead the `-enableCodeCoverage YES` option has to be used.
 
 In case of `CLANG_ENABLE_CODE_COVERAGE` add `CLANG_COVERAGE_MAPPING = YES` to xcconfigs to get proper flags mapping.
 
@@ -83,6 +91,29 @@ In case of `CLANG_ENABLE_CODE_COVERAGE` add `CLANG_COVERAGE_MAPPING = YES` to xc
 
 - [ ] The flags like `-std=gnu++14` are added to `compiler_flags` but are not applicable for C/Objective-C code.
 Most tools have differentiation between C flags (C and Objective-C) and Cxx flags (C++/Objective-C++).
+The solution would be to return 2 sets of flags for C and Cxx families, instead of just one `compiler_flags` option.
+- [ ] [Build setting transformations](http://codeworkshop.net/posts/xcode-build-setting-transformations) like `$(PRODUCT_NAME:c99extidentifer)` are [not supported yet](https://github.com/mgrebenets/fastlane-plugin-xcconfig_actions/issues/1).
+- [ ] Xcconfig includes are resolved **before** variable references. For example:
+
+    ```c
+    #include "A.xcconfig"
+    VAR = A
+    #include "B.xcconfig" // Contains "VAR = B" statement.
+
+    // Resolved value of `VAR` is "B".
+    ```
+
+    Will be resolved in the following order:
+
+    ```c
+    #include "A.xcconfig"
+    #include "B.xcconfig"
+    VAR = A
+
+    // Resolved value of `VAR` is "A"!
+    ```
+
+    This will cause issues if value of `VAR` is set in `B.xcconfig`.
 
 ### validate_xcconfig
 
@@ -92,33 +123,33 @@ Validate xcconfig using set of very opinionated rules:
 - Include flow is unidirectional, i.e. top-down only:
 
 ```c
-#include "../level_up.xcconfig" // File is in parent directory.
+#include "../level_up.xcconfig" // ERROR: File is in parent directory.
 ```
 
 - Files do not include other files on the same level:
 
 ```c
-#include "same_level.xcconfig" // Included file is on the same level.
+#include "same_level.xcconfig" // ERROR: Included file is on the same level.
 ```
 
 - Files do not include other files more than 1 level down
 
 ```c
-#include "level1/level2/level2.xcconfig" // 2 levels down: level1/level2.
+#include "level1/level2/level2.xcconfig" // ERROR: 2 levels down: level1/level2.
 ```
 
 - Duplicated includes are not allowed
 
 ```c
 #include "other.xcconfig"
-#include "other.xcconfig" // Duplicated include.
+#include "other.xcconfig" // ERROR: Duplicated include.
 ```
 
 - Circular includes are not allowed
 
 ```c
 // example.xcconfig file
-#include "example.xcconfig" // Include self creates circular include.
+#include "example.xcconfig" // ERROR: Include self creates circular include.
 ```
 
 Things **not supported** at the moment:
@@ -130,8 +161,8 @@ Things **not supported** at the moment:
 Xcconfigs are too easy to get out of hand.
 Ability to use arbitrary include paths complicates usage of xcconfigs in quite a few ways:
 
-- Hard to track where the variables are declared and the overwritten
-- Xcode does not always report an error when a file is missing
+- Hard to track where the variables are declared and then overwritten
+- Xcode does not always report an error when a file is missing, but silently fails to resolve variables instead
 
 These rules introduce convention to organizing xcconfigs.
 The end goal is to make config files more manageable.

data/lib/fastlane/plugin/xcconfig_actions.rb

@@ -1,6 +1,8 @@
 require 'fastlane/plugin/xcconfig_actions/version'
 
+# Extension for Fastlane module.
 module Fastlane
+  # Main module for xcconfig actions plugin.
   module XcconfigActions
     # Return all .rb files inside the "actions" and "helper" directory
     def self.all_classes

data/lib/fastlane/plugin/xcconfig_actions/actions/build_settings_to_flags_action.rb

@@ -4,14 +4,21 @@ require_relative '../helper/xcspec'
 
 module Fastlane
   module Actions
+    # Alias for helper class.
     ActionHelper = Fastlane::Helper::XcconfigActionsHelper
+    # Alias for Xcspec class.
     Xcspec = Fastlane::Helper::Xcspec
 
     module SharedValues
+      # Key for accessing build flags shared value in lane context.
       XCCONFIG_ACTIONS_BUILD_FLAGS = :XCCONFIG_ACTIONS_BUILD_FLAGS
     end
 
+    # Action to map build settings to build flags.
     class BuildSettingsToFlagsAction < Action
+      # Run action.
+      # @param [Hash] params Action parameters.
+      # @return [Hash] Build flags.
       def self.run(params)
         build_settings = params[:build_settings] || Actions.lane_context[SharedValues::XCCONFIG_ACTIONS_BUILD_SETTINGS]
         UI.user_error!("Missing build settings input") unless build_settings
@@ -50,6 +57,10 @@ module Fastlane
       # @!group Xcspecs
       ###
 
+      # Load complete spec.
+      # @param [String] name Name of the xcspec.
+      # @param [String] xcode Path to or version of Xcode.
+      # @return [Xcspec] Xcspec that includes Core Build System options.
       def self.load_complete_spec(name, xcode:)
         Xcspec.new(
           ActionHelper.find_xcspec(name, xcode: xcode),
@@ -57,6 +68,10 @@ module Fastlane
         )
       end
 
+      # Load xcspec.
+      # @param [String] name Spec name.
+      # @param [String] xcode Path to or version of Xcode.
+      # @return [Xcspec] Loaded xcspecs.
       def self.load_spec(name, xcode:)
         spec_path = ActionHelper.find_xcspec(name, xcode: xcode)
         Xcspec.new(spec_path)
@@ -66,18 +81,22 @@ module Fastlane
       # @!group Info and Options
       ###
 
+      # Plugin action description.
       def self.description
         "Map xcconfig build settings to compiler and linker build flags"
       end
 
+      # Plugin action authors.
       def self.authors
         ["Maksym Grebenets"]
       end
 
+      # Plugin action return value.
       def self.return_value
         "Build flags dictionary"
       end
 
+      # Plugin action details.
       def self.details
         [
           "Build flags keys:",
@@ -87,10 +106,12 @@ module Fastlane
         ].join("\n")
       end
 
+      # Plugin action category.
       def self.category
         :building
       end
 
+      # Plugin action available options.
       def self.available_options
         [
           FastlaneCore::ConfigItem.new(key: :build_settings,
@@ -115,6 +136,9 @@ module Fastlane
         ]
       end
 
+      # Check if platform is supported by the action.
+      # @param [Symbol] platform Platform to check.
+      # @return [Boolean] A Boolean indicating whether the platform is supported by the action.
       def self.is_supported?(platform)
         [:ios, :mac].include?(platform)
       end

data/lib/fastlane/plugin/xcconfig_actions/actions/read_xcconfig_action.rb

@@ -3,12 +3,19 @@ require 'json'
 require_relative '../helper/xcconfig_actions_helper'
 
 module Fastlane
+  # Extension for Fastlane::Actions.
   module Actions
+    # Values shared by action.
     module SharedValues
+      # Key for accessing xcconfig shared value in lane context.
       XCCONFIG_ACTIONS_BUILD_SETTINGS = :XCCONFIG_ACTIONS_BUILD_SETTINGS
     end
 
+    # Action to read and resolve values in Xcconfig files.
     class ReadXcconfigAction < Action
+      # Run action.
+      # @param [Hash] params Action parameters.
+      # @return [Hash] Xcconfig dictionary.
       def self.run(params)
         path = params[:path]
         parent = params[:parent]
@@ -33,6 +40,11 @@ module Fastlane
       ###
 
       # Resolve config using parent information.
+      # @param [Hash] config Config to resolve.
+      # @param [Hash] parent Parent config.
+      # @param [String] srcroot Path to use for $(SRCROOT).
+      # @param [String] target_name Name to use for $(TARGET_NAME)
+      # @return [Hash] Resolved config.
       def self.resolve(config, parent, srcroot, target_name)
         parent_config = read_config(parent)
 
@@ -139,26 +151,32 @@ module Fastlane
       # @!group Info and Options
       ###
 
+      # Plugin action description.
       def self.description
         "Read and resolve contents of xcconfig file and return as JSON"
       end
 
+      # Plugin action authors.
       def self.authors
         ["Maksym Grebenets"]
       end
 
+      # Plugin action return value.
       def self.return_value
         "Parse and resolved build settings from xcconfig represented as JSON"
       end
 
+      # Plugin action details.
       def self.details
         ""
       end
 
+      # Plugin action category.
       def self.category
         :building
       end
 
+      # Plugin action available options.
       def self.available_options
         [
           FastlaneCore::ConfigItem.new(key: :path,
@@ -200,6 +218,9 @@ module Fastlane
         ]
       end
 
+      # Check if platform is supported by the action.
+      # @param [Symbol] platform Platform to check.
+      # @return [Boolean] A Boolean indicating whether the platform is supported by the action.
       def self.is_supported?(platform)
         [:ios, :mac].include?(platform)
       end

data/lib/fastlane/plugin/xcconfig_actions/actions/validate_xcconfig_action.rb

@@ -3,7 +3,11 @@ require_relative '../helper/xcconfig_actions_helper'
 
 module Fastlane
   module Actions
+    # Action for validating Xcconfig files.
     class ValidateXcconfigAction < Action
+      # Run action.
+      # @param [Hash] params Action parameters.
+      # @return [Array<String>] List of validation issues.
       def self.run(params)
         path = params[:path]
         root_path = params[:root_path]
@@ -17,9 +21,10 @@ module Fastlane
       ###
 
       # Validate xcconfig file.
-      # @param [String] xcconfig path to xcconfig.
-      # @param [String] root_path root path for all xcconfigs validated in this method.
-      # @param [Array<String>] list of files included so far, used to detect circular includes.
+      # @param [String] xcconfig Path to xcconfig.
+      # @param [String] root_path Root path for all xcconfigs validated in this method.
+      # @param [Array<String>] included_paths List of files included so far, used to detect circular includes.
+      # @param [Int] level Nesting level of xcconfig.
       # @return [Array<String>] list of issues.
       def self.validate_xcconfig(xcconfig, root_path:, included_paths: [], level: 0)
         require "pathname"
@@ -68,18 +73,22 @@ module Fastlane
       # @!group Info and Options
       ###
 
+      # Plugin action description.
       def self.description
         "Validate xcconfig file"
       end
 
+      # Plugin action authors.
       def self.authors
         ["Maksym Grebenets"]
       end
 
+      # Plugin action return value.
       def self.return_value
         "List of validation issues"
       end
 
+      # Plugin action details.
       def self.details
         [
           "Validation rules:",
@@ -91,10 +100,12 @@ module Fastlane
         ].join("\n")
       end
 
+      # Plugin action category.
       def self.category
         :linting
       end
 
+      # Plugin action available options.
       def self.available_options
         [
           FastlaneCore::ConfigItem.new(key: :path,
@@ -116,6 +127,9 @@ module Fastlane
         ]
       end
 
+      # Check if platform is supported by the action.
+      # @param [Symbol] platform Platform to check.
+      # @return [Boolean] A Boolean indicating whether the platform is supported by the action.
       def self.is_supported?(platform)
         [:ios, :mac].include?(platform)
       end

data/lib/fastlane/plugin/xcconfig_actions/helper/xcconfig_actions_helper.rb

@@ -4,15 +4,17 @@ module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?("UI")
 
   module Helper
+    # Helper module for Xcconfig actions plugin.
     class XcconfigActionsHelper
       # Check if shell command exists.
+      # @param [String] cmd Shell command.
+      # @return [Boolean] A Boolean indicating whether the shell command exists.
       def self.command_exist?(cmd)
         `which #{cmd} 2>/dev/null`.chomp != ""
       end
 
       # class methods that you define here become available in your action
       # as `Helper::XcconfigActionsHelper.your_method`
-      #
       def self.show_message
         UI.message("Hello from the xcconfig_actions plugin helper!")
       end
@@ -21,6 +23,8 @@ module Fastlane
       # 'config' containing the hash-map of resolved variables,
       # 'includes' containing an array of include paths.
       # The config values are not resolved.
+      # @param [String] path Xcconfig path.
+      # @return [Hash] Dictionary representing xcconfig.
       def self.read_xcconfig(path)
         # Get rid of comments and blank lines.
         contents = File.read(path).gsub(%r{\s*//.*$}, "").gsub(/^$\n/, "")
@@ -43,6 +47,10 @@ module Fastlane
         }
       end
 
+      # Find xcspec by name.
+      # @param [String] name Xcspec name.
+      # @param [String] xcode Path to Xcode app or Xcode version for version of bundled xcspecs, e.g. "10.2".
+      # @return [String] Path to xcspec file.
       def self.find_xcspec(name, xcode:)
         search_path = File.exist?(xcode) ? File.join(xcode, "Contents/{Plugins,Developer/Platforms/MacOSX.platform/Developer/Library/Xcode/Specifications}") : File.join(File.dirname(__FILE__), "xcspecs", xcode)
 

data/lib/fastlane/plugin/xcconfig_actions/helper/xcspec.rb

@@ -2,23 +2,36 @@ require "plist"
 require "nokogiri-plist"
 
 module Fastlane
+  # Alias for displaying UI messages.
   UI = UI unless Fastlane.const_defined?("UI")
 
+  # Extension for Fastlane::Helper module.
   module Helper
     # Xcspec helper class.
     class Xcspec
       ###
       # @!group Mapping
       ###
+
+      # Class for managing build flags mapping.
       class Mapping
-        attr_reader :flags, :linker_flags
+        # Main tool flags.
+        attr_reader :flags
+
+        # Additional linker flags
+        attr_reader :linker_flags
 
+        # Initialize new mapping.
+        # @param [String] flags Main tool flags.
+        # @param [String] linker_flags Additional linker flags.
         def initialize(flags = "", linker_flags = "")
           @flags = flags
           @linker_flags = linker_flags
         end
 
         # Join with other mapping and return new mapping.
+        # @param [Mapping] other Other mapping to join with.
+        # @return [Mapping] New joined mapping.
         def join(other)
           return self if other.nil?
 
@@ -33,8 +46,15 @@ module Fastlane
       # @!group Initialization
       ###
 
-      attr_reader :path, :options
+      # Path to xcspec file.
+      attr_reader :path
 
+      # @return [Array<Hash>] Xcspec options.
+      attr_reader :options
+
+      # Create new instance.
+      # @param [String] path Path to xcspec file.
+      # @param [Xcspec] core_build_system_spec Core build system spec.
       def initialize(path, core_build_system_spec: nil)
         UI.user_error!("No such file: #{path}") unless path && File.exist?(path)
 
@@ -47,6 +67,9 @@ module Fastlane
         @options += core_build_system_spec.options if core_build_system_spec
       end
 
+      # Load plist as a dictionary.
+      # @param [String] path Path to plist file.
+      # @return [Hash] Plist dictionary.
       def self.load_plist(path)
         file_type = `file -b --mime-type #{path.shellescape}`.chomp
         if file_type == "text/xml" || file_type == "application/xml"
@@ -69,6 +92,9 @@ module Fastlane
       # @!group Helpers
       ###
 
+      # Find option by name.
+      # @param [String] name Option name.
+      # @return [Hash] Option or `nil`.
       def find_option(name)
         @options.find { |o| o["Name"] == name }
       end
@@ -77,6 +103,9 @@ module Fastlane
       # @!group Mapping
       ###
 
+      # Map build settings to build flags.
+      # @param [Hash] build_settings Build settings.
+      # @return [Hash] Build flags.
       def map_build_settings(build_settings)
         # Some settings like ENABLE_TESTABILITY are used as default value for other build settings,
         # e.g. SWIFT_ENABLE_TESTABILITY.
@@ -105,6 +134,11 @@ module Fastlane
         mappings.reduce(Mapping.new) { |memo, m| memo.join(m) }
       end
 
+      # Map single build setting value.
+      # @param [String] name Build setting name.
+      # @param [String] value Build setting value.
+      # @param [Hash] build_settings Dictionary of build settings to resolve the values against.
+      # @return [Array<Mapping>] List of mappings for this build setting value.
       def map_build_setting_value(name, value, build_settings)
         option = find_option(name)
         return nil unless option
@@ -112,6 +146,11 @@ module Fastlane
         map_option(option, value, build_settings)
       end
 
+      # Map the spec option to build settings using the value.
+      # @param [Hash] option Xcspec option describing build setting.
+      # @param [String] value Build setting value.
+      # @param [Hash] build_settings Dictionary of all build settings.
+      # @return [Array<Mapping>] List of mappings.
       def map_option(option, value, build_settings)
         # Evaluate and check the 'Condition'.
         return nil unless check_condition(option, build_settings)
@@ -122,6 +161,11 @@ module Fastlane
         scalar_values.flat_map { |v| map_option_scalar_value(option, v, build_settings) }.compact
       end
 
+      # Map the spec option scalar value to build flags.
+      # @param [Hash] option Xcspec option for build setting.
+      # @param [String] value Scalar value of the build setting.
+      # @param [Hash] build_settings Dictionary of all resolved build settings.
+      # @return [Mapping] Mapping for the specified scalar value.
       def map_option_scalar_value(option, value, build_settings)
         # At this point we deal with scalar value.
 
@@ -196,6 +240,12 @@ module Fastlane
         Mapping.new(flags, linker_flags)
       end
 
+      # Map command line arguments to build flags.
+      # @param [Hash] option Xcspec option for build setting.
+      # @param [Array<String>] args List of arguments to map.
+      # @param [String] value Value of the build setting.
+      # @param [Hash] build_settings All build settings to use for mapping.
+      # @return [String] Resolved value.
       def map_args(option, args, value, build_settings)
         return "" unless args
 
@@ -216,14 +266,24 @@ module Fastlane
         end
       end
 
+      ###
+      # @!group Evaluating Conditions
+      ###
+
       # Constants for condition evaluation.
+
+      # Value to use for `NO`.
       NO = false
+      # Value to use for `YES`.
       YES = true
 
       # Evaluate and check the condition.
       # Conditions come in form like this:
       # "$(COMPILER_INDEX_STORE_ENABLE) == YES  ||  ( $(COMPILER_INDEX_STORE_ENABLE) == Default  &&  $(GCC_OPTIMIZATION_LEVEL) == 0 )"
       # Return true if there's no condition to evaluate.
+      # @param [Hash] option Xcspec option for build setting.
+      # @param [Hash] build_settings All resolved build settings.
+      # @return [Boolean] A Boolean indicating whether condition passes or not.
       def check_condition(option, build_settings)
         condition = option["Condition"]
         return true unless condition
@@ -247,7 +307,7 @@ module Fastlane
         # which are replaced with `true` and `false`.
         # However, xcspecs are very inconsistent when it comes to strings.
         # Some values are used unquoted in the conditions, such as:
-        # Defatult, mh_object, bitcode.
+        # Default, mh_object, bitcode.
         # There's also use of '' and \"\" for empty string, the latter may cause issues.
         # Then "same-as-input" that may have to be resolved - do not handle for now.
         # Finally, $(variant) == profile - just leave it for now.