fastlane-plugin-wpmreleasetoolkit 14.11.1 → 14.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 264531e5928d22e6bf9b73c4857885a01344392511225591d4dae8bd1cc3480a
-  data.tar.gz: f831520911a045538a4c0557eaf65a92c00794a5763ca8db66e33942d53f4a12
+  metadata.gz: 0a1f1e623158a6faef2f63c3376a61d70cdcee25c70ebf91802d0cebdacef0a2
+  data.tar.gz: af2b3f68f2cc761f05a88c676bad63b12b55b44944052e11fe04b210c3421102
 SHA512:
-  metadata.gz: 3dfad31148be24c6265580f275a77551a461b65fba0e89f190505aa24c496f7d95783615e3cb044dab23ec930949a7177c8a4fbffc8b2060a13b70331b15b717
-  data.tar.gz: 9321312c16fa81f7dde696e665863f24211dcbae173049b3d65aa87a4aa57372b1d43a54c0f241393ac6906a99fd14349bf3cb3145f12c35258a2ee7bee8c5e7
+  metadata.gz: daf03a722ae1f03c8b9883a7552ca75d575ff059233eed51cb9368686bf4007a816ac193f89a4892f9d1d36ab3fe0d51ad8e09dd2ad2d0301144db006b478258
+  data.tar.gz: 9c0edbfe34703dbf6dace3a805dc22f639cbd861d8d8f3615129eca857000ce9d516e159bff6413f45c92e2cff5dfd43c9c35a6fedcaef6369f6158e856d2f38

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/publish_github_release_action.rb

@@ -35,7 +35,14 @@ module Fastlane
       end
 
       def self.details
-        'Publish an existing GitHub Release still in draft mode'
+        <<~DETAILS
+          Publish an existing draft GitHub Release.
+
+          If several GitHub Releases share the same `name`, the most recently created one is published,
+          as it is the one targeting the latest commit of the release branch.
+          (Multiple releases can exist with the same `name` when the release finalization automation
+          is run more than once for the same version, each run creating its own draft.)
+        DETAILS
       end
 
       def self.available_options

data/lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -244,8 +244,36 @@ module Fastlane
         release.html_url
       end
 
+      # Returns all the GitHub Releases of a repository matching a given criteria, sorted from the oldest to the most recent one.
+      #
+      # @param [String] repository The repository to fetch the GitHub Releases from. Typically a repo slug (<org>/<repo>).
+      # @yield [Sawyer::Resource] Each GitHub Release of the repository, to decide whether it matches the criteria.
+      # @yieldreturn [TrueClass|FalseClass] `true` to include that GitHub Release in the returned list.
+      # @return [Array<Sawyer::Resource>] The matching GitHub Releases, sorted from the oldest to the most recently created one.
+      #
+      # @note A repository can legitimately host several GitHub Releases sharing the same name or tag—e.g. when `finalize_release`
+      #       is run more than once for the same version, creating one draft per run—and the GitHub API makes no promise about the
+      #       order in which it returns them. Callers must thus pick explicitly amongst the matches instead of relying on that order.
+      # @note The sort key is the release `id`, not `created_at`: once a GitHub Release is published, GitHub rewrites its `created_at`
+      #       to the date of the commit it targets, so `created_at` is not a reliable creation timestamp. Release `id`s, on the other
+      #       hand, are assigned by GitHub in increasing order as releases are created, including for drafts.
+      #
+      def matching_releases(repository:, &matcher)
+        client.releases(repository).select(&matcher).sort_by { |release| release[:id] }
+      end
+
+      # Returns the GitHub Release associated with a given tag, if any, including draft ones.
+      #
+      # @note Unlike a lookup by name, "the most recently created match" is not the right answer here: a git tag can
+      #       only ever back a single *published* release, so if one of the matches is not a draft then it is the
+      #       release owning that tag, and a more recent draft sharing the same `tag_name` is a leftover—typically
+      #       from a re-run of the release finalization—rather than a successor. Only when no published release
+      #       claims the tag yet do we fall back to the most recent draft, which is the case when uploading assets
+      #       to a release that has not been published yet.
+      #
       def find_release(repository:, version:)
-        release = client.releases(repository).find { |candidate| candidate.tag_name == version }
+        matches = matching_releases(repository: repository) { |candidate| candidate.tag_name == version }
+        release = matches.reject { |candidate| candidate[:draft] }.last || matches.last
         return release unless release.nil?
 
         release_for_tag(repository: repository, version: version)
@@ -259,6 +287,7 @@ module Fastlane
         nil
       end
 
+      private :matching_releases
       private :find_release
       private :release_for_tag
 
@@ -306,12 +335,19 @@ module Fastlane
       # @param [Boolean] prerelease Indicates if this should be created as a pre-release (i.e. for alpha/beta)
       #
       # @return [String] URL of the corresponding GitHub Release
+      # @raise [Fastlane::UI::Error] UI.user_error! if no GitHub Release with that name exists.
+      #
+      # @note If several GitHub Releases share that same `name`—which happens when `finalize_release` is run more than once
+      #       for the same version, each run creating its own draft—the most recently created one is the one being published,
+      #       as it is the one targeting the latest commit of the release branch. The other, staler ones are left untouched.
       #
       def publish_release(repository:, name:, prerelease: nil)
-        releases = client.releases(repository)
-        release = releases.find { |r| r.name == name }
+        releases = matching_releases(repository: repository) { |release| release.name == name }
+        UI.user_error!("No release found with name #{name}") if releases.empty?
 
-        UI.user_error!("No release found with name #{name}") unless release
+        release = releases.last
+        UI.important("Found #{releases.count} GitHub Releases named `#{name}`. Publishing the most recently created one, targeting #{release.target_commitish}, and leaving the #{releases.count - 1} older one(s) untouched.") if releases.count > 1
+        UI.important("The most recent GitHub Release named `#{name}` (#{release.html_url}) has already been published. Updating it nonetheless.") unless release.draft
 
         client.update_release(
           release.url,

data/lib/fastlane/plugin/wpmreleasetoolkit/version.rb

@@ -3,6 +3,6 @@
 module Fastlane
   module Wpmreleasetoolkit
     NAME = 'fastlane-plugin-wpmreleasetoolkit'
-    VERSION = '14.11.1'
+    VERSION = '14.11.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wpmreleasetoolkit
 version: !ruby/object:Gem::Version
-  version: 14.11.1
+  version: 14.11.2
 platform: ruby
 authors:
 - Automattic