fastlane-plugin-wpmreleasetoolkit 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22d749d3edd201c7a544486c77eee999cf5c2f4eb6232d575d3dbe7c2bca9371
-  data.tar.gz: 93bfa99fe6595eca9a27a0b900c2fe0bbd9ecaf4c116fd9de8acf8a02c7498fa
+  metadata.gz: 0ea5db89dea2eb4b4879985bc5ee3d716ee8863f340ccc5fc285e34433353c51
+  data.tar.gz: 5aa0d8e024ef9fc4efb28f455be892be78a5fd8ae58fb7b99c60c5f941a8f51f
 SHA512:
-  metadata.gz: c73d585587a42656b6a0f39e60573a38bc73464c15ef20ddc02650e6fb0dca830277f92962ac2d97544ab59ecda388d1a2b31265e17976d846a0c251dbb7e720
-  data.tar.gz: 5a2afb8d0d5f8a835124ebf937be6e67f34686b7e44931e7d843b989c0daf2f69cb782bb530b2adaa23cff8952c5204687217ef4a46e21ae8bf48965963a959e
+  metadata.gz: fb23526af1cee62f484c4629ea986f111ba7c0f0fa64c2a649fc9aa358fb0f5e20f07de899c8da82bea9c7dfed0fa101e2437bb6cb3354cfda0ed38ff4568d84
+  data.tar.gz: e586e3f278be182ea75ce5023e27e2bef958a434d24228280bb8a3a29729e0a49499a26e282592d2ce136019bd02446c5c3b12501fb6b74a01f23fcc8eb983f9

data/ext/drawText/extconf.rb

@@ -33,4 +33,4 @@ FileUtils.cp(compiledPath, destinationPath)
 
 # Delete and overwrite the bundle file
 FileUtils.rm_rf(File.join(libDirectory, 'drawText.bundle'))
-FileUtils.touch(File.join(compilationDirectory, 'drawText.' + RbConfig::CONFIG['DLEXT']))
+FileUtils.touch(File.join(compilationDirectory, "drawText.#{RbConfig::CONFIG['DLEXT']}"))

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb

@@ -1,5 +1,5 @@
 require 'fastlane/action'
-require_relative '../../helper/an_metadata_update_helper.rb'
+require_relative '../../helper/an_metadata_update_helper'
 
 module Fastlane
   module Actions
@@ -23,7 +23,7 @@ module Fastlane
       # Verifies that all the source files are available
       # to this action
       def self.check_source_files(source_files)
-        source_files.values.each do |file_path|
+        source_files.each_value do |file_path|
           UI.user_error!("Couldn't find file at path '#{file_path}'") unless File.exist?(file_path)
         end
       end
@@ -92,7 +92,7 @@ module Fastlane
       # Manages tags depending on the type
       def self.write_target_block(fw, line)
         if is_block_id(line)
-          key = line.split(' ')[1].tr('\"', '')
+          key = line.split[1].tr('\"', '')
           @blocks.each do |block|
             @current_block = block if block.is_handler_for(key)
           end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb

@@ -5,8 +5,8 @@ module Fastlane
         UI.message "Skip confirm: #{params[:skip_confirm]}"
         UI.message "Work on version: #{params[:base_version]}" unless params[:base_version].nil?
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         # Checkout develop and update
         Fastlane::Helper::GitHelper.checkout_and_pull('develop')
@@ -34,10 +34,10 @@ module Fastlane
         # Verify
         message << "Updating branch to version: #{next_beta_version[Fastlane::Helper::Android::VersionHelper::VERSION_NAME]}(#{next_beta_version[Fastlane::Helper::Android::VersionHelper::VERSION_CODE]}) "
         message << "and #{next_alpha_version[Fastlane::Helper::Android::VersionHelper::VERSION_NAME]}(#{next_alpha_version[Fastlane::Helper::Android::VersionHelper::VERSION_CODE]}).\n" unless alpha_release_version.nil?
-        if !params[:skip_confirm]
-          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
-        else
+        if params[:skip_confirm]
           UI.message(message)
+        else
+          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
         end
 
         # Check local repo status

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class AndroidBuildPrechecksAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
 
         UI.user_error!("Can't build beta and final at the same time!") if params[:final] && params[:beta]
 
@@ -18,10 +18,10 @@ module Fastlane
         message << "Building version #{beta_version[Fastlane::Helper::Android::VersionHelper::VERSION_NAME]}(#{beta_version[Fastlane::Helper::Android::VersionHelper::VERSION_CODE]}) (for upload to Beta Channel)\n" if params[:beta]
         message << "Building version #{alpha_version[Fastlane::Helper::Android::VersionHelper::VERSION_NAME]}(#{alpha_version[Fastlane::Helper::Android::VersionHelper::VERSION_CODE]}) (for upload to Alpha Channel)\n" if params[:alpha]
 
-        if !params[:skip_confirm]
-          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
-        else
+        if params[:skip_confirm]
           UI.message(message)
+        else
+          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
         end
 
         # Check local repo status

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_beta.rb

@@ -4,8 +4,8 @@ module Fastlane
       def self.run(params)
         UI.message 'Bumping app release version...'
 
-        require_relative '../../helper/android/android_git_helper.rb'
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_git_helper'
+        require_relative '../../helper/android/android_version_helper'
 
         Fastlane::Helper::GitHelper.ensure_on_branch!('release')
         create_config()

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_final_release.rb

@@ -4,8 +4,8 @@ module Fastlane
       def self.run(params)
         UI.message 'Bumping app release version...'
 
-        require_relative '../../helper/android/android_git_helper.rb'
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_git_helper'
+        require_relative '../../helper/android/android_version_helper'
 
         Fastlane::Helper::GitHelper.ensure_on_branch!('release')
         create_config()

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb

@@ -4,7 +4,7 @@ module Fastlane
       def self.run(params)
         UI.message 'Bumping app release version for hotfix...'
 
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_git_helper'
         Fastlane::Helper::GitHelper.create_branch("release/#{params[:version_name]}", from: params[:previous_version_name])
         create_config(params[:previous_version_name], params[:version_name], params[:version_code])
         show_config()

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_release.rb

@@ -5,8 +5,8 @@ module Fastlane
         # fastlane will take care of reading in the parameter and fetching the environment variable:
         UI.message 'Bumping app release version...'
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         other_action.ensure_git_branch(branch: 'develop')
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_codefreeze_prechecks.rb

@@ -8,8 +8,8 @@ module Fastlane
         # fastlane will take care of reading in the parameter and fetching the environment variable:
         UI.message "Skip confirm on code freeze: #{params[:skip_confirm]}"
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         # Checkout develop and update
         Fastlane::Helper::GitHelper.checkout_and_pull('develop')

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb

@@ -4,8 +4,8 @@ module Fastlane
       def self.run(params)
         UI.message "Skip confirm: #{params[:skip_confirm]}"
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         UI.user_error!('This is not a release branch. Abort.') unless other_action.git_branch.start_with?('release/')
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_xml_release_notes.rb

@@ -2,9 +2,9 @@ module Fastlane
   module Actions
     class AndroidCreateXmlReleaseNotesAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_git_helper'
 
-        release_notes_path = params[:download_path] + '/release_notes.xml'
+        release_notes_path = "#{params[:download_path]}/release_notes.xml"
         open(release_notes_path, 'w') do |f|
           params[:locales].each do |loc|
             puts "Looking for language: #{loc[1]}"

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_current_branch_is_hotfix.rb

@@ -6,7 +6,7 @@ module Fastlane
 
     class AndroidCurrentBranchIsHotfixAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
         Fastlane::Helper::Android::VersionHelper.is_hotfix?(Fastlane::Helper::Android::VersionHelper.get_release_version)
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_file_by_version.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class AndroidDownloadFileByVersionAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_localize_helper.rb'
+        require_relative '../../helper/android/android_localize_helper'
         require_relative '../../helper/github_helper'
 
         version = Fastlane::Helper::Android::VersionHelper.get_library_version_from_gradle_config(import_key: params[:import_key])

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb

@@ -4,8 +4,8 @@ module Fastlane
   module Actions
     class AndroidDownloadTranslationsAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_localize_helper.rb'
-        require_relative '../../helper/git_helper.rb'
+        require_relative '../../helper/android/android_localize_helper'
+        require_relative '../../helper/git_helper'
 
         res_dir = File.join(ENV['PROJECT_ROOT_FOLDER'] || '.', params[:res_dir])
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_finalize_prechecks.rb

@@ -8,17 +8,17 @@ module Fastlane
       def self.run(params)
         UI.message "Skip confirm: #{params[:skip_confirm]}"
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         UI.user_error!('This is not a release branch. Abort.') unless other_action.git_branch.start_with?('release/')
 
         version = Fastlane::Helper::Android::VersionHelper.get_public_version
         message = "Finalizing release: #{version}\n"
-        if !params[:skip_confirm]
-          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
-        else
+        if params[:skip_confirm]
           UI.message(message)
+        else
+          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
         end
 
         # Check local repo status

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_get_alpha_version.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class AndroidGetAlphaVersionAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
         Fastlane::Helper::Android::VersionHelper.get_alpha_version()
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_get_app_version.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class AndroidGetAppVersionAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
         Fastlane::Helper::Android::VersionHelper.get_public_version
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_get_release_version.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class AndroidGetReleaseVersionAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_version_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
         Fastlane::Helper::Android::VersionHelper.get_release_version()
       end
 

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_hotifx_prechecks.rb

@@ -5,8 +5,8 @@ module Fastlane
         UI.message "Skip confirm: #{params[:skip_confirm]}"
         UI.message ''
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         # Evaluate previous tag
         new_ver = params[:version_name]
@@ -16,10 +16,10 @@ module Fastlane
         message = "Requested Hotfix version: #{new_ver}\n"
         message << "Branching from: #{prev_ver}\n"
 
-        if !params[:skip_confirm]
-          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
-        else
+        if params[:skip_confirm]
           UI.message(message)
+        else
+          UI.user_error!('Aborted by user request') unless UI.confirm("#{message}Do you want to continue?")
         end
 
         # Check tags

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb

@@ -21,7 +21,7 @@ module Fastlane
 
         UI.message("Merging in: #{strings_folder}")
 
-        tmp_main_file = main_file + '.tmp'
+        tmp_main_file = "#{main_file}.tmp"
         FileUtils.cp(main_file, tmp_main_file)
 
         join_files = Dir.glob(File.join(strings_folder, 'strings-*.xml'))

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_tag_build.rb

@@ -2,8 +2,8 @@ module Fastlane
   module Actions
     class AndroidTagBuildAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/android/android_git_helper'
 
         release_ver = Fastlane::Helper::Android::VersionHelper.get_release_version()
         alpha_ver = Fastlane::Helper::Android::VersionHelper.get_alpha_version() unless ENV['HAS_ALPHA_VERSION'].nil?

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_metadata.rb

@@ -6,7 +6,7 @@ module Fastlane
 
     class AndroidUpdateMetadataAction < Action
       def self.run(params)
-        require_relative '../../helper/android/android_git_helper.rb'
+        require_relative '../../helper/android/android_git_helper'
 
         Fastlane::Helper::Android::GitHelper.update_metadata(ENV['validate_translations'])
       end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_release_notes.rb

@@ -4,9 +4,9 @@ module Fastlane
       def self.run(params)
         UI.message 'Updating the release notes...'
 
-        require_relative '../../helper/android/android_version_helper.rb'
-        require_relative '../../helper/release_notes_helper.rb'
-        require_relative '../../helper/git_helper.rb'
+        require_relative '../../helper/android/android_version_helper'
+        require_relative '../../helper/release_notes_helper'
+        require_relative '../../helper/git_helper'
 
         path = File.join(ENV['PROJECT_ROOT_FOLDER'] || '.', 'RELEASE-NOTES.txt')
         next_version = Fastlane::Helper::Android::VersionHelper.calc_next_release_short_version(params[:new_version])

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_for_toolkit_updates_action.rb

@@ -0,0 +1,99 @@
+require 'fastlane/action'
+require 'rubygems/command_manager'
+
+module Fastlane
+  module Actions
+    class CheckForToolkitUpdatesAction < Action
+      TOOLKIT_SPEC_NAME = 'fastlane-plugin-wpmreleasetoolkit'.freeze
+
+      def self.run(params)
+        updater = Gem::CommandManager.instance[:update]
+        installed_gems = updater.highest_installed_gems.select { |spec| spec == TOOLKIT_SPEC_NAME }
+        local_version = Gem::Version.new(installed_gems[TOOLKIT_SPEC_NAME].version)
+        UI.message("Currently using release toolkit version #{local_version.to_s.yellow}.")
+        UI.message('Checking for updates now...')
+        updates_needed = updater.which_to_update(installed_gems, [TOOLKIT_SPEC_NAME])
+
+        if updates_needed.empty?
+          UI.success('Your release toolkit is up-to-date! ✅')
+          return nil
+        end
+
+        # Return type of which_to_update differs before/after RubyGems 3.1.0, so normalize to always use Gem::NameTuple
+        updates_needed = Gem::NameTuple.from_list(updates_needed)
+        latest_version = updates_needed.find { |gem_info| gem_info.name == TOOLKIT_SPEC_NAME }.version
+
+        UI.message(['There is a newest version '.yellow, latest_version.to_s.red, ' of the release toolkit!'.yellow].join)
+        warn_on_breaking_update(local_version, latest_version)
+
+        return latest_version if params[:skip_update_suggestion] || !UI.confirm('Do you want to run bundle update now?')
+
+        sh('bundle', 'update', TOOLKIT_SPEC_NAME)
+        UI.abort_with_message! <<~UPDATE_MESSAGE
+          #{TOOLKIT_SPEC_NAME} have been updated. Please check and commit the changes in your Gemfile.lock file,
+          then restart your previous invocation of fastlane to use the new toolkit.
+        UPDATE_MESSAGE
+      end
+
+      def self.warn_on_breaking_update(current_version, latest_version)
+        current_semver_requirement = Gem::Requirement.new(current_version.approximate_recommendation)
+        compatible_update = current_semver_requirement.satisfied_by?(latest_version)
+        return if compatible_update
+
+        new_semver_requirement = latest_version.approximate_recommendation
+        UI.important <<~BREAKING_CHANGE_MESSAGE
+          The latest version available (#{latest_version}) introduces breaking changes compared to the #{current_version} you are currently using.
+
+           - To update to #{latest_version}, first edit your \`Pluginfile\` to use '#{new_semver_requirement}', run \`bundle update\`,
+             then be sure to make all the necessary changes to your \`Fastfile\` (see the toolkit's CHANGELOG)
+             to take those breaking changes into account.
+
+           - If you are not ready to make the major version bump, you can still try to update to the latest compatible,
+             non-breaking version by running \`bundle update\` now. This will not update to the latest #{latest_version}, but
+             might still update to a newer version compatible with '#{current_semver_requirement}' if one exists; which is still valuable
+             to at least get bugfixes, until you are ready to jump to the next major version later.
+        BREAKING_CHANGE_MESSAGE
+      end
+
+      def self.description
+        'Check that we are on the latest version of the release toolkit, and propose to update if not'
+      end
+
+      def self.authors
+        ['Olivier Halligon']
+      end
+
+      def self.return_value
+        'Returns the latest version of the toolkit available if your toolkit is not up-to-date, or nil if you are already up-to-date.'
+      end
+
+      def self.details
+        <<~DETAILS
+          Check that we are on the latest version of the release toolkit, and propose to update if not.
+
+          This action will check if you are on the *latest* version, regardless of the version requirement restriction you might have
+          set in your Gemfile/Pluginfile; which means that even if you agree to the prompt suggesting you to run bundle update, it might not
+          actually end up updating to the *latest* version automatically (esp. if the latest introduces breaking changes).
+
+          Note that if it finds an update and you then agree to the prompt and run bundle update, the action will abort your fastlane invocation
+          after running bundle update. This will let you check and commit the changes, before restarting the lane by re-invoking fastlane.
+          This is also needed to ensure fastlane loads the new toolkit version after update on second run.
+        DETAILS
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(key: :skip_update_suggestion,
+                                       env_name: 'CHECK_FOR_TOOLKIT_UPDATES_SKIP_UPDATE_SUGGESTION',
+                                       description: 'If true, will still check for new versions, but will not ask if you want to run bundle update if an update is found',
+                                       is_string: false, # Boolean
+                                       default_value: false),
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/circleci_trigger_job_action.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class CircleciTriggerJobAction < Action
       def self.run(params)
-        require_relative '../../helper/ci_helper.rb'
+        require_relative '../../helper/ci_helper'
 
         UI.message "Triggering job #{params[:job_params]} on branch #{params[:branch]}"