fastlane-plugin-wait_xcrun 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67da3a0ba4896db2e1554b81c2b6bd0522dcaf4b
-  data.tar.gz: 3fccb1e069353bd63d6db38af1ca90c95ca36413
+  metadata.gz: 16f8bc77c0a635e55d37cf62b699a30fff47989e
+  data.tar.gz: f8aed4bb27b10a438d855f19b84ae1b6f79a3c40
 SHA512:
-  metadata.gz: af56741b19c79e7bb1cf669d0a06b1be7b1bbc32d6d8bd58cf09f37007b1aff56482959702a53de340be130dd3f382133919df73824844ac4fe52c845e44b0c7
-  data.tar.gz: 6eb5fdb6d89fb3aa5f931c1bfc38eb50199d83f5f3a2e0ac483149d193dbd93396d475285376a38e2d1ded294a559f1f2294ba25ad67f4cbcfbafba209ae7d9f
+  metadata.gz: b05e1568a6a8ec2f13bb558e20f2caf0b38ec5e2205211c97e7df5b7e65799301f4a303c0233a63e5351f14714b01a3599028dff4975f3b71654f8fe42d19e51
+  data.tar.gz: 6a9d65bd140fde73af7ee449d2507ae37b2f52b27918b701d5614c80996058cb59c547b571e2d5910ffcb9807124fd4692095664c83b84f49b7b3c191e3c46af

data/LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016 Maksym Grebenets <maksym.grebenets@cba.com.au>
+Copyright (c) 2016 Maksym Grebenets <mgrebenets@gmail.com>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -14,13 +14,24 @@ fastlane add_plugin wait_xcrun
 
 Wait for Xcode toolchain to come back online after switching Xcode versions.
 
-**Note to author:** Add a more detailed description about this plugin here. If your plugin contains multiple actions, make sure to mention them here.
+In particular, the plugin is designed to help with issues like this: https://github.com/fastlane/fastlane/issues/5435.
+
+This kind of issue often happens on CI servers, for example when previous build was using Xcode 7.3.1 and next build is using Xcode 8. Switching Xcode version can cause Xcode toolchain commands to fail.
 
 ## Example
 
-Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`. 
+Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`.
+
+The recommended way is to call `wait_xcrun` in `before_all` hook, but _after_ the `DEVELOPER_DIR` environment variable has been set.
 
-**Note to author:** Please set up a sample project to make it easy for users to explore what your plugin does. Provide everything that is necessary to try out the plugin in this project (including a sample Xcode/Android project if necessary)
+```ruby
+before_all do
+  # Make sure proper Xcode version is selected by CI server
+  # or by setting DEVELOPER_DIR environment variable
+
+  wait_xcrun
+end
+```
 
 ## Run tests for this plugin
 
@@ -30,11 +41,20 @@ To run both the tests, and code style validation, run
 rake
 ```
 
-To automatically fix many of the styling issues, use 
+To automatically fix many of the styling issues, use
 ```
 rubocop -a
 ```
 
+To see the real issue "in action", make sure you have both Xcode 8 and Xcode 7.3.1 installed in `/Applications`.
+Specify the name of Xcode 8 and Xcode 7.3.1 apps without the `.app` extension using `prev_xcode` and `next_xcode` options and run `switch_xcode_test` lane.
+
+```shell
+# In this example Xcode 8 is installed to /Applications/Xcode.app
+# Xcode 7.3.1 is installed to /Applications/Xcode7.3.1.app
+bundle exec fastlane switch_xcode_test prev_xcode:Xcode next_xcode:Xcode7.3.1
+```
+
 ## Issues and Feedback
 
 For any other issues and feedback about this plugin, please submit it to this repository.

data/lib/fastlane/plugin/wait_xcrun/actions/wait_xcrun_action.rb

@@ -7,12 +7,13 @@ module Fastlane
         retry_count = 0
         loop do
           system("xcrun simctl help 2>/dev/null 1>/dev/null")
-          break if $?.exitstatus == 0 || retry_count >= 10
+          break if $?.success? || retry_count >= 10
+          UI.important("Xcode toochain is not ready yet. Retrying ...")
           sleep(1) # Take a short break
           retry_count += 1
         end
 
-        $?.exitstatus == 0 ? UI.success("Xcode is back online!") : UI.user_error("Xcode toolchain is offline.")
+        $?.success? ? UI.success("Xcode toolchain is back online!") : UI.user_error!("Xcode toolchain is offline.")
       end
 
       def self.description

data/lib/fastlane/plugin/wait_xcrun/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module WaitXcrun
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-wait_xcrun
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Maksym Grebenets
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-25 00:00:00.000000000 Z
+date: 2017-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Wait for Xcode toolchain to come back online after switching Xcode versions.