fastlane-plugin-versioning_android 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 15bae969f46be3a8a3e83bd25718d261ab19fdbf
-  data.tar.gz: 4c8ded404085de387760b4aaf047f57509965b44
+SHA256:
+  metadata.gz: f579270ad456e0040fc01cf9551f47b9021bba4dd71b628e8aab1d4d45e08b99
+  data.tar.gz: d06125c50eb443ee7c02a05d199c0e805d6056681114c9614dc745b4494fbbf1
 SHA512:
-  metadata.gz: 000f1388360a17d8f631cca27e65a9e112967e3b9270ca96a1ae52cdd5f1c2bfb6d2c7315d675a635e607cb0ca36c962d97af49d9e07578535b77e6a7a007887
-  data.tar.gz: 3a40ecde89768df83e6cc141b57962784f16375812ad3a968d4aba452b40795fcdf70fbd86c31f14a9f295c80f0e9a3412c099571bbd356a842d8235a5e132ed
+  metadata.gz: 615e6e368ff5da83b8233a83aa5a94f41f8b626b24cb94eaccc584ad2de95158df75405ee194e746624cf429dcac0c77952d1cc75f847dbb5b115194034e3ac0
+  data.tar.gz: 0e6179b2386237fabe5d008bb3a7a467e38430c88cc6857f7a05a1c03469a48dfba76da725adff0c2feb473c1b03c858f24c1f616099880da62fee69f3b12a29

data/README.md

@@ -1,5 +1,6 @@
 # versioning_android plugin
 
+[![Build Status](https://travis-ci.org/beplus/fastlane-plugin-versioning_android.svg?branch=master)](https://travis-ci.org/beplus/fastlane-plugin-versioning_android)
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-versioning_android)
 
 ## Getting Started
@@ -12,9 +13,12 @@ fastlane add_plugin versioning_android
 
 ## About versioning_android
 
-Android Versioning Plugin for Fastlane
+Android Versioning Plugin for Fastlane - easily Get / Set `versionCode` and `versionName` on your Android project.
+
+**Note**: If you need to work with `Build Number` and `Version` on iOS, see [versioning_ios](https://github.com/beplus/fastlane-plugin-versioning_ios)
 
 ### Available actions
+
 - `android_get_version_code` to get the Version Code
 - `android_get_version_name` to get the Version Name
 - `android_set_version_code` to set the new Version Code
@@ -24,7 +28,9 @@ Android Versioning Plugin for Fastlane
 
 Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`.
 
-You can find a fully functional setup of this plugin in the [UdemyFastlane](https://github.com/igorlamos/udemy-fastlane) repo, where you can also find more info about versioning of Android apps.
+### Example project
+
+**@todo** You can find a fully functional setup of this plugin in the [UdemyFastlane](https://github.com/igorlamos/udemy-fastlane) repo, where you can also find more info about versioning of Android apps.
 
 ## Run tests for this plugin
 
@@ -35,13 +41,22 @@ rake
 ```
 
 To automatically fix many of the styling issues, use
+
 ```
 rubocop -a
 ```
 
 ## Issues and Feedback
 
-For any other issues and feedback about this plugin, please submit it to this repository.
+### Flutter
+
+The `android_set_version_name` action on Flutter requires a different usage when setting a specific version.
+
+To avoid setting a numeral instead of a string in the build.gradle file, the `version_name` argument (string) needs to be wrapped in quotes:
+
+```rb
+android_set_version_name(version_name: '"1.23.4"')
+```
 
 ## Troubleshooting
 

data/lib/fastlane/plugin/versioning_android/actions/android_set_version_name.rb

@@ -7,7 +7,7 @@ module Fastlane
     class AndroidSetVersionNameAction < Action
       def self.run(params)
         gradle_file_path = Helper::VersioningAndroidHelper.get_gradle_file_path(params[:gradle_file])
-        new_version_name = Helper::VersioningAndroidHelper.get_new_version_name(gradle_file_path, params[:version_name])
+        new_version_name = Helper::VersioningAndroidHelper.get_new_version_name(gradle_file_path, params[:version_name], params[:bump_type])
         # bump_type ||= params[:bump_type]
 
         saved = Helper::VersioningAndroidHelper.save_key_to_gradle_file(gradle_file_path, "versionName", new_version_name)

data/lib/fastlane/plugin/versioning_android/helper/versioning_android_helper.rb

@@ -13,7 +13,7 @@ module Fastlane
 
       def self.get_gradle_file_path(gradle_file)
         gradle_file = self.get_gradle_file(gradle_file)
-        return File.expand_path(gradle_file).shellescape
+        return File.expand_path(gradle_file)
       end
 
       def self.get_new_version_code(gradle_file, new_version_code)
@@ -27,20 +27,20 @@ module Fastlane
 
       def self.get_new_version_name(gradle_file, new_version_name, bump_type = nil)
         if new_version_name.nil?
-          current_version_name = self.read_key_from_gradle_file(gradle_file, "versionName")
-          current_version_parts = current_version_name.split(/[.]/)
+          new_version_name = self.read_key_from_gradle_file(gradle_file, "versionName")
+        end
 
-          major = current_version_parts[0].to_i
-          minor = current_version_parts[1].to_i
-          patch = current_version_parts[2].to_i
+        current_version_parts = new_version_name.split(/[.]/)
+        major = current_version_parts[0].to_i
+        minor = current_version_parts[1].to_i
+        patch = current_version_parts[2].to_i
 
-          if bump_type == "major"
-            new_version_name = "#{major + 1}.0.0"
-          elsif bump_type == "minor"
-            new_version_name = "#{major}.#{minor + 1}.0"
-          elsif bump_type == "patch"
-            new_version_name = "#{major}.#{minor}.#{patch + 1}"
-          end
+        if bump_type == "major"
+          new_version_name = "#{major + 1}.0.0"
+        elsif bump_type == "minor"
+          new_version_name = "#{major}.#{minor + 1}.0"
+        elsif bump_type == "patch"
+          new_version_name = "#{major}.#{minor}.#{patch + 1}"
         end
 
         return new_version_name.to_s

data/lib/fastlane/plugin/versioning_android/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module VersioningAndroid
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-versioning_android
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Igor Lamos
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-21 00:00:00.000000000 Z
+date: 2023-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -122,7 +122,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.66.0
-description: 
+description:
 email: igor@be.plus
 executables: []
 extensions: []
@@ -141,7 +141,7 @@ homepage: https://github.com/beplus/fastlane-plugin-versioning_android
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -156,9 +156,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: Android Versioning Plugin for Fastlane
 test_files: []