fastlane-plugin-verify_ipa_with_app_store_connect 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dfab198795b0518959e8e54de8822d3ddbf5bb0da5e8eb612aada16e2f9c0995
-  data.tar.gz: ef3b1b81020360fd6d770d32e8e92f662a0f8ece631448f84ed6dbe4b8968d27
+  metadata.gz: 0677a740aa7e0b8d0ac48463cf7052253af3cef440ee5e2758df2d6f4814eb3d
+  data.tar.gz: f6e825799386e0b44a15ab9f8d38cdd30745c62129e876945977cf975e0e2088
 SHA512:
-  metadata.gz: 59faf9c81212b6ca293aa35d8fcea70b532689259c757f187edd23dee2b665157a268bdfe51747cafd60ef0335f5420d7090acbf41d4f9e6eb0e0bb2ecb72032
-  data.tar.gz: a00f9eaefe17c4d3e1f370380e4bd9a882ed856b92b729e72e29bdd7ba411664b12b09ff002f3749292ca4564c9247113a0b56d65d6ef5ea492b30e2a8476311
+  metadata.gz: 0616f4a88ccad1d278a2f1f8e53eddb15aa1dcd6d9eb6a5815ad3e9617c31cbca96d87fa0a55e9f38aff819adcbd716cec3d6c6cda4a1cb81cab3b0a203a86cf
+  data.tar.gz: 7e2fa4e2547a62181915c99261a93ee202a1a205d4fda6538187648efdfb8dc5c79c807fa8bcee6fe485535ffa3aa0bdfa950dca0c82eab54b2ff2a7a7c8da72

data/lib/fastlane/plugin/verify_ipa_with_app_store_connect/actions/verify_ipa_with_app_store_connect_action.rb

@@ -5,59 +5,52 @@ module Fastlane
   module Actions
     class VerifyIpaWithAppStoreConnectAction < Action
       def self.run(params)
-        UI.message "Parameter ipa_path: #{params[:ipa_path]}"
+        ipa_path = params[:ipa_path]
 
-        app = find_app(params)
-
-        package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
-          app_id: app.id,
-          ipa_path: params[:ipa_path],
-          package_path: "/tmp",
-          platform: params[:platform]
-        )
+        UI.message "Parameter ipa_path: #{ipa_path}"
 
         api_token = params[:api_token]
-        transporter = FastlaneCore::JavaTransporterExecutor.new
 
-        command = [
-          'xcrun iTMSTransporter',
-          '-m verify',
-          "-jwt #{api_token.text}",
-          "-f #{package_path.shellescape}",
-          '2>&1' # cause stderr to be written to stdout
-        ].compact.join(' ') # compact gets rid of the possibly nil ENV value
+        transporter = FastlaneCore::AltoolTransporterExecutor.new
+
+        api_key = { key_id: api_token.key_id, issuer_id: api_token.issuer_id, key: api_token.key_raw }
+
+        api_key = api_key.clone
+        api_key[:key_dir] = Dir.mktmpdir("deliver-")
+        # Specified p8 needs to be generated to call altool
+        File.open(File.join(api_key[:key_dir], "AuthKey_#{api_key[:key_id]}.p8"), "wb") do |p8|
+          p8.write(api_key[:key])
+        end
 
+        command = [
+          "API_PRIVATE_KEYS_DIR=#{api_key[:key_dir]}",
+          "xcrun altool",
+          "--validate-app",
+          "--apiKey #{api_key[:key_id]}",
+          "--apiIssuer #{api_key[:issuer_id]}",
+          "-t #{params[:platform]}",
+          "-f #{ipa_path.shellescape}",
+          "-k 100000"
+        ].compact.join(' ')
 
         UI.verbose(command)
 
-        result = transporter.execute(command, false)
+        begin
+          result = transporter.execute(command, false)
+        ensure
+          FileUtils.rm_rf(api_key[:key_dir])  # we don't need the file with the api key any more
+          # FileUtils.rm_rf(package_path) # we don't need the ipa any more
+        end
 
         if result
           UI.header("Successfully verified package with App Store Connect.")
         end
 
-        FileUtils.rm_rf(package_path) unless Helper.test? # we don't need the package any more
-
         unless result
           UI.user_error!("Error verifying ipa file!")
         end
       end
 
-      def self.find_app(options)
-        app_identifier = options[:app_identifier]
-
-        if !app_identifier.to_s.empty?
-          Spaceship::ConnectAPI.token = options[:api_token]
-          app = Spaceship::ConnectAPI::App.find(app_identifier)
-        end
-
-        if app
-          return app
-        else
-          UI.user_error!("Could not find app with app identifier '#{options[:app_identifier]}' in your App Store Connect account")
-        end
-      end
-
       #####################################################
       # @!group Documentation
       #####################################################
@@ -72,11 +65,6 @@ module Fastlane
 
       def self.available_options
         [
-          FastlaneCore::ConfigItem.new(key: :app_identifier,
-                                       env_name: "FL_VERIFY_IPA_APP_IDENTIFIER",
-                                       description: "Provide the app identifier",
-                                       is_string: true, # true: verifies the input is a string, false: every kind of value
-                                       default_value: false), # the default value if the user didn't provide one
           FastlaneCore::ConfigItem.new(key: :ipa_path,
                                        env_name: "FL_VERIFY_IPA_IPA_PATH",
                                        description: "Path to the ipa file to validate",

data/lib/fastlane/plugin/verify_ipa_with_app_store_connect/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module VerifyIpaWithAppStoreConnect
-    VERSION = "0.1.0"
+    VERSION = "1.0.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-verify_ipa_with_app_store_connect
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Onno Bergob
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-30 00:00:00.000000000 Z
+date: 2022-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -128,15 +128,15 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.174.0
+        version: 2.210.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.174.0
-description: 
+        version: 2.210.1
+description:
 email: oonoo@github.com
 executables: []
 extensions: []
@@ -152,7 +152,7 @@ homepage: https://github.com/oonoo/verify_ipa_with_app_store_connect
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -167,8 +167,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
-summary: Uses iTMSTransporter to verify an ipa with App Store Connect.
+summary: Uses altool to verify an ipa with App Store Connect.
 test_files: []