fastlane-plugin-validate_ipa 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d3337d4e7227f864a4b647a22950e03e7a881846757a0801b57888b17a757b9
-  data.tar.gz: e466eaaebb6f04fee0935064d3b267e7fdf15b7a3d633c334c22f6d507266efa
+  metadata.gz: 3497a90c150e14d70cdbe85e12933e2146ce59bb61801b0cf4099170c8f5444c
+  data.tar.gz: 0a60e50657dc78dd8a0303bdcadc5ffd176001bff5c0489653d23166659ff48f
 SHA512:
-  metadata.gz: f8a4390928714d98da1b82ac614c9d0ac2f153217567be1ff1d3798b2051730165cf49254ec7dc0c0d25de538e60e14db01a7c0582aa856af05bbd18f0f0d479
-  data.tar.gz: 3066dc3d1ac55be220ee238d6df817bc0c826d216a64042072f545b8e4c53968592071d8d993ec6f2f97eafe7fd0d8e17a6b8a99646b50c5f835262ed8f87c8f
+  metadata.gz: bb8c48e7411e67a46204a8cc3e73cd4848c43ba01c8166e3fc6b5eb6165762d40bee818830b32aff05433bcac22cba83369a76f50322abdbcf66fbda40f7d95c
+  data.tar.gz: 9f1b241d071c8f4c5096c31978faab09e8fce74748c89e366d72e8fad1eae407741a20f936b71f04c922a7695aeb8d6b7d6cc99aa47e03dd7fa37113a3cc8743

data/README.md

@@ -1,59 +1,52 @@
 # validate_ipa plugin
 
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-validate_ipa)
+[![Gem Version](https://badge.fury.io/rb/fastlane-plugin-validate_ipa.svg)](https://rubygems.org/gems/fastlane-plugin-validate_ipa)
 
-## Getting Started
+## About
 
-This project is a [_fastlane_](https://github.com/fastlane/fastlane) plugin. To get started with `fastlane-plugin-validate_ipa`, add it to your project by running:
+A [fastlane](https://github.com/fastlane/fastlane) plugin that validates IPA files using Apple's `altool`.
+
+This plugin improves upon the [validate_app](https://github.com/fastlane-community/fastlane-plugin-validate_app) plugin, which is no longer maintained. If your Apple ID uses two-factor authentication, pass an [app-specific password](https://support.apple.com/en-us/102654).
+
+## Installation
 
 ```bash
 fastlane add_plugin validate_ipa
 ```
 
-## About validate_ipa
+Or add to your `Gemfile`:
 
-Validate the IPA using altool. Improved the [validate_app](https://github.com/fastlane-community/fastlane-plugin-validate_app) plugin, which is no longer maintained. If your Apple ID is using Two-factor authentication, you will need to pass an app-specific password.
-
-## Example
+```ruby
+gem 'fastlane-plugin-validate_ipa'
+```
 
-Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`. 
+## Usage
 
 ```ruby
-lane :test do
+lane :validate do
   validate_ipa(
-    path: "result/test.ipa",
+    path: "build/MyApp.ipa",
     platform: "ios",
-    username: "username",
-    password: "password" 
+    username: "your@apple.id",
+    password: "app-specific-password"
   )
 end
 ```
 
-## Run tests for this plugin
-
-To run both the tests, and code style validation, run
+### Parameters
 
-```
-rake
-```
-
-To automatically fix many of the styling issues, use
-```
-rubocop -a
-```
+| Key | Description | Env Var | Required |
+|-----|-------------|---------|----------|
+| `path` | Path to the IPA file | `FL_VALIDATE_IPA_PATH` | Yes |
+| `platform` | Target platform (`ios` or `macos`) | `FL_VALIDATE_IPA_PLATFORM` | Yes |
+| `username` | Apple ID | `FL_VALIDATE_IPA_USERNAME` | Yes |
+| `password` | Apple ID or app-specific password | `FL_VALIDATE_IPA_PASSWORD` | Yes |
 
 ## Issues and Feedback
 
-For any other issues and feedback about this plugin, please submit it to this repository.
-
-## Troubleshooting
-
-If you have trouble using plugins, check out the [Plugins Troubleshooting](https://docs.fastlane.tools/plugins/plugins-troubleshooting/) guide.
-
-## Using _fastlane_ Plugins
-
-For more information about how the `fastlane` plugin system works, check out the [Plugins documentation](https://docs.fastlane.tools/plugins/create-plugin/).
+For any issues and feedback, please [open an issue](https://github.com/binaryloader/fastlane-plugin-validate_ipa/issues).
 
-## About _fastlane_
+## License
 
-_fastlane_ is the easiest way to automate beta deployments and releases for your iOS and Android apps. To learn more, check out [fastlane.tools](https://fastlane.tools).
+This plugin is available under the MIT license. See the [LICENSE](LICENSE) file for details.

data/lib/fastlane/plugin/validate_ipa/actions/validate_ipa_action.rb

@@ -24,8 +24,13 @@ module Fastlane
         split_result = output.split("\n")
         result = split_result[-1]
         plist = Plist.parse_xml(result)
+
+        if plist.nil?
+          UI.user_error!("Failed to parse altool output. Raw output:\n#{output}")
+        end
+
         errors = plist["product-errors"]
-        
+
         if errors.nil?
           UI.success("IPA validation success => " + plist["success-message"])
         else

data/lib/fastlane/plugin/validate_ipa/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module ValidateIpa
-    VERSION = "1.0.3"
+    VERSION = "1.0.4"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-validate_ipa
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - binaryloader