fastlane-plugin-validate_app 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b8d3e8ef9b50f594618caeb2ca5d1a5bccafacb4
-  data.tar.gz: 0440afb4eb950734887b220d7b3485cfe407cc5e
+SHA256:
+  metadata.gz: 23f1630229f7d4a28178a8e9f1aae956b172f77b34cf97de10827adbb86d548d
+  data.tar.gz: 0036edf06288f78fe88fa9742f01c38feef1cab8e7209c864e3587edd410ce0c
 SHA512:
-  metadata.gz: e968f314c198c645a7d92544df4420fa839cbbb0e53ca15e1598920b9ea433ab47b60a9648832e4befab5dbddc94463fef083df7ef7366e25ac9a4338a353c7a
-  data.tar.gz: 76145fa0cae4012f3d0c0d0dbf6e05022871665b80e551a264e9eab3d6587f4ec58942b848a31175bdb9540bcc95fbd292ca969c9bbb9115c3c414fee34481f9
+  metadata.gz: 6e28d8635adbf958cb1bd5bea00001346571218550514ea1fc38fd385951579a554af5f3d39b282a8ae49713a9a8da9c2f5fdd7193f55307c7d98f3c6f66bbda
+  data.tar.gz: fcbd928cd3533aab6422b5f0fb91f4ee93aebecbd417dccca2ccec67b2ba3af9a0b4de940670a67773e93c5bc082a5e9c8c46dfeb7823bab0f7202577163a8e3

data/lib/fastlane/plugin/validate_app/actions/validate_app_action.rb

@@ -10,31 +10,30 @@ module Fastlane
         xcode_contents_path = `dirname "$(xcode-select --print-path)"`.strip
         altool = "#{xcode_contents_path}/Applications/Application Loader.app/Contents/Frameworks/ITunesSoftwareService.framework/Support/altool".shellescape
 
+        ENV["VALIDATE_APP_PASSWORD"] = ENV["FASTLANE_PASSWORD"] || ENV["DELIVER_PASSWORD"] || self.fetch_password_from_keychain
+
         ipa = params[:ipa].to_s.shellescape
+        username = params[:username]
+        password = "@env:VALIDATE_APP_PASSWORD"
 
         UI.message("Validating #{ipa}. This may take a while.")
 
-        password = "@env:DELIVER_PASSWORD" if ENV["DELIVER_PASSWORD"].to_s.length > 0
-        password = "@env:FASTLANE_PASSWORD" if ENV["FASTLANE_PASSWORD"].to_s.length > 0
-
-        if password.to_s.empty?
-          password = self.fetch_password_from_keychain
-        end
-
         command = [altool]
         command << "--validate-app"
         command << "--file"
         command << ipa
-        command << "--username #{params[:username]}"
+        command << "--username"
+        command << username
         command << "--password"
         command << password
         command << "--output-format xml"
 
-        plist = Plist.parse_xml(`#{command.join(' ')}`)
+        result = Actions.sh(command.join(' '))
+        plist = Plist.parse_xml(result)
         errors = plist["product-errors"]
 
         if errors.nil?
-          UI.success("IPA file is valid. Ready to be uploaded to iTunes Connect!")
+          UI.success(plist["success-message"])
           return nil
         end
 
@@ -84,7 +83,7 @@ module Fastlane
                                        description: "Path to the ipa file to validate",
                                        is_string: true,
                                        default_value: Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last,
-                                       optional: false,
+                                       optional: true,
                                        verify_block: proc do |value|
                                          value = File.expand_path(value)
                                          UI.user_error!("could not find ipa file at path '#{value}'") unless File.exist?(value)
@@ -96,7 +95,7 @@ module Fastlane
                                        description: "Your Apple ID username",
                                        is_string: true,
                                        default_value: @user,
-                                       optional: false)
+                                       optional: true)
         ]
       end
 

data/lib/fastlane/plugin/validate_app/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module ValidateApp
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-validate_app
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Thi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-20 00:00:00.000000000 Z
+date: 2018-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -168,7 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Validate your build before uploading to iTunes Connect