fastlane-plugin-taiwan_number_one 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1747d4598e6ab056cc1250a135c930e0f551e990c2d9c700a64ec920c393fcd
-  data.tar.gz: 8cf6b8d22266a4a98cee49e9dce576a9667bb8417b6858adc2be0aead9378651
+  metadata.gz: bb753f703cb1ca29144e73ab02075eef0ba777a23005447ae29b71b7851c5469
+  data.tar.gz: 8d62b2ac64f6ff3b45adeec927f060e0785ee75f9c0ecb7ca70ac3e7217abc10
 SHA512:
-  metadata.gz: 8727b5bf9b93db5fc8315a7106a32f190c2a55076e853f9031dd2dba293d53bc08b64a4a8224482bcb604a82a7aff190282e8b4cda79ab68e4e8d3653a3777e4
-  data.tar.gz: fe1b47c93f05c3e0427c8342233626d62a6a0224330d5662f0f3d6d737f986ab3f614f7560ba08daa14fc078fe236069ca4a8fcb2c770e7106dc11ef4dc87b44
+  metadata.gz: 8ab1d0603fcb11a782a795a50d2c8624428215b16d5132bf1658657ffc0c8eff78c51c19a6e21ae870d6040444f24085a914116c52c1c72e82eab623dced7f9d
+  data.tar.gz: 5f947b531a3e54378f787addf6b12af3882d84fcb9b935f9f3d97b0105de5dac820bddfcb5208f100aa5b3319cd27e6e1fcf4b0487eb925c136915ceeac5ca87

data/README.md

@@ -33,6 +33,17 @@ https://github.com/fastlane/fastlane/issues/17539
 
 ## Usage
 
+##### install plugin for fastlane
+[install instructions](https://docs.fastlane.tools/plugins/using-plugins/)
+```
+bundle exce fastlane add_plugin taiwan_number_one
+```
+but I personally prefer adding plugin in `Gemfile` like this to avoid additional `Pluginfile` in ~'your_ios_project_dir'/fastlane
+
+```
+bundle add fastlane-plugin-taiwan_number_one
+```
+
 ##### Show info
 
 ```

data/lib/fastlane/plugin/taiwan_number_one/actions/taiwan_number_one_action.rb

@@ -1,5 +1,5 @@
 require "fastlane/action"
-require "Spaceship/client"
+require "Spaceship"
 require_relative "../helper/taiwan_number_one_helper"
 
 module Fastlane
@@ -11,9 +11,12 @@ module Fastlane
       end
 
       def self.run(params)
-        require "spaceship"
-
-        app_id = params[:app_identifier]
+        app_id = params.fetch(:app_identifier)
+        username = params.fetch(:username)
+        unless app_id && username
+          UI.message("Could not find app_id and username.")
+          return
+        end
 
         # Prompts select team if multiple teams and none specified
         UI.message("Login to App Store Connect (#{params[:username]})")
@@ -35,8 +38,6 @@ module Fastlane
         app = Spaceship::ConnectAPI::App.find(app_id)
         version = app.get_app_store_versions.first
         UI.message("app_store_state is #{version.app_store_state}")
-        UI.message("version string is #{version.version_string}")
-        UI.message("pending version is #{version}")
         client ||= Spaceship::ConnectAPI
         platform ||= Spaceship::ConnectAPI::Platform::IOS
         filter = {
@@ -49,72 +50,70 @@ module Fastlane
                                .sort_by { |v| Gem::Version.new(v.version_string) }
                                .last
         if app_store_version
-          UI.message("app_store_version is #{app_store_version}")
-          state = app_store_version.app_store_state
-          UI.message("state is #{state}")
-  
           version_string = app_store_version.version_string
-          UI.message("version_string is #{version_string}")
+          state = app_store_version.app_store_state
+          UI.message("version #{version_string} is #{state}")
           unless state == Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::PENDING_DEVELOPER_RELEASE
             UI.message("AppStoreState is not PENDING_DEVELOPER_RELEASE")
             return
           end
           decision = params[:app_decision]
-          decision ||= get_decision
+          decision ||= fetch_decision
           case decision
           when DicisionType::RELEASE
             UI.message("decision is release")
+            release_version_if_possible(app: application, app_store_version: app_store_version)
           when DicisionType::REJECT
             UI.message("decision is reject")
+            reject_version_if_possible(app: app, app_store_version: app_store_version)
           else
-            decision ||= get_decision
+            decision ||= fetch_decision
           end
-          release_version_if_possible(app: application, app_store_version: app_store_version) if decision == "release"
-          reject_version_if_possible(app: application) if decision == "reject"
-  
-          UI.message("The taiwan_number_one plugin is finished!")
         else
           UI.message("no pending release version exist.")
         end
-
+        UI.message("The taiwan_number_one plugin action is finished!")
       end
 
-      def self.get_decision()
+      def self.fetch_decision
         decision = nil
         until ["release", "reject"].include?(decision)
           decision = UI.input("Please enter the app's release decision (release, reject): ")
           UI.message("App's decision must be release or reject")
         end
         # return decision
+        UI.message("return type #{decision}")
         if decision == DicisionType::RELEASE
-          UI.message("return type #{decision}")
           return DicisionType::RELEASE
         else
-          UI.message("return type #{decision}")
           return DicisionType::REJECT
         end
       end
-
-      def self.reject_version_if_possible(app: nil)
+      
+      def self.release_version_if_possible(app: nil, app_store_version: Spaceship::ConnectAPI::AppStoreVersion)
         unless app
           UI.user_error!("Could not find app with bundle identifier '#{params[:app_identifier]}' on account #{params[:username]}")
         end
-        if app.reject_version_if_possible!
-          UI.success("Successfully rejected previous version!")
+
+        begin
+          app_store_version.create_app_store_version_release_request
+          UI.message("release version #{app_store_version.version_string} successfully!")
+        rescue => e
+          UI.user_error!("An error occurred while releasing version #{app_store_version}")
+          UI.error("#{e.message}\n#{e.backtrace.join("\n")}") if FastlaneCore::Globals.verbose?
         end
       end
 
-      def self.release_version_if_possible(app: nil, app_store_version: Spaceship::ConnectAPI::AppStoreVersion)
+      def self.reject_version_if_possible(app: nil, app_store_version: Spaceship::ConnectAPI::AppStoreVersion)
         unless app
           UI.user_error!("Could not find app with bundle identifier '#{params[:app_identifier]}' on account #{params[:username]}")
         end
-        model = app_store_version.create_app_store_version_release_request
-        UI.success("response model is #{model}")
-
-        # release(version_id: version_id)
-        # if
-        UI.success("Successfully released previous version!")
-        # end
+        
+        if app_store_version.reject!
+          UI.success("rejected version #{app_store_version} Successfully!")
+        else
+          UI.user_error!("An error occurred while rejected version #{app_store_version}")
+        end
       end
 
       def self.description
@@ -139,7 +138,6 @@ module Fastlane
         user ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
         [
           FastlaneCore::ConfigItem.new(key: :app_decision,
-                                       short_option: "-d",
                                        env_name: "app_decision",
                                        description: "A description of your decision, should be release or reject",
                                        optional: false,

data/lib/fastlane/plugin/taiwan_number_one/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module TaiwanNumberOne
-    VERSION = "0.1.0"
+    VERSION = "0.1.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-taiwan_number_one
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - andrew54068
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-03 00:00:00.000000000 Z
+date: 2021-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry