fastlane-plugin-stream_actions 0.1.14 → 0.1.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fcb13b3f09d78254a4fd4bd0aedfaa73dbd01471f286048fc262ad5519743551
-  data.tar.gz: 525d059e5ad30f690e8c28d575f4e752ce38ce01390f399d5cf867d9a473f560
+  metadata.gz: af1d94514c2d3fc5e6de1be36819a669dd210316016d6f1724722ef337e72603
+  data.tar.gz: 1dd2ee983d552514d090a4f09900300fe8a5df4bac091123b7b4d097a9954d2b
 SHA512:
-  metadata.gz: 13f3f4538eddb334ab7a3fb408baf4bb3776737d6fee60575fc384c779b9b63a085bda1bb94a359d4d50f9618e18a1d8fb958697f883827753a2fdc2f9c55c5d
-  data.tar.gz: f15417504964bb1deebb850244be7c1de7bad5d5bf964838fe5779ae969338f8b33dcddbabbe2435c4d104a9f4efca0e29363341db6969fbc61eee0d3bf37a5e
+  metadata.gz: 347bd253d9443b5bb14683ac93fc4408ddf6e34bd43060db1699e18d2d5ceaf8eadb1eb6addfa970e69713c0302926c614b30315f3b0b3492b590a96803655ac
+  data.tar.gz: 8e2e9b4ef242c8f3eff526fd212dac0f6fc99ae0231a6659bc526dddfed7130f54d7b89494a5eba6b3449635dd181aa7ef3417f8a8b2287d0c463f8092674e4f

data/lib/fastlane/plugin/stream_actions/actions/custom_match.rb

@@ -35,7 +35,7 @@ module Fastlane
             description: 'AppStore Connect API Key',
             is_string: false,
             verify_block: proc do |api_key|
-              UI.user_error!('AppStore Connect API Key has to be specified') unless api_key
+              UI.user_error!('AppStore Connect API Key has to be specified') if api_key.nil? || api_key.empty? || !api_key.kind_of?(Hash)
             end
           ),
           FastlaneCore::ConfigItem.new(

data/lib/fastlane/plugin/stream_actions/actions/is_check_required.rb

@@ -2,11 +2,11 @@ module Fastlane
   module Actions
     class IsCheckRequiredAction < Action
       def self.run(params)
-        return true unless params[:github_pr_num]
+        return true if params[:github_pr_num].nil? || params[:github_pr_num].empty?
 
         UI.message("Checking if check is required for PR ##{params[:github_pr_num]}")
 
-        changed_files = sh("gh pr view #{params[:github_pr_num]} --json files -q '.files[].path'").split("\n")
+        changed_files = Actions.sh("gh pr view #{params[:github_pr_num]} --json files -q '.files[].path'").split("\n")
 
         return true if changed_files.size == 100 # TODO: https://github.com/cli/cli/issues/5368
 
@@ -31,14 +31,15 @@ module Fastlane
             key: :sources,
             description: 'Array of paths to scan',
             is_string: false,
-            verify_block: proc do |source|
-              UI.user_error!("Sources have to be specified") unless source
+            verify_block: proc do |array|
+              UI.user_error!("Sources have to be specified") unless array.kind_of?(Array) && array.size.positive?
             end
           ),
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_PR_NUM',
             key: :github_pr_num,
-            description: 'GitHub PR number'
+            description: 'GitHub PR number',
+            optional: true
           )
         ]
       end

data/lib/fastlane/plugin/stream_actions/actions/read_changelog.rb

@@ -2,8 +2,6 @@ module Fastlane
   module Actions
     class ReadChangelogAction < Action
       def self.run(params)
-        UI.user_error!('You need to pass the version of the release you want to obtain the changelog from') unless params[:version]
-
         UI.message("Getting changelog for #{params[:version]}")
         reading_changelog = false
         changes = ''
@@ -38,7 +36,7 @@ module Fastlane
             key: :version,
             description: 'Release version',
             verify_block: proc do |v|
-              UI.user_error!("You need to pass the version of the release you want to obtain the changelog from") unless v
+              UI.user_error!("You need to pass the version of the release you want to obtain the changelog from") if v.nil? || v.empty?
             end
           ),
           FastlaneCore::ConfigItem.new(

data/lib/fastlane/plugin/stream_actions/actions/release_ios_sdk.rb

@@ -30,7 +30,7 @@ module Fastlane
 
         release_details = other_action.set_github_release(
           repository_name: params[:github_repo],
-          api_token: ENV['GITHUB_TOKEN'],
+          api_token: params[:github_token],
           name: version_number,
           tag_name: version_number,
           description: changes,
@@ -115,7 +115,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(
             env_name: 'GITHUB_TOKEN',
             key: :github_token,
-            description: 'GITHUB_TOKEN env var has to be set up'
+            description: 'GITHUB_TOKEN environment variable'
           ),
           FastlaneCore::ConfigItem.new(
             key: :check_git_status,

data/lib/fastlane/plugin/stream_actions/actions/testflight_build.rb

@@ -47,9 +47,9 @@ module Fastlane
           "This is the build for Regression testing on release candidate v#{version_number} (sha: #{sha})."
         else
           "This is the official sample app built with iOS #{params[:sdk_target]} SDK v#{version_number}. It's designed " \
-          'to highlight engaging features and new improvements to the SDK, but remember that this is just one ' \
-          'possible implementation. You can start your own by borrowing and customizing the code from this ' \
-          "sample, or build something completely different using Stream's components."
+            'to highlight engaging features and new improvements to the SDK, but remember that this is just one ' \
+            'possible implementation. You can start your own by borrowing and customizing the code from this ' \
+            "sample, or build something completely different using Stream's components."
         end
       end
 
@@ -68,35 +68,35 @@ module Fastlane
             description: 'AppStore Connect API Key',
             is_string: false,
             verify_block: proc do |api_key|
-              UI.user_error!('AppStore Connect API Key has to be specified') unless api_key
+              UI.user_error!('AppStore Connect API Key has to be specified') if api_key.nil? || api_key.empty?
             end
           ),
           FastlaneCore::ConfigItem.new(
             key: :xcode_project,
             description: 'Path to the Xcode project',
             verify_block: proc do |path|
-              UI.user_error!('Path to the Xcode project has to be specified') unless path
+              UI.user_error!('Path to the Xcode project has to be specified') if path.nil? || path.empty?
             end
           ),
           FastlaneCore::ConfigItem.new(
             key: :sdk_target,
             description: 'SDK target name',
             verify_block: proc do |target|
-              UI.user_error!('SDK target name has to be specified') unless target
+              UI.user_error!('SDK target name has to be specified') if target.nil? || target.empty?
             end
           ),
           FastlaneCore::ConfigItem.new(
             key: :app_target,
             description: 'DemoApp target name',
             verify_block: proc do |target|
-              UI.user_error!('DemoApp target name has to be specified') unless target
+              UI.user_error!('DemoApp target name has to be specified') if target.nil? || target.empty?
             end
           ),
           FastlaneCore::ConfigItem.new(
             key: :app_identifier,
             description: 'DemoApp bundle identifier',
             verify_block: proc do |id|
-              UI.user_error!('DemoApp bundle identifier has to be specified') unless id
+              UI.user_error!('DemoApp bundle identifier has to be specified') if id.nil? || id.empty?
             end
           ),
           FastlaneCore::ConfigItem.new(

data/lib/fastlane/plugin/stream_actions/actions/update_testplan.rb

@@ -4,14 +4,17 @@ module Fastlane
       def self.run(params)
         data_hash = JSON.parse(File.read(params[:path]))
 
-        # Create the `environmentVariableEntries` array if it doesn't exist
         data_hash['defaultOptions']['environmentVariableEntries'] ||= []
 
-        data_hash['defaultOptions']['environmentVariableEntries'] << params[:env_vars]
+        if params[:env_vars].kind_of?(Hash)
+          data_hash['defaultOptions']['environmentVariableEntries'] << params[:env_vars]
+        else
+          params[:env_vars].each { |env| data_hash['defaultOptions']['environmentVariableEntries'] << env }
+        end
+
         File.write(params[:path], JSON.pretty_generate(data_hash))
 
-        UI.success("✅ `#{params[:env_vars]}` ENV variables have been added to #{params[:path]}")
-        UI.message("👀 #{params[:path]} ENV variables:\n#{data_hash['defaultOptions']['environmentVariableEntries']}")
+        UI.message("👀 Testplan environment variables:\n#{data_hash['defaultOptions']['environmentVariableEntries']}")
       end
 
       #####################################################
@@ -35,8 +38,8 @@ module Fastlane
             key: :env_vars,
             description: 'The environment variables to add to test plan',
             is_string: false,
-            verify_block: proc do |array|
-              UI.user_error!("The environment variables array should not be empty") if array.empty?
+            verify_block: proc do |env_vars|
+              UI.user_error!("The environment variables array should not be empty") if env_vars.nil? || env_vars.empty?
             end
           )
         ]

data/lib/fastlane/plugin/stream_actions/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module StreamActions
-    VERSION = "0.1.14"
+    VERSION = "0.1.15"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-stream_actions
 version: !ruby/object:Gem::Version
-  version: 0.1.14
+  version: 0.1.15
 platform: ruby
 authors:
 - GetStream
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.1
+        version: '1.38'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.1
+        version: '1.38'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -184,14 +184,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.15.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.15.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -239,7 +239,8 @@ files:
 - lib/fastlane/plugin/stream_actions/version.rb
 homepage: https://github.com/GetStream/fastlane-plugin-stream_actions
 licenses: []
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: