fastlane-plugin-settings_bundle 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e4de8d118519798ac033619bc8e7d97df7a53ed
-  data.tar.gz: 7c4b5392ec299f3793407f595f4ebddd7db7a6b0
+  metadata.gz: 2aa666c2aa65309f87d1a08e58de02488322ce58
+  data.tar.gz: 1531c25fbf01ac9d8b8225ce77f4a5aecabba97a
 SHA512:
-  metadata.gz: a8d7cee31bc2f87df9d4887c723b66d07b38eb1db2c7665343ffe1eeb2b692006eeeda7311b4389aa2949d9b9bc00e2db947438df950acc948567d803f8c3f8b
-  data.tar.gz: 816ac7eaf9b17e5e3e8b65a6f5318260932d73289c5eb487531c968d48fe902a4339b90868ab46262349589f527929c07bf2c6781e3db6f0bd8f94237a87b317
+  metadata.gz: b3323b058b91c1af1574ffefd338c4357091ddc59088b6fd9a35cfd3ad2565913189a6fa595029a86eef9c39f034c3aeed75bb81d8e79359b20d44d0f3d4dd6f
+  data.tar.gz: 0dbeba2dde57705a7dfba30aaf549bb89ca9a27e1687d552d5176a5cdaef9f639be56b1b367b41f65678b9c259e77eaf0f55c9b7d6e829614bebd3ac6df5b6ae

data/README.md

@@ -1,8 +1,9 @@
 # settings_bundle plugin
 
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg?style=flat)](https://rubygems.org/gems/fastlane-plugin-settings_bundle)
+[![Gem](https://img.shields.io/gem/v/fastlane-plugin-settings_bundle.svg)](https://rubygems.org/gems/fastlane-plugin-settings_bundle)
 [![License](https://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/jdee/settings-bundle/blob/master/LICENSE)
-[![CircleCI](https://circleci.com/gh/jdee/settings-bundle.svg?style=svg)](https://circleci.com/gh/jdee/settings-bundle)
+[![CircleCI](https://img.shields.io/circleci/project/github/jdee/settings-bundle.svg)](https://circleci.com/gh/jdee/settings-bundle)
 
 ## Getting Started
 
@@ -83,6 +84,20 @@ update_settings_bundle(
   key: "CurrentAppVersion",
   value: ":version (:build)",
   configuration: "Debug"
+)
+```
+
+#### Target parameter
+
+By default, this action takes the settings from the first non-test, non-extension target in
+the project. Use the optional :target parameter to specify a target by name.
+```ruby
+update_settings_bundle(
+  xcodeproj: "MyProject.xcodeproj",
+  key: "CurrentAppVersion",
+  value: ":version (:build)",
+  target: "MyAppTarget"
+)
 ```
 
 ## Example
@@ -90,13 +105,12 @@ update_settings_bundle(
 See the SettingsBundleExample subdirectory for a sample project that
 makes use of this action.
 
-First build and run the sample project on a simulator. It should show
+First build and run the sample project on a simulator or device. It should show
 you the current
-version and build number: 1.0.0 (1). This info is taken from the main
-bundle.
+version and build number: 1.0.0 (1). This information is taken from the app's Info.plist.
 
-If you visit the Settings app and look at the settings for
-SettingsBundleExample, you'll see the same version and build number
+Tap the version number to view the settings for
+SettingsBundleExample in the Settings app. You'll see the same version and build number
 as well as a blank field for the Build date.
 
 Now run Fastlane:
@@ -106,8 +120,8 @@ bundle install
 bundle exec fastlane test
 ```
 
-Now run the sample app again. It should display 1.0.0 (2). Visit the
-Settings app under the settings for the app to see the update to the
+Run the sample app again. It should display 1.0.0 (2). Tap the version number again
+to see the update to the
 settings bundle. The Build date field should show the current date.
 
 ## Run tests for this plugin

data/lib/fastlane/plugin/settings_bundle/actions/update_settings_bundle_action.rb

@@ -24,6 +24,7 @@ module Fastlane
       def self.run(params)
         key = params[:key]
         configuration = params[:configuration]
+        target_name = params[:target]
         file = params[:file]
         value = params[:value]
 
@@ -32,7 +33,7 @@ module Fastlane
 
         helper = Helper::SettingsBundleHelper
 
-        settings = helper.settings_from_project project, configuration
+        settings = helper.settings_from_project project, configuration, target_name
 
         formatted_value = helper.formatted_value value, settings
 
@@ -89,6 +90,11 @@ module Fastlane
                                description: "The plist file in the Settings.bundle to update",
                                   optional: true,
                              default_value: "Root.plist",
+                                      type: String),
+          FastlaneCore::ConfigItem.new(key: :file,
+                                  env_name: "SETTINGS_BUNDLE_TARGET",
+                               description: "An optional target name from the project",
+                                  optional: true,
                                       type: String)
         ]
       end
@@ -124,6 +130,14 @@ module Fastlane
               value: ":version (:build)",
               configuration: "Debug"
             )
+          EOF,
+          <<-EOF
+            update_settings_bundle(
+              xcodeproj: "MyProject.xcodeproj",
+              key: "CurrentAppVersion",
+              value: ":version (:build)",
+              target: "MyAppTarget"
+            )
           EOF
         ]
       end

data/lib/fastlane/plugin/settings_bundle/helper/settings_bundle_helper.rb

@@ -45,11 +45,17 @@ module Fastlane
         #
         # :project: An open Xcodeproj::Project via Xcodeproj::Project.open, e.g.
         # :configuration: A valid build configuration in the project
-        def settings_from_project(project, configuration)
-          # find the first non-test, non-extension target
-          # TODO: Make this a :target parameter
-          target = project.targets.find { |t| !t.test_target_type? && !t.extension_target_type? }
-          raise "No application target found" if target.nil?
+        # :target_name: A valid target name in the project or nil to use the first application target
+        def settings_from_project(project, configuration, target_name)
+          if target_name
+            target = project.targets.find { |t| t.name == target_name }
+            raise "Target named \"#{target_name}\" not found" if target.nil?
+          else
+            # find the first non-test, non-extension target
+            # TODO: Make this a :target parameter
+            target = project.targets.find { |t| !t.test_target_type? && !t.extension_target_type? }
+            raise "No application target found" if target.nil?
+          end
 
           # find the Info.plist paths for all configurations
           info_plist_paths = target.resolved_build_setting "INFOPLIST_FILE"

data/lib/fastlane/plugin/settings_bundle/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module SettingsBundle
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-settings_bundle
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Jimmy Dee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-25 00:00:00.000000000 Z
+date: 2017-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plist