fastlane-plugin-sentry 1.2.5 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 555d3e43f1f0901d7a09bd93cd07187162127088
-  data.tar.gz: a0d13dda1a41ace0c79f31c3fc19bbacccac3a03
+  metadata.gz: af49c66cfc8efdf4ae25c334f362f76c4596d34a
+  data.tar.gz: 3ac7e68fbf6e51ee1db654205fad6712dbd17cf4
 SHA512:
-  metadata.gz: a8c877838b304cceee8999430d91c4ea6191c2a8ff0ef2d6cbe552a1ecbc75021076babc9f7c0c5fc210219a40549fdf8306d4c76ce3d949dba559b3e8a0bb7f
-  data.tar.gz: 17e978f1d4952fda6bbc0077f4c799a00ecf4b89eb23ad143060bd78c30044505fe23ae2e653c181f48ff67576475da6cb5b787761861f5b3f738ac5f5fa37c6
+  metadata.gz: a83d0ebca78f478f2d835a060f0eb4fcd4a04dcc4a70b21dc921fa3ba464eb24679310474778ddf3a9db293d40d85da5af263051acf208ba1334f715ab24135b
+  data.tar.gz: c5450415b2c29193b7a5a63f61d52501e581e1653dbf53733f6dc096aae8e91df7b68de1dae5aa770f183569d7df75cdbc8421180d91b2f2845bfb7bd7a4f722

data/lib/fastlane/plugin/sentry/actions/sentry_create_release.rb

@@ -10,13 +10,11 @@ module Fastlane
         version = params[:version]
         version = "#{params[:app_identifier]}-#{params[:version]}" if params[:app_identifier]
 
-        #finalize_arg = params[:finalize] ? '--finalize'
-
         command = [
           "sentry-cli",
           "releases",
           "new",
-          Shellwords.escape(version)
+          version
         ]
         command.push("--finalize") if params[:finalize].nil?
 

data/lib/fastlane/plugin/sentry/actions/sentry_finalize_release.rb

@@ -8,12 +8,13 @@ module Fastlane
         Helper::SentryConfig.parse_api_params(params)
 
         version = params[:version]
+        version = "#{params[:app_identifier]}-#{params[:version]}" if params[:app_identifier]
 
         command = [
           "sentry-cli",
           "releases",
           "finalize",
-          Shellwords.escape(version)
+          version
         ]
 
         Helper::SentryHelper.call_sentry_cli(command)
@@ -38,7 +39,14 @@ module Fastlane
       def self.available_options
         Helper::SentryConfig.common_api_config_items + [
           FastlaneCore::ConfigItem.new(key: :version,
-                                       description: "Release version to finalize on Sentry")
+                                       description: "Release version to finalize on Sentry"),
+          FastlaneCore::ConfigItem.new(key: :app_identifier,
+                                      short_option: "-a",
+                                      env_name: "SENTRY_APP_IDENTIFIER",
+                                      description: "App Bundle Identifier",
+                                      optional: true,
+                                      default_value: CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier))
+
         ]
       end
 

data/lib/fastlane/plugin/sentry/actions/sentry_upload_file.rb

@@ -7,21 +7,21 @@ module Fastlane
         Helper::SentryHelper.check_sentry_cli!
         Helper::SentryConfig.parse_api_params(params)
 
-        version = params[:version]
         file = params[:file]
 
+        version = params[:version]
         version = "#{params[:app_identifier]}-#{params[:version]}" if params[:app_identifier]
 
         command = [
           "sentry-cli",
           "releases",
           "files",
-          Shellwords.escape(version),
+          version,
           "upload",
           file
         ]
-        command.push(params[:file_url]) if !params[:file_url].nil?
-        command.push("--dist").push(params[:dist]) if !params[:dist].nil?
+        command.push(params[:file_url]) unless params[:file_url].nil?
+        command.push("--dist").push(params[:dist]) unless params[:dist].nil?
 
         Helper::SentryHelper.call_sentry_cli(command)
         UI.success("Successfully uploaded files to release: #{version}")
@@ -56,7 +56,6 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :file_url,
                                        description: "Optional URL we should associate with the file",
                                        optional: true),
-
           FastlaneCore::ConfigItem.new(key: :app_identifier,
                                       short_option: "-a",
                                       env_name: "SENTRY_APP_IDENTIFIER",

data/lib/fastlane/plugin/sentry/actions/sentry_upload_sourcemap.rb

@@ -24,8 +24,8 @@ module Fastlane
         command.push('--rewrite') if params[:rewrite]
         command.push('--strip-prefix') if params[:strip_prefix]
         command.push('--strip-common-prefix') if params[:strip_common_prefix]
-        command.push('--url-prefix').push(params[:url_prefix]) if !params[:url_prefix].nil?
-        command.push('--dist').push(params[:dist]) if !params[:dist].nil?
+        command.push('--url-prefix').push(params[:url_prefix]) unless params[:url_prefix].nil?
+        command.push('--dist').push(params[:dist]) unless params[:dist].nil?
 
         Helper::SentryHelper.call_sentry_cli(command)
         UI.success("Successfully uploaded files to release: #{version}")

data/lib/fastlane/plugin/sentry/helper/sentry_helper.rb

@@ -31,7 +31,8 @@ module Fastlane
           UI.command(command.to_s)
           UI.verbose("\n\n")
         end
-        Open3.popen3(command.join(" ")) do |stdin, stdout, stderr, wait_thr|
+        final_command = command.map { |arg| Shellwords.escape(arg) }.join(" ")
+        Open3.popen3(final_command) do |stdin, stdout, stderr, wait_thr|
           while (line = stderr.gets)
             error << line.strip!
           end

data/lib/fastlane/plugin/sentry/version.rb

@@ -1,6 +1,6 @@
 module Fastlane
   module Sentry
-    VERSION = "1.2.5"
+    VERSION = "1.2.6"
     CLI_VERSION = "1.9.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-sentry
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.2.6
 platform: ruby
 authors:
 - Sentry