fastlane-plugin-screenshot_notifier 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ffa76f65c4d14cfeec1c37d5add43cd0983532f942cb53acd5b8cc319367f2fa
-  data.tar.gz: 3da1f83f3206b4fe18d014c83a8c5505c34b95b8817fc322cd19afd5f9b76eae
+  metadata.gz: 0fbde9cfedf4a778509f8b7ea23d92dc972251297b6ee4981cc56933ee92fcd8
+  data.tar.gz: 2da75461850c503933f0079a8318046fb0360d75c2970a36547d9331d719efd4
 SHA512:
-  metadata.gz: 31b9bbcf59b34fce031c196fd44dc156557586351f2ecf425d00a478390ab1c63456374dc2ae7d558841db6936df4844056e544b8d07374d2591b96a3c4417e5
-  data.tar.gz: d36ded2a517f76f34afed9d66ab8438e4c692ab456a77079c2e5c4373eb51b17ea3d5d315966c8de218f1fb059de8867d2aeed399ca7c1e4a4ec39356bb22271
+  metadata.gz: 1019e99a90cddf10a12c0400699619e5d979b17f5c46c15913dd2cdfb1c972b7579972f21c4c34b1b2ba3ce1ebdb1008be9128d6fac7c0f6eb27741f3fd4aeb4
+  data.tar.gz: 24ccddf8baf9cca131900f8f391318e0ab15bcdd2d89df609985b8e132b7f8b047d59b7d1933cebe64dbccc737a4c51fa546f8bab408150888148136e4ca0f98

data/lib/fastlane/plugin/screenshot_notifier/actions/screenshot_notifier_action.rb

@@ -23,14 +23,16 @@ module Fastlane
         UI.message "Post screenshots as PR comments"
         screenshot_dir = params[:screenshot_dir]
         devices = Dir.chdir("#{screenshot_dir}") do
-          Dir.glob("*").select {|path| FileTest.directory? path}.sort
+          Dir.glob("*").select { |path| FileTest.directory? path }.sort
         end
-        header = "<tr><td>Screen Name</td>\n#{devices.map {|device| "<td>#{device}</td>\n"}.inject(&:+)}</tr>"
+        header = "<tr><td>Screen Name</td>\n#{devices.map { |device| "<td>#{device}</td>\n" }.inject(&:+)}</tr>"
         rows = Dir.glob("#{screenshot_dir}/#{devices[0]}/*.jpg")
-                   .map {|path| File.basename(path)}
-                   .map {|file_name|
-                     cells = devices.map {|device|
-                       ratio = Helper.calc_aspect_ratio("#{screenshot_dir}/#{device}/#{file_name}")
+                   .map { |path| File.basename(path) }
+                   .map { |file_name|
+                     cells = devices.map { |device|
+                       file_path = "#{screenshot_dir}/#{device}/#{file_name}"
+                       next if !File.exist?(file_path)
+                       ratio = Helper.calc_aspect_ratio(file_path)
                        is_portrait = ratio >= 1.0
                        size_attr = if params[:image_length] != nil
                                      if is_portrait

data/lib/fastlane/plugin/screenshot_notifier/helper/github_notifier.rb

@@ -8,8 +8,8 @@ module Fastlane
     def self.fold_comments(github_owner, github_repository, github_pr_number, comment_prefix, summary, github_api_token)
       res = get_comments(github_owner, github_repository, github_pr_number, github_api_token)
       JSON.parse(res.body)
-          .select {|comment| comment["body"] != nil && comment["body"].start_with?(comment_prefix)}
-          .each {|comment|
+          .select { |comment| comment["body"] != nil && comment["body"].start_with?(comment_prefix) }
+          .each { |comment|
             body = "<details><summary>#{summary}</summary>\n#{comment["body"]}\n\n</details>\n"
             patch_comment(github_owner, github_repository, comment["id"], body, github_api_token)
           }
@@ -18,8 +18,8 @@ module Fastlane
     def self.delete_comments(github_owner, github_repository, github_pr_number, comment_prefix, github_api_token)
       res = get_comments(github_owner, github_repository, github_pr_number, github_api_token)
       JSON.parse(res.body)
-          .select {|comment| comment["body"] != nil && comment["body"].start_with?(comment_prefix)}
-          .each {|comment| delete_comment(github_owner, github_repository, comment["id"], github_api_token)}
+          .select { |comment| comment["body"] != nil && comment["body"].start_with?(comment_prefix) }
+          .each { |comment| delete_comment(github_owner, github_repository, comment["id"], github_api_token) }
     end
 
     def self.get_comments(github_owner, github_repository, github_pr_number, github_api_token)
@@ -31,7 +31,7 @@ module Fastlane
       req["Content-Type"] = "application/json"
       req["Authorization"] = "token #{github_api_token}"
 
-      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) {|http| http.request(req)}
+      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) { |http| http.request(req) }
       UI.message "#{res.code}\n#{res.body}"
 
       res
@@ -47,7 +47,7 @@ module Fastlane
       req["Authorization"] = "token #{github_api_token}"
       req.body = {:body => body}.to_json
 
-      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) {|http| http.request(req)}
+      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) { |http| http.request(req) }
       UI.message "#{res.code}\n#{res.body}"
 
       res
@@ -63,7 +63,7 @@ module Fastlane
       req["Authorization"] = "token #{github_api_token}"
       req.body = {:body => body}.to_json
 
-      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) {|http| http.request(req)}
+      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) { |http| http.request(req) }
       UI.message "#{res.code}\n#{res.body}"
 
       res
@@ -78,7 +78,7 @@ module Fastlane
       req["Content-Type"] = "application/json"
       req["Authorization"] = "token #{github_api_token}"
 
-      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) {|http| http.request(req)}
+      res = Net::HTTP.start(uri.hostname, uri.port, {use_ssl: uri.scheme = "https"}) { |http| http.request(req) }
       UI.message "#{res.code}\n#{res.body}"
 
       res

data/lib/fastlane/plugin/screenshot_notifier/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module ScreenshotNotifier
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-screenshot_notifier
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Moyuru Aizawa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-09 00:00:00.000000000 Z
+date: 2019-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -168,7 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Post screenshots to a pull request