fastlane-plugin-notarize 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a4ed3b8ac3d78250058bfede6901efca6737e756
-  data.tar.gz: 559bbd32554af05a591c42478013fd751882d2d0
+  metadata.gz: 7c6b2af870f602051718f4e12a3ff8f50e143de5
+  data.tar.gz: 354fb94000dd61c23ae7d69efe5c7c8770e65daa
 SHA512:
-  metadata.gz: d1052f35aa220439d85a292f7b8272652d8af0e6fbc6e5f84dd2154af80c323fbde49b5115b9af7fdd2b9b61a7d95d622274011443d53e9d87a3244fe35e0587
-  data.tar.gz: 3c59545938745b0fa78257c4fb647991f465f1e3ae99c4add2b236d223af853dc1f9dc9724ed8644441714d24d79a11ee3ea32cd9cfc24fee2bfd5cd2e537ef1
+  metadata.gz: e617932066cfc9fedbef60f70a85da79892fe8df874d2400ab022e7012351754f4fd54869cd756e6accc0f5f8388b3231e97ff0e270b79f9c5036cb6dce4d655
+  data.tar.gz: 76cf8459503aa0b52a3ca81d361b7745e22a2109fb46c72828c08de96609480ae0fc61997cc17607985dbad4abe913501735ff1fc0889464ecf98e291cbe341d

data/README.md

@@ -1,6 +1,6 @@
 # fastlane notarize plugin [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-notarize)
 
-[fastlane](https://github.com/fastlane/fastlane) plugin to [notarize](https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution) a macOS app.
+[fastlane](https://github.com/fastlane/fastlane) plugin to [notarize](https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution) a macOS app. 🛂
 
 Notarize plugin provides a `notarize` action to upload an app to Apple's notarization service, querying the result periodically until it's complete—which currently takes around 2 minutes. In case of success, it staples the app with the notarization ticket. In case of failure, it prints the log file listing all the issues.
 
@@ -20,7 +20,7 @@ notarize(
 )
 ```
 
-This action should prompt you for an Apple ID and password, using fastlane's built-in credentials manager. To use the action in a CI environment like Travis CI, CircleCI or Bitrise, you can set `FASTLANE_USER` and `FASTLANE_PASSWORD` environment variables. (Make sure to use secret environment variables, specifically for the password.)
+This action should prompt you for an Apple ID and password, using fastlane's built-in credentials manager. To use the action in a CI environment like Bitrise, CircleCI or Travis CI, you can set `FASTLANE_USER` and `FASTLANE_PASSWORD` environment variables. (Make sure to use secret environment variables, specifically for the password.)
 
 ## Example
 

data/lib/fastlane/plugin/notarize/actions/notarize_action.rb

@@ -18,7 +18,10 @@ module Fastlane
 
           unless bundle_id
             info_plist_path = File.join(package_path, 'Contents', 'Info.plist')
-            bundle_id = Plist.parse_xml(info_plist_path)['CFBundleIdentifier']
+            bundle_id = Actions.sh(
+              "/usr/libexec/PlistBuddy -c \"Print :CFBundleIdentifier\" \"#{info_plist_path}\"",
+              log: false
+            ).strip
           end
         end
 
@@ -31,8 +34,11 @@ module Fastlane
 
         UI.message('Uploading package to notarization service, might take a while')
 
+        notarization_upload_command = "xcrun altool --notarize-app -t osx -f \"#{compressed_package_path || package_path}\" --primary-bundle-id #{bundle_id} -u #{apple_id_account.user} -p @env:FL_NOTARIZE_PASSWORD --output-format xml"
+        notarization_upload_command << " --asc-provider \"#{params[:asc_provider]}\"" unless params[:asc_provider]
+
         notarization_upload_response = Actions.sh(
-          "xcrun altool --notarize-app -t osx -f \"#{compressed_package_path || package_path}\" --primary-bundle-id #{bundle_id} -u #{apple_id_account.user} -p @env:FL_NOTARIZE_PASSWORD --output-format xml",
+          notarization_upload_command,
           log: false
         )
 
@@ -103,6 +109,8 @@ module Fastlane
         username = CredentialsManager::AppfileConfig.try_fetch_value(:apple_dev_portal_id)
         username ||= CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)
 
+        asc_provider = CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_id)
+
         [
           FastlaneCore::ConfigItem.new(key: :package,
                                        env_name: 'FL_NOTARIZE_PACKAGE',
@@ -120,7 +128,12 @@ module Fastlane
                                        env_name: 'FL_NOTARIZE_USERNAME',
                                        description: 'Apple ID username',
                                        default_value: username,
-                                       default_value_dynamic: true)
+                                       default_value_dynamic: true),
+          FastlaneCore::ConfigItem.new(key: :asc_provider,
+                                       env_name: 'FL_NOTARIZE_ASC_PROVIDER',
+                                       description: 'Provider short name for accounts associated with multiple providers',
+                                       optional: true,
+                                       default_value: asc_provider)
         ]
       end
 

data/lib/fastlane/plugin/notarize/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Notarize
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-notarize
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Zeplin, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-05 00:00:00.000000000 Z
+date: 2019-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry