fastlane-plugin-latest_appcenter_build_number 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: f9b2555a719cd267f2ab535d3aaa65d52b20756b1c629a25c29403c35ceae36e
-  data.tar.gz: 286400c56c2068ff07cf0060b607363773cbd29f23c0ae5650204f8500c45db7
+SHA1:
+  metadata.gz: 91ce3611fe391250e87abecde468adf27b666758
+  data.tar.gz: 6e970ac127bbf04124452b6f5c2ed81b6ac04c2d
 SHA512:
-  metadata.gz: 2869a4a6cdbad6a559dbb3342f426051695ac504a7dccd8c80a228a4d90a19ca9dfda46ef96689f10a326933f004c58c6dddcf613aa2560ede272a0310adbf1f
-  data.tar.gz: a9006f753b7b648a629466a8238685f5a8ba1bdfac72506371abcf1ddd9067e986fb14e9ac373e729df561b5251db1eace391b8eaa35d1a6b96afaef3d23324d
+  metadata.gz: fbf017dcba261ff063212d047409aef563b2765f93598f51c917422b781eeecc6e57add759a2b359c537e7a5e357c325a17a51b973b0523d22a01c627eea77fe
+  data.tar.gz: df4eb46a8c16c3f7a3632e7c37a0584ed412b43bd7baf042d10bec5cb440a48261cd6af8de60fbe489baa6f4d50f7a990fd705693093a2674daf806dfeccea55

data/lib/fastlane/plugin/latest_appcenter_build_number/actions/latest_appcenter_build_number_action.rb

@@ -8,14 +8,32 @@ module Fastlane
   module Actions
     class LatestAppcenterBuildNumberAction < Action
       def self.run(config)
+        unless check_valid_app_name(config[:app_name])
+          UI.user_error!("The `app_name` ('#{config[:app_name]}') cannot contains spaces and must only contain alpha numeric characters and dashes")
+          return nil
+        end
+
         app_name = config[:app_name]
         owner_name = config[:owner_name]
-        if app_name.nil? || owner_name.nil?
+        if app_name.nil? && owner_name.nil?
           owner_and_app_name = get_owner_and_app_name(config[:api_token])
           app_name = owner_and_app_name[0]
           owner_name = owner_and_app_name[1]
         end
 
+        if owner_name.nil?
+          owner_name = get_owner_name(config[:api_token], app_name)
+        end
+
+        if app_name.nil?
+          app_name = get_owner_and_app_name(config[:api_token])[0]
+        end
+
+        if app_name.nil? || owner_name.nil?
+          UI.user_error!("No app '#{app_name}' found for owner #{owner_name}")
+          return nil
+        end
+
         host_uri = URI.parse('https://api.appcenter.ms')
         http = Net::HTTP.new(host_uri.host, host_uri.port)
         http.use_ssl = true
@@ -24,13 +42,18 @@ module Fastlane
         list_response = http.request(list_request)
 
         if list_response.kind_of?(Net::HTTPForbidden)
-          UI.error("API Key not valid for #{owner_name}. This will be because either the API Key or the owner_name are incorrect")
+          UI.user_error!("API Key not valid for '#{owner_name}'. This will be because either the API Key or the `owner_name` are incorrect")
+          return nil
+        end
+
+        if list_response.kind_of?(Net::HTTPNotFound)
+          UI.user_error!("No app or owner found with `app_name`: '#{app_name}' and `owner_name`: '#{owner_name}'")
           return nil
         end
 
         releases = JSON.parse(list_response.body)
         if releases.nil?
-          UI.error("No versions found for #{app_name} owned by #{owner_name}")
+          UI.user_error!("No versions found for '#{app_name}' owned by #{owner_name}")
           return nil
         end
 
@@ -38,7 +61,7 @@ module Fastlane
         latest_build = releases.first
 
         if latest_build.nil?
-          UI.error("The app has no versions yet")
+          UI.user_error!("The app has no versions yet")
           return nil
         end
 
@@ -86,13 +109,26 @@ module Fastlane
         apps = get_apps(api_token)
         app_names = apps.map { |app| app['name'] }.sort
         selected_app_name = UI.select("Select your project: ", app_names)
-        selected_app = apps.select { |app| app['name'] == selected_app_name }.first
+        app_matches = apps.select { |app| app['name'] == selected_app_name }
+        return unless app_matches.count > 0
+        selected_app = app_matches.first
 
         name = selected_app['name'].to_s
         owner = selected_app['owner']['name'].to_s
         return name, owner
       end
 
+      def self.get_owner_name(api_token, app_name)
+        apps = get_apps(api_token)
+        return unless apps.count > 0
+        app_matches = apps.select { |app| app['name'] == app_name }
+        return unless app_matches.count > 0
+        selected_app = app_matches.first
+
+        owner = selected_app['owner']['name'].to_s
+        return owner
+      end
+
       def self.get_apps(api_token)
         host_uri = URI.parse('https://api.appcenter.ms')
         http = Net::HTTP.new(host_uri.host, host_uri.port)
@@ -100,8 +136,13 @@ module Fastlane
         apps_request = Net::HTTP::Get.new("/v0.1/apps")
         apps_request['X-API-Token'] = api_token
         apps_response = http.request(apps_request)
-        apps = JSON.parse(apps_response.body)
-        return apps
+        return [] unless apps_response.kind_of?(Net::HTTPOK)
+        return JSON.parse(apps_response.body)
+      end
+
+      def self.check_valid_app_name(app_name)
+        regexp = /^[a-zA-Z0-9\-]+$/i
+        return regexp.match?(app_name)
       end
     end
   end

data/lib/fastlane/plugin/latest_appcenter_build_number/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module LatestAppcenterBuildNumber
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-latest_appcenter_build_number
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Jack Spargo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-05 00:00:00.000000000 Z
+date: 2019-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -167,7 +167,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubyforge_project: 
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Use AppCenter API to get the latest version and build number for an App Center