fastlane-plugin-ipa_info 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4760b3932e7e1b06973ec7bba3af813b0e73d126fc07735b7a5f851c31d8c5e
-  data.tar.gz: 933a353918805cb565d01652b76675923780f982de0587919569869d137c0a2d
+  metadata.gz: 01742d4f12328334684ce676dd4d347a8728c00d66cbdb5868cd493a275d0947
+  data.tar.gz: 95ef95fa5b756e0b4242c608eb1d467aed2525a2379b5597b8bb89b13a7a91b6
 SHA512:
-  metadata.gz: 684a77ae2d2876dc5c00a07718684d899d8ee71dd09903afe675b7e7e19e69b15c8f78afd3372ef378489637e8db6428c658d0116bf41dcce804cfcf6599cea3
-  data.tar.gz: 9e2b92e2f584f35e14fad54117ac2bb39e81f9abbe72015e5744fde542924f77bebc3834f22c38cf920d5d84ed055f379c4566a5664467ee7c700399e3c10db9
+  metadata.gz: 8e54eebcf53a0885e570df99541156fd3dc43549abfca176879a96c7e8ad13903890db463aae1f6d0ded0e95cfe155b6a1b83e5b1cc0441b9253842543882791
+  data.tar.gz: 95aedea9818581710484f8d3cece34c54d7390ad1d37b1803768c64fc1dbaaf51c26d6fbb35968d2ebf0d9da45fab3fd2492355691dd506d74905ee6a84014ef

data/lib/fastlane/plugin/ipa_info/helper/ipa_analyze_helper.rb

@@ -4,32 +4,27 @@ require 'fileutils'
 require 'plist'
 require 'open3'
 require 'fastlane_core/ui/ui'
+require "securerandom"
 
 module Fastlane
   module Helper
     class IpaAnalyzeHelper
       def self.analyze(ipa_path)
-        app_folder_path = find_app_folder_path_in_ipa(ipa_path)
-        plist_data = self.fetch_file_with_unzip(ipa_path, "#{app_folder_path}/Info.plist")
-        mobileprovisioning_data = self.fetch_file_with_unzip(ipa_path, "#{app_folder_path}/embedded.mobileprovision")
-
         return {
-            provisiong_info: self.analyze_mobileprovisioning(mobileprovisioning_data),
-            plist_info: self.analyze_info_plist(plist_data),
-            certificate_info: self.codesigned(ipa_path, app_folder_path)
+            provisiong_info: self.analyze_file_with_unzip(ipa_path, "embedded.mobileprovision"),
+            plist_info: self.analyze_file_with_unzip(ipa_path, "Info.plist"),
+            certificate_info: analyze_file_with_unzip(ipa_path, "")
         }
       end
 
       # Info plist
-      def self.analyze_info_plist(data)
-        tempfile = Tempfile.new(::File.basename("infoplist"))
+      def self.analyze_info_plist(tempfile)
         result = {}
 
         begin
-          File.binwrite(tempfile.path, data)
-          UI.user_error!("Failed to convert binary Plist to XML") unless system("plutil -convert xml1 '#{tempfile.path}'")
+          UI.user_error!("Failed to convert binary Plist to XML") unless system("plutil -convert xml1 '#{tempfile}'")
 
-          plist = Plist.parse_xml(tempfile.path)
+          plist = Plist.parse_xml(tempfile)
           plist.each do |key, value|
             parse_value = value.class == Hash || value.class == Array ? value : value.to_s
 
@@ -38,20 +33,18 @@ module Fastlane
         rescue StandardError => e
           UI.user_error!(e.message)
         ensure
-          tempfile.close && tempfile.unlink
+          FileUtils.rm_r(tempfile)
         end
 
         result
       end
 
       # mobileprovisioning
-      def self.analyze_mobileprovisioning(data)
-        tempfile = Tempfile.new(::File.basename("mobileprovisioning"))
+      def self.analyze_mobileprovisioning(tempfile)
         result = {}
 
         begin
-          File.binwrite(tempfile.path, data)
-          mobileprovisioning = Plist.parse_xml(`security cms -D -i #{tempfile.path}`)
+          mobileprovisioning = Plist.parse_xml(`security cms -D -i #{tempfile}`)
           mobileprovisioning.each do |key, value|
             next if key == 'DeveloperCertificates'
 
@@ -62,49 +55,61 @@ module Fastlane
         rescue StandardError => e
           UI.user_error!(e.message)
         ensure
-          tempfile.close && tempfile.unlink
+          FileUtils.rm_r(tempfile)
         end
 
         result
       end
 
       # certificate
-      def self.codesigned(ipa_path, app_folder_path)
-        tempdir = Dir.pwd + "/tmp"
+      def self.codesigned(temp_file_path)
         result = {}
 
+        cmd = "codesign -dv #{temp_file_path}"
+        _stdout, stderr, _status = Open3.capture3(cmd)
+        codesigned_flag = stderr.include?("Signed Time")
+        result["CodeSigned"] = codesigned_flag
+
+        return result
+      end
+
+      # unzip ipa file and analyze file
+      def self.analyze_file_with_unzip(ipa_path, target_file_name)
+        tempdir = Dir.pwd + "/tmp-#{SecureRandom.hex(10)}"
+        target_file_path = find_app_folder_path_in_ipa(ipa_path) + "/#{target_file_name}"
+        temp_file_path = "#{tempdir}/#{target_file_name}"
+
         begin
-          _, error, = Open3.capture3("unzip -d #{tempdir} #{ipa_path}")
+          _, error, = Open3.capture3("unzip -o -d #{tempdir} #{ipa_path}")
           UI.user_error!(error) unless error.empty?
 
-          cmd = "codesign -dv #{tempdir}/#{app_folder_path}"
-          _stdout, stderr, _status = Open3.capture3(cmd)
-          codesigned_flag = stderr.include?("Signed Time")
-          result["CodeSigned"] = codesigned_flag
+          copy_cmd = "#{tempdir}/#{target_file_path} #{temp_file_path}"
+
+          case target_file_name
+          when "Info.plist" then
+            self.copy_file(copy_cmd)
+            return self.analyze_info_plist(temp_file_path)
+          when "embedded.mobileprovision" then
+            self.copy_file(copy_cmd)
+            return self.analyze_mobileprovisioning(temp_file_path)
+          when "" then
+            return self.codesigned(target_file_path)
+          end
         rescue StandardError => e
+          FileUtils.rm_r(tempdir)
           UI.user_error!(e.message)
         ensure
           FileUtils.rm_r(tempdir)
         end
 
-        return result
+        return nil
       end
 
-      # extract file
-      def self.fetch_file_with_unzip(path, target_file)
-        list, error, = Open3.capture3("unzip", "-Z", "-1", path)
+      # copy
+      def self.copy_file(cmd)
+        cmd = "cp #{cmd}"
+        _, error, = Open3.capture3(cmd)
         UI.user_error!(error) unless error.empty?
-
-        return nil if list.empty?
-        entry = list.chomp.split("\n").find do |e|
-          File.fnmatch(target_file, e, File::FNM_PATHNAME)
-        end
-
-        data, error, = Open3.capture3("unzip", "-p", path, entry)
-        UI.user_error!(error) unless error.empty?
-        UI.user_error!("not exits data for #{target_file}") if data.empty?
-
-        data
       end
 
       # return app folder path

data/lib/fastlane/plugin/ipa_info/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module IpaInfo
-    VERSION = "0.8.1"
+    VERSION = "0.8.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-ipa_info
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - tarappo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-11 00:00:00.000000000 Z
+date: 2021-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plist