fastlane-plugin-ipa_info 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1f62b0d7e6c8bdd7c5cc220230db3b89e1ff4db74b7f0d6d9bb04e5960152a7
-  data.tar.gz: b9fcbdbc8ce50d2cb634f2068b1dea22a79331595242a476ccf199894c046ce9
+  metadata.gz: 0d02632c59b5d057a6227def1bc12cc69deb3f0c5a05b9448cd034675d12ce9a
+  data.tar.gz: aa464bb64612797248568cfc0ba704150dc59d9fc9872781c92e1ac6147545c6
 SHA512:
-  metadata.gz: 994167e35df5b86846550df1eab3e6ec4d521ec3abfeb980bbbdf42852ea7a180a61166ffaa9b0de5049b13ec1a121fb3db66fa14c8fc1e2108efd3795207ca2
-  data.tar.gz: 1d1f284971cb79cb423952226d321d0edc6beb7c26f25cad1d3a1389010cce8503222096ade8186a5daece3deb7232e06f1ac4fb482cfe8ea798e1dfd131f05e
+  metadata.gz: 9c23edd1aef4d7ee8364747f40ae35f12ce7ba6002e0b35855991a55535af4d69f8c5a6d9925ab7843e8895ec0c8b331de5198505865ac5ba17e54a5621b29a4
+  data.tar.gz: bb96ff38f13fe7b0767292e8d944a9191909667a4636634b6cafa58c21a2b711980a9ee74633e5b07f30b0db6c5fad6ac343701b2758733f08b0375546544ce2

data/lib/fastlane/plugin/ipa_info/helper/ipa_analyze_helper.rb

@@ -1,7 +1,5 @@
 require 'tempfile'
 require 'tmpdir'
-require 'zip'
-require 'zip/filesystem'
 require 'fileutils'
 require 'plist'
 require 'open3'
@@ -11,34 +9,29 @@ module Fastlane
   module Helper
     class IpaAnalyzeHelper
       def self.analyze(ipa_path)
-        ipa_zipfile = Zip::File.open(ipa_path)
         app_folder_path = find_app_folder_path_in_ipa(ipa_path)
-        ipa_zipfile.close
-
-        # file path
-        mobileprovision_entry = ipa_zipfile.find_entry("#{app_folder_path}/embedded.mobileprovision")
-        UI.user_error!("mobileprovision not found in #{ipa_path}") unless mobileprovision_entry
-        info_plist_entry = ipa_zipfile.find_entry("#{app_folder_path}/Info.plist")
-        UI.user_error!("Info.plist not found in #{ipa_path}") unless info_plist_entry
+        plist_data = self.fetch_file_with_unzip(ipa_path, "#{app_folder_path}/Info.plist")
+        mobileprovisioning_data = self.fetch_file_with_unzip(ipa_path, "#{app_folder_path}/embedded.mobileprovision")
 
         return {
-            provisiong_info: self.analyze_mobileprovisioning(mobileprovision_entry, ipa_zipfile),
-            plist_info: self.analyze_info_plist(info_plist_entry, ipa_zipfile),
-            certificate_info: self.codesigned(ipa_zipfile)
+            provisiong_info: self.analyze_mobileprovisioning(mobileprovisioning_data),
+            plist_info: self.analyze_info_plist(plist_data),
+            certificate_info: self.codesigned(ipa_path, app_folder_path)
         }
       end
 
       # Info plist
-      def self.analyze_info_plist(info_plist_entry, ipa_zipfile)
+      def self.analyze_info_plist(data)
+        tempfile = Tempfile.new(::File.basename("info_plist"))
         result = {}
 
-        tempfile = Tempfile.new(::File.basename(info_plist_entry.name))
         begin
-          ipa_zipfile.extract(info_plist_entry, tempfile.path) { true }
+          File.open(tempfile.path, 'w') do |output|
+            output.puts(data)
+          end
           UI.user_error!("Failed to convert binary Plist to XML") unless system("plutil -convert xml1 '#{tempfile.path}'")
 
           plist = Plist.parse_xml(tempfile.path)
-
           plist.each do |key, value|
             parse_value = value.class == Hash || value.class == Array ? value : value.to_s
 
@@ -49,18 +42,20 @@ module Fastlane
         ensure
           tempfile.close && tempfile.unlink
         end
-        return result
+
+        result
       end
 
       # mobileprovisioning
-      def self.analyze_mobileprovisioning(mobileprovision_entry, ipa_zipfile)
+      def self.analyze_mobileprovisioning(data)
+        tempfile = Tempfile.new(::File.basename("mobile_provisioning"))
         result = {}
 
-        tempfile = Tempfile.new(::File.basename(mobileprovision_entry.name))
         begin
-          ipa_zipfile.extract(mobileprovision_entry, tempfile.path) { true }
+          File.open(tempfile.path, 'w') do |output|
+            output.puts(data)
+          end
           mobileprovisioning = Plist.parse_xml(`security cms -D -i #{tempfile.path}`)
-
           mobileprovisioning.each do |key, value|
             next if key == 'DeveloperCertificates'
 
@@ -73,33 +68,49 @@ module Fastlane
         ensure
           tempfile.close && tempfile.unlink
         end
-        return result
+
+        result
       end
 
       # certificate
-      def self.codesigned(ipa_zipfile)
-        result = {}
+      def self.codesigned(ipa_path, app_folder_path)
         tempdir = Dir.pwd + "/tmp"
+        result = {}
 
         begin
-          ipa_zipfile.each do |entry_first|
-            entry_first.extract(tempdir + "/" + entry_first.name) { true }
-          end
+          _, error, = Open3.capture3("unzip -d #{tempdir} #{ipa_path}")
+          UI.user_error!(error) unless error.empty?
 
-          app_path = tempdir + "/Payload/*.app"
-          cmd = "codesign -dv #{app_path}"
+          cmd = "codesign -dv #{tempdir}/#{app_folder_path}"
           _stdout, stderr, _status = Open3.capture3(cmd)
           codesigned_flag = stderr.include?("Signed Time")
-
           result["CodeSigned"] = codesigned_flag
         rescue StandardError => e
           UI.user_error!(e.message)
         ensure
           FileUtils.rm_r(tempdir)
         end
+
         return result
       end
 
+      # extract file
+      def self.fetch_file_with_unzip(path, target_file)
+        list, error, = Open3.capture3("unzip", "-Z", "-1", path)
+        UI.user_error!(error) unless error.empty?
+
+        return nil if list.empty?
+        entry = list.chomp.split("\n").find do |e|
+          File.fnmatch(target_file, e, File::FNM_PATHNAME)
+        end
+
+        data, error, = Open3.capture3("unzip", "-p", path, entry)
+        UI.user_error!(error) unless error.empty?
+        UI.user_error!("not exits data for #{target_file}") if data.empty?
+
+        data
+      end
+
       # return app folder path
       def self.find_app_folder_path_in_ipa(ipa_path)
         return "Payload/#{File.basename(ipa_path, File.extname(ipa_path))}.app"

data/lib/fastlane/plugin/ipa_info/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module IpaInfo
-    VERSION = "0.7.0"
+    VERSION = "0.8.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-ipa_info
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - tarappo
@@ -30,26 +30,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: rubyzip
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.7
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.7
 - !ruby/object:Gem::Dependency
   name: mac_ios_info
   requirement: !ruby/object:Gem::Requirement
@@ -201,7 +181,6 @@ files:
 - lib/fastlane/plugin/ipa_info.rb
 - lib/fastlane/plugin/ipa_info/actions/ipa_info_action.rb
 - lib/fastlane/plugin/ipa_info/helper/ipa_analyze_helper.rb
-- lib/fastlane/plugin/ipa_info/helper/ipa_analyze_helper2.rb
 - lib/fastlane/plugin/ipa_info/helper/ipa_info_helper.rb
 - lib/fastlane/plugin/ipa_info/version.rb
 homepage: https://github.com/tarappo/fastlane-plugin-ipa_info

data/lib/fastlane/plugin/ipa_info/helper/ipa_analyze_helper2.rb

@@ -1,124 +0,0 @@
-require 'tempfile'
-require 'tmpdir'
-require 'zip'
-require 'zip/filesystem'
-require 'fileutils'
-require 'plist'
-require 'open3'
-require 'fastlane_core/ui/ui'
-
-module Fastlane
-  module Helper
-    class IpaAnalyzeHelper2
-      def self.analyze(ipa_path)
-        app_folder_path = find_app_folder_path_in_ipa(ipa_path)
-        plist_data = self.fetch_file_with_unzip(ipa_path, "#{app_folder_path}/Info.plist")
-        mobileprovisioning_data = self.fetch_file_with_unzip(ipa_path, "#{app_folder_path}/embedded.mobileprovision")
-
-        return {
-            provisiong_info: self.analyze_mobileprovisioning(mobileprovisioning_data),
-            plist_info: self.analyze_info_plist(plist_data),
-            certificate_info: self.codesigned(ipa_path, app_folder_path)
-        }
-      end
-
-      # Info plist
-      def self.analyze_info_plist(data)
-        tempfile = Tempfile.new(::File.basename("info_plist"))
-        result = {}
-
-        begin
-          File.open(tempfile.path, 'w') do |output|
-            output.puts(data)
-          end
-          UI.user_error!("Failed to convert binary Plist to XML") unless system("plutil -convert xml1 '#{tempfile.path}'")
-
-          plist = Plist.parse_xml(tempfile.path)
-          plist.each do |key, value|
-            parse_value = value.class == Hash || value.class == Array ? value : value.to_s
-
-            result[key] = parse_value
-          end
-        rescue StandardError => e
-          UI.user_error!(e.message)
-        ensure
-          tempfile.close && tempfile.unlink
-        end
-
-        result
-      end
-
-      # mobileprovisioning
-      def self.analyze_mobileprovisioning(data)
-        tempfile = Tempfile.new(::File.basename("mobile_provisioning"))
-        result = {}
-
-        begin
-          File.open(tempfile.path, 'w') do |output|
-            output.puts(data)
-          end
-          mobileprovisioning = Plist.parse_xml(`security cms -D -i #{tempfile.path}`)
-          mobileprovisioning.each do |key, value|
-            next if key == 'DeveloperCertificates'
-
-            parse_value = value.class == Hash || value.class == Array ? value : value.to_s
-
-            result[key] = parse_value
-          end
-        rescue StandardError => e
-          UI.user_error!(e.message)
-        ensure
-          tempfile.close && tempfile.unlink
-        end
-
-        result
-      end
-
-      # certificate
-      def self.codesigned(ipa_path, app_folder_path)
-        tempdir = Dir.pwd + "/tmp"
-        result = {}
-
-        begin
-          data, error, = Open3.capture3("unzip -d #{tempdir} #{ipa_path}")
-
-          cmd = "codesign -dv #{tempdir}/#{app_folder_path}"
-          _stdout, stderr, _status = Open3.capture3(cmd)
-          codesigned_flag = stderr.include?("Signed Time")
-          result["CodeSigned"] = codesigned_flag
-        rescue StandardError => e
-          UI.user_error!(e.message)
-        ensure
-          FileUtils.rm_r(tempdir)
-        end
-
-        return result
-      end
-
-      # extract file
-      def self.fetch_file_with_unzip(path, target_file)
-        list, error, = Open3.capture3("unzip", "-Z", "-1", path)
-        UI.user_error!(error) unless error.empty?
-
-        return nil if list.empty?
-        entry = list.chomp.split("\n").find do |e|
-          File.fnmatch(target_file, e, File::FNM_PATHNAME)
-        end
-
-        data, error, = Open3.capture3("unzip", "-p", path, entry)
-        UI.user_error!(error) unless error.empty?
-        UI.user_error!("not exits data for #{target_file}") if data.empty?
-
-        data
-      end
-
-      private
-
-      # return app folder path
-      def self.find_app_folder_path_in_ipa(ipa_path)
-        return "Payload/#{File.basename(ipa_path, File.extname(ipa_path))}.app"
-      end
-
-    end
-  end
-end