fastlane-plugin-ionic 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f9a5b7b3ba70799970af36c04b593d103a24c94
-  data.tar.gz: 1beb8a562abe037dcfc1b3d63ff36ca2eccaf1df
+  metadata.gz: b6eec2eb14314f04375f251a8a83d28c310ba63b
+  data.tar.gz: 901a1527245a86578b3d0df24c1f98349cc7b9d6
 SHA512:
-  metadata.gz: 415582a5eb8c2c010c8bd19c2835b5606b2399b5a2d37723ee7d03b2e4001248f98a0c0078b0536563d16d32c1a9c72e101762ee68f3a4dfb75da1dfa7390f24
-  data.tar.gz: bd765bb631defb1237c6a331a01531e391d1d24dd863d5118addc08f4f947decbd4e310b9fb6dae805d5382f9aa6a27112872b26b573e608e649ecd5fec0ae15
+  metadata.gz: 2cf5d0dd574748686010767ca61c356b83ac180b7960877c6cc769b78325091aba08d151520d5d7f8de4a32511c39d9e4eca29cf3422d96d6691c42857b181b6
+  data.tar.gz: 25cd713d21cab83a37b6c0b98daca713c2e863b95a4c3d873b51e8ade8f3c67f2c482ab2897cdd4f254f3e6d90e100b95916057e93a814c622290c7ce70e7fe0

data/README.md

@@ -3,8 +3,9 @@
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-ionic) [![License](https://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://github.com/ionic-zone/fastlane-plugin-ionic/blob/master/LICENSE)
 [![Gem](https://img.shields.io/gem/v/fastlane-plugin-ionic.svg?style=flat)](http://rubygems.org/gems/fastlane-plugin-ionic)
 
-This _fastlane_ plugin lets you build your Ionic Cordova project via the [Ionic Command line tool](https://ionicframework.com/docs/cli/), `ionic`, and its `ionic cordova build` command in a _fastlane_ lane.  
-It is based on [fastlane-plugin-cordova](https://github.com/bamlab/fastlane-plugin-cordova) (where it borrows most of its code).
+This _fastlane_ plugin helps you build your **Ionic Cordova** project via the [`ionic` CLI](https://ionicframework.com/docs/cli/) and its `ionic cordova build` command.
+
+It is based on [fastlane-plugin-cordova](https://github.com/bamlab/fastlane-plugin-cordova) (where it borrows a lot of its code. Thanks!).
 
 ## Getting Started
 
@@ -18,12 +19,12 @@ fastlane add_plugin ionic
 
 ### `ionic`
 
-Run `ionic cordova build` to build your Ionic project.
+Runs `ionic cordova build` to build your Ionic project.
 
 ```ruby
 ionic(
   platform: 'ios', # Build your iOS Ionic project
-) 
+)
 ionic(
   platform: 'android', # Build your Android Ionic project
   release: false # Build a "Debug" app
@@ -42,7 +43,7 @@ platform :ios do
   lane :deploy do
     match(type: "appstore")
     ionic(platform: 'ios')
-    appstore(ipa: ENV['CORDOVA_IOS_RELEASE_BUILD_PATH'])
+    deliver(ipa: ENV['CORDOVA_IOS_RELEASE_BUILD_PATH'])
   end
 end
 
@@ -70,10 +71,11 @@ team_id "28323HT"
 ```
 
 If you're using **Crosswalk**, replace `supply(apk: ENV['CORDOVA_ANDROID_RELEASE_BUILD_PATH'])` (and equivalents) by:
-```
+
+```ruby
 supply(
   apk_paths: [
-   'platforms/android/build/outputs/apk/android-armv7-release.apk', 
+   'platforms/android/build/outputs/apk/android-armv7-release.apk',
    'platforms/android/build/outputs/apk/android-x86-release.apk'
   ],
 )
@@ -82,6 +84,7 @@ supply(
 ## Plugin API
 
 To check what's available in the plugin, install it in a project and run at the root of the project:
+
 ```
 fastlane actions ionic
 ```
@@ -93,6 +96,7 @@ Which will produce:
 | **platform**             | Platform to build on. <br>Should be either android or ios | CORDOVA_PLATFORM            |        |
 | **release**              | Build for release if true,<br>or for debug if false       | CORDOVA_RELEASE             | *true* |
 | **device**               | Build for device                                          | CORDOVA_DEVICE              | *true* |
+| **prod**                 | Build for production                                      | IONIC_PROD                  | *true* |
 | **type**                 | This will determine what type of build is generated by Xcode. <br>Valid options are development, enterprise, adhoc, and appstore| CORDOVA_IOS_PACKAGE_TYPE    | appstore |
 | **team_id**              | The development team (Team ID) to use for code signing  | CORDOVA_IOS_TEAM_ID               | *28323HT* |
 | **provisioning_profile** | GUID of the provisioning profile to be used for signing | CORDOVA_IOS_PROVISIONING_PROFILE  |           |
@@ -102,7 +106,7 @@ Which will produce:
 | **keystore_alias**       | Android Keystore alias                                  | CORDOVA_ANDROID_KEYSTORE_ALIAS    |           |
 | **build_number**         | Build Number for iOS and Android                        | CORDOVA_BUILD_NUMBER              |           |
 | **browserify**           | Specifies whether to browserify build or not            | CORDOVA_BROWSERIFY                |  *false*  |
-| **cordova_prepare**      | Specifies whether to run `cordova prepare` before building  | CORDOVA_PREPARE               |  *true*   |
+| **cordova_prepare**      | Specifies whether to run `ionic cordova prepare` before building  | CORDOVA_PREPARE               |  *true*   |
 
 ## Run tests for this plugin
 

data/lib/fastlane/plugin/ionic/actions/ionic_action.rb

@@ -6,7 +6,6 @@ module Fastlane
     end
 
     class IonicAction < Action
-
       # valid action params
 
       ANDROID_ARGS_MAP = {
@@ -20,7 +19,7 @@ module Fastlane
       IOS_ARGS_MAP = {
         type: 'packageType',
         team_id: 'developmentTeam',
-        provisioning_profile: 'provisioningProfile',
+        provisioning_profile: 'provisioningProfile'
       }
 
       # do rewriting and copying of action params
@@ -50,7 +49,8 @@ module Fastlane
         app_identifier = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)
 
         if params[:provisioning_profile].empty?
-          params[:provisioning_profile] = ENV['SIGH_UUID'] || ENV["sigh_#{app_identifier}_#{params[:type].sub("-","")}"] # TODO What does this do? Does it also work for `match`?
+          # If `match` or `sigh` were used before this, use the certificates returned from there
+          params[:provisioning_profile] = ENV['SIGH_UUID'] || ENV["sigh_#{app_identifier}_#{params[:type].sub('-', '')}"]
         end
 
         if params[:type] == 'adhoc'
@@ -71,24 +71,26 @@ module Fastlane
       end
 
       # app_name
-      def self.get_app_name()
+      def self.get_app_name
         config = REXML::Document.new(File.open('config.xml'))
-        return config.elements['widget'].elements['name'].first.value # TODO Simplify!? (Check logic in cordova)
+        return config.elements['widget'].elements['name'].first.value # TODO: Simplify!? (Check logic in cordova)
       end
 
       # actual building! (run #2)
       def self.build(params)
         args = [params[:release] ? '--release' : '--debug']
         args << '--device' if params[:device]
+        args << '--prod' if params[:prod]
         args << '--browserify' if params[:browserify]
         android_args = self.get_android_args(params) if params[:platform].to_s == 'android'
         ios_args = self.get_ios_args(params) if params[:platform].to_s == 'ios'
 
-        # TODO Extract param string for prepare and compile here
         if params[:cordova_prepare]
-          sh "ionic cordova prepare #{params[:platform]} #{args.join(' ')} -- #{ios_args} -- -- #{android_args}" # TODO only attach set args - makes a nicer command
+          # TODO: Remove params not allowed/used for `prepare`
+          sh "ionic cordova prepare #{params[:platform]} #{args.join(' ')}"
         end
 
+        # special handling for `build_number` param
         if params[:platform].to_s == 'ios' && !params[:build_number].to_s.empty?
           cf_bundle_version = params[:build_number].to_s
           Actions::UpdateInfoPlistAction.run(
@@ -100,18 +102,19 @@ module Fastlane
           )
         end
 
-        sh "ionic cordova compile #{params[:platform]} #{args.join(' ')} -- #{ios_args} -- -- #{android_args}" # TODO only attach set args - makes a nicer command
+        # TODO: extract params - only attach correct platform args
+        sh "ionic cordova compile #{params[:platform]} #{args.join(' ')} -- #{ios_args} -- -- #{android_args}" 
       end
 
       # export build paths (run #3)
       def self.set_build_paths(is_release)
-        app_name = self.get_app_name()
+        app_name = self.get_app_name
         build_type = is_release ? 'release' : 'debug'
 
         ENV['CORDOVA_ANDROID_RELEASE_BUILD_PATH'] = "./platforms/android/build/outputs/apk/android-#{build_type}.apk"
         ENV['CORDOVA_IOS_RELEASE_BUILD_PATH'] = "./platforms/ios/build/device/#{app_name}.ipa"
 
-        # TODO https://github.com/bamlab/fastlane-plugin-cordova/issues/7
+        # TODO: https://github.com/bamlab/fastlane-plugin-cordova/issues/7
       end
 
       def self.run(params)
@@ -164,6 +167,16 @@ module Fastlane
               UI.user_error!("Device should be boolean") unless [false, true].include? value
             end
           ),
+          FastlaneCore::ConfigItem.new(
+            key: :prod,
+            env_name: "IONIC_PROD",
+            description: "Build for production",
+            is_string: false,
+            default_value: false,
+            verify_block: proc do |value|
+              UI.user_error!("Prod should be boolean") unless [false, true].include? value
+            end
+          ),
           FastlaneCore::ConfigItem.new(
             key: :type,
             env_name: "CORDOVA_IOS_PACKAGE_TYPE",
@@ -221,7 +234,7 @@ module Fastlane
             env_name: "CORDOVA_BUILD_NUMBER",
             description: "Build Number for iOS",
             optional: true,
-            is_string: false,
+            is_string: false
           ),
           FastlaneCore::ConfigItem.new(
             key: :browserify,

data/lib/fastlane/plugin/ionic/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module Ionic
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-ionic
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Jan Piotrowski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-13 00:00:00.000000000 Z
+date: 2017-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry