RubyGems - fastlane-plugin-icon_versioning - Versions diffs - 1.1.1 → 1.1.2 - Mend

fastlane-plugin-icon_versioning 1.1.1 → 1.1.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b3342d869116d96a3f67589c5af009f34ce1793
-  data.tar.gz: 13af54a1b2cc783a587e6d1bd08fcd8ee565803c
+  metadata.gz: 82d1d032b7ce422d1fb0d748d3a158bd9e7dcad9
+  data.tar.gz: 0b12e1a6604c765f1e8b08dd4c930c4451db73e8
 SHA512:
-  metadata.gz: 9efbb55e5b50519cab73b8609e69b789ffbdb78975c47a0630d549e70dc999dd040a97c04c688fcb297c60daa9f86678397a7d960ddb8b060c21b9d965f52168
-  data.tar.gz: 98355d4430391cb7a43cb72e97dbdc78249acf137cf9bc038cc02e2afd1b7431669df2029b268aadeb8136e754af078458c3d5f3c70bece2b09780b00220cd6d
+  metadata.gz: 969bc76c0919823f4e236232ffd4b68101b239207257affa314c5e7b8b75e8ad91776584d2336deba4c802f509f16be01e5130ae500dc1b253f5036eeae06114
+  data.tar.gz: 9f0b38c180c88bf57df4b87604be79bf4e73c897b981db30bf2777d0bcbacd0d1b486090754a63bf140f17f8b7ac5178dd49f480eca76644f0d3ee0f85ae95c6

data/README.md CHANGED Viewed

@@ -3,6 +3,7 @@
 [![fastlane Plugin Badge](https://rawcdn.githack.com/fastlane/fastlane/master/fastlane/assets/plugin-badge.svg)](https://rubygems.org/gems/fastlane-plugin-icon_versioning)
 [![Build Status](https://travis-ci.org/revolter/fastlane-plugin-icon_versioning.svg?branch=master)](https://travis-ci.org/revolter/fastlane-plugin-icon_versioning)
 [![Coverage Status](https://coveralls.io/repos/github/revolter/fastlane-plugin-icon_versioning/badge.svg)](https://coveralls.io/github/revolter/fastlane-plugin-icon_versioning)
+[![Maintainability](https://api.codeclimate.com/v1/badges/c25b5a17cfad82881a70/maintainability)](https://codeclimate.com/github/revolter/fastlane-plugin-icon_versioning/maintainability)
 ## Getting Started

data/lib/fastlane/plugin/icon_versioning/actions/icon_versioning_action.rb CHANGED Viewed

@@ -1,91 +1,21 @@
 require 'fastlane/action'
-require_relative '../helper/icon_versioning_helper'
+require_relative 'version_icon_action'
 module Fastlane
   module Actions
-    class IconVersioningAction < Action
+    class IconVersioningAction < VersionIconAction
       def self.run(params)
-        icon_versioning_helper = Helper::IconVersioningHelper.new(params)
+        UI.important('This action was deprecated. Please use "version_icon" instead.')
-        return icon_versioning_helper.run()
+        return super
       end
-      def self.description
-        'Overlay build information on top of your app icon. Based on original work by Krzysztof Zabłocki (https://github.com/krzysztofzablocki/Bootstrap).'
+      def self.category
+        :deprecated
       end
-      def self.authors
-        ['Iulian Onofrei', 'Krzysztof Zabłocki']
-      end
-      def self.available_options
-        [
-          FastlaneCore::ConfigItem.new(
-            key: :appiconset_path,
-            env_name: 'ICON_VERSIONING_APPICONSET_PATH',
-            description: 'The path to the `.appiconset` directory containing the icon images',
-            verify_block: proc do |value|
-              path = File.expand_path(value.to_s)
-              UI.user_error!('Appiconset not found') unless File.exist?(path)
-              UI.user_error!('Appiconset is not a directory') unless File.directory?(path)
-              UI.user_error!('Appiconset does not end with .appiconset') unless path.end_with?('.appiconset')
-            end,
-            type: String
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :text,
-            env_name: 'ICON_VERSIONING_TEXT',
-            description: 'The text to overlay over the icon images',
-            type: String
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :band_height_percentage,
-            env_name: 'ICON_VERSIONING_BAND_HEIGHT_PERCENTAGE',
-            description: 'The percentage of the text band height relative to the image\'s height. A float number between 0 and 1',
-            default_value: 0.5,
-            verify_block: proc do |value|
-              UI.user_error!('Band height percentage is less than 0') if value < 0
-              UI.user_error!('Band height percentage is greater than 1') if value > 1
-            end,
-            optional: true,
-            type: Float
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :band_blur_radius_percentage,
-            env_name: 'ICON_VERSIONING_BAND_BLUR_RADIUS_PERCENTAGE',
-            description: 'The blur radius percentage of the text band. The default value behaves like an automatic setting which produces the best results. More details: http://www.imagemagick.org/Usage/blur/#blur_args',
-            default_value: 0,
-            verify_block: proc do |value|
-              UI.user_error!('Band blur radius percentage is less than 0') if value < 0
-            end,
-            optional: true,
-            type: Float
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :band_blur_sigma_percentage,
-            env_name: 'ICON_VERSIONING_BAND_BLUR_SIGMA_PERCENTAGE',
-            description: 'The blur sigma percentage of the text band. More details: http://www.imagemagick.org/Usage/blur/#blur_args',
-            default_value: 0.05,
-            verify_block: proc do |value|
-              UI.user_error!('Band blur sigma percentage is less than 0') if value < 0
-              UI.user_error!('Band blur sigma percentage is greater than 65355') if value > 65_355
-            end,
-            optional: true,
-            type: Float
-          ),
-          FastlaneCore::ConfigItem.new(
-            key: :ignored_icons_regex,
-            env_name: 'ICON_VERSIONING_IGNORED_ICONS_REGEX',
-            description: 'An optional regex that causes the icons that match agains it not to be versioned',
-            optional: true,
-            type: Regexp
-          )
-        ]
-      end
-      def self.is_supported?(platform)
-        [:ios].include?(platform)
+      def self.deprecated_notes
+        'Please use the `version_icon` action instead.'
       end
     end
   end

data/lib/fastlane/plugin/icon_versioning/actions/version_icon_action.rb ADDED Viewed

@@ -0,0 +1,92 @@
+require 'fastlane/action'
+require_relative '../helper/version_icon_helper'
+module Fastlane
+  module Actions
+    class VersionIconAction < Action
+      def self.run(params)
+        version_icon_helper = Helper::VersionIconHelper.new(params)
+        return version_icon_helper.run()
+      end
+      def self.description
+        'Overlay build information on top of your app icon. Based on original work by Krzysztof Zabłocki (https://github.com/krzysztofzablocki/Bootstrap).'
+      end
+      def self.authors
+        ['Iulian Onofrei', 'Krzysztof Zabłocki']
+      end
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.new(
+            key: :appiconset_path,
+            env_name: 'VERSION_ICON_APPICONSET_PATH',
+            description: 'The path to the `.appiconset` directory containing the icon images',
+            verify_block: proc do |value|
+              path = File.expand_path(value.to_s)
+              UI.user_error!('Appiconset not found') unless File.exist?(path)
+              UI.user_error!('Appiconset is not a directory') unless File.directory?(path)
+              UI.user_error!('Appiconset does not end with .appiconset') unless path.end_with?('.appiconset')
+            end,
+            type: String
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :text,
+            env_name: 'VERSION_ICON_TEXT',
+            description: 'The text to overlay over the icon images',
+            type: String
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :band_height_percentage,
+            env_name: 'VERSION_ICON_BAND_HEIGHT_PERCENTAGE',
+            description: 'The percentage of the text band height relative to the image\'s height. A float number between 0 and 1',
+            default_value: 0.5,
+            verify_block: proc do |value|
+              UI.user_error!('Band height percentage is less than 0') if value < 0
+              UI.user_error!('Band height percentage is greater than 1') if value > 1
+            end,
+            optional: true,
+            type: Float
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :band_blur_radius_percentage,
+            env_name: 'VERSION_ICON_BAND_BLUR_RADIUS_PERCENTAGE',
+            description: 'The blur radius percentage of the text band. The default value behaves like an automatic setting which produces the best results. More details: http://www.imagemagick.org/Usage/blur/#blur_args',
+            default_value: 0,
+            verify_block: proc do |value|
+              UI.user_error!('Band blur radius percentage is less than 0') if value < 0
+            end,
+            optional: true,
+            type: Float
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :band_blur_sigma_percentage,
+            env_name: 'VERSION_ICON_BAND_BLUR_SIGMA_PERCENTAGE',
+            description: 'The blur sigma percentage of the text band. More details: http://www.imagemagick.org/Usage/blur/#blur_args',
+            default_value: 0.05,
+            verify_block: proc do |value|
+              UI.user_error!('Band blur sigma percentage is less than 0') if value < 0
+              UI.user_error!('Band blur sigma percentage is greater than 65355') if value > 65_355
+            end,
+            optional: true,
+            type: Float
+          ),
+          FastlaneCore::ConfigItem.new(
+            key: :ignored_icons_regex,
+            env_name: 'VERSION_ICON_IGNORED_ICONS_REGEX',
+            description: 'An optional regex that causes the icons that match agains it not to be versioned',
+            optional: true,
+            type: Regexp
+          )
+        ]
+      end
+      def self.is_supported?(platform)
+        [:ios].include?(platform)
+      end
+    end
+  end
+end

data/lib/fastlane/plugin/icon_versioning/helper/{icon_versioning_helper.rb → version_icon_helper.rb} RENAMED Viewed

@@ -9,7 +9,7 @@ module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?('UI')
   module Helper
-    class IconVersioningHelper
+    class VersionIconHelper
       CACHE_FILE_NAME = 'cache.yml'.freeze
       attr_accessor :appiconset_path
@@ -80,7 +80,9 @@ module Fastlane
         return path.gsub(/([^.]+)(\.appiconset)/, '\1-Versioned\2')
       end
-      private def version_icon(original_icon_path, versioned_icon_path)
+      private
+      def version_icon(original_icon_path, versioned_icon_path)
         image = MiniMagick::Image.open(original_icon_path)
         width = image[:width]
@@ -154,7 +156,7 @@ module Fastlane
         File.delete(text_base_icon_path, text_icon_path, temp_icon_path)
       end
-      private def suffix(path, text)
+      def suffix(path, text)
         extension = File.extname(path)
         return path.gsub(extension, "_#{text}#{extension}")

data/lib/fastlane/plugin/icon_versioning/version.rb CHANGED Viewed

@@ -1,5 +1,5 @@
 module Fastlane
   module IconVersioning
-    VERSION = '1.1.1'
+    VERSION = '1.1.2'
   end
 end

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-icon_versioning
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Iulian Onofrei
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-03-13 00:00:00.000000000 Z
+date: 2018-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mini_magick
@@ -174,7 +174,8 @@ files:
 - README.md
 - lib/fastlane/plugin/icon_versioning.rb
 - lib/fastlane/plugin/icon_versioning/actions/icon_versioning_action.rb
-- lib/fastlane/plugin/icon_versioning/helper/icon_versioning_helper.rb
+- lib/fastlane/plugin/icon_versioning/actions/version_icon_action.rb
+- lib/fastlane/plugin/icon_versioning/helper/version_icon_helper.rb
 - lib/fastlane/plugin/icon_versioning/version.rb
 homepage: https://github.com/revolter/fastlane-plugin-icon_versioning
 licenses:
@@ -196,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.5.2
+rubygems_version: 2.6.13
 signing_key:
 specification_version: 4
 summary: Overlay build information on top of your app icon