fastlane-plugin-google_sheet_localize 0.1.62 → 0.1.63

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2a5b148feb10990de9fc299ee5b885f13b81558404549934b3dea242d3d3588
-  data.tar.gz: 1ea19cbdab4d86334cf6c45ba3a8da63cd180d5882454d72ca5ab30c336e23d4
+  metadata.gz: 102188576599a79430b403b7f1281392f5d1561b13ccd8d0e98cbe1b180bd484
+  data.tar.gz: f48b48392ea363cede16ebf8b1e9f59209d2bf999393d126fb07ee67889ffe56
 SHA512:
-  metadata.gz: 9c03d350f56fb338c9c38f509bb9524034ae9dc047d5e04dee190410871a6fe74f5185227d7f718b73a3eeb3ecf713ab91d40059ae51b9a8c86eadb82239b2de
-  data.tar.gz: c79affce8ad07e67abe628ceeff9fe07784f762b196c728379f808596c275c537d045de2739e74e77f4decb3470990f7bfe94116d7ce16b3363e1642cf62e0a1
+  metadata.gz: f8d38dffd11d365c4cf3062f5c16c6a8dc2e01448d2460faf36bb11d6ecc94f6818d1f4f7b268f5b5b6a1b64173590daf432dcdd84ea62b625767f639e162073
+  data.tar.gz: 1239bcada1be1cf536d58e29cb1c6ec3cfc2bcb58990424e3fc89b7083a60c345c3bef8d618a34c3f5fcd80ca16efaf22671bdf4845287bd552d7586e2203ce9

data/README.md

@@ -14,13 +14,25 @@ fastlane add_plugin google_sheet_localize
 
 Creates .strings files for iOS and strings.xml files for Android
 
-**Note to author:** Add a more detailed description about this plugin here. If your plugin contains multiple actions, make sure to mention them here.
+to use our plugin you have to duplicate this google sheet: https://docs.google.com/spreadsheets/d/1fwRj1ZFPu2XlrDqkaqmIpJulqR5OVFEZnN35a9v37yc/edit?usp=sharing
+
+Google Drive access token: 
+https://medium.com/@osanda.deshan/getting-google-oauth-access-token-using-google-apis-18b2ba11a11a
 
 ## Example
 
-Check out the [example `Fastfile`](fastlane/Fastfile) to see how to use this plugin. Try it by cloning the repo, running `fastlane install_plugins` and `bundle exec fastlane test`.
+```bash
+  lane :localize do
+    google_sheet_localize(service_account_path: "./fastlane/google_drive_credentials.json",
+                                      sheet_id: "sheet id",
+                                      platform: "ios",
+                                          tabs: ["3TV"],
+                             localization_path: "./Kit/TVKit",
+                               language_titles: ["de", "en"],
+                              default_language: "de")
+  end
+```
 
-**Note to author:** Please set up a sample project to make it easy for users to explore what your plugin does. Provide everything that is necessary to try out the plugin in this project (including a sample Xcode/Android project if necessary)
 
 ## Run tests for this plugin
 

data/lib/fastlane/plugin/google_sheet_localize/actions/google_sheet_localize_action.rb

@@ -195,7 +195,10 @@ module Fastlane
           File.open("#{destinationPath}/#{languageDir}/strings.xml", "w") do |f|
             f.write("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n")
             f.write("<resources>\n")
-            language["items"].each { |item|
+
+            filteredItems = self.filterUnusedRows(language["items"],'identifierAndroid')
+
+            filteredItems.each { |item|
 
               comment = item['comment']
               identifier = item['identifierAndroid']
@@ -208,6 +211,15 @@ module Fastlane
                   line = line + "\t<!--#{comment}-->\n"
                 end
 
+                if text == "" || text == "TBD"
+                  default_language_object = languages.select { |languageItem| languageItem['language'] == defaultLanguage }.first["items"]
+                  default_language_object = self.filterUnusedRows(default_language_object,'identifierAndroid')
+
+                  defaultLanguageText = default_language_object[index]['text']
+                  puts "found empty text for identifier: #{identifier} for language:#{language['language']}, replaceing it with #{defaultLanguageText}"
+                  text = defaultLanguageText
+                end
+
                 line = line + "\t<string name=\"#{identifier}\"><![CDATA[#{text}]]></string>\n"
 
                 f.write(line)
@@ -220,14 +232,13 @@ module Fastlane
       end
 
       def self.createiOSFileEndString()
-        return "\n\nextension Localization {\n\tprivate static func localized(identifier key: String, _ args: CVarArg...) -> String {\n\t\tlet format = NSLocalizedString(key, tableName: nil, bundle: Bundle.main, comment: \"\")\n\n\t\tguard !args.isEmpty else { return format }\n\n\t\treturn String(format: format, locale: Locale.current, arguments: args)\n\t}\n}"
+        return "\n\nprivate class LocalizationHelper { }\n\nextension Localization {\n\tprivate static func localized(identifier key: String, _ args: CVarArg...) -> String {\n\t\tlet format = NSLocalizedString(key, tableName: nil, bundle: Bundle(for: LocalizationHelper.self), comment: \"\")\n\n\t\tguard !args.isEmpty else { return format }\n\n\t\treturn String(format: format, locale: Locale.current, arguments: args)\n\t}\n}"
       end
 
       def self.createiOSFunction(constantName, identifier, arguments, comment)
           functionTitle = "\n\t///Sheet comment: #{comment}\n\tpublic static func #{constantName}("
 
           arguments.each_with_index do |item, index|
-            puts item
             functionTitle = functionTitle + "_ arg#{index}: #{item[:type]}"
             if index < arguments.count - 1
               functionTitle = functionTitle + ", "

data/lib/fastlane/plugin/google_sheet_localize/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module GoogleSheetLocalize
-    VERSION = "0.1.62"
+    VERSION = "0.1.63"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-google_sheet_localize
 version: !ruby/object:Gem::Version
-  version: 0.1.62
+  version: 0.1.63
 platform: ruby
 authors:
 - Mario Hahn