fastlane-plugin-firebase_app_distribution 0.9.0.pre.4 → 0.9.0.pre.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae48b7ba8c86fc7e54c30a6717e389c8878a1184cf2475d59b1e459e3267fe55
-  data.tar.gz: f748841840157b734cfe23855aa5ed75f40536adc94523d53e94f3b7a3db6018
+  metadata.gz: aceee5f3b1696286ac2811aed9705f09d603d724c906845762f7ff76f3ed55e3
+  data.tar.gz: 7f8daaf84f2a08e82c064fd99dd9b0465434b4c11720f5616a39e82a82a945ec
 SHA512:
-  metadata.gz: 54b126b759d40b3b5ea71c5e259247964cf4d0a722b6da144ff706d33ed1b5919d1b7db4a9bf160b21b83b0effdf815187cdad910809b84ba836d6fcc2b02d51
-  data.tar.gz: 3490226a8aea0711d0a3f4e3ebc48664aa91fa0ac2e97cf64b2b88ceafb0bdc5e53b4334d9ce37e83333e10bdccaf88a900ddab603a5235a95c75a75d4ef8a41
+  metadata.gz: edd6b12487d3382f3ee7164e0b7f73d5e442b86262c046866ef475f52e32085375abc497d9809061f7f636f798b1c99653a212a44e8e6ab9cd50e8b32f0dc544
+  data.tar.gz: 53e4f7ec3690cd8784fb74aa36543b70b4de708e78c5c7ad3ebeaf89068db724265ba67cfb91f7354f73311d441f36144e13bed24b9020c90276d8420c0e57a2

data/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -88,8 +88,9 @@ module Fastlane
           get_value_from_value_or_file(params[:test_devices], params[:test_devices_file])
         if present?(test_devices)
           UI.message("🤖 Starting automated tests. Note: This feature is in beta.")
-          release_test = test_release(alpha_client, release, test_devices, params[:test_username], params[:test_password], params[:test_username_resource], params[:test_password_resource])
-          unless params[:test_async]
+          test_password = test_password_from_params(params)
+          release_test = test_release(alpha_client, release, test_devices, params[:test_username], test_password, params[:test_username_resource], params[:test_password_resource])
+          unless params[:test_non_blocking]
             poll_test_finished(alpha_client, release_test.name)
           end
         end
@@ -133,6 +134,12 @@ module Fastlane
         "Release your beta builds with Firebase App Distribution"
       end
 
+      def self.test_password_from_params(params)
+        test_password = get_value_from_value_or_file(params[:test_password], params[:test_password_file])
+        # Remove trailing newline if present
+        test_password && test_password.sub(/\r?\n$/, "")
+      end
+
       def self.app_id_from_params(params)
         if params[:app]
           app_id = params[:app]
@@ -522,23 +529,33 @@ module Fastlane
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_username,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_USERNAME",
                                        description: "Username for automatic login",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_password,
-                                       description: "Password for automatic login",
+                                       env_name: "FIREBASEAPPDISTRO_TEST_PASSWORD",
+                                       description: "Password for automatic login. If using a real password consider using test_password_file or setting FIREBASEAPPDISTRO_TEST_PASSWORD to avoid exposing sensitive info",
                                        optional: true,
                                        type: String),
+          FastlaneCore::ConfigItem.new(key: :test_password_file,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_PASSWORD_FILE",
+                                      description: "Path to file containing password for automatic login",
+                                      optional: true,
+                                      type: String),
           FastlaneCore::ConfigItem.new(key: :test_username_resource,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_USERNAME_RESOURCE",
                                        description: "Resource name for the username field for automatic login",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_password_resource,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_PASSWORD_RESOURCE",
                                        description: "Resource name for the password field for automatic login",
                                        optional: true,
                                        type: String),
-          FastlaneCore::ConfigItem.new(key: :test_async,
-                                       description: "Run tests asynchronously. Visit the Firebase console for the automatic test results",
+          FastlaneCore::ConfigItem.new(key: :test_non_blocking,
+                                       env_name: "FIREBASEAPPDISTRO_TEST_NON_BLOCKING",
+                                       description: "Run automated tests without waiting for them to finish. Visit the Firebase console for the test results",
                                        optional: false,
                                        default_value: false,
                                        type: Boolean),

data/lib/fastlane/plugin/firebase_app_distribution/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module FirebaseAppDistribution
-    VERSION = "0.9.0.pre.4"
+    VERSION = "0.9.0.pre.5"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane-plugin-firebase_app_distribution
 version: !ruby/object:Gem::Version
-  version: 0.9.0.pre.4
+  version: 0.9.0.pre.5
 platform: ruby
 authors:
 - Stefan Natchev